refactor(mmc): replace 0 with MMC_RESPONSE_NONE

Use the newly introduced MMC_RESPONSE_NONE macro for Command 0,
where no response is expected.

Change-Id: I861a1bd009ea131677a23e2d94ea27bff3653360
S

refactor(mmc): replace 0 with MMC_RESPONSE_NONE

Use the newly introduced MMC_RESPONSE_NONE macro for Command 0,
where no response is expected.

Change-Id: I861a1bd009ea131677a23e2d94ea27bff3653360
Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>

show more ...

fix(mmc): initialises response buffer with zeros

if ops->send_cmd in mmc_send_cmd returns a non-zero value, r_data
(resp_data in mmc_device_state) is never populated, so the while
condition in mmc_d

fix(mmc): initialises response buffer with zeros

if ops->send_cmd in mmc_send_cmd returns a non-zero value, r_data
(resp_data in mmc_device_state) is never populated, so the while
condition in mmc_device_state would end up reading the uninitialized
resp_data buffer

Signed-off-by: Anand Saminathan <anans@google.com>
Change-Id: I72d752867c537d49e111e6d149c3cca122f7dc9f

show more ...

fix(mmc): remove redundant reset_to_idle call

mmc_enumerate() is the only caller of mmc_send_op_cond().
mmc_enumerate() calls mmc_reset_to_idle() just before calling
mmc_send_op_cond(). No need to d

fix(mmc): remove redundant reset_to_idle call

mmc_enumerate() is the only caller of mmc_send_op_cond().
mmc_enumerate() calls mmc_reset_to_idle() just before calling
mmc_send_op_cond(). No need to do that again in mmc_send_op_cond().

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Change-Id: Ib8c8ed1a559e3fecb315245f91bb3dc1f547d820

show more ...

fix(mmc): align part config type

This corrects MISRA C2012 10.3: The value of an expression shall not be
assigned to an object with a narrower essential type or of a different
essential type categor

fix(mmc): align part config type

This corrects MISRA C2012 10.3: The value of an expression shall not be
assigned to an object with a narrower essential type or of a different
essential type category.
Set part_config to be an unsigned char everywhere it is used.

Signed-off-by: Yann Gautier <yann.gautier@st.com>
Change-Id: I9cf87848fb016a5630b3c8091290419e3bc62b91

show more ...

fix(mmc): do not modify r_data in mmc_send_cmd()

Fix MISRA C2012-17.8:
A function parameter should not be modified

Signed-off-by: Yann Gautier <yann.gautier@st.com>
Change-Id: I08ed4c6768c7988a98de

fix(mmc): do not modify r_data in mmc_send_cmd()

Fix MISRA C2012-17.8:
A function parameter should not be modified

Signed-off-by: Yann Gautier <yann.gautier@st.com>
Change-Id: I08ed4c6768c7988a98de21da181b97b0885139de

show more ...

fix(mmc): explicitly check operators precedence

This corrects the MISRA violation C2012-12.1:
The precedence of operators within expressions should be made explicit
While at it put the test on one l

fix(mmc): explicitly check operators precedence

This corrects the MISRA violation C2012-12.1:
The precedence of operators within expressions should be made explicit
While at it put the test on one line.

Signed-off-by: Yann Gautier <yann.gautier@st.com>
Change-Id: Id19231faaf033c1e7dbe703690e0dddc7aa8f346

show more ...