fix(debugfs): return negative value on error

The current implementation of buf_to_channel() returns 0 even on invalid
input, making it difficult for callers to distinguish between an error
and a suc

fix(debugfs): return negative value on error

The current implementation of buf_to_channel() returns 0 even on invalid
input, making it difficult for callers to distinguish between an error
and a successful zero-byte transfer.

Change the return behavior to return -1 for error conditions.

Change-Id: Id57d7fd9365f5961a72ba7633dbedd701740e7c4
Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>

show more ...

fix(debugfs): guard against negative ch offsets

The `chan` struct’s `offset` field was previously a signed long,
allowing negative values. When used in comparisons in `buf_to_channel`,
a negative of

fix(debugfs): guard against negative ch offsets

The `chan` struct’s `offset` field was previously a signed long,
allowing negative values. When used in comparisons in `buf_to_channel`,
a negative offset would be cast to a large unsigned integer, causing the
bounds check to silently fail. This could allow a negative offset to
bypass validation and lead to an out-of-bounds access during operations
like `memcpy`.

This patch changes the `offset` field to `unsigned long` and updates
affected functions to use the correct types, ensuring all offset
comparisons are safe and negative values are disallowed at the type
level.

Change-Id: I5d37bbd2fe6d7d3a19628c1a0376c3bf83947f27
Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>
Reported-by: Bartek Piekarski <bartek.piekarski@arm.com>

show more ...

fix(debugfs): set debugfs smc start to vendor EL3

The smc calls for debugfs were moved from the sip service to the vendor
specific EL3 service [1], so the debugfs smc call handler needs to be
update

fix(debugfs): set debugfs smc start to vendor EL3

The smc calls for debugfs were moved from the sip service to the vendor
specific EL3 service [1], so the debugfs smc call handler needs to be
updated to reflect this change so that it does not view debugfs smc
calls to be invalid.

[1]: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/26917

Change-Id: Ic24e3b7ab4c8a37b888aaf11060da0bc8abe072d
Signed-off-by: Slava Andrianov <slava.andrianov@arm.com>

show more ...

fix(smccc): resolve caller world confusion

TF-A checks the SMC caller world using is_caller_secure,
is_caller_non_secure and is_caller_realm macros. Until
realm world was introduced it was fine to u

fix(smccc): resolve caller world confusion

TF-A checks the SMC caller world using is_caller_secure,
is_caller_non_secure and is_caller_realm macros. Until
realm world was introduced it was fine to use a pattern like

if (is_caller_non_secure(flags))
return DENY;

// Handle secure call
secure_operation();

is_caller_non_secure would be false for a realm caller, so this pattern
treats this like a secure world caller. This patch fixes
improper use of is_caller_non_secure and is_caller_secure
to handle realm world caller properly.

Signed-off-by: Arvind Ram Prakash <arvind.ramprakash@arm.com>
Change-Id: I60b125853183ac2ac15277f06d2efb7f3a9d3977

show more ...

chore: update to use Arm word across TF-A

Align entire TF-A to use Arm in copyright header.

Change-Id: Ief9992169efdab61d0da6bd8c5180de7a4bc2244
Signed-off-by: Govindraj Raja <govindraj.raja@arm.co

chore: update to use Arm word across TF-A

Align entire TF-A to use Arm in copyright header.

Change-Id: Ief9992169efdab61d0da6bd8c5180de7a4bc2244
Signed-off-by: Govindraj Raja <govindraj.raja@arm.com>

show more ...

fix(tree): correct some typos

found using codespell (https://github.com/codespell-project/codespell).

Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: I1bfa797e3460adddeefa916bb68e22beddaf6

fix(tree): correct some typos

found using codespell (https://github.com/codespell-project/codespell).

Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: I1bfa797e3460adddeefa916bb68e22beddaf6373

show more ...