| 3b3c70a4 | 07-Jun-2023 |
Michal Simek <michal.simek@amd.com> |
fix(zynqmp): fix sdei arm_validate_ns_entrypoint()
Don't use BL31_LIMIT macro for validation logic directly but clearly mark BL31_LIMIT as 64bit address to avoid compilation error when -Werror=logic
fix(zynqmp): fix sdei arm_validate_ns_entrypoint()
Don't use BL31_LIMIT macro for validation logic directly but clearly mark BL31_LIMIT as 64bit address to avoid compilation error when -Werror=logical-op is passed.
Likely caused by ZYNQMP_ATF_MEM_BASE + ZYNQMP_ATF_MEM_SIZE is in 64bit logic 0x100000000 and compiler handles it as 32bit value. That's why error is shown.
Use uint64_t variable for limit and also for base.
Here is command line to replicate this issue: make realclean; make -j PLAT=zynqmp DEBUG=1 RESET_TO_BL31=1 \ SPD=tspd SDEI_SUPPORT=1 ZYNQMP_ATF_MEM_BASE=0xFFFC0000 \ ZYNQMP_ATF_MEM_SIZE=0x00040000 all -Werror=logical-op
Also error which is coming: plat/xilinx/zynqmp/zynqmp_sdei.c: In function 'arm_validate_ns_entrypoint': plat/xilinx/zynqmp/zynqmp_sdei.c:19:40: error: logical 'or' of collectively exhaustive tests is always true [-Werror=logical-op] 19 | return (entrypoint < BL31_BASE || entrypoint > BL31_LIMIT) ? 0 : -1;
Change-Id: Ie1f1b4d2cd94b977aebb72786ecace0b062da418 Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| c8be2240 | 26-Apr-2023 |
Prasad Kummari <prasad.kummari@amd.com> |
chore(xilinx): replace ATF with TFA
Since the Arm Trusted Firmware(ATF) has been renamed to Trusted Firmware-A (TF-A), replace all the instances of ATF from code comments, macros, variables and func
chore(xilinx): replace ATF with TFA
Since the Arm Trusted Firmware(ATF) has been renamed to Trusted Firmware-A (TF-A), replace all the instances of ATF from code comments, macros, variables and functions to TF-A.
Change-Id: Iab448d96158612a3effb4e49943f8d6cb43aaad5 Signed-off-by: Prasad Kummari <prasad.kummari@amd.com> Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
show more ...
|
| c0d8ee38 | 26-May-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge "fix(zynqmp): handling of type el3 interrrupts" into integration |
| 16cb3be8 | 24-May-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge changes from topic "xlnx_smcc_soc_id" into integration
* changes: feat(versal-net): add support for SMCC ARCH SOC ID feat(versal): add support for SMCC ARCH SOC ID refactor(versal-net):
Merge changes from topic "xlnx_smcc_soc_id" into integration
* changes: feat(versal-net): add support for SMCC ARCH SOC ID feat(versal): add support for SMCC ARCH SOC ID refactor(versal-net): move macros to common header feat(xilinx): add support to get chipid
show more ...
|
| 7e3e7999 | 27-Apr-2023 |
Michal Simek <michal.simek@amd.com> |
fix(zynqmp): make zynqmp_devices structure smaller
Pack the structure and make id/ver smaller and sorted. The change saves 400bytes in RODATA section.
Change-Id: I8bcbe8fd589ba193551a0dd2cd19572516
fix(zynqmp): make zynqmp_devices structure smaller
Pack the structure and make id/ver smaller and sorted. The change saves 400bytes in RODATA section.
Change-Id: I8bcbe8fd589ba193551a0dd2cd19572516252e73 Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| e8077044 | 24-May-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge changes from topic "xilinx-ipi" into integration
* changes: feat(xilinx): fix IPI calculation for Versal/NET feat(xilinx): setup local/remote id in header feat(xilinx): clean macro names
Merge changes from topic "xilinx-ipi" into integration
* changes: feat(xilinx): fix IPI calculation for Versal/NET feat(xilinx): setup local/remote id in header feat(xilinx): clean macro names fix(zynqmp): do not export apu_ipi fix(zynqmp): remove unused headers feat(xilinx): move IPI related macros to plat_ipi.h
show more ...
|
| 32d6396a | 24-May-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge "feat(versal-net): add the IPI CRC checksum macro support" into integration |
| 1873e7f7 | 03-Apr-2023 |
Akshay Belsare <akshay.belsare@amd.com> |
feat(versal-net): add support for SMCC ARCH SOC ID
Add support for SMCCC_ARCH_SOC_ID as per SMC Calling Convention for Versal NET platform. The SMCC ARCH SOC ID call is used by system software to ob
feat(versal-net): add support for SMCC ARCH SOC ID
Add support for SMCCC_ARCH_SOC_ID as per SMC Calling Convention for Versal NET platform. The SMCC ARCH SOC ID call is used by system software to obtain the SiP defined SoC identification details.
Change-Id: I6648051c7f5fa27d2f02080209da36ee8d5a9d95 Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
show more ...
|
| 079c6e24 | 08-May-2023 |
Akshay Belsare <akshay.belsare@amd.com> |
feat(versal): add support for SMCC ARCH SOC ID
Add support for SMCCC_ARCH_SOC_ID as per SMC Calling Convention for Versal platform. The SMCC ARCH SOC ID call is used by system software to obtain the
feat(versal): add support for SMCC ARCH SOC ID
Add support for SMCCC_ARCH_SOC_ID as per SMC Calling Convention for Versal platform. The SMCC ARCH SOC ID call is used by system software to obtain the SiP defined SoC identification details.
Change-Id: I1466a9ad1bc8dde1cda516ddd3edbaa6a5941237 Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
show more ...
|
| 4265bcae | 12-May-2023 |
Akshay Belsare <akshay.belsare@amd.com> |
refactor(versal-net): move macros to common header
Move the macros to common header from platform specific folder, so that the same macros can be re-used in other platforms.
Change-Id: I355b024f5e8
refactor(versal-net): move macros to common header
Move the macros to common header from platform specific folder, so that the same macros can be re-used in other platforms.
Change-Id: I355b024f5e870c6fc104598bc571dbaa29503ae2 Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
show more ...
|
| 0563601f | 03-Apr-2023 |
Akshay Belsare <akshay.belsare@amd.com> |
feat(xilinx): add support to get chipid
Add support for PM API SYS to get the chip ID from the target. The API calls the IPI command to read the Chip idcode and revision.
Change-Id: Id4d7d812cbf77c
feat(xilinx): add support to get chipid
Add support for PM API SYS to get the chip ID from the target. The API calls the IPI command to read the Chip idcode and revision.
Change-Id: Id4d7d812cbf77c5e2fc7785b8afb379214f8dd19 Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
show more ...
|
| 545330b8 | 24-May-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge "fix(versal-net): fix BLXX memory limits for user defined values" into integration |
| a80da389 | 24-May-2023 |
Michal Simek <michal.simek@amd.com> |
fix(versal-net): fix BLXX memory limits for user defined values
When compiling with user defined areas of memory the platform code calculates the size with (base + size - 1). However, the linker fi
fix(versal-net): fix BLXX memory limits for user defined values
When compiling with user defined areas of memory the platform code calculates the size with (base + size - 1). However, the linker file aligns section on a page boundary. So having the -1 in the size calculations leads to an error message looking like this:
bl31.elf section `coherent_ram' will not fit in region `RAM' aarch64-buildroot-linux-uclibc-ld: region `RAM' overflowed by 1 byte
While at it fix all other occurences of predefined values that were calculated with -1.
Fixes: 1d333e69091f ("feat(versal-net): add support for Xilinx Versal NET platform") Change-Id: I4455f63ee3ad52369f517a7d8d3627faf0b28c0f Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| f123b91f | 23-May-2023 |
Ilias Apalodimas <ilias.apalodimas@linaro.org> |
fix(versal): fix BLXX memory limits for user defined values
When compiling with user defined areas of memory the platform code calculates the size with (base + size - 1). However, the linker file a
fix(versal): fix BLXX memory limits for user defined values
When compiling with user defined areas of memory the platform code calculates the size with (base + size - 1). However, the linker file aligns section on a page boundary. So having the -1 in the size calculations leads to an error message looking like this:
bl31.elf section `coherent_ram' will not fit in region `RAM' aarch64-buildroot-linux-uclibc-ld: region `RAM' overflowed by 1 byte
While at it fix all other occurences of predefined values that were calculated with -1
Fixes: commit f91c3cb1df7d4 ("arm64: versal: Add support for new Xilinx Versal ACAPs") Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> Change-Id: Ica1f97867b701e7fcd60ea8ea07d2ae96c485443
show more ...
|
| 8ce2fbff | 18-May-2023 |
Ilias Apalodimas <ilias.apalodimas@linaro.org> |
fix(zynqmp): fix BLXX memory limits for user defined values
When compiling with user defined areas of memory the platform code calculates the size with (base + size - 1). However, the linker file a
fix(zynqmp): fix BLXX memory limits for user defined values
When compiling with user defined areas of memory the platform code calculates the size with (base + size - 1). However, the linker file aligns section on a page boundary. So having the -1 in the size calculations leads to an error message looking like this:
bl31.elf section `coherent_ram' will not fit in region `RAM' aarch64-buildroot-linux-uclibc-ld: region `RAM' overflowed by 1 byte
Commit 9b4ed0af02a8 ("feat(plat/zynqmp): fix section `coherent_ram' will not fit in region `RAM'") applied a similar fix, but only in the predefined for BL31LIMIT/BASE.
While at it fix all other occurences of predefined values that were calculated with -1
Fixes: 01555332faa48 ("zynqmp: Revise memory configuration options") Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> Change-Id: Ic96e36808d01f6bb92e6839cec92fc52320dd3f3
show more ...
|
| e8d61f7d | 11-May-2023 |
Prasad Kummari <prasad.kummari@amd.com> |
fix(zynqmp): handling of type el3 interrrupts
The array type_el3_interrupt_table is defined for MAX_INTR_EL3(128) elements and only two interrupts - ARM_IRQ_SEC_SGI_7(15), IRQ_TTC3_1(77) are being h
fix(zynqmp): handling of type el3 interrrupts
The array type_el3_interrupt_table is defined for MAX_INTR_EL3(128) elements and only two interrupts - ARM_IRQ_SEC_SGI_7(15), IRQ_TTC3_1(77) are being handled. Current implementation is consuming 1024 bytes which can be optimized for the number of interrupts to be handled. The current array is replaced with the array of struct zynmp_intr_info_type_el3_t (id and handler as member) and with maximum number of interrupts to be handled as the size of array (MAX_INTR_EL3 = 2). User is expected to adjust MAX_INTR_EL3 based on how many interrupts are handled in TF-A. With the updated implementation, a reduction of 960 bytes is observed. Versal and Versal NET are using similar implementation introduced by commit e497421d7f1e ("feat(versal): add infrastructure to handle multiple interrupts") and commit 0654ab7f7544 ("feat(versal-net): add support for platform management").
Signed-off-by: Prasad Kummari <prasad.kummari@amd.com> Change-Id: I07aa388d38ac3ff3c0d25decbe0719087b27ee18
show more ...
|
| 69a5bee4 | 25-Apr-2023 |
Michal Simek <michal.simek@amd.com> |
feat(xilinx): fix IPI calculation for Versal/NET
Fix buffer calculation logic for Versal and Versal NET to use LOCAL/REMOTE_ID.
Change-Id: Icf6985a19183cc8e51f3a536130695e00c32c736 Signed-off-by: M
feat(xilinx): fix IPI calculation for Versal/NET
Fix buffer calculation logic for Versal and Versal NET to use LOCAL/REMOTE_ID.
Change-Id: Icf6985a19183cc8e51f3a536130695e00c32c736 Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| 068b0bc6 | 25-Apr-2023 |
Michal Simek <michal.simek@amd.com> |
feat(xilinx): setup local/remote id in header
Use new macros IPI_LOCAL_ID/IPI_REMOTE_ID to specify source and destination channels.
Change-Id: I558eebb4d4a83ae0ca9316824f9dba7426adbe3f Signed-off-b
feat(xilinx): setup local/remote id in header
Use new macros IPI_LOCAL_ID/IPI_REMOTE_ID to specify source and destination channels.
Change-Id: I558eebb4d4a83ae0ca9316824f9dba7426adbe3f Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| bfd06265 | 25-Apr-2023 |
Michal Simek <michal.simek@amd.com> |
feat(xilinx): clean macro names
This is preparation for cleaning up IPI local and remote side communication. As of today macros are aligned to communication channel but there is missing calculation
feat(xilinx): clean macro names
This is preparation for cleaning up IPI local and remote side communication. As of today macros are aligned to communication channel but there is missing calculation based on channel selection.
Change-Id: Iac7daf832ff372ea2fece72a15afdfe988b4b7db Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| 237c5a74 | 25-Apr-2023 |
Michal Simek <michal.simek@amd.com> |
fix(zynqmp): do not export apu_ipi
apu_ipi structure is not used anywhere externally that's why make it static.
Change-Id: Icfa99e16ae36fcbcc83b0891aa3527993d49c7ed Signed-off-by: Michal Simek <mic
fix(zynqmp): do not export apu_ipi
apu_ipi structure is not used anywhere externally that's why make it static.
Change-Id: Icfa99e16ae36fcbcc83b0891aa3527993d49c7ed Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| 62886363 | 25-Apr-2023 |
Michal Simek <michal.simek@amd.com> |
fix(zynqmp): remove unused headers
There is no need to include all headers. Enough to have only needed one.
Change-Id: I4813156404969df36f66c1102cd627fdc1e3e9dc Signed-off-by: Michal Simek <michal.
fix(zynqmp): remove unused headers
There is no need to include all headers. Enough to have only needed one.
Change-Id: I4813156404969df36f66c1102cd627fdc1e3e9dc Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| b2258ce3 | 25-Apr-2023 |
Michal Simek <michal.simek@amd.com> |
feat(xilinx): move IPI related macros to plat_ipi.h
The reason is to have all IPI related macros in the same file.
Change-Id: I88ddaa3a5dd1f10114371fc5405f8daf148ca3b8 Signed-off-by: Michal Simek <
feat(xilinx): move IPI related macros to plat_ipi.h
The reason is to have all IPI related macros in the same file.
Change-Id: I88ddaa3a5dd1f10114371fc5405f8daf148ca3b8 Signed-off-by: Michal Simek <michal.simek@amd.com>
show more ...
|
| ba56b012 | 15-May-2023 |
Prasad Kummari <prasad.kummari@amd.com> |
feat(versal-net): add the IPI CRC checksum macro support
Add support for CRC checksum for IPI data when the macro IPI_CRC_CHECK is enabled.
Change-Id: I14dee4729f88c407bafdf1d6b46106459d8e22c4 Sign
feat(versal-net): add the IPI CRC checksum macro support
Add support for CRC checksum for IPI data when the macro IPI_CRC_CHECK is enabled.
Change-Id: I14dee4729f88c407bafdf1d6b46106459d8e22c4 Signed-off-by: Prasad Kummari <prasad.kummari@amd.com>
show more ...
|
| 1b491eea | 13-Feb-2023 |
Elyes Haouas <ehaouas@noos.fr> |
fix(tree): correct some typos
found using codespell (https://github.com/codespell-project/codespell).
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Change-Id: I1bfa797e3460adddeefa916bb68e22beddaf6
fix(tree): correct some typos
found using codespell (https://github.com/codespell-project/codespell).
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Change-Id: I1bfa797e3460adddeefa916bb68e22beddaf6373
show more ...
|
| 837fc96c | 02-May-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge "feat(xilinx): sync copyright format" into integration |