fix(sptool): handle load-address-relative-offset property

If the SP manifest contains load-address-relative-offset then the script
failed to generate the sp_list_fragment.dts file because that line

fix(sptool): handle load-address-relative-offset property

If the SP manifest contains load-address-relative-offset then the script
failed to generate the sp_list_fragment.dts file because that line was
also added to the load_address_lines list.
This commit fixes this issue: a line is only added to the list if the
property name is exactly "load-address", without a following '-'
character.

Change-Id: I1fd2006d37d9cc1864af31576e60565a7bce6023
Signed-off-by: Bence Balogh <bence.balogh@arm.com>

show more ...

refactor(memmap)!: change behavioural flags to commands

This change factors out the following memory map tool flags into
independent commands:

- `--footprint` (becomes `memory footprint`)
- `--tree

refactor(memmap)!: change behavioural flags to commands

This change factors out the following memory map tool flags into
independent commands:

- `--footprint` (becomes `memory footprint`)
- `--tree` (becomes `memory tree`)
- `--symbol` (becomes `memory symbol`)

So, for example, where previously you would generate the memory
footprint of a build with:

memory --tree

You would now instead use:

memory footprint

Any flags specific to a command (e.g. `--depth` for `tree`) must be
specified after the command, e.g.

memory tree --depth 1

... instead of:

memory --depth 1 tree

BREAKING-CHANGE: The image memory map visualization tool now uses
commands, rather than arguments, to determine the behaviour of the
script. See the commit message for further details.

Change-Id: I11d54d1f6276b8447bdfb8496544ab80399459ac
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

refactor(memmap): fix typing-related issues

This change introduces Pyright - a static type checker for Python - and
resolves a large number of the errors that it reports. Some errors have
not been r

refactor(memmap): fix typing-related issues

This change introduces Pyright - a static type checker for Python - and
resolves a large number of the errors that it reports. Some errors have
not been resolved as they require larger refactors, so these will be
done in later patches.

Change-Id: I2ed9b1cc729bf44a1fa8e69882af34657cc30b38
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

refactor(memmap): create common image parser interface

This is another non-functional change, which factors the memory
footprint and symbol listing interfaces shared by the two image parsing
backend

refactor(memmap): create common image parser interface

This is another non-functional change, which factors the memory
footprint and symbol listing interfaces shared by the two image parsing
backends into a common `Image` interface.

Change-Id: I625a8e5ca77e38155b6ed545a33a8ae4c2cf133a
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

refactor(memmap): represent image symbols with key-value map

The symbols defined by an image are currently returned as a list of
tuple pairs, which is a fairly unintuitive way of representing what i

refactor(memmap): represent image symbols with key-value map

The symbols defined by an image are currently returned as a list of
tuple pairs, which is a fairly unintuitive way of representing what is
essentially a map.

This commit changes the return type to the appropriate map type, and
moves the heavy-lifting required to turn it into a list of tuples into
the printer, which is the only place where this representation is
necessary.

Change-Id: I87d047608b390e1e0cdf93eb6af5aeb103b1d69e
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

refactor(memmap): factor memory regions into their own structure

This is a non-functional change to clean up how we represent memory
regions in the memory map tool.

This introduces the `Region` dat

refactor(memmap): factor memory regions into their own structure

This is a non-functional change to clean up how we represent memory
regions in the memory map tool.

This introduces the `Region` data-class, which does little more than
store the region data exposed by the linker scripts, and provides some
additional helper methods which re-produce what was already being done
by both the ELF parser and the map file parser.

Change-Id: Idf45b71bd460f7312498b97b9e4743f4dc482411
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

refactor(memmap): apply additional type hints

This is a non-functional change which adds type hints wherever they
might be helpful. Outside of human readability, this can also help
static analysis t

refactor(memmap): apply additional type hints

This is a non-functional change which adds type hints wherever they
might be helpful. Outside of human readability, this can also help
static analysis tools and IDEs identify additional errors.

Change-Id: Ie63e7f1cdeb893ca7d8a703aff56361eaa4e8f1b
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

refactor(memmap): check ELF object type rather than flag

This is a small functional change which removes the need to pass the
type of the ELF object given to `memory.elfparser.tfa_mem_obj_factory`
b

refactor(memmap): check ELF object type rather than flag

This is a small functional change which removes the need to pass the
type of the ELF object given to `memory.elfparser.tfa_mem_obj_factory`
by instead checking its type.

Change-Id: I653e71345e41bcbae87a3a7475d7a1dd69614b5d
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

refactor(memmap): remove unused functionality

The functionality removed by this patch is currently unused, and there
are currently no plans to expose it to users.

Change-Id: I277fce51e0f34cd9608b4b

refactor(memmap): remove unused functionality

The functionality removed by this patch is currently unused, and there
are currently no plans to expose it to users.

Change-Id: I277fce51e0f34cd9608b4bc1258c78af208897fa
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

fix(memmap): ensure terminal width is respected

Python, for one reason or another, doesn't always get access to the
terminal columns environment variable (`COLUMNS`). Instead, switch out
this logic

fix(memmap): ensure terminal width is respected

Python, for one reason or another, doesn't always get access to the
terminal columns environment variable (`COLUMNS`). Instead, switch out
this logic with the Python-recommended way to get the terminal width,
via the `shutil` import.

Change-Id: I3956f10e91b286404c4d9e802d94592a00c746fb
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

style(memmap): format with Ruff

This change adds the Python formatter and linter Ruff to the Poetry
development dependencies for the memory map script, and formats the
entire project using it.

Chan

style(memmap): format with Ruff

This change adds the Python formatter and linter Ruff to the Poetry
development dependencies for the memory map script, and formats the
entire project using it.

Change-Id: I7c5898bd8ee364e3b72476014ef6b4b11947ae18
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

docs(changelog): changelog for v2.13 release

Generated this change-log using below command:
npm run release -- --skip.commit --skip.tag --release-as 2.13.0

Change-Id: Ibb0623f04c641b65a03deaffd50a5

docs(changelog): changelog for v2.13 release

Generated this change-log using below command:
npm run release -- --skip.commit --skip.tag --release-as 2.13.0

Change-Id: Ibb0623f04c641b65a03deaffd50a5a8b65637419
Signed-off-by: Govindraj Raja <govindraj.raja@arm.com>

show more ...

fix(tools): change data type to size_t for doimage

In image_encrypt function, vulnerability arises
due to a mismatch between unsigned and signed
integer types. When a large unsigned integer
is retur

fix(tools): change data type to size_t for doimage

In image_encrypt function, vulnerability arises
due to a mismatch between unsigned and signed
integer types. When a large unsigned integer
is returned by strlen and stored into signed
integer k, the value represented is a large
negative integer. This bypasses the subsequent
check against AES_BLOCK_SZ and allows a buffer
overflow to happen at memcpy.

Similar, vulnerability issue is fixed in
function verify_and_copy_file_name_entry.

Change-Id: I658521c1eec1c79933ba8082ba507df04d174e52
Signed-off-by: Jaiprakash Singh <jaiprakashs@marvell.com>

show more ...

fix(nxp-tools): fix2 create_pbl buildroot build

For some unknown reasons I did miss this '+' which does not make
sense when I submitted the former commit. We all did miss
it during codre reviews, so

fix(nxp-tools): fix2 create_pbl buildroot build

For some unknown reasons I did miss this '+' which does not make
sense when I submitted the former commit. We all did miss
it during codre reviews, sorry for the confusion. I do not understand
how it happened, late commits -> stupid issues.

Revert and fix: 634c7d81 fix create_pbl buildroot build
Wall -Werror -pedantic -std=c99 -O2 -DVERSION='"v2.12.0(release):master"' -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -c -o create_pbl.o create_pbl.c
make[3]: Wall: No such file or directory

Change-Id: I1e17e4793061966ce5fa5e0c122914bfaed27952
Signed-off-by: Vincent Jardin <vjardin@free.fr>

show more ...

fix(nxp-tools): fix create_pbl buildroot build

When building with Buildroot environment, the rule to build
the object is not used from the Makefile but from another one with
a higher priority.

It l

fix(nxp-tools): fix create_pbl buildroot build

When building with Buildroot environment, the rule to build
the object is not used from the Makefile but from another one with
a higher priority.

It leads to the following error:
Built fiptool successfully

EL3 Runtime Firmware BL31: offset=0x88, size=0xE401, cmdline="--soc-fw"
Non-Trusted Firmware BL33: offset=0xE489, size=0xD1438, cmdline="--nt-fw"

Wall -Werror -pedantic -std=c99 -O2 -DVERSION='"v2.12.0(release):master"' -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -c -o create_pbl.o create_pbl.c
make[3]: Wall: No such file or directory

Let's be explicit in order to enforce the local rule. There is not .h
file so it should be removed from the dependency list in oder to avoid
such error:
make[3]: *** No rule to make target 'create_pbl.h', needed by 'create_pbl.o'. Stop.

Change-Id: Idec378c5688e332695d805f3fca2800d905a1c74
Signed-off-by: Vincent Jardin <vjardin@free.fr>

show more ...

build(dev-deps): bump the dev-deps group across 3 directories with 9 updates

Bumps the dev-deps group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [sphinxcontrib

build(dev-deps): bump the dev-deps group across 3 directories with 9 updates

Bumps the dev-deps group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [sphinxcontrib-svg2pdfconverter](https://github.com/missinglinkelectronics/sphinxcontrib-svg2pdfconverter) | `1.2.2` | `1.3.0` |
| [click](https://github.com/pallets/click) | `8.1.7` | `8.1.8` |
| [plotly](https://github.com/plotly/plotly.py) | `5.24.0` | `5.24.1` |
| [igraph](https://github.com/igraph/python-igraph) | `0.11.6` | `0.11.8` |
| [tox](https://github.com/tox-dev/tox) | `4.18.1` | `4.24.2` |
| [jinja2](https://github.com/pallets/jinja) | `3.1.5` | `3.1.6` |

Bumps the dev-deps group with 5 updates in the /tools/cot_dt2c directory:

| Package | From | To |
| --- | --- | --- |
| [click](https://github.com/pallets/click) | `8.1.7` | `8.1.8` |
| [plotly](https://github.com/plotly/plotly.py) | `5.23.0` | `5.24.1` |
| [igraph](https://github.com/igraph/python-igraph) | `0.11.6` | `0.11.8` |
| [pyparsing](https://github.com/pyparsing/pyparsing) | `3.1.2` | `3.1.4` |
| [pytest](https://github.com/pytest-dev/pytest) | `8.3.4` | `8.3.5` |

Bumps the dev-deps group with 5 updates in the /tools/tlc directory:

| Package | From | To |
| --- | --- | --- |
| [click](https://github.com/pallets/click) | `8.1.7` | `8.1.8` |
| [pytest](https://github.com/pytest-dev/pytest) | `8.3.3` | `8.3.5` |
| [tox](https://github.com/tox-dev/tox) | `4.20.0` | `4.24.2` |
| [jinja2](https://github.com/pallets/jinja) | `3.1.5` | `3.1.6` |
| [bandit](https://github.com/PyCQA/bandit) | `1.7.9` | `1.7.10` |

Updates `sphinxcontrib-svg2pdfconverter` from 1.2.2 to 1.3.0
- [Commits](https://github.com/missinglinkelectronics/sphinxcontrib-svg2pdfconverter/compare/v1.2.2...v1.3.0)

Updates `click` from 8.1.7 to 8.1.8
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/click/compare/8.1.7...8.1.8)

Updates `plotly` from 5.24.0 to 5.24.1
- [Release notes](https://github.com/plotly/plotly.py/releases)
- [Changelog](https://github.com/plotly/plotly.py/blob/main/CHANGELOG.md)
- [Commits](https://github.com/plotly/plotly.py/compare/v5.24.0...v5.24.1)

Updates `igraph` from 0.11.6 to 0.11.8
- [Release notes](https://github.com/igraph/python-igraph/releases)
- [Changelog](https://github.com/igraph/python-igraph/blob/main/CHANGELOG.md)
- [Commits](https://github.com/igraph/python-igraph/compare/0.11.6...0.11.8)

Updates `tox` from 4.18.1 to 4.24.2
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.18.1...4.24.2)

Updates `jinja2` from 3.1.5 to 3.1.6
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/jinja/compare/3.1.5...3.1.6)

Updates `click` from 8.1.7 to 8.1.8
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/click/compare/8.1.7...8.1.8)

Updates `plotly` from 5.23.0 to 5.24.1
- [Release notes](https://github.com/plotly/plotly.py/releases)
- [Changelog](https://github.com/plotly/plotly.py/blob/main/CHANGELOG.md)
- [Commits](https://github.com/plotly/plotly.py/compare/v5.24.0...v5.24.1)

Updates `igraph` from 0.11.6 to 0.11.8
- [Release notes](https://github.com/igraph/python-igraph/releases)
- [Changelog](https://github.com/igraph/python-igraph/blob/main/CHANGELOG.md)
- [Commits](https://github.com/igraph/python-igraph/compare/0.11.6...0.11.8)

Updates `pyparsing` from 3.1.2 to 3.1.4
- [Release notes](https://github.com/pyparsing/pyparsing/releases)
- [Changelog](https://github.com/pyparsing/pyparsing/blob/master/CHANGES)
- [Commits](https://github.com/pyparsing/pyparsing/compare/pyparsing_3.1.2...3.1.4)

Updates `pytest` from 8.3.4 to 8.3.5
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest/compare/8.3.4...8.3.5)

Updates `click` from 8.1.7 to 8.1.8
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/click/compare/8.1.7...8.1.8)

Updates `pytest` from 8.3.3 to 8.3.5
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest/compare/8.3.4...8.3.5)

Updates `tox` from 4.20.0 to 4.24.2
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.18.1...4.24.2)

Updates `jinja2` from 3.1.5 to 3.1.6
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/jinja/compare/3.1.5...3.1.6)

Updates `bandit` from 1.7.9 to 1.7.10
- [Release notes](https://github.com/PyCQA/bandit/releases)
- [Commits](https://github.com/PyCQA/bandit/compare/1.7.9...1.7.10)

---
updated-dependencies:
- dependency-name: sphinxcontrib-svg2pdfconverter
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: dev-deps
- dependency-name: click
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: plotly
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: igraph
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: tox
dependency-type: indirect
update-type: version-update:semver-minor
dependency-group: dev-deps
- dependency-name: jinja2
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: click
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: plotly
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: dev-deps
- dependency-name: igraph
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: pyparsing
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: pytest
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: click
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: pytest
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: dev-deps
- dependency-name: jinja2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: dev-deps
- dependency-name: bandit
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-deps
...

Change-Id: Iae14b792174786dfb57fa0fb08de5af801d1d1e1
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

feat(sptool): add StMM memory region descriptor

StandaloneMM partition requires that the first memory region in its list
of reserved memory regions describe the full partition layout. Hafnium
SPMC c

feat(sptool): add StMM memory region descriptor

StandaloneMM partition requires that the first memory region in its list
of reserved memory regions describe the full partition layout. Hafnium
SPMC checks that memory regions in FF-A manifest do not overlap.
Therefore, this region is added directly in HOB generation code rather
than as a memory region in the FF-A manifest for the StMM partition.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Change-Id: Ia22174d755a5776e20ecf9639584f3c08cf9e60e

show more ...

feat(sptool): specify endianness for HOB bin

Specify endianness encoding when packing HOB binary. Little-endian is
used as target platforms are expected to be little-endian.

Signed-off-by: Kathleen

feat(sptool): specify endianness for HOB bin

Specify endianness encoding when packing HOB binary. Little-endian is
used as target platforms are expected to be little-endian.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Change-Id: I28d7b302f79482ed142c1964409c310f713a9b8c

show more ...

feat(sptool): include HOB file in the TL pkg

If the "hob_path" has been introduced in the `args`
dictionary, use it when creating a Transfer List
type of package.

Create a HOB entry in the transfer

feat(sptool): include HOB file in the TL pkg

If the "hob_path" has been introduced in the `args`
dictionary, use it when creating a Transfer List
type of package.

Create a HOB entry in the transfer list with the
respective transfer entry type.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Signed-off-by: J-Alves <joao.alves@arm.com>
Change-Id: Ie5fefe90205cf89ee26c3683048bf42229cb4bee

show more ...

feat(sptool): invoke the HOB list creation code

Add an SP setup function that invokes the HOB creation
utilities.

It introduces an argument "hob_path" to the shared dictionary of args
with the loca

feat(sptool): invoke the HOB list creation code

Add an SP setup function that invokes the HOB creation
utilities.

It introduces an argument "hob_path" to the shared dictionary of args
with the location of the generated binary containing the HOB list.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Signed-off-by: J-Alves <joao.alves@arm.com>
Change-Id: I26a07027b6344c9d7ba732d022932736a62e2505

show more ...

feat(sptool): add the HOB list creation script

Add python library to build the Handoff Block list (HOB list) for an SP
at build time.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Chan

feat(sptool): add the HOB list creation script

Add python library to build the Handoff Block list (HOB list) for an SP
at build time.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Change-Id: I17d46f7ed21ce42a83f33dfdc4fad038653d1ec3

show more ...

refactor(memmap): migrate to Poetry

This change refactors the memmap tool into a Poetry project, with its
own dependencies. You can continue to run it manually with:

poetry run memory <args>

C

refactor(memmap): migrate to Poetry

This change refactors the memmap tool into a Poetry project, with its
own dependencies. You can continue to run it manually with:

poetry run memory <args>

Change-Id: I346283df1b8bfad4babc1f5a3861dab94d4a006a
Signed-off-by: Chris Kay <chris.kay@arm.com>

show more ...

Merge "feat(sptool): transfer list to replace SP Pkg" into integration

feat(sptool): transfer list to replace SP Pkg

Generate the rules for calling 'tlc' tool, and generating
a partition package as a TL:
- The data is aligned to 4k.
- Using TE types 0x103 for FF-A mani

feat(sptool): transfer list to replace SP Pkg

Generate the rules for calling 'tlc' tool, and generating
a partition package as a TL:
- The data is aligned to 4k.
- Using TE types 0x103 for FF-A manifest, and 0x106 for
FF-A SP binary.

Signed-off-by: J-Alves <joao.alves@arm.com>
Change-Id: I1941e3e8f43d8dad33cdd0dea0571cf4a0d5e8f3

show more ...

feat(sptool): populate secure partition number in makefile

Calculate the secure partition number and saves it into the defined
macro NUM_SP.

Signed-off-by: Ben Horgan <ben.horgan@arm.com>
Signed-of

feat(sptool): populate secure partition number in makefile

Calculate the secure partition number and saves it into the defined
macro NUM_SP.

Signed-off-by: Ben Horgan <ben.horgan@arm.com>
Signed-off-by: Leo Yan <leo.yan@arm.com>
Change-Id: I4175a10d315482b65fd0f3eed4c6fd1e1e2b5e4d

show more ...