rpmb: fix parsing of op_result

From the eMMC spec, the "Operation result" (Table 19) -- 7 bit quantity
-- is the LSB of "Operation Results data structure" -- 16-bit quantity
-- minus the high order

rpmb: fix parsing of op_result

From the eMMC spec, the "Operation result" (Table 19) -- 7 bit quantity
-- is the LSB of "Operation Results data structure" -- 16-bit quantity
-- minus the high order bit. In other words it is
'rpmb_data_frame::op_result[1] & 0x7F' which is probably what we should
be doing here instead of bytes_to_u16().

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

rpmb: Convert comment about error into EMSG

This will give users more details without having to sift through the
code.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Fori

rpmb: Convert comment about error into EMSG

This will give users more details without having to sift through the
code.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

rpmb: verify key: change DMSG to EMSG

Rather than printing all results with DMSG, it's more suitable to
print only errors with EMSG.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-b

rpmb: verify key: change DMSG to EMSG

Rather than printing all results with DMSG, it's more suitable to
print only errors with EMSG.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

rpmb: print error if derive key fails

Let users know if an RPMB key fails to be generated during RPMB
initializations instead of just exiting the function quietly.

Signed-off-by: Victor Chong <vict

rpmb: print error if derive key fails

Let users know if an RPMB key fails to be generated during RPMB
initializations instead of just exiting the function quietly.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

rpmb: dump key if CFG_RPMB_WRITE_KEY=y

If we want to write key, then we'd want to write it down as well, so
print it for records.

Note that the key is printed with severity TRACE_DEBUG hence a rele

rpmb: dump key if CFG_RPMB_WRITE_KEY=y

If we want to write key, then we'd want to write it down as well, so
print it for records.

Note that the key is printed with severity TRACE_DEBUG hence a release
build will not leak it.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

rpmb: write key only if not yet programmed

An RPMB key should only be written if the device returns
RPMB_RESULT_AUTH_KEY_NOT_PROGRAMMED, not on any RPMB_RESULT* that is
not RPMB_RESULT_OK.

Signed-o

rpmb: write key only if not yet programmed

An RPMB key should only be written if the device returns
RPMB_RESULT_AUTH_KEY_NOT_PROGRAMMED, not on any RPMB_RESULT* that is
not RPMB_RESULT_OK.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: imx: add imx6sll evk board support

Add i.MX6SLL EVK board support.
Add mx6sllevk platform flavor.

Signed-off-by: Bai Ping <ping.bai@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.co

core: imx: add imx6sll evk board support

Add i.MX6SLL EVK board support.
Add mx6sllevk platform flavor.

Signed-off-by: Bai Ping <ping.bai@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: add imx6sl evk board support

Add i.MX6SL EVK board support.
Add mx6slevk platform flavor.

Signed-off-by: Bai Ping <ping.bai@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.com>

core: imx: add imx6sl evk board support

Add i.MX6SL EVK board support.
Add mx6slevk platform flavor.

Signed-off-by: Bai Ping <ping.bai@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: move SRC functions to a dedicated file

Move SRC functions from imx-common.c to a dedicated file imx_src.c

Signed-off-by: Silvano di Ninno <silvano.dininno@nxp.com>
Acked-by: Etienne Carr

core: imx: move SRC functions to a dedicated file

Move SRC functions from imx-common.c to a dedicated file imx_src.c

Signed-off-by: Silvano di Ninno <silvano.dininno@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: split registers declaration

Split imx registers declaration into separate files for imx6, imx7 and
imx8m.
Move it to a separate registers folder.

Signed-off-by: Silvano di Ninno <silvano

core: imx: split registers declaration

Split imx registers declaration into separate files for imx6, imx7 and
imx8m.
Move it to a separate registers folder.

Signed-off-by: Silvano di Ninno <silvano.dininno@nxp.com>
Signed-off-by: Alessandro Di Chiara <alessandro.dichiara@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: update PL310 settings for mx6sx

Update and fix PL310 settings for mx6sx.

Signed-off-by: Silvano di Ninno <silvano.dininno@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

core: imx: fix mx7swarp7 build

Split mx7 flavor list into two flavor lists:
* mx7s-flavorlist
* mx7d-flavorlist

Fix build error for mx7swarp7 platforms:
core/arch/arm/plat-imx/conf.mk:150: *** CF

core: imx: fix mx7swarp7 build

Split mx7 flavor list into two flavor lists:
* mx7s-flavorlist
* mx7d-flavorlist

Fix build error for mx7swarp7 platforms:
core/arch/arm/plat-imx/conf.mk:150: *** CFG_TEE_CORE_NB_CORE is set
to '2' (from file) but its value must be '1'. Stop.

Signed-off-by: Silvano di Ninno <silvano.dininno@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

plat-ls: add LS1028ARDB platform

Adds support for the The Layerscape® LS1028A reference
design board (LS1028ARDB) from NXP.

Signed-off-by: Sahil Malhotra <sahil.malhotra@nxp.com>
Reviewed-by: Joaki

plat-ls: add LS1028ARDB platform

Adds support for the The Layerscape® LS1028A reference
design board (LS1028ARDB) from NXP.

Signed-off-by: Sahil Malhotra <sahil.malhotra@nxp.com>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

core: remove user_ta_map() and friends

Removes the functions user_ta_map(), user_ta_unmap(), user_ta_set_prot()
and user_ta_remap() since what was left of them was just thin wrappers
around the vm_*

core: remove user_ta_map() and friends

Removes the functions user_ta_map(), user_ta_unmap(), user_ta_set_prot()
and user_ta_remap() since what was left of them was just thin wrappers
around the vm_* counterpart.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: remove struct load_seg

Removes struct load_seg, the mobj stored in struct load_seg is already
stored in struct vm_region. A flag VM_FLAG_EXCLUSIVE_MOBJ is added to
indicate that the mobj in st

core: remove struct load_seg

Removes struct load_seg, the mobj stored in struct load_seg is already
stored in struct vm_region. A flag VM_FLAG_EXCLUSIVE_MOBJ is added to
indicate that the mobj in struct vm_region should be freed instead of
just ignored when removing a region.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: store file pointer in struct mobj_with_fobj

Stores the file pointer in struct mobj_with_fobj instead of in struct
load_seg. When the mobj is freed the stored file pointer has its
reference cou

core: store file pointer in struct mobj_with_fobj

Stores the file pointer in struct mobj_with_fobj instead of in struct
load_seg. When the mobj is freed the stored file pointer has its
reference counter decreased instead of relying on free_seg() to do it
when the struct load_seg is freed.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add VM_FLAG_READONLY

Adds VM_FLAG_READONLY which is used to enforce that read-only parts of a
TA binary shared between TAs cannot be mapped read/write.

Reviewed-by: Jerome Forissier <jerome.f

core: add VM_FLAG_READONLY

Adds VM_FLAG_READONLY which is used to enforce that read-only parts of a
TA binary shared between TAs cannot be mapped read/write.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: user_ta_remap() use vm_remap()

user_ta_remap() switches to use vm_remap() instead of vm_unmap() and
vm_map_pad().

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Je

core: user_ta_remap() use vm_remap()

user_ta_remap() switches to use vm_remap() instead of vm_unmap() and
vm_map_pad().

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add vm_get_flags()

Adds vm_get_flags() which returns the flags of a mapped region.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@li

core: add vm_get_flags()

Adds vm_get_flags() which returns the flags of a mapped region.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add vm_remap()

Adds vm_remap() to allow changing virtual address of an already
established mapping

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <j

core: add vm_remap()

Adds vm_remap() to allow changing virtual address of an already
established mapping

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: split TEE_MATTR_* defines

Splits the TEE_MATTR_* defines into two groups, TEE_MATTR_* and VM_FLAG_*.
TEE_MATTR_* is restored to only handle mappings attributes and permissions.
The new group V

core: split TEE_MATTR_* defines

Splits the TEE_MATTR_* defines into two groups, TEE_MATTR_* and VM_FLAG_*.
TEE_MATTR_* is restored to only handle mappings attributes and permissions.
The new group VM_FLAG_* is added to tag regions with purpose and such.

As a consequence user_ta_map(), vm_map_pad() and vm_map() takes one more
argument, the flags field.

struct vm_region also gains a flags field, but since only the lower bits
are used in the flags and attr fields they are each stored as uint16_t
instead.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: simplify umap_add_region()

Simplifies umap_add_region() and select_va_in_range() by using dummy
regions for start and end of range.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

core: simplify umap_add_region()

Simplifies umap_add_region() and select_va_in_range() by using dummy
regions for start and end of range.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: vm_map_pad(): remove TEE_MATTR_PERMANENT test

Removes the unneeded TEE_MATTR_PERMANENT test for a paged mobj before
calling tee_pager_add_uta_area().

Acked-by: Jerome Forissier <jerome.foriss

core: vm_map_pad(): remove TEE_MATTR_PERMANENT test

Removes the unneeded TEE_MATTR_PERMANENT test for a paged mobj before
calling tee_pager_add_uta_area().

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: change vm_set_prot() to only accept prot bits

Changes vm_set_prot() to only accept prot bits as defined by
TEE_MATTR_PROT_MASK.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Sig

core: change vm_set_prot() to only accept prot bits

Changes vm_set_prot() to only accept prot bits as defined by
TEE_MATTR_PROT_MASK.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: only pass prot bits to tee_pager_add_uta_area()

Fixes vm_map_pad() to only pass the prot bits (TEE_MATTR_PROT_MASK) to
tee_pager_add_uta_area().

Fixes: 2616b1036291 ("core: add prot arg to te

core: only pass prot bits to tee_pager_add_uta_area()

Fixes vm_map_pad() to only pass the prot bits (TEE_MATTR_PROT_MASK) to
tee_pager_add_uta_area().

Fixes: 2616b1036291 ("core: add prot arg to tee_pager_add_uta_area()")
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...