Searched hist:"6 ba97f83dbb314b076588b97415a4078924e1903" (Results 1 – 2 of 2) sorted by relevance
| /rk3399_ARM-atf/drivers/marvell/comphy/ |
| H A D | phy-comphy-3700.h | 6ba97f83dbb314b076588b97415a4078924e1903 Wed Dec 01 12:23:11 UTC 2021 Marek Behún <marek.behun@nic.cz> fix(drivers/marvell/comphy-3700): fix reference clock selection value names
The current definitions of reference clock speed register values
#define PCIE_REF_CLOCK_SPEED_25M REF_CLOCK_SPEED_30M
#define USB3_REF_CLOCK_SPEED_25M REF_CLOCK_SPEED_30M
is ambiguous. The name of the constant implies 25 MHz, but the value
implies 30 MHz, which may make the reader think that the setting has
something to do with both values.
In reality, the values have different tables for SerDes and PCIe/USB3
PHY mode. The value for 25 MHz for PCIe/USB3 mode (0x2) is the value
for 30 MHz for SerDes mode.
Instead of defining the PCIe/USB3 constants relative to SerDes
constants, define them with absolute values, thus making it a little bit
more obvious that different modes have different value tables.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Change-Id: I50c66c6bbe22b9a9bec4685600cb8560524a643c
|
| H A D | phy-comphy-3700.c | 6ba97f83dbb314b076588b97415a4078924e1903 Wed Dec 01 12:23:11 UTC 2021 Marek Behún <marek.behun@nic.cz> fix(drivers/marvell/comphy-3700): fix reference clock selection value names
The current definitions of reference clock speed register values
#define PCIE_REF_CLOCK_SPEED_25M REF_CLOCK_SPEED_30M
#define USB3_REF_CLOCK_SPEED_25M REF_CLOCK_SPEED_30M
is ambiguous. The name of the constant implies 25 MHz, but the value
implies 30 MHz, which may make the reader think that the setting has
something to do with both values.
In reality, the values have different tables for SerDes and PCIe/USB3
PHY mode. The value for 25 MHz for PCIe/USB3 mode (0x2) is the value
for 30 MHz for SerDes mode.
Instead of defining the PCIe/USB3 constants relative to SerDes
constants, define them with absolute values, thus making it a little bit
more obvious that different modes have different value tables.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Change-Id: I50c66c6bbe22b9a9bec4685600cb8560524a643c
|