usb: host: ohci: fix null buffer pointer

During the USB enumeration phase, the buffer address passed by certain
commands such as usb_set_address() is NULL. Therefore, ensure that the
buffer is not e

usb: host: ohci: fix null buffer pointer

During the USB enumeration phase, the buffer address passed by certain
commands such as usb_set_address() is NULL. Therefore, ensure that the
buffer is not empty when calling flush_dcache_buffer().

Without this patch, the panic occurred and the call trace was parsed as
below by running ./scripts/stacktrace.sh dump.txt

Call trace:
PC: [< 40201dc0 >] __asm_flush_dcache_range+0x20/0x3c uboot-nextdev/arch/arm/cpu/armv8/cache.S:144
LR: [< 4025cfc4 >] sohci_submit_job+0x518/0x7f4 uboot-nextdev/drivers/usb/host/ohci-hcd.c:964

Stack:
[< 40201dc0 >] __asm_flush_dcache_range+0x20/0x3c
[< 4025d4d8 >] submit_common_msg+0xe0/0x1ac
[< 4025dba4 >] ohci_submit_control_msg+0x554/0x51c
[< 4025b9e8 >] submit_control_msg+0x48/0x9c
[< 4021abb8 >] usb_control_msg+0x5c/0xbc
[< 4021b934 >] usb_setup_device+0xb8/0x120
[< 4025bc88 >] usb_scan_device+0x98/0x2a0

Change-Id: I467fe5a02f21ad06de43d34d75c052f5603f7ae3
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>

show more ...

Merge branch 'next-dev' into thunder-boot

UPSTREAM: usb: Add nonblock argument to submit_int_msg

This will be used to implement non-blocking keyboard polling in case of
errors.

Conflicts:
common/usb.c
common/usb_kbd.c
common/usb_storage

UPSTREAM: usb: Add nonblock argument to submit_int_msg

This will be used to implement non-blocking keyboard polling in case of
errors.

Conflicts:
common/usb.c
common/usb_kbd.c
common/usb_storage.c
include/usb.h

Change-Id: I4a951d779e2cf9e80380f93000a87a617453fb32
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
(cherry picked from commit 3437121c037f502a3b0faaec97059777034a1ead)

show more ...

UPSTREAM: usb, ohci: add warning if none on pci found

Change-Id: I7e7a39a7d3ff257381a63a6bc07f86d1fa16a159
Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Frank Wang <frank.wang@rock-chips

UPSTREAM: usb, ohci: add warning if none on pci found

Change-Id: I7e7a39a7d3ff257381a63a6bc07f86d1fa16a159
Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
(cherry picked from commit f9c7fecbeb938d9a17e31bf7c8766190752790ae)

show more ...

UPSTREAM: usb, ohci-hcd: set OHCI_USE_NPS if DM_PCI

set OHCI_USE_NPS if DM_PCI is enabled.

Change-Id: I75001b7d3c9efdcd448d089ee0e99019a35d9d31
Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off

UPSTREAM: usb, ohci-hcd: set OHCI_USE_NPS if DM_PCI

set OHCI_USE_NPS if DM_PCI is enabled.

Change-Id: I75001b7d3c9efdcd448d089ee0e99019a35d9d31
Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
(cherry picked from commit dc4e48d845d9971d2b21f99c12f874dd06cedc0a)

show more ...

UPSTREAM: usb, ohci-hdc: fix warning 'ohci_pci_ids' defined but not used

var ohci_pci_ids is only used if DM_USB is not enabled.
So define this varaible only if
!CONFIG_IS_ENABLED(DM_USB)

Change-Id

UPSTREAM: usb, ohci-hdc: fix warning 'ohci_pci_ids' defined but not used

var ohci_pci_ids is only used if DM_USB is not enabled.
So define this varaible only if
!CONFIG_IS_ENABLED(DM_USB)

Change-Id: I2da8e2b51cd2f225e7b452bf5bb0179a2d1e4ee4
Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
(cherry picked from commit b005d7d5f96539450e50450f12491913e135c2a9)

show more ...

UPSTREAM: usb: ohci: Re-enable commented out delay

There is a delay function that was commented out. This patch
re-enables it, because it will be needed for da850 ohci support.

Change-Id: Ibfbe284

UPSTREAM: usb: ohci: Re-enable commented out delay

There is a delay function that was commented out. This patch
re-enables it, because it will be needed for da850 ohci support.

Change-Id: Ibfbe2844807ac13501cc17a297c724791e1eac52
Signed-off-by: Adam Ford <aford173@gmail.com>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
(cherry picked from commit e0b0af666a81f166397e3aebd26e9401ae48c97d)

show more ...

UPSTREAM: usb: s/CONFIG_DM_USB/CONFIG_IS_ENABLED(DM_USB)/

This allows to disable the USB driver model in SPL because it checks
the CONFIG_SPL_DM_USB variable for SPL builds. Nothing changes for
regu

UPSTREAM: usb: s/CONFIG_DM_USB/CONFIG_IS_ENABLED(DM_USB)/

This allows to disable the USB driver model in SPL because it checks
the CONFIG_SPL_DM_USB variable for SPL builds. Nothing changes for
regular non-SPL builds.

Conflicts:
drivers/usb/host/ehci-atmel.c
drivers/usb/host/xhci-fsl.c

Change-Id: If6c980c620cf97c1dd131f60953c305e34dba505
Signed-off-by: Sven Schwermer <sven@svenschwermer.de>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
(cherry picked from commit fd09c205fc57b90a782cac33449ef172575d0a8c)

show more ...

powerpc: remove 4xx support

There was for long time no activity in the 4xx area.
We need to go further and convert to Kconfig, but it
turned out, nobody is interested anymore in 4xx,
so remove it.

powerpc: remove 4xx support

There was for long time no activity in the 4xx area.
We need to go further and convert to Kconfig, but it
turned out, nobody is interested anymore in 4xx,
so remove it.

Signed-off-by: Heiko Schocher <hs@denx.de>

show more ...

powerpc, 5xxx, 512x: remove support for mpc5xxx and mpc512x

There was for long time no activity in the mpx5xxx area.
We need to go further and convert to Kconfig, but it
turned out, nobody is intere

powerpc, 5xxx, 512x: remove support for mpc5xxx and mpc512x

There was for long time no activity in the mpx5xxx area.
We need to go further and convert to Kconfig, but it
turned out, nobody is interested anymore in mpc5xxx,
so remove it.

Signed-off-by: Heiko Schocher <hs@denx.de>

show more ...

samsung: Drop more references fo s3c24x0

This is dead code now. Drop it.

Signed-off-by: Simon Glass <sjg@chromium.org>

Fix spelling of "resetting".

Cover-Letter: Fixes several spelling errors for the words "resetting",
"extended", "occur", and "multiple".

Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
Revi

Fix spelling of "resetting".

Cover-Letter: Fixes several spelling errors for the words "resetting",
"extended", "occur", and "multiple".

Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

show more ...

Merge branch 'master' of git://git.denx.de/u-boot-usb

drivers: USB: OHCI: allow compilation for 64-bit targets

OHCI has a known limitation of allowing only 32-bit DMA buffer
addresses, so we have a lot of u32 variables around, which are assigned
to poi

drivers: USB: OHCI: allow compilation for 64-bit targets

OHCI has a known limitation of allowing only 32-bit DMA buffer
addresses, so we have a lot of u32 variables around, which are assigned
to pointers and vice versa. This obviously creates issues with 64-bit
systems, so the compiler complains here and there.
To allow compilation for 64-bit boards which use only memory below 4GB
anyway (and to avoid more invasive fixes), adjust some casts and types
and assume that the EDs and TDs are all located in the lower 4GB.
This fixes compilation of the OHCI driver for the Pine64.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>

show more ...

Merge git://git.denx.de/u-boot

Merge git://git.denx.de/u-boot-usb

ohci: Add missing cache-flush for hcca area

We need to cache-flush the hcca area after the initial memset, otherwise
on the first hc_interrupt we might see an old $random value as done_head and
try

ohci: Add missing cache-flush for hcca area

We need to cache-flush the hcca area after the initial memset, otherwise
on the first hc_interrupt we might see an old $random value as done_head and
try to interpret that as the address for a completed td (followed by chaos).

Signed-off-by: Hans de Goede <hdegoede@redhat.com>

show more ...

Merge remote-tracking branch 'u-boot/master'

Move ALLOC_CACHE_ALIGN_BUFFER() to the new memalign.h header

Now that we have a new header file for cache-aligned allocation, we should
move the stack-based allocation macro there also.

Signed-off-

Move ALLOC_CACHE_ALIGN_BUFFER() to the new memalign.h header

Now that we have a new header file for cache-aligned allocation, we should
move the stack-based allocation macro there also.

Signed-off-by: Simon Glass <sjg@chromium.org>

show more ...

usb: ohci: enable cache support

Remove the CONFIG_DM_USB limitation to enable cache support functions.
Tested on SAMA5D3x-EK board.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
Acked-by: Hans de Goed

usb: ohci: enable cache support

Remove the CONFIG_DM_USB limitation to enable cache support functions.
Tested on SAMA5D3x-EK board.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>

show more ...

usb: ohci: Add support for interrupt queues

Add support for interrupt queues to the ohci hcd code, bringing it inline
with the ehci and musb-new(host) code.

Signed-off-by: Hans de Goede <hdegoede@r

usb: ohci: Add support for interrupt queues

Add support for interrupt queues to the ohci hcd code, bringing it inline
with the ehci and musb-new(host) code.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Marek Vasut <marex@denx.de>

show more ...

usb: ohci: Add an ohci_alloc_urb() function

Add an ohci_alloc_urb() function, this is a preparation patch for adding
interrupt queue support.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Revi

usb: ohci: Add an ohci_alloc_urb() function

Add an ohci_alloc_urb() function, this is a preparation patch for adding
interrupt queue support.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Marek Vasut <marex@denx.de>

show more ...

usb: ohci: Do not reuse ed for interrupt endpoints of different devices

When submitting interrupt packets to an endpoint we only link in the ed
once to avoid some races surrounding unlinking of peri

usb: ohci: Do not reuse ed for interrupt endpoints of different devices

When submitting interrupt packets to an endpoint we only link in the ed
once to avoid some races surrounding unlinking of periodic endpoints,
but we share one ohci_device struct / one set of ed-s for all devices,
which means that if we have an interrupt endpoint at endpoint 1 with one
device, and a non interrupt endpoint 1 with another device we end up
with the same ed linked into both the periodic and async lists, which is
not good (tm).

This commit switches over to using separate ohci_device structs, and thus
separate ed-s for devices with interrupt endpoints, fixing this.

This fixes e.g. matching a usb storage device and keyboard on the same
usb-1 hub not working.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Marek Vasut <marex@denx.de>

show more ...

usb: ohci: Add dm support

Add driver-model support to the ohci code.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Marek Vasut <marex@denx.de>

usb: ohci: Skip unnecessary mdelay(1) calls in various places

For some reason the ohci code is full with:

#ifdef DEBUG
pkt_print(...)
#else
mdelay(1);
#endif

AFAICT there is no reason for t

usb: ohci: Skip unnecessary mdelay(1) calls in various places

For some reason the ohci code is full with:

#ifdef DEBUG
pkt_print(...)
#else
mdelay(1);
#endif

AFAICT there is no reason for the mdelay(1) calls. This commit disables them
when building the ohci code for new driver-model using boards. It leaves
the mdelay(1) calls in place when building for older boards, so as to avoid
causing any regressions there.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>

show more ...