Merge "fix(psci): add missing curly braces" into integration

fix(el3-runtime): typecast operands to match data type

This corrects the MISRA violation C2012-10.3:
The value of an expression shall not be assigned to an object with a
narrower essential type or o

fix(el3-runtime): typecast operands to match data type

This corrects the MISRA violation C2012-10.3:
The value of an expression shall not be assigned to an object with a
narrower essential type or of a different essential type category.
Replaced usage of 'unsigned int' with 'size_t' to ensure type
consistency and prevent assignment to a narrower or different
essential type.

Change-Id: I79501e216a04753ebd005d64375357b9332440d9
Signed-off-by: Nithin G <nithing@amd.com>
Signed-off-by: Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com>

show more ...

fix(arm): typecast operands to match data type

This corrects the MISRA violation C2012-10.3:
The value of an expression shall not be assigned to an object with a
narrower essential type or of a diff

fix(arm): typecast operands to match data type

This corrects the MISRA violation C2012-10.3:
The value of an expression shall not be assigned to an object with a
narrower essential type or of a different essential type category.
The condition is explicitly checked against 0U, appending 'U' and
typecasting for unsigned comparison.

Change-Id: I7a2565ce6b8beb71dc9c711327ab72ce825111cc
Signed-off-by: Nithin G <nithing@amd.com>
Signed-off-by: Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com>

show more ...

Merge "fix(build): add DTB dependency for certificate generation" into integration

fix(build): add DTB dependency for certificate generation

When building ARM Trusted Firmware with Trusted Board Boot enabled
(TRUSTED_BOARD_BOOT=1 and GENERATE_COT=1) using parallel builds
(make -j)

fix(build): add DTB dependency for certificate generation

When building ARM Trusted Firmware with Trusted Board Boot enabled
(TRUSTED_BOARD_BOOT=1 and GENERATE_COT=1) using parallel builds
(make -j), the build fails with a dependency error where
certificate generation starts before Device Tree Blob (DTB)
files are built, even though certificates depend on DTB files.

Change-Id: I51bfe6c99406c77addb8f680351cbae6cf10edc6
Signed-off-by: Fabien Lehoussel <fabien.lehoussel@smile.fr>

show more ...

Merge "feat(st): put stm32image tool in build directory" into integration

fix(tpm): extend timeout before reading data

- extended timeout before reading data from timeout_msec_c (200ms) to timeout_msec_a (750ms)
- new timeout is compatible with spec and avoids incorrect b

fix(tpm): extend timeout before reading data

- extended timeout before reading data from timeout_msec_c (200ms) to timeout_msec_a (750ms)
- new timeout is compatible with spec and avoids incorrect behavior

Change-Id: I35a44e93a331a11fcab32b3b64c2adf770e5951d
Signed-off-by: Jenna May <jenna.may@arm.com>

show more ...

Merge "fix(mhu): shift by minor revision offset" into integration

Merge "feat(mt8189): add hotplug driver" into integration

Merge "feat(locks): add non-blocking spinlock_try() API" into integration

fix(qti): allow secure r/w to the EUD enable register

The EUD (Embedded USB Debugger) is an IP block that can only be toggled
from the secure world. Allow accessing its enable register through the
S

fix(qti): allow secure r/w to the EUD enable register

The EUD (Embedded USB Debugger) is an IP block that can only be toggled
from the secure world. Allow accessing its enable register through the
SCM MMIO R/W calls.

The remaining (non-qtiseclib) platforms don't feature this hardware.

Compile-tested only, but should be simple enough.

Change-Id: I2763fd89f2a9d068ec2b4662dc2de91d1d466666
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

show more ...

Merge "refactor(cm): gather per-world context management to the same place" into integration

feat(st): put stm32image tool in build directory

Following the series moving common tools compilation to the build
directory[1], do the same for stm32image tool.

[1]: cbd6cec3c3 feat(build): put fi

feat(st): put stm32image tool in build directory

Following the series moving common tools compilation to the build
directory[1], do the same for stm32image tool.

[1]: cbd6cec3c3 feat(build): put fiptool in the build directory

Signed-off-by: Yann Gautier <yann.gautier@st.com>
Change-Id: If33556e98c4788350a29c8ad96dc574584b67abd

show more ...

refactor(cm): gather per-world context management to the same place

The per-world calls are disparate - they get called in different places,
are guarded in different ways, and the code is apart.

Si

refactor(cm): gather per-world context management to the same place

The per-world calls are disparate - they get called in different places,
are guarded in different ways, and the code is apart.

Since they just need to be called once at boot, add a function that we
can call from BL31 and be done with it.

Change-Id: Id0ade302e35f2b00ca37c552a53038942ab7b58e
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...

Merge "feat(nxp-mmc): add timeout to blocking loops" into integration

Merge changes from topic "bk/multibuild" into integration

* changes:
fix(lx2160a): put cert_create_tbbr.mk in the standard location
feat(build): put crttool in the build directory
feat(build):

Merge changes from topic "bk/multibuild" into integration

* changes:
fix(lx2160a): put cert_create_tbbr.mk in the standard location
feat(build): put crttool in the build directory
feat(build): put enctool in the build directory
feat(build): put fiptool in the build directory
build(marvell): avoid using recursive expansion for BLE_INCLUDES

show more ...

fix(lx2160a): put cert_create_tbbr.mk in the standard location

The cert_create_tbbr.mk file is generally looked for in the platform
directory. The lx2160a breaks from this convention and stores the

fix(lx2160a): put cert_create_tbbr.mk in the standard location

The cert_create_tbbr.mk file is generally looked for in the platform
directory. The lx2160a breaks from this convention and stores the file
elsewhere, requiring a cludgy `cp` mid way through the make process. The
result is an untracked file when building the platform, which is
undesirable.

Fix this by putting the cert_create_tbbr.mk (and associated source
files) in the plat/ directory, just like we do for juno and stm32mp1.

Change-Id: Ifa8bb07dba4f55da4f0e230efa7beccf30bd1de7
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...

feat(build): put crttool in the build directory

Same as fiptool. Move all artefacts to the platform build directory and
convert to the standard build macro to make things more generic. Leave
a symli

feat(build): put crttool in the build directory

Same as fiptool. Move all artefacts to the platform build directory and
convert to the standard build macro to make things more generic. Leave
a symlink for the final binary in case someone depends on it.

Change-Id: I82ef846a95474ba385377032fb185e548827bf5c
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...

feat(build): put enctool in the build directory

Same as fiptool. Move all artefacts to the platform build directory and
convert to the standard build macro to make things more generic. Only
differen

feat(build): put enctool in the build directory

Same as fiptool. Move all artefacts to the platform build directory and
convert to the standard build macro to make things more generic. Only
difference is that there is no symlink as the tool is only used
internally and is not exported.

Change-Id: I7570f13505ed9c5d91b3582d9981177df4d5d04c
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...

feat(build): put fiptool in the build directory

For some reason, tools are not built in the build directory, but rather
in the source directory, regardless of what BUILD_BASE might say. This
is espe

feat(build): put fiptool in the build directory

For some reason, tools are not built in the build directory, but rather
in the source directory, regardless of what BUILD_BASE might say. This
is especially annoying when trying to have a few builds going at the
same time (like in a CI). For example, run A may check if a file X
exists. Seeing that it does not, it will start building the file. At the
same time, run B may also check if file X exists but before A has
written it, starting a build again. Then it is possible for A to use the
file it believes to have built right at the moment B begins writing to
it (and truncating it beforehand). This results in gcc failing to read a
fail and a failed build. The more parallel runs there are, the more
likely this is to happen, and this is virtually guaranteed to happen
with just a handful onwards.

So move fiptool and all of its build artefacts to the build directory.
Since there are platform differences between the various fiptool
incarnations, this goes in the plat build rather than a more top-level
location.

This patch adds the build macro MAKE_TOOL to do this generically for any
kind of tool since the other tools suffer from the same shortfall. This
macro takes care to use unique names for every type of argument that
building a tool might need. The fiptool makefile and platform add-ons
are updated accordingly.

This should have never been allowed in the first place, but downstream
scripts almost certainly depend on this behaviour now. So add a symlink
in the place of the old fiptool so these continue working. With any
luck, this will be removed in the future.

Change-Id: I3d4d87dab0f53deab5b43fbc6652146f0e4e7e81
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...

build(marvell): avoid using recursive expansion for BLE_INCLUDES

Commit 559ab2df4 specifies that there should be a PLAT_INCLUDES
specifically for the BLE image. This is done with a quirky rule that

build(marvell): avoid using recursive expansion for BLE_INCLUDES

Commit 559ab2df4 specifies that there should be a PLAT_INCLUDES
specifically for the BLE image. This is done with a quirky rule that
triggers only on the BLE files and relies on PLAT_INCLUDES expanding
recursively to work correctly.

Recursively expanded variables are a brittle part of the build system,
so this patch removes that aspect but keeps the BLE_INCLUDES principle
via the BLE_INCLUDE_DIRS variable that MAKE_C will correctly pick up.

Change-Id: Ibd10904f6a005fef9ed242b65e96662ce002eb18
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...

Merge changes I9bc7b609,Ie56dc965,Ic57d46bf,I3f2ab549,I3ad715fa, ... into integration

* changes:
refactor(build): initialise `arch-features` closer to where it is needed
refactor(build): define

Merge changes I9bc7b609,Ie56dc965,Ic57d46bf,I3f2ab549,I3ad715fa, ... into integration

* changes:
refactor(build): initialise `arch-features` closer to where it is needed
refactor(build): define the W and DEBUG flags in the standard way
refactor(build): put the cross referencing of options together
fix: use LDLIBS instead of LDFLAGS for library search paths
fix(build): remove redundant variables
fix(intel): fix variable may be used uninitialized error

show more ...

refactor(build): initialise `arch-features` closer to where it is needed

Change-Id: I9bc7b609e7cb5aa42528ba151b5a30c386de0792
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

refactor(build): define the W and DEBUG flags in the standard way

We have the assert_boolean section where DEBUG belongs and W should have
an initial value (of 0) and only be allowed to be a number.

refactor(build): define the W and DEBUG flags in the standard way

We have the assert_boolean section where DEBUG belongs and W should have
an initial value (of 0) and only be allowed to be a number.

Change-Id: Ie56dc9659f32c8a202f4506bc27e8bbf84c0f73f
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...

refactor(build): put the cross referencing of options together

We have an immense number of incompatible options and several places to
check them, making things hard to follow and leading to some
du

refactor(build): put the cross referencing of options together

We have an immense number of incompatible options and several places to
check them, making things hard to follow and leading to some
duplication. Previous attempts at reordering helped in the short term
but things have slowly deteriorated again.

Tackle this by introducing a single file to do all cross referencing of
all options. This should remove any ambiguity as to where these go.

No functional change besides relative ordering in the top-level Makefile.

Change-Id: Ic57d46bf602bd34d3af45a05e4ac8ca0dfcd1f7b
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>

show more ...