core: fix possible NULL dereference in tee_ta_close_session()

This patch fixes a possible NULL dereference in a debug print in
tee_ta_close_session() which is done before checking the supplied
param

core: fix possible NULL dereference in tee_ta_close_session()

This patch fixes a possible NULL dereference in a debug print in
tee_ta_close_session() which is done before checking the supplied
parameter for NULL.

Fixes: 99164a05ff51 ("core: do not use virtual addresses as session identifier")
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ftrace: enable trace for utee_* assembly APIs

Enable function trace for utee_* syscall assembly APIs for better view
of user-space to kernel switching.

Suggested-by: Jerome Forissier <jerome.foriss

ftrace: enable trace for utee_* assembly APIs

Enable function trace for utee_* syscall assembly APIs for better view
of user-space to kernel switching.

Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

checkpatch: allow string concatenation without space

Adds --ignore CONCATENATED_STRING to checkpatch to allow constructs
like:
DMESG("value1 %"PRIX32" value2 %"PRIX32, v1, v2);

Without this we're f

checkpatch: allow string concatenation without space

Adds --ignore CONCATENATED_STRING to checkpatch to allow constructs
like:
DMESG("value1 %"PRIX32" value2 %"PRIX32, v1, v2);

Without this we're forced to use:
DMESG("value1 %" PRIX32 " value2 %" PRIX32, v1, v2);

Which is a bit harder to read, especially for more complicated cases.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

checkpatch: use --strict option

Uses the --strict option with checkpatch to catch more of the common style
issues. Ignoring the PREFER_KERNEL_TYPES since we are normally not using
those types. CAMEL

checkpatch: use --strict option

Uses the --strict option with checkpatch to catch more of the common style
issues. Ignoring the PREFER_KERNEL_TYPES since we are normally not using
those types. CAMELCASE is also ignored for now since it triggers many false
positives due to the TEE_Result type.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: imx: Add imx7ulp evk board support

Add support for i.MX 7ulp SoC

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Alessandro Di Chiara <alessandro.dichiara@nxp.com>
Signed-off-by: Cl

core: imx: Add imx7ulp evk board support

Add support for i.MX 7ulp SoC

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Alessandro Di Chiara <alessandro.dichiara@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: fix gpcv2 compilation

gpcv2 functions are only used by imx7 platform and not shared with other
SoCs.

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Peng Fan <peng.fan@

core: imx: fix gpcv2 compilation

gpcv2 functions are only used by imx7 platform and not shared with other
SoCs.

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

drivers: imx_wdog: update wdog support for mx7ulp

Update watchdog for imx7ulp SoC support.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

drivers: imx_lpuart: add i.MX lpuart driver

add new lpuart driver
This driver is used by the i.MX 7ulp SoC

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@li

drivers: imx_lpuart: add i.MX lpuart driver

add new lpuart driver
This driver is used by the i.MX 7ulp SoC

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: minor compilation fix

Merge compilation rules for a7_plat_init.S

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere

core: imx: minor compilation fix

Merge compilation rules for a7_plat_init.S

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: fix soc revision for imx7

digproc registers layout differs for mx7

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carrier

core: imx: fix soc revision for imx7

digproc registers layout differs for mx7

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: imx: re-work SoC version detection

Move DIGPROG_OFFSET to appropriate registers header files.
Store cpu type and SoC revision in global variables instead of
reading ANATOP registers each time.

core: imx: re-work SoC version detection

Move DIGPROG_OFFSET to appropriate registers header files.
Store cpu type and SoC revision in global variables instead of
reading ANATOP registers each time.
imx_digproc() now gets also the minor SoC revision.

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

build: correct sign.py mandated arguments

Script sign.py mandates arguments --key and --inf. This change corrects
argument definition and usage accordingly.

Signed-off-by: Etienne Carriere <etienne

build: correct sign.py mandated arguments

Script sign.py mandates arguments --key and --inf. This change corrects
argument definition and usage accordingly.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

script/sign.py: introduce --ta-version

Restores argument --version to script sign.py to allow user to
set the trusted application version identifier in the signed
header of the TA binary image. This

script/sign.py: introduce --ta-version

Restores argument --version to script sign.py to allow user to
set the trusted application version identifier in the signed
header of the TA binary image. This argument was removed by [1].
This change also renames argument into --ta-version to prevent
confusion with script or data structure versioning argument.

[1] commit 1cdd95a2a46d ("Support offline signing of TAs.")

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: rename versioning field in bootstrap TA header

Rename field version into ta_version in struct shdr_bootstrap_ta
to explicit the info related to TA versioning.

Signed-off-by: Etienne Carriere

core: rename versioning field in bootstrap TA header

Rename field version into ta_version in struct shdr_bootstrap_ta
to explicit the info related to TA versioning.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: unwind: fix function args for print_stack_arm64

Fix a build failure when CFG_TEE_CORE_LOG_LEVEL=0,

core/arch/arm/kernel/abort.c: In function ‘__print_stack_unwind’:
core/arch/arm/kernel/abort

core: unwind: fix function args for print_stack_arm64

Fix a build failure when CFG_TEE_CORE_LOG_LEVEL=0,

core/arch/arm/kernel/abort.c: In function ‘__print_stack_unwind’:
core/arch/arm/kernel/abort.c:85:2: error: too few arguments to function
‘print_stack_arm64’
print_stack_arm64(TRACE_ERROR, &state, thread_stack_start(),
^~~~~~~~~~~~~~~~~

Signed-off-by: Clement Faure <clement.faure@nxp.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: ftrace: fix incorrect usage of ROUNDUP

Fix incorrect usage of ROUNDUP macro during ftrace data dump to normal
world. It leads to random crashes dependent on ftrace buffer size.

Fixes: 153479a

core: ftrace: fix incorrect usage of ROUNDUP

Fix incorrect usage of ROUNDUP macro during ftrace data dump to normal
world. It leads to random crashes dependent on ftrace buffer size.

Fixes: 153479acb74e ("core: dump ftrace data with ldelf")
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

arm32_sysreg.py: shorten lines to <= 79 characters

pycodestyle v2.4.0 complains:

$ pycodestyle scripts/arm32_sysreg.py
scripts/arm32_sysreg.py:72:80: E501 line too long (80 > 79 characters)
scripts

arm32_sysreg.py: shorten lines to <= 79 characters

pycodestyle v2.4.0 complains:

$ pycodestyle scripts/arm32_sysreg.py
scripts/arm32_sysreg.py:72:80: E501 line too long (80 > 79 characters)
scripts/arm32_sysreg.py:99:80: E501 line too long (80 > 79 characters)

Break those two lines before the 79 character limit.

Fixes: 4486d5866e238 ("libutee: add headers for user-space to access sysregs")
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

drivers: wdt: Add arm SP805 watchdog driver

Add sp805 watchdog driver with following functionality:
- start/reload watchdog with specified timeout
- stop watchdog
- ping watchdog (clear watchdog int

drivers: wdt: Add arm SP805 watchdog driver

Add sp805 watchdog driver with following functionality:
- start/reload watchdog with specified timeout
- stop watchdog
- ping watchdog (clear watchdog interrupt and reload it)
- register watchdog interrupt handler

Signed-off-by: Abhishek Shah <abhishek.shah@broadcom.com>
Reviewed-by: Sandeep Tripathy <sandeep.tripathy@broadcom.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

ftrace: Add function execution time support

Add support to dump function execution time at corresponding function
exit points in output ftrace buffer.

To achieve proper function execution time we n

ftrace: Add function execution time support

Add support to dump function execution time at corresponding function
exit points in output ftrace buffer.

To achieve proper function execution time we need to exclude TA suspend
time from timestamps, so add corresponding support in TEE core.

Also user mapping must be active to access ftrace buffer, so do that
during TA resume.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (QEMU)
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ldelf: ftrace: pass ftrace buffer address to kernel

Enable support to pass ftrace buffer address to kernel during loading
of particular TA. It is required to support function execution time
feature

ldelf: ftrace: pass ftrace buffer address to kernel

Enable support to pass ftrace buffer address to kernel during loading
of particular TA. It is required to support function execution time
feature since kernel needs to update timestamps in ftrace buffer during
TA suspends for proper execution time.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

libutee: add headers for user-space to access sysregs

User space may require to access system registers like generic timer
registers in case function tracing is enabled etc. So provide headers
for u

libutee: add headers for user-space to access sysregs

User space may require to access system registers like generic timer
registers in case function tracing is enabled etc. So provide headers
for user space to access sysregs.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: ftrace: Enable user-space access to counter regs

To enable function execution time support in function tracing output,
user-space ftrace framework needs to access frequency register and
physic

core: ftrace: Enable user-space access to counter regs

To enable function execution time support in function tracing output,
user-space ftrace framework needs to access frequency register and
physical counter register. So enable user-space access.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Add scripts/get_maintainer.py

Adds a script to help identify all the maintainer/reviewers for some
path in the source tree, or for some patch or Github pull request.
When processing a patch or a pul

Add scripts/get_maintainer.py

Adds a script to help identify all the maintainer/reviewers for some
path in the source tree, or for some patch or Github pull request.
When processing a patch or a pull request the script can take into
account the Acked-by: and Reviewed-by: tags, so that it can easily tell
if a change is ready to be merged or still needs reviewing (and by
whom). Information comes from the MAINTAINERS file.

The script is similar to the Linux kernel's get_maintainer.pl, although
its use cases are a bit different.

Examples:

1. Who maintains the i.MX platform? Do not show the top-level maintainers
(subsystem "THE REST"), unless there is no specific maintainer.

$ ./scripts/get_maintainer.py --strict core/arch/arm/plat-imx
Peng Fan <peng.fan@nxp.com> [@MrVan] (reviewer:NXP (Freescale) i.MX family)
$

2. Who maintains the i.MX configuration file?

$ ./scripts/get_maintainer.py --strict core/arch/arm/plat-imx/conf.mk
Peng Fan <peng.fan@nxp.com> [@MrVan] (reviewer:NXP (Freescale) i.MX family)
Peng Fan <peng.fan@nxp.com> [@MrVan] (reviewer:NXP (Freescale) i.MX7 WaRP7)
Bryan O'Donoghue <bryan.odonoghue@linaro.org> [@bryanodonoghue] (reviewer:NXP (Freescale) i.MX7 WaRP7)
$

3. Is PR 3169 ready for merging?

$ ./scripts/get_maintainer.py --merge-check --github-pr 3169
Downloading https://github.com/OP-TEE/optee_os/pull/3169.patch... Done.
$

4. Is PR 3169 lacking some reviews from subsystem maintainers? In other
words, is it still properly approved for merging if we ignore the tags
given by members of subsystem "THE REST" whenever there is another
subsystem maintainer?

$ ./scripts/get_maintainer.py --merge-check --strict --github-pr 3169
Peng Fan <peng.fan@nxp.com> [@MrVan] (reviewer:NXP (Freescale) i.MX family)
Peng Fan <peng.fan@nxp.com> [@MrVan] (reviewer:NXP (Freescale) i.MX7 WaRP7)
Bryan O'Donoghue <bryan.odonoghue@linaro.org> [@bryanodonoghue] (reviewer:NXP (Freescale) i.MX7 WaRP7)
$

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

MAINTAINERS: fix tag for Hisilicon D02

The platform path for Hisilicon D02 is incorrectly tagged as 'S:' in
the MAINTAINERS file. Use 'F:' instead.

Signed-off-by: Jerome Forissier <jerome.forissier

MAINTAINERS: fix tag for Hisilicon D02

The platform path for Hisilicon D02 is incorrectly tagged as 'S:' in
the MAINTAINERS file. Use 'F:' instead.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: add CFG_CORE_WORKAROUND_NSITR_CACHE_PRIME

Adds CFG_CORE_WORKAROUND_NSITR_CACHE_PRIME which if 'y' enables
protection against a tool like Cachegrab
(https://github.com/nccgroup/cachegrab), whic

core: add CFG_CORE_WORKAROUND_NSITR_CACHE_PRIME

Adds CFG_CORE_WORKAROUND_NSITR_CACHE_PRIME which if 'y' enables
protection against a tool like Cachegrab
(https://github.com/nccgroup/cachegrab), which uses non-secure
interrupts to prime and later analyze the L1D, L1I and BTB caches to
gain information from secure world execution.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...