ta: remoteproc: clarify remoteproc_get_tlv() behavior

Add an inline comment to explicitly state that TA remoteproc local
function remoteproc_get_tlv() loads specific values in its output
arguments w

ta: remoteproc: clarify remoteproc_get_tlv() behavior

Add an inline comment to explicitly state that TA remoteproc local
function remoteproc_get_tlv() loads specific values in its output
arguments when it returns with error code TEE_ERROR_NO_DATA.
This way it is clearer that caller expect such values on such error
cases.

Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>

show more ...

ta: remoteproc: clarify case empty key info is last TLV cell

Clarify case when remote processor firmware key info
TLV RPROC_TLV_PKEYINFO is present but empty (size = 0) and is placed
last in the TLV

ta: remoteproc: clarify case empty key info is last TLV cell

Clarify case when remote processor firmware key info
TLV RPROC_TLV_PKEYINFO is present but empty (size = 0) and is placed
last in the TLVs memory area hence its value cell start address matches
the TLV area end address. The previous implementation was fine but
it looked odd the main loop does not address the case.

Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>

show more ...

remoteproc: fix potential overflows in TLV parsing

This commit is fixing two issues:
- Verify that the end of the buffer is not reached before reading the
tag and value.
- Verify that the entire TLV

remoteproc: fix potential overflows in TLV parsing

This commit is fixing two issues:
- Verify that the end of the buffer is not reached before reading the
tag and value.
- Verify that the entire TLV fits into the TLV chunk

Signed-off-by: Alexandre Gonzalo <alexandre.gonzalo@arm.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>

show more ...

ta: remoteproc: add command to release remote processor firmware

This patch introduces a new command `TA_RPROC_CMD_RELEASE_FW` to release
the firmware images and associated resources of a remote pro

ta: remoteproc: add command to release remote processor firmware

This patch introduces a new command `TA_RPROC_CMD_RELEASE_FW` to release
the firmware images and associated resources of a remote processor.

This command can be called by the non-secure context to release the loaded
firmware if the remoteproc is not running.

The command can be used, for instance, in case an error occurs in the
non-secure context between the load request and the start of the
remote processor. Calling the command allows releasing the loaded firmware
and going back to the REMOTEPROC_OFF state.

This command should also be called after the stop of the
remote processor to release associated resources.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>

show more ...

ta: remoteproc: allow remoteproc_load_fw re-entrance

Instead of returning an error if the TA_RPROC_CMD_LOAD_FW is called
several times, just return TEE_SUCCESS if the firmware is already loaded.

Th

ta: remoteproc: allow remoteproc_load_fw re-entrance

Instead of returning an error if the TA_RPROC_CMD_LOAD_FW is called
several times, just return TEE_SUCCESS if the firmware is already loaded.

This commit is the result of a discussion on Linux Kernel mailing list:
https://lore.kernel.org/lkml/ZeCujRgH%2FodzU9og@p14s/

Fixes: fcf382e2440c ("ta: remoteproc: add remote processor Trusted Application")

Suggested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

show more ...

ta: remoteproc: add support for resource table

The resource table is a specific table declared in the remote processor
firmware and that is parsed by the main processor to discover resources
and con

ta: remoteproc: add support for resource table

The resource table is a specific table declared in the remote processor
firmware and that is parsed by the main processor to discover resources
and configure inter-processors communication.
The resource table is requested by the non-secure context.
The remoteproc TA retrieves it from the firmware ELF file.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

ta: remoteproc: add support for start and stop command

Implement command TA_RPROC_FW_CMD_START_FW and TA_RPROC_FW_CMD_STOP_FW
in remoteproc TA. The TA relay the request to the platform specific PTA

ta: remoteproc: add support for start and stop command

Implement command TA_RPROC_FW_CMD_START_FW and TA_RPROC_FW_CMD_STOP_FW
in remoteproc TA. The TA relay the request to the platform specific PTA
that can act on the hardware.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

ta: remoteproc: add remote processor Trusted Application

Add a generic TA for a remote processor firmware management.
This TA should be defined as early TA to allow remote processor
firmware managem

ta: remoteproc: add remote processor Trusted Application

Add a generic TA for a remote processor firmware management.
This TA should be defined as early TA to allow remote processor
firmware management in Linux kernel built-in driver and in boot stages.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

ta: remoteproc: add firmware ELF parser

Add a ELF parser that will used by the remoteproc generic TA.
It is in charge of parsing the ELF files to extract segments
to load in the remote processor mem

ta: remoteproc: add firmware ELF parser

Add a ELF parser that will used by the remoteproc generic TA.
It is in charge of parsing the ELF files to extract segments
to load in the remote processor memories.
It also offers an API to retrieve the resource table in the
image. This optional table is defined in a specific section
".resource_table" and is used by the Linux remoteproc driver to
discover services exposed by the remote processor.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...