ta: avb: fix memory copied in read_persist_value()read_persist_value() allocates a temporary buffer and reads persistentvalue from secure storage into that buffer. Next it copies the contentof th
ta: avb: fix memory copied in read_persist_value()read_persist_value() allocates a temporary buffer and reads persistentvalue from secure storage into that buffer. Next it copies the contentof the buffer into an out memref, but it copies the number of allocatedbytes instead of the size of the persistent value. No unintendedinformation leaks though, since Temporary buffer was zero-initialized byTEE_Malloc(). To avoid unnecessary copying, copy only the number of readbytes from secure storage.Fixes: ddcd07a27aa6 ("ta: avb: copy data to temporary buffers")Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>Reviewed-by: Jerome Forissier <jerome.forissier@arm.com>Reviewed-by: Etienne Carriere <etienne.carriere@st.com>
show more ...
ta: avb: Add TA version and description property valuesAdd meaningful values for AVB TA version and description propertiesto replace previously embedded default respective values"Undefined versio
ta: avb: Add TA version and description property valuesAdd meaningful values for AVB TA version and description propertiesto replace previously embedded default respective values"Undefined version" and "Undefined description".Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>Acked-by: Jerome Forissier <jerome.forissier@linaro.org>Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
ta: remove unnecessary includesRemove unnecessary includes.Signed-off-by: Clement Faure <clement.faure@nxp.com>Acked-by: Jerome Forissier <jerome.forissier@linaro.org>Acked-by: Jens Wiklander <
ta: remove unnecessary includesRemove unnecessary includes.Signed-off-by: Clement Faure <clement.faure@nxp.com>Acked-by: Jerome Forissier <jerome.forissier@linaro.org>Acked-by: Jens Wiklander <jens.wiklander@linaro.org>Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
Upgrade in-tree TAs to use latest version of TEE Internal Core APIUpgrades in-tree TAs to use latest version of TEE Internal Core API andthe compatibility flag is by default turned off.Upgrading
Upgrade in-tree TAs to use latest version of TEE Internal Core APIUpgrades in-tree TAs to use latest version of TEE Internal Core API andthe compatibility flag is by default turned off.Upgrading the TAs is basically a matter of replacing a few uint32_tpointers with size_t pointers instead. This is done in as few places aspossible. So in particular the PKCS#11 TA might benefit from anotherround of refactoring now that the contagious use of uint32_t as sizefield is removed.Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
ta: avb: fix object leakage at lock state writeShould close object created for reading, so better use seekand then close the object.Fixes: b29b419506fa ("ta: add AVB TA")Reviewed-by: Jens Wikla
ta: avb: fix object leakage at lock state writeShould close object created for reading, so better use seekand then close the object.Fixes: b29b419506fa ("ta: add AVB TA")Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@globallogic.com>
avb: Fix warnings in ta/avb/entry.cFixes -Wdeclaration-after-statement warnings in ta/avb/entry.c:ta/avb/entry.c: In function ‘write_persist_value’:ta/avb/entry.c:267:2: error: ISO C90 forbids mi
avb: Fix warnings in ta/avb/entry.cFixes -Wdeclaration-after-statement warnings in ta/avb/entry.c:ta/avb/entry.c: In function ‘write_persist_value’:ta/avb/entry.c:267:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] char *name_buf = params[0].memref.buffer; ^~~~ta/avb/entry.c: In function ‘read_persist_value’:ta/avb/entry.c:316:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] char *name_buf = params[0].memref.buffer; ^~~~Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
ta: avb: copy data to temporary buffersUse intermediate temporary buffers instead of directly supplyingnon-secure buffers to TEE_ReadObjectData()/TEE_CreatePersistentObject().This fixes TA panics
ta: avb: copy data to temporary buffersUse intermediate temporary buffers instead of directly supplyingnon-secure buffers to TEE_ReadObjectData()/TEE_CreatePersistentObject().This fixes TA panics while accessing persistent objects:E/TC:? 0 TA panicked with code 0xffff0001E/LD: Status of TA 023f8f1a-292a-432b-8fc4-de8471358067...D/TC:? 0 user_ta_enter:176 tee_user_ta_enter: TA panicked withcode 0xffff0001Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io>Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
TA dev kit: expose CFG_TA_VERSION build optionAllow to configure version of a TA via CFG_TA_VERSION as TA compiletime option.Signed-off-by: Sumit Garg <sumit.garg@linaro.org>Reviewed-by: Jerome
TA dev kit: expose CFG_TA_VERSION build optionAllow to configure version of a TA via CFG_TA_VERSION as TA compiletime option.Signed-off-by: Sumit Garg <sumit.garg@linaro.org>Reviewed-by: Jerome Forissier <jerome@forissier.org>Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
ta: avb: add support for named persistent valuesIntroduce support for named persistent values [1], that are mainly usedto store persistent digests.Link: [1] https://android.googlesource.com/plat
ta: avb: add support for named persistent valuesIntroduce support for named persistent values [1], that are mainly usedto store persistent digests.Link: [1] https://android.googlesource.com/platform/external/avb/+/master/README.md#Named-Persistent-ValuesReviewed-by: Jens Wiklander <jens.wiklander@linaro.org>Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>
ta: add AVB TAAdds an AVB TA to be used to provide required services for AVB in U-boot.Acked-by: Jerome Forissier <jerome.forissier@linaro.org>Signed-off-by: Jens Wiklander <jens.wiklander@linar
ta: add AVB TAAdds an AVB TA to be used to provide required services for AVB in U-boot.Acked-by: Jerome Forissier <jerome.forissier@linaro.org>Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>