Home
last modified time | relevance | path

Searched hist:a7cb29b7d5dbc2ff9177695425ff065215a314cb (Results 1 – 1 of 1) sorted by relevance

/rk3399_rockchip-uboot/drivers/video/drm/
H A Drockchip_vop2.ca7cb29b7d5dbc2ff9177695425ff065215a314cb Tue Feb 11 12:32:39 UTC 2025 Damon Ding <damon.ding@rock-chips.com> video/drm: vop2: fix the unexpected logs related to the primary plane of the unused VPs

If only the logo display of VP0 is enabled in RK3576, the unexpected
logs may appear:
......
Assign plane mask automatically
VOP have 1 active VP
vp0 have layer nr:1[Esmart0 ], primary plane: Esmart0
vp1 have layer nr:0[], primary plane: Cluster0
vp2 have layer nr:0[], primary plane: Cluster0
......

It is better to be like:
......
VOP have 1 active VP
vp0 have layer nr:1[Esmart0 ], primary plane: Esmart0
vp1 have layer nr:0[], primary plane: INVALID
vp2 have layer nr:0[], primary plane: INVALID
......

The modifications are:
1.Set primary plane id of unused VPs to ROCKCHIP_VOP2_PHY_ID_INVALID.
2.Convert the type of ROCKCHIP_VOP2_PHY_ID_INVALID to u8 to avoid
unexpected comparison result, due to the parameters
&vop2_vp_plane_mask.primary_plane_id and
&vop2_vp_plane_mask.attached_layers are also u8.

In addition, it may be better to rename vop2_plane_id_to_string() to
vop2_plane_phys_id_to_string() based on the definition of
&vop2_win_data.phys_id.

Change-Id: I4cea1d91fabc03d110d176282acab04670da9054
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>