Searched hist:"835688 ac5ca7b0a507c4860121019b95df82d32d" (Results 1 – 4 of 4) sorted by relevance
| /optee_os/core/ |
| H A D | core.mk | 835688ac5ca7b0a507c4860121019b95df82d32d Thu Apr 11 16:25:27 UTC 2024 Jerome Forissier <jerome.forissier@linaro.org> core: make sure tee_entry_get_os_revision() uses a proper TEE_IMPL_GIT_SHA1
tee_entry_get_os_revision() stores TEE_IMPL_GIT_SHA1 into a 32 or 64-bit register, depending on the platform. Unfortunately the command that creates TEE_IMPL_GIT_SHA1 does not provide any guarantee that the value will fit. For instance it can happen that 8 characters are not enough to disambiguate two commits in the repository, in which case git rev-parse --short=8 will happily return 9 or more characters. In this case a 32-bit build would display a warning and TEE_IMPL_GIT_SHA1 would be truncated in a way we don't want (discarding the most significant bits).
Therefore, make sure TEE_IMPL_GIT_SHA1 is exactly 8 or 16 hexadecimal characters (plus the leading 0x).
The OPTEE_FFA_GET_OS_VERSION operation in handle_blocking_call() has to be modified since the output is a 32-bit register, and SPMC being a 64-bit TEE core, TEE_IMPL_GIT_SHA1 is a 64-bit value too.
CI needs updating to avoid the following error:
fatal: detected dubious ownership in repository at '/__w/optee_os/optee_os'
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reported-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Closes: https://github.com/OP-TEE/optee_os/issues/6783 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
|
| /optee_os/core/arch/arm/kernel/ |
| H A D | thread_spmc.c | 835688ac5ca7b0a507c4860121019b95df82d32d Thu Apr 11 16:25:27 UTC 2024 Jerome Forissier <jerome.forissier@linaro.org> core: make sure tee_entry_get_os_revision() uses a proper TEE_IMPL_GIT_SHA1
tee_entry_get_os_revision() stores TEE_IMPL_GIT_SHA1 into a 32 or 64-bit register, depending on the platform. Unfortunately the command that creates TEE_IMPL_GIT_SHA1 does not provide any guarantee that the value will fit. For instance it can happen that 8 characters are not enough to disambiguate two commits in the repository, in which case git rev-parse --short=8 will happily return 9 or more characters. In this case a 32-bit build would display a warning and TEE_IMPL_GIT_SHA1 would be truncated in a way we don't want (discarding the most significant bits).
Therefore, make sure TEE_IMPL_GIT_SHA1 is exactly 8 or 16 hexadecimal characters (plus the leading 0x).
The OPTEE_FFA_GET_OS_VERSION operation in handle_blocking_call() has to be modified since the output is a 32-bit register, and SPMC being a 64-bit TEE core, TEE_IMPL_GIT_SHA1 is a 64-bit value too.
CI needs updating to avoid the following error:
fatal: detected dubious ownership in repository at '/__w/optee_os/optee_os'
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reported-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Closes: https://github.com/OP-TEE/optee_os/issues/6783 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
|
| /optee_os/.github/workflows/ |
| H A D | ci.yml | 835688ac5ca7b0a507c4860121019b95df82d32d Thu Apr 11 16:25:27 UTC 2024 Jerome Forissier <jerome.forissier@linaro.org> core: make sure tee_entry_get_os_revision() uses a proper TEE_IMPL_GIT_SHA1
tee_entry_get_os_revision() stores TEE_IMPL_GIT_SHA1 into a 32 or 64-bit register, depending on the platform. Unfortunately the command that creates TEE_IMPL_GIT_SHA1 does not provide any guarantee that the value will fit. For instance it can happen that 8 characters are not enough to disambiguate two commits in the repository, in which case git rev-parse --short=8 will happily return 9 or more characters. In this case a 32-bit build would display a warning and TEE_IMPL_GIT_SHA1 would be truncated in a way we don't want (discarding the most significant bits).
Therefore, make sure TEE_IMPL_GIT_SHA1 is exactly 8 or 16 hexadecimal characters (plus the leading 0x).
The OPTEE_FFA_GET_OS_VERSION operation in handle_blocking_call() has to be modified since the output is a 32-bit register, and SPMC being a 64-bit TEE core, TEE_IMPL_GIT_SHA1 is a 64-bit value too.
CI needs updating to avoid the following error:
fatal: detected dubious ownership in repository at '/__w/optee_os/optee_os'
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reported-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Closes: https://github.com/OP-TEE/optee_os/issues/6783 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
|
| /optee_os/mk/ |
| H A D | config.mk | 835688ac5ca7b0a507c4860121019b95df82d32d Thu Apr 11 16:25:27 UTC 2024 Jerome Forissier <jerome.forissier@linaro.org> core: make sure tee_entry_get_os_revision() uses a proper TEE_IMPL_GIT_SHA1
tee_entry_get_os_revision() stores TEE_IMPL_GIT_SHA1 into a 32 or 64-bit register, depending on the platform. Unfortunately the command that creates TEE_IMPL_GIT_SHA1 does not provide any guarantee that the value will fit. For instance it can happen that 8 characters are not enough to disambiguate two commits in the repository, in which case git rev-parse --short=8 will happily return 9 or more characters. In this case a 32-bit build would display a warning and TEE_IMPL_GIT_SHA1 would be truncated in a way we don't want (discarding the most significant bits).
Therefore, make sure TEE_IMPL_GIT_SHA1 is exactly 8 or 16 hexadecimal characters (plus the leading 0x).
The OPTEE_FFA_GET_OS_VERSION operation in handle_blocking_call() has to be modified since the output is a 32-bit register, and SPMC being a 64-bit TEE core, TEE_IMPL_GIT_SHA1 is a 64-bit value too.
CI needs updating to avoid the following error:
fatal: detected dubious ownership in repository at '/__w/optee_os/optee_os'
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reported-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Closes: https://github.com/OP-TEE/optee_os/issues/6783 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
|