History log of /rk3399_rockchip-uboot/board/micronas/vct/smc_eeprom.c (Results 1 – 6 of 6)
Revision Date Author Comments
# 2271d3dd 06-Jul-2010 Minkyu Kang <mk7.kang@samsung.com>

Merge branch 'master' of git://git.denx.de/u-boot


# 54841ab5 28-Jun-2010 Wolfgang Denk <wd@denx.de>

Make sure that argv[] argument pointers are not modified.

The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
comm

Make sure that argv[] argument pointers are not modified.

The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands. Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
while (--argc > 0 && **++argv == '-') {
/* ====> */ while (*++*argv) {
switch (**argv) {
case 'd':
debug++;
break;
...
default:
usage ();
}
}
}
...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell. With the modification, the compiler will prevent this with
an
error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

while (--argc > 0 && **++argv == '-') {
char *arg = *argv;
while (*++arg) {
switch (*arg) {
...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>

show more ...


# 92afd368 14-Jun-2009 Wolfgang Denk <wd@denx.de>

Merge branch 'next' of ../master


# a89c33db 24-May-2009 Wolfgang Denk <wd@denx.de>

General help message cleanup

Many of the help messages were not really helpful; for example, many
commands that take no arguments would not print a correct synopsis
line, but "No additional help ava

General help message cleanup

Many of the help messages were not really helpful; for example, many
commands that take no arguments would not print a correct synopsis
line, but "No additional help available." which is not exactly wrong,
but not helpful either.

Commit ``Make "usage" messages more helpful.'' changed this
partially. But it also became clear that lots of "Usage" and "Help"
messages (fields "usage" and "help" in struct cmd_tbl_s respective)
were actually redundant.

This patch cleans this up - for example:

Before:
=> help dtt
dtt - Digital Thermometer and Thermostat

Usage:
dtt - Read temperature from digital thermometer and thermostat.

After:
=> help dtt
dtt - Read temperature from Digital Thermometer and Thermostat

Usage:
dtt

Signed-off-by: Wolfgang Denk <wd@denx.de>

show more ...


# 49ad4801 27-Jan-2009 Wolfgang Denk <wd@denx.de>

Merge branch 'master' of git://git.denx.de/u-boot-mips


# ae691e57 21-Jan-2009 Stefan Roese <sr@denx.de>

MIPS: Add VCT board series support (Part 2/3)

Signed-off-by: Stefan Roese <sr@denx.de>