| e75a3b6e | 04-Apr-2023 |
Andre Przywara <andre.przywara@arm.com> |
fix(imx8mq): fix compilation with gcc >= 12.x
Starting with GCC >= 12.x the -Wall option includes -Werror=array-bounds checks. Per default GCC treats all memory accesses below 4096 as NULL, so acces
fix(imx8mq): fix compilation with gcc >= 12.x
Starting with GCC >= 12.x the -Wall option includes -Werror=array-bounds checks. Per default GCC treats all memory accesses below 4096 as NULL, so access to ROMAPI causes the following warning:
------------ In file included from plat/imx/imx8m/imx8mq/imx8mq_bl31_setup.c:20: In function 'mmio_read_8', inlined from 'imx8mq_soc_info_init' at plat/imx/imx8m/imx8mq/imx8mq_bl31_setup.c:70:16, inlined from 'bl31_platform_setup' at plat/imx/imx8m/imx8mq/imx8mq_bl31_setup.c:206:2: include/lib/mmio.h:19:16: error: array subscript 0 is outside array bounds of 'volatile uint8_t[0]' {aka 'volatile unsigned char[]'} [-Werror=array-bounds] 19 | return *(volatile uint8_t*)addr; | ^~~~~~~~~~~~~~~~~~~~~~~~ In function 'mmio_read_8', inlined from 'imx8mq_soc_info_init' at plat/imx/imx8m/imx8mq/imx8mq_bl31_setup.c:74:16, inlined from 'bl31_platform_setup' at plat/imx/imx8m/imx8mq/imx8mq_bl31_setup.c:206:2: include/lib/mmio.h:19:16: error: array subscript 0 is outside array bounds of 'volatile uint8_t[0]' {aka 'volatile unsigned char[]'} [-Werror=array-bounds] 19 | return *(volatile uint8_t*)addr; | ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ------------
This comes arguably from us somewhat abusing pointers to access MMIO memory regions, which is not really covered by the C language.
Replace the pointer-dereferencing mmio_read_8() with an implementation that uses inline assembly, to directly generate an 8-bit load instruction. This avoids the compiler thinking that this access is using a pointer it needs to jealously look after.
Change-Id: Iab39f6f615d51d3e8a1c54a1262d1e6ec208811d Reported-by: Marco Felsch <m.felsch@pengutronix.de> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
show more ...
|
| 55b748a0 | 04-Apr-2023 |
Anurag Koul <anurag.koul@arm.com> |
docs(maintainers): update maintainers for n1sdp/morello
Signed-off-by: Anurag Koul <anurag.koul@arm.com> Change-Id: I305d03ae664f7d6124bf73d3bfdd81d34d760065 |
| 6578343b | 13-Mar-2023 |
Govindraj Raja <govindraj.raja@arm.com> |
feat(cpus): add support for blackhawk cpu
Add basic CPU library code to support the Blackhawk CPU, BlackHawk core is based out of Hunter ELP core, so overall library code was adapted based on that.
feat(cpus): add support for blackhawk cpu
Add basic CPU library code to support the Blackhawk CPU, BlackHawk core is based out of Hunter ELP core, so overall library code was adapted based on that.
Change-Id: I4750e774732218ee669dceb734cd107f46b78492 Signed-off-by: Govindraj Raja <govindraj.raja@arm.com>
show more ...
|
| 516a52f6 | 10-Mar-2023 |
Govindraj Raja <govindraj.raja@arm.com> |
feat(cpus): add support for chaberton cpu
Add basic CPU library code to support the Chaberton CPU, Chaberton cores are based out of Hunter core, so overall library code was adapted based on that.
C
feat(cpus): add support for chaberton cpu
Add basic CPU library code to support the Chaberton CPU, Chaberton cores are based out of Hunter core, so overall library code was adapted based on that.
Change-Id: I58321c77f2c364225a764da6fa65656d1bec33f1 Signed-off-by: Govindraj Raja <govindraj.raja@arm.com>
show more ...
|
| 7762e5d0 | 04-Apr-2023 |
Boyan Karatotev <boyan.karatotev@arm.com> |
fix(fvp): work around DRTM_SUPPORT BL31 progbits exceeded
Just like the tspd, DRTM support pulls in a lot of code which can't fit into SRAM with everything else the fvp is including. Luckily, testin
fix(fvp): work around DRTM_SUPPORT BL31 progbits exceeded
Just like the tspd, DRTM support pulls in a lot of code which can't fit into SRAM with everything else the fvp is including. Luckily, testing this feature is only done on v8.0 models, meaning all feature related code can be excluded for this run, saving space. The benefit of doing it this way is that the test can continue running unaltered in the interim.
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com> Change-Id: Iced2089837622fea49c10ae403c653dd1f331ca3
show more ...
|
| 42fb812a | 04-Apr-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge changes from topic "ethos-n" into integration
* changes: docs(maintainers): update NPU driver files docs(ethos-n): update porting-guide.rst for NPU feat(ethos-n): add separate RO and RW
Merge changes from topic "ethos-n" into integration
* changes: docs(maintainers): update NPU driver files docs(ethos-n): update porting-guide.rst for NPU feat(ethos-n): add separate RO and RW NSAIDs feat(ethos-n)!: add protected NPU firmware setup feat(ethos-n): add stream extends and attr support feat(ethos-n): add reserved memory address support feat(ethos-n): add event and aux control support feat(ethos-n): add SMC call to get FW properties refactor(ethos-n): split up SMC call handling feat(ethos-n): add NPU firmware validation feat(ethos-n): add check for NPU in SiP setup feat(ethos-n)!: load NPU firmware at BL2 feat(juno): support ARM_IO_IN_DTB option for Juno fix(fconf): fix FCONF_ARM_IO_UUID_NUMBER value fix(fvp): incorrect UUID name in FVP tb_fw_config fix(ethos-n): add workaround for erratum 2838783 feat(ethos-n): add support for NPU to cert_create feat(ethos-n): add NPU support in fiptool feat(ethos-n): add support to set up NSAID build(fiptool): add object dependency generation feat(ethos-n): add NPU sleeping SMC call feat(ethos-n): add multiple asset allocators feat(ethos-n): add reset type to reset SMC calls feat(ethos-n): add protected NPU TZMP1 regions build(ethos-n): add TZMP1 build flag
show more ...
|
| 19886773 | 04-Apr-2023 |
Sandrine Bailleux <sandrine.bailleux@arm.com> |
docs(threat-model): refresh top-level page
The top-level page for threat model documents is evidently out-dated, as it contains text which no longer makes sense on its own. Most likely it relates ba
docs(threat-model): refresh top-level page
The top-level page for threat model documents is evidently out-dated, as it contains text which no longer makes sense on its own. Most likely it relates back to the days where we had a single threat model document.
Reword it accordingly. While we are at it, explain the motivation and structure of the documents.
Change-Id: I63c8f38ec32b6edbfd1b4332eeaca19a01ae70e9 Signed-off-by: Sandrine Bailleux <sandrine.bailleux@arm.com>
show more ...
|
| e6faf282 | 04-Apr-2023 |
Manish Pandey <manish.pandey2@arm.com> |
Merge "fix(psci): remove unreachable switch/case blocks" into integration |
| 4e5f1ca0 | 04-Apr-2023 |
Joanna Farley <joanna.farley@arm.com> |
Merge "docs(maintainers): update NPU driver owners" into integration |
| ad27f4b5 | 29-Mar-2023 |
Andre Przywara <andre.przywara@arm.com> |
fix(psci): remove unreachable switch/case blocks
The PSCI function dispatcher switch/case is split up between 32-bit and 64-bit function IDs, based on bit 30 of the encoding. This bit just encodes t
fix(psci): remove unreachable switch/case blocks
The PSCI function dispatcher switch/case is split up between 32-bit and 64-bit function IDs, based on bit 30 of the encoding. This bit just encodes the maximum size of the arguments, not necessarily whether they are used from AArch64 or AArch32. So while some functions exist in both worlds (CPU_ON, for instance), some functions take no or only 32-bit arguments (CPU_OFF, PSCI_FEATURES), so they only exist as a 32-bit function call.
Commit b88a4416b5e5 ("feat(psci): add support for PSCI_SET_SUSPEND_MODE" , gerrit ID Iebf65f5f7846aef6b8643ad6082db99b4dcc4bef) and commit 9a70e69e0598 ("feat(psci): update PSCI_FEATURES", gerrit ID I5da8a989b53419ad2ab55b73ddeee6e882c25554) introduced two "case" sections for 32-bit function IDs in the 64-bit branch, which will never trigger. The one small extra case caused the sun50i_a64 DEBUG build to go beyond its RAM limit.
Removed the redundant switch/case blocks, to make sun50i_a64 build again.
Change-Id: Ic65b7403d128837296a0c3af42c6f23f9f57778e Signed-off-by: Andre Przywara <andre.przywara@arm.com>
show more ...
|
| 3e1921c8 | 27-Mar-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
docs(maintainers): update NPU driver owners
Mikael Olsson will no longer be working with the Arm(R) Ethos(TM)-N NPU so Ştefana Simion will take over the ownership of the driver.
Change-Id: If22bbdc
docs(maintainers): update NPU driver owners
Mikael Olsson will no longer be working with the Arm(R) Ethos(TM)-N NPU so Ştefana Simion will take over the ownership of the driver.
Change-Id: If22bbdcb26af9bf851efc14ad96ed76c745eadfd Signed-off-by: Mikael Olsson <mikael.olsson@arm.com>
show more ...
|
| 61ff8f72 | 28-Mar-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
docs(maintainers): update NPU driver files
New files have been added for the Arm(R) Ethos(TM)-N NPU driver with the addition of TZMP1 support so the files in the maintainers list have been updated a
docs(maintainers): update NPU driver files
New files have been added for the Arm(R) Ethos(TM)-N NPU driver with the addition of TZMP1 support so the files in the maintainers list have been updated accordingly.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I3768b2ab78c117c1dd4fc03b38cf35f6811fa378
show more ...
|
| 6ce4c6c0 | 20-Feb-2023 |
Rob Hughes <robert.hughes@arm.com> |
docs(ethos-n): update porting-guide.rst for NPU
Add some missing configuration that must be done for supporting NPU on other platforms.
Signed-off-by: Rob Hughes <robert.hughes@arm.com> Signed-off-
docs(ethos-n): update porting-guide.rst for NPU
Add some missing configuration that must be done for supporting NPU on other platforms.
Signed-off-by: Rob Hughes <robert.hughes@arm.com> Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: Ic505ea60f73b970d0d7ded101830eb2ce8c7ab64
show more ...
|
| 986c4e99 | 14-Mar-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n): add separate RO and RW NSAIDs
To be able to further restrict the memory access for the Arm(R) Ethos(TM)-N NPU, separate read-only and read/write NSAIDs for the non-protected and prote
feat(ethos-n): add separate RO and RW NSAIDs
To be able to further restrict the memory access for the Arm(R) Ethos(TM)-N NPU, separate read-only and read/write NSAIDs for the non-protected and protected memory have been added to the Juno platform's TZMP1 TZC configuration for the NPU.
The platform definition has been updated accordingly and the NPU driver will now only give read/write access to the streams that require it.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I5a173500fc1943a5cd406a3b379e1f1f554eeda6
show more ...
|
| 6dcf3e77 | 10-Feb-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n)!: add protected NPU firmware setup
When the Arm(R) Ethos(TM)-N NPU driver is built with TZMP1 support, the NPU should use the firmware that has been loaded into the protected memory by
feat(ethos-n)!: add protected NPU firmware setup
When the Arm(R) Ethos(TM)-N NPU driver is built with TZMP1 support, the NPU should use the firmware that has been loaded into the protected memory by BL2. The Linux Kernel NPU driver in the non-secure world is not allowed to configure the NPU to do this in a TZMP1 build so the SiP service will now configure the NPU to boot with the firmware in the protected memory.
BREAKING CHANGE: The Linux Kernel NPU driver can no longer directly configure and boot the NPU in a TZMP1 build. The API version has therefore been given a major version bump with this change.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I65d00f54b3ade3665d7941e270da7a3dec02281a
show more ...
|
| e64abe7b | 10-Feb-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n): add stream extends and attr support
The SiP service for the Arm(R) Ethos(TM)-N NPU driver will now handle setting up the address extension and attribute control for the NPU's streams.
feat(ethos-n): add stream extends and attr support
The SiP service for the Arm(R) Ethos(TM)-N NPU driver will now handle setting up the address extension and attribute control for the NPU's streams. The non-secure world will still be allowed to read the address extension for stream0 but non-secure access to all other streams have been removed.
The API version has been given a minor bump with this change to indicate the added functionality.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I2b041ca4a0a2b5cd6344a4ae144f75e137c72592
show more ...
|
| a19a0241 | 10-Feb-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n): add reserved memory address support
The FCONF parsing of the HW_CONFIG for the Arm(R) Ethos(TM)-N NPU now supports reading the address of the reserved memory setup for the NPU so the
feat(ethos-n): add reserved memory address support
The FCONF parsing of the HW_CONFIG for the Arm(R) Ethos(TM)-N NPU now supports reading the address of the reserved memory setup for the NPU so the address can be used in the SiP service for the NPU.
Change-Id: I0968255a966e84896b00ea935d6aa3d5232c5f7b Signed-off-by: Mikael Olsson <mikael.olsson@arm.com>
show more ...
|
| 7820777f | 10-Feb-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n): add event and aux control support
The SiP service for the Arm(R) Ethos(TM)-N NPU driver will now handle setting up the NPU's event and aux control registers during the SMC reset call.
feat(ethos-n): add event and aux control support
The SiP service for the Arm(R) Ethos(TM)-N NPU driver will now handle setting up the NPU's event and aux control registers during the SMC reset call. The aux control register will no longer be accessible by the non-secure world.
The API version has been given a minor bump with this change to indicate the added functionality.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I5b099e25978aa4089c384eb17c5060c5b4eaf373
show more ...
|
| e9812ddc | 27-Jan-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n): add SMC call to get FW properties
When the Arm(R) Ethos(TM)-N NPU firmware is loaded by BL2 into protected memory, the Linux kernel NPU driver cannot access the firmware. To still all
feat(ethos-n): add SMC call to get FW properties
When the Arm(R) Ethos(TM)-N NPU firmware is loaded by BL2 into protected memory, the Linux kernel NPU driver cannot access the firmware. To still allow the kernel driver to access some information about the firmware, SMC calls have been added so it can check compatibility and get the necessary information to map the firmware into the SMMU for the NPU.
The API version has been given a minor version bump with this change to indicate the added functionality.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: Idb076b7bcf54ed7e8eb39be80114dc1d1c45336d
show more ...
|
| 18a6b79c | 27-Jan-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
refactor(ethos-n): split up SMC call handling
Doing all the SMC call handling in a single function and using specific names for the x1-4 parameters is no longer practical for upcoming additions to t
refactor(ethos-n): split up SMC call handling
Doing all the SMC call handling in a single function and using specific names for the x1-4 parameters is no longer practical for upcoming additions to the SiP service. Handling of the different SMC functions have therefore been split into separate functions.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: If28da8df0f13c449d1fdb2bd9d792d818ec5e1af
show more ...
|
| 313b776f | 13-Jan-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n): add NPU firmware validation
When the Arm(R) Ethos(TM)-N NPU driver is built with TZMP1 support, it will now validate the NPU firmware binary that BL2 is expected to load into the prot
feat(ethos-n): add NPU firmware validation
When the Arm(R) Ethos(TM)-N NPU driver is built with TZMP1 support, it will now validate the NPU firmware binary that BL2 is expected to load into the protected memory location specified by ARM_ETHOSN_NPU_IMAGE_BASE.
Juno has been updated with a new BL31 memory mapping to allow the SiP service to read the protected memory that contains the NPU firmware binary.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I633256ab7dd4f8f5a6f864c8c98a66bf9dfc37f3
show more ...
|
| a2cdbb1d | 18-Jan-2023 |
Mikael Olsson <mikael.olsson@arm.com> |
feat(ethos-n): add check for NPU in SiP setup
The SiP service in the Arm(R) Ethos(TM)-N NPU driver requires that there is at least one NPU available. If there is no NPU available, the driver is eith
feat(ethos-n): add check for NPU in SiP setup
The SiP service in the Arm(R) Ethos(TM)-N NPU driver requires that there is at least one NPU available. If there is no NPU available, the driver is either used incorrectly or the HW config is incorrect.
To ensure that the SiP service is not incorrectly used, a setup handler has been added to the service that will validate that there is at least one NPU available.
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I8139a652f265cfc0db4a37464f39f1fb92868e10
show more ...
|
| 33bcaed1 | 17-Jan-2023 |
Rob Hughes <robert.hughes@arm.com> |
feat(ethos-n)!: load NPU firmware at BL2
BL2 on Juno now loads the Arm(R) Ethos(TM)-N NPU firmware into a fixed address, using the existing image loading framework.
Includes support for TRUSTED_BOA
feat(ethos-n)!: load NPU firmware at BL2
BL2 on Juno now loads the Arm(R) Ethos(TM)-N NPU firmware into a fixed address, using the existing image loading framework.
Includes support for TRUSTED_BOARD_BOOT, if enabled, using the firmware content and key certificates from the FIP.
Supports the ARM_IO_IN_DTB option so can specify the firmware location from the dtb rather than it being hardcoded to the FIP
Update makefile to automatically embed the appropriate images into the FIP.
BREAKING CHANGE: Building the FIP when TZMP1 support is enabled in the NPU driver now requires a parameter to specify the NPU firmware file.
Signed-off-by: Rob Hughes <robert.hughes@arm.com> Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I8cd64fb20d58f8bd539facb085606213d6cead06
show more ...
|
| 2fad320f | 20-Jan-2023 |
Rob Hughes <robert.hughes@arm.com> |
feat(juno): support ARM_IO_IN_DTB option for Juno
Add UUIDs for loadable FIP images to Juno's tb_fw_config device tree, so that it can be built with the ARM_IO_IN_DTB option. Increase the max-size o
feat(juno): support ARM_IO_IN_DTB option for Juno
Add UUIDs for loadable FIP images to Juno's tb_fw_config device tree, so that it can be built with the ARM_IO_IN_DTB option. Increase the max-size of the tb_fw-config image accordingly, as the new entries enlarge that image(new size is 2,116 bytes, rounded up to 2,560 = 0xA00)
Signed-off-by: Rob Hughes <robert.hughes@arm.com> Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I557bca7dd32c3be084bbba11d84dfa2818cb6789
show more ...
|
| e208f324 | 20-Jan-2023 |
Rob Hughes <robert.hughes@arm.com> |
fix(fconf): fix FCONF_ARM_IO_UUID_NUMBER value
The FCONF_ARM_IO_UUID_NUMBER macro is hardcoded to the number of entries in the `load_info` array, but this number did not match the actual length of t
fix(fconf): fix FCONF_ARM_IO_UUID_NUMBER value
The FCONF_ARM_IO_UUID_NUMBER macro is hardcoded to the number of entries in the `load_info` array, but this number did not match the actual length of the array in the case that TRUSTED_BOARD_BOOT is defined, but SPD_spmd is not defined.
This patch fixes the hardcoded length by replacing it with a more flexible calculation which sums up the various contributing groups of entries.
Signed-off-by: Rob Hughes <robert.hughes@arm.com> Signed-off-by: Mikael Olsson <mikael.olsson@arm.com> Change-Id: I557bca7dd32c3be084bbba11d84dfa2818cb6790
show more ...
|