Merge "fix(xilinx): correct node idx for Versal Gen 2" into integration

Merge changes from topic "amd_feat_dyn_core_clust" into integration

* changes:
feat(versal2): update plat psci based on dynamic core and cluster
feat(versal2): add dynamic fetching of core and c

Merge changes from topic "amd_feat_dyn_core_clust" into integration

* changes:
feat(versal2): update plat psci based on dynamic core and cluster
feat(versal2): add dynamic fetching of core and cluster
refactor(xilinx): promote map/unmap helpers to public scope
feat(versal2): use runtime core/cluster variables for dyn topology

show more ...

fix(xilinx): correct node idx for Versal Gen 2

Several device node indices are incorrectly placed in the common
section of the enum but are only used in Versal Gen 2:
- XPM_NODEIDX_DEV_I2C_2 through

fix(xilinx): correct node idx for Versal Gen 2

Several device node indices are incorrectly placed in the common
section of the enum but are only used in Versal Gen 2:
- XPM_NODEIDX_DEV_I2C_2 through XPM_NODEIDX_DEV_I2C_7 (0x117-0x11C)
- XPM_NODEIDX_DEV_CAN_FD_2, XPM_NODEIDX_DEV_CAN_FD_3 (0x11D-0x11E)
- XPM_NODEIDX_DEV_TTC_4 through XPM_NODEIDX_DEV_TTC_7 (0x11F-0x122)
- XPM_NODEIDX_DEV_MMI_GEM (0x13A)

This causes incorrect XPM_NODEIDX_DEV_MAX values:
- Versal: is 0x13B, should be 0x54
- Versal Gen 2: is 0xD8 (USB_1 came after MMI_GEM in source order),
should be 0x13B to include MMI_GEM

The incorrect MAX on Versal Gen 2 causes the bounds check in
pm_client_set_wakeup_sources() to silently reject MMI_GEM
(0x13A).

Move all Versal Gen 2-specific device indices inside the
XPM_NODEIDX_DEV_MAX:
- Versal: XPM_NODEIDX_DEV_MAX = 0x54
- Versal Net: XPM_NODEIDX_DEV_MAX = 0xDF (unchanged)
- Versal Gen 2: XPM_NODEIDX_DEV_MAX = 0x13B

Change-Id: I6979758b1295782a9743301d0ad7f7cda75d1b36
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

refactor(xilinx): promote map/unmap helpers to public scope

Remove the static qualifier from add_mmap_dynamic_region() and
remove_mmap_dynamic_region() in plat_fdt.c, and add their
declarations to p

refactor(xilinx): promote map/unmap helpers to public scope

Remove the static qualifier from add_mmap_dynamic_region() and
remove_mmap_dynamic_region() in plat_fdt.c, and add their
declarations to plat_fdt.h so they can be reused across Xilinx
platform code.

When XILINX_OF_BOARD_DTB_ADDR is not defined, static inline no-op
stubs are provided to allow unconditional calls without link errors.

Change-Id: I795dbcb2b13b4e5d5fe900edabaa703d6aade0be
Signed-off-by: Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com>

show more ...

fix(versal2): resolve type mismatch

This corrects MISRA violation C2012-10.3:
The value of an expression shall not be assigned to an object with a
narrower essential type or of a different essential

fix(versal2): resolve type mismatch

This corrects MISRA violation C2012-10.3:
The value of an expression shall not be assigned to an object with a
narrower essential type or of a different essential type category.
Adjust macro definition to avoid implicit type conversion.

This corrects MISRA violation C2012-10.4:
Both operands of an operator in which the usual arithmetic
conversions are performed shall have the same essential type category.
Make operands of the same essential type category.

Change-Id: I66c18422b701515947c32b0aabfc3aec4bad3dff
Signed-off-by: Sai Varun Venkatapuram <saivarun.venkatapuram@amd.com>

show more ...

fix(versal2): fix misra rule 8.13 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.13:
- A pointer should point to a const-qualified type whenever
possible.
- Fix:
-

fix(versal2): fix misra rule 8.13 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.13:
- A pointer should point to a const-qualified type whenever
possible.
- Fix:
- Add const qualifier to pointer parameters.

Change-Id: I4572e507156de74b5f9c16a59de054ac8e497562
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(versal2): fix misra rule 2.5 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.5:
- A project should not contain unused macro declarations.
- Fix:
- Remove unused mac

fix(versal2): fix misra rule 2.5 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.5:
- A project should not contain unused macro declarations.
- Fix:
- Remove unused macro declarations.

Change-Id: I3645a08f3282ec06a75f6ef424fab2c5bca3aed6
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(xilinx): remove PM_ABORT_SUSPEND API implementation

The API is not getting called by Linux. Removing it to reduce dead
code and improve maintainability.

Note: This change removes code that is c

fix(xilinx): remove PM_ABORT_SUSPEND API implementation

The API is not getting called by Linux. Removing it to reduce dead
code and improve maintainability.

Note: This change removes code that is common between versal and
versal_net.

Change-Id: Ia7bfbcf2bbf80309beda7f8fa1ecf87de2591e2e
Signed-off-by: Madhav Bhatt <madhav.bhatt@amd.com>

show more ...

Merge changes from topic "xlnx_enhance_tfa_feature_check" into integration

* changes:
chore(xilinx): add deprecation warning to pm_feature_check
refactor(xilinx): rename eemi_feature_check to tf

Merge changes from topic "xlnx_enhance_tfa_feature_check" into integration

* changes:
chore(xilinx): add deprecation warning to pm_feature_check
refactor(xilinx): rename eemi_feature_check to tfa_api_feature_check

show more ...

fix(versal2): handle debugfs specific APIs before EEMI handler

In Versal Gen 2 SoC, all PM APIs use the extended SMC format including
the debugfs-specific APIs. So, call eemi_psci_debugfs_handler be

fix(versal2): handle debugfs specific APIs before EEMI handler

In Versal Gen 2 SoC, all PM APIs use the extended SMC format including
the debugfs-specific APIs. So, call eemi_psci_debugfs_handler before
eemi_api_handler. This ensures that debugfs-specific PM APIs are handled
correctly by TF-A and are not forwarded to the PLM firmware.

Change-Id: Ibab08c851c853a8f4272783b210040ddf7291d76
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>

show more ...

refactor(xilinx): rename eemi_feature_check to tfa_api_feature_check

Rename eemi_feature_check() to tfa_api_feature_check() for better
clarity. The new name clearly indicates its purpose of handling

refactor(xilinx): rename eemi_feature_check to tfa_api_feature_check

Rename eemi_feature_check() to tfa_api_feature_check() for better
clarity. The new name clearly indicates its purpose of handling TF-A
specific feature checks and improves code maintainability.

Change-Id: Ia74b12933427ccadbc8ede5ddc2a7a4822766264
Signed-off-by: Devanshi Chauhan <devanshi.chauhan@amd.com>

show more ...

feat(xilinx): use common SECURE/NON_SECURE macro

Remove platform-specific macro definitions such as SECURE_FLAG and
NON_SECURE_FLAG, and replace them with the common macros SECURE and
NON_SECURE acr

feat(xilinx): use common SECURE/NON_SECURE macro

Remove platform-specific macro definitions such as SECURE_FLAG and
NON_SECURE_FLAG, and replace them with the common macros SECURE and
NON_SECURE across all AMD-Xilinx platforms.

Change-Id: I95465e29ac8a9370da135c2113203c3206ecfec0
Signed-off-by: Ronak Jain <ronak.jain@amd.com>

show more ...

feat(xilinx): deprecate PM_REQ_SUSPEND EEMI API

Deprecate the use of the PM_REQ_SUSPEND EEMI API from the Versal,
Versal-Net and Versal Gen 2 platforms. This is because the API is
intended for suspe

feat(xilinx): deprecate PM_REQ_SUSPEND EEMI API

Deprecate the use of the PM_REQ_SUSPEND EEMI API from the Versal,
Versal-Net and Versal Gen 2 platforms. This is because the API is
intended for suspending cross-subsystems, and the same functionality
can now be achieved using the ForcePowerdown API. Therefore,
continuing to use PM_REQ_SUSPEND API may no longer be necessary.
Hence deprecating the same.

Change-Id: I967d7803da4cf433fabfe8d87c32305954f69884
Signed-off-by: Ronak Jain <ronak.jain@amd.com>

show more ...

feat(versal): add support to clear PM specific data

During a kexec restart, only the kernel is reloaded while TF-A state
remains unchanged, causing a mismatch between kernel and TF-A states.
To reso

feat(versal): add support to clear PM specific data

During a kexec restart, only the kernel is reloaded while TF-A state
remains unchanged, causing a mismatch between kernel and TF-A states.
To resolve this, add support for the TF_A_CLEAR_PM_STATE API, which
clears TF-A PM state.

Change-Id: I6b460f8cd4293381d3a9c574dd144521b8e54f8a
Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>

show more ...

fix(xilinx): fix missing security flag in suspend path

Suspend flow was always programming wakeup sources with a fixed
secure flag, regardless of whether the caller was secure or
non-secure. This ma

fix(xilinx): fix missing security flag in suspend path

Suspend flow was always programming wakeup sources with a fixed
secure flag, regardless of whether the caller was secure or
non-secure. This may cause incorrect behavior for non-secure
suspend requests.

Fix this by passing the caller's security state (flag) through
pm_client_suspend() and pm_client_set_wakeup_sources() to ensure
that wakeup sources are set with the correct context.

Fixes: <4697164a3fa8> ("plat: xilinx: versal: Mark IPI calls secure/non-secure")

Change-Id: I5fcf65788a54010b4759b0d08e4f54c6e5037e47
Signed-off-by: Ronak Jain <ronak.jain@amd.com>

show more ...

Merge "fix(versal-net): add fallback on handoff failure" into integration

feat(versal2): add support of MMI_GEM as wakeup source

Add MMI_GEM device node ID and add support of MMI_GEM as wakeup
source.

Change-Id: I449e23df63e887978be1ff6d151542a27c44466f
Signed-off-by: Na

feat(versal2): add support of MMI_GEM as wakeup source

Add MMI_GEM device node ID and add support of MMI_GEM as wakeup
source.

Change-Id: I449e23df63e887978be1ff6d151542a27c44466f
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>

show more ...

fix(versal-net): add fallback on handoff failure

On the Versal-Net platform, booting can fail during ELF loading due to
the absence of a PLM handoff, preventing the system from booting
further.

To

fix(versal-net): add fallback on handoff failure

On the Versal-Net platform, booting can fail during ELF loading due to
the absence of a PLM handoff, preventing the system from booting
further.

To address this, a fallback mechanism has been introduced that allows
the boot process to continue even if the PLM handoff is not provided
only in debug builds with jtag boot mode.

Change-Id: Ib8d92ab8400b7a63b05ae8c77b40b30fe7abaab8
Signed-off-by: Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com>

show more ...

feat(versal2): parse reserve memory subnodes

In Versal Gen 2, TF-A parses the device tree to identify secure and
non-secure memory regions, which are then used to validate the
non-secure entry point

feat(versal2): parse reserve memory subnodes

In Versal Gen 2, TF-A parses the device tree to identify secure and
non-secure memory regions, which are then used to validate the
non-secure entry point address during a hot plug event

Change-Id: I8cdb098509bd3b06f0df5ea647220bdbb8a4bf35
Signed-off-by: Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com>

show more ...

fix(xilinx): add API to get powerdown request status

The pwrdwn_req_received variable is used across multiple platforms
through extern keyword. Instead of using the extern, add getter
API to access

fix(xilinx): add API to get powerdown request status

The pwrdwn_req_received variable is used across multiple platforms
through extern keyword. Instead of using the extern, add getter
API to access this variable across the platforms, and restrict the
scope of variable to the particular file by defining it as static
variable. This prevents unintended access of variable from other
files and increase safety.

Change-Id: I758466ea7f6be2a90ec249dc3e4fa56cdbe11e57
Signed-off-by: Devanshi Chauhan <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): add macro to extract node class from node ID

Introduce the NODECLASS() macro to extract the node class from a given
node ID. This helps in filtering nodes based on their class as encode

fix(xilinx): add macro to extract node class from node ID

Introduce the NODECLASS() macro to extract the node class from a given
node ID. This helps in filtering nodes based on their class as encoded
in the ID.

Change-Id: I0e55b68a0103a99748df93b6fe9a3f1df4a7cca4
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>

show more ...

Merge changes from topic "xlnx_versal_custom_sip" into integration

* changes:
feat(versal): add hooks for mmap and early setup
refactor(zynqmp): refactor custom sip service

fix(xilinx): resolve misra rule 2.5 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.5:
- A project should not contain unused macro declarations.
- Fix:
- Removed unus

fix(xilinx): resolve misra rule 2.5 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.5:
- A project should not contain unused macro declarations.
- Fix:
- Removed unused macro declarations.

Change-Id: I2b9deda95d1a3927ab8b4e2c8a41bd85acb62be3
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 4.6 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.4.6:
- Typedefs that indicate size and signedness should be used in
place of the b

fix(xilinx): resolve misra rule 4.6 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.4.6:
- Typedefs that indicate size and signedness should be used in
place of the basic numerical types.
- Fix:
- Used typedefs that indicate size and signedness in place of basic
numerical types and updated return type of function wherever needed.

Change-Id: Ifde2379ee3f9d5ab30ef695d99f59591af575aba
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 12.2 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.12.2:
- The right hand operand of a shift operator shall lie in the range
zero to

fix(xilinx): resolve misra rule 12.2 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.12.2:
- The right hand operand of a shift operator shall lie in the range
zero to one less than the width in bits of the essential type of
the left hand operand.
- Fix:
- Type casted left operand to a larger width than shift.

Change-Id: I662ff57e52d1260e2f1a0de595f19a9143714892
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...