feat(versal2): add PM support for 1-cluster 4-core topology

Add PM node IDs for Core 2 and Core 3 of Cluster 0.

Add new pm_proc structure to support the 1 Cluster 4 cores topology and
select the pm

feat(versal2): add PM support for 1-cluster 4-core topology

Add PM node IDs for Core 2 and Core 3 of Cluster 0.

Add new pm_proc structure to support the 1 Cluster 4 cores topology and
select the pm_proc table dynamically based on topology.

Update APU_PCIL core index calculation logic to support 1-cluster
4-core topology.

Change-Id: I14ba4a2caa9a9872adaa44a78dc288ec49cbcc89
Signed-off-by: Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com>
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>

show more ...

fix(versal2): fix violations for unreferenced functions

Fix below violations:
- Violation:
- The function that is declared should be referenced or used.
- Fix:
- Remove unused function declarati

fix(versal2): fix violations for unreferenced functions

Fix below violations:
- Violation:
- The function that is declared should be referenced or used.
- Fix:
- Remove unused function declarations.

Change-Id: I0e5fb40c84b3daa34ca516eb53a8b2a29c05b7e6
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(versal2): fix misra rule 8.13 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.13:
- A pointer should point to a const-qualified type whenever
possible.
- Fix:
-

fix(versal2): fix misra rule 8.13 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.13:
- A pointer should point to a const-qualified type whenever
possible.
- Fix:
- Add const qualifier to pointer parameters.

Change-Id: I4572e507156de74b5f9c16a59de054ac8e497562
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(versal2): fix misra rule 2.7 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.7:
- There should be no unused parameters in functions.
- Fix:
- Type cast unused param

fix(versal2): fix misra rule 2.7 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.7:
- There should be no unused parameters in functions.
- Fix:
- Type cast unused parameters to void.

Change-Id: Ic28f8904647cc592dae3a2db0d6b614746e48876
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(versal2): fix misra rule 4.6 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 Dir 4.6:
- Typedefs that indicate size and signedness should be used in
place of the basi

fix(versal2): fix misra rule 4.6 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 Dir 4.6:
- Typedefs that indicate size and signedness should be used in
place of the basic numerical types.
- Fix:
- Replace basic numerical types with specific-width typedefs.

Change-Id: Id096937ac9998a7a2e980e0e08680db5a19f87aa
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(versal2): fix misra rule 5.7 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.5.7:
- A tag name shall be a unique identifier.
- Fix:
- Rename local variables to avoid

fix(versal2): fix misra rule 5.7 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.5.7:
- A tag name shall be a unique identifier.
- Fix:
- Rename local variables to avoid conflict with type names.

Change-Id: Iac8df3166dcc69ceccaaddae2134f9c8a043b3b6
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(versal2): fix misra rule 10.3 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.3:
- The value of an expression shall not be assigned to an object
with a narrower

fix(versal2): fix misra rule 10.3 violations

Fix below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.3:
- The value of an expression shall not be assigned to an object
with a narrower essential type or of a different essential type
category.
- Fix:
- Add explicit type casts to prevent implicit narrowing
conversions.

Change-Id: I756137cf9a403f1f6395c1d7c2d9bb70a3f6ff80
Signed-off-by: Devanshi Chauhan <Devanshi.ChauhanAlpeshbhai@amd.com>

show more ...

fix(versal2): remove PM_ABORT_SUSPEND API implementation

The API is not getting called by Linux. Removing it to reduce dead
code and improve maintainability.

Change-Id: I88025fa0213e40c510a2f1edb65

fix(versal2): remove PM_ABORT_SUSPEND API implementation

The API is not getting called by Linux. Removing it to reduce dead
code and improve maintainability.

Change-Id: I88025fa0213e40c510a2f1edb6566fc849a8dbb6
Signed-off-by: Madhav Bhatt <madhav.bhatt@amd.com>

show more ...

Merge changes from topic "xlnx_enhance_tfa_feature_check" into integration

* changes:
chore(xilinx): add deprecation warning to pm_feature_check
refactor(xilinx): rename eemi_feature_check to tf

Merge changes from topic "xlnx_enhance_tfa_feature_check" into integration

* changes:
chore(xilinx): add deprecation warning to pm_feature_check
refactor(xilinx): rename eemi_feature_check to tfa_api_feature_check

show more ...

fix(versal2): handle debugfs specific APIs before EEMI handler

In Versal Gen 2 SoC, all PM APIs use the extended SMC format including
the debugfs-specific APIs. So, call eemi_psci_debugfs_handler be

fix(versal2): handle debugfs specific APIs before EEMI handler

In Versal Gen 2 SoC, all PM APIs use the extended SMC format including
the debugfs-specific APIs. So, call eemi_psci_debugfs_handler before
eemi_api_handler. This ensures that debugfs-specific PM APIs are handled
correctly by TF-A and are not forwarded to the PLM firmware.

Change-Id: Ibab08c851c853a8f4272783b210040ddf7291d76
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>

show more ...

refactor(xilinx): rename eemi_feature_check to tfa_api_feature_check

Rename eemi_feature_check() to tfa_api_feature_check() for better
clarity. The new name clearly indicates its purpose of handling

refactor(xilinx): rename eemi_feature_check to tfa_api_feature_check

Rename eemi_feature_check() to tfa_api_feature_check() for better
clarity. The new name clearly indicates its purpose of handling TF-A
specific feature checks and improves code maintainability.

Change-Id: Ia74b12933427ccadbc8ede5ddc2a7a4822766264
Signed-off-by: Devanshi Chauhan <devanshi.chauhan@amd.com>

show more ...

feat(xilinx): use common SECURE/NON_SECURE macro

Remove platform-specific macro definitions such as SECURE_FLAG and
NON_SECURE_FLAG, and replace them with the common macros SECURE and
NON_SECURE acr

feat(xilinx): use common SECURE/NON_SECURE macro

Remove platform-specific macro definitions such as SECURE_FLAG and
NON_SECURE_FLAG, and replace them with the common macros SECURE and
NON_SECURE across all AMD-Xilinx platforms.

Change-Id: I95465e29ac8a9370da135c2113203c3206ecfec0
Signed-off-by: Ronak Jain <ronak.jain@amd.com>

show more ...

feat(xilinx): deprecate PM_REQ_SUSPEND EEMI API

Deprecate the use of the PM_REQ_SUSPEND EEMI API from the Versal,
Versal-Net and Versal Gen 2 platforms. This is because the API is
intended for suspe

feat(xilinx): deprecate PM_REQ_SUSPEND EEMI API

Deprecate the use of the PM_REQ_SUSPEND EEMI API from the Versal,
Versal-Net and Versal Gen 2 platforms. This is because the API is
intended for suspending cross-subsystems, and the same functionality
can now be achieved using the ForcePowerdown API. Therefore,
continuing to use PM_REQ_SUSPEND API may no longer be necessary.
Hence deprecating the same.

Change-Id: I967d7803da4cf433fabfe8d87c32305954f69884
Signed-off-by: Ronak Jain <ronak.jain@amd.com>

show more ...

Merge "chore(versal2): rename versal2 to Versal Gen 2" into integration

chore(versal2): rename versal2 to Versal Gen 2

The term Versal2 should be updated to Versal Gen 2.

Change-Id: Iac94ef32604f88ec030bf95ec35484b72a0f7ffa
Signed-off-by: Prasad Kummari <prasad.kummari

chore(versal2): rename versal2 to Versal Gen 2

The term Versal2 should be updated to Versal Gen 2.

Change-Id: Iac94ef32604f88ec030bf95ec35484b72a0f7ffa
Signed-off-by: Prasad Kummari <prasad.kummari@amd.com>

show more ...

fix(xilinx): fix missing security flag in suspend path

Suspend flow was always programming wakeup sources with a fixed
secure flag, regardless of whether the caller was secure or
non-secure. This ma

fix(xilinx): fix missing security flag in suspend path

Suspend flow was always programming wakeup sources with a fixed
secure flag, regardless of whether the caller was secure or
non-secure. This may cause incorrect behavior for non-secure
suspend requests.

Fix this by passing the caller's security state (flag) through
pm_client_suspend() and pm_client_set_wakeup_sources() to ensure
that wakeup sources are set with the correct context.

Fixes: <4697164a3fa8> ("plat: xilinx: versal: Mark IPI calls secure/non-secure")

Change-Id: I5fcf65788a54010b4759b0d08e4f54c6e5037e47
Signed-off-by: Ronak Jain <ronak.jain@amd.com>

show more ...

feat(versal2): add support of MMI_GEM as wakeup source

Add MMI_GEM device node ID and add support of MMI_GEM as wakeup
source.

Change-Id: I449e23df63e887978be1ff6d151542a27c44466f
Signed-off-by: Na

feat(versal2): add support of MMI_GEM as wakeup source

Add MMI_GEM device node ID and add support of MMI_GEM as wakeup
source.

Change-Id: I449e23df63e887978be1ff6d151542a27c44466f
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>

show more ...

fix(xilinx): add API to get powerdown request status

The pwrdwn_req_received variable is used across multiple platforms
through extern keyword. Instead of using the extern, add getter
API to access

fix(xilinx): add API to get powerdown request status

The pwrdwn_req_received variable is used across multiple platforms
through extern keyword. Instead of using the extern, add getter
API to access this variable across the platforms, and restrict the
scope of variable to the particular file by defining it as static
variable. This prevents unintended access of variable from other
files and increase safety.

Change-Id: I758466ea7f6be2a90ec249dc3e4fa56cdbe11e57
Signed-off-by: Devanshi Chauhan <devanshi.chauhanalpeshbhai@amd.com>

show more ...

Merge changes from topic "validate node ID in PM events" into integration

* changes:
fix(versal2): validate Node ID in PM callback events
fix(xilinx): validate Node ID in PM callback events
fi

Merge changes from topic "validate node ID in PM events" into integration

* changes:
fix(versal2): validate Node ID in PM callback events
fix(xilinx): validate Node ID in PM callback events
fix(xilinx): add macro to extract node class from node ID

show more ...

fix(versal2): validate Node ID in PM callback events

The PM_NOTIFY_CB is used to notify both events and errors from the PLM
firmware. The values of events and errors can overlap, they can be
disting

fix(versal2): validate Node ID in PM callback events

The PM_NOTIFY_CB is used to notify both events and errors from the PLM
firmware. The values of events and errors can overlap, they can be
distinguished using the Node ID, which is included in the callback payload.

Currently, when an EVENT_CPU_PWRDWN notification is received, TF-A powers
down cores without validating the Node ID. This leads to incorrect
behavior, as TFA powers down cores even when an error occurs that shares
the same event value.

Add a Node ID check to differentiate between events and errors to fix
this issue.

Change-Id: I65d69731b692928597e47678c684aea2b90b5e6d
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>

show more ...

fix(versal2): fix offsets for apu pcil

The current APU_PCIL offsets for disabling power down and wakeup
interrupts are incorrect. The cpuid passed to the register offset
macro is linear (0-8), but t

fix(versal2): fix offsets for apu pcil

The current APU_PCIL offsets for disabling power down and wakeup
interrupts are incorrect. The cpuid passed to the register offset
macro is linear (0-8), but the actual register offsets are
non-linear: 0, 1, 4, 5, 8, 9, 12, 13. As a result, the system
mistakenly disables wakeup and power down interrupts for other
cores. So convert the linear cpuid to a non-linear mapping and
update the APU_PCIL offset macros accordingly.

Change-Id: Ifd823f51d70d9d03fa87cc35ccc733a462eae36a
Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>

show more ...

fix(xilinx): resolve misra rule 10.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.4:
- Both operands of an operator in which the usual arithmetic conversions
ar

fix(xilinx): resolve misra rule 10.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.4:
- Both operands of an operator in which the usual arithmetic conversions
are performed shall have the same essential type category.
- Fix:
- Made data type same for both the operands.

Change-Id: I0cea19477f3c10265d95ea1d5d2ea151dbf174bb
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...