core: rename cache_maintenance_l2() into cache_op_outer()

Rename cache_maintenance_l2() into cache_op_outer() to prevent
confusion as the function targets outer cache only, not specific
level2 cache

core: rename cache_maintenance_l2() into cache_op_outer()

Rename cache_maintenance_l2() into cache_op_outer() to prevent
confusion as the function targets outer cache only, not specific
level2 cache, even if current implementation supports only the
PL310 that is mainly used as a level2 cache.

Fix return type of cache_op_outer().

Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: prevent useless cache clean on cache flush operation

If there is no outer cache, a cache flush request ends in a cache
clean followed by a cache flush sequence. This change prevents former
cac

core: prevent useless cache clean on cache flush operation

If there is no outer cache, a cache flush request ends in a cache
clean followed by a cache flush sequence. This change prevents former
cache clean request in case no outer cache is supported. Note that
the sole outer cache currently supported is the PL310.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: move cache_operation() out of SVC cache services

cache_operation() is moved to a specific tee/cache.c source file.
This will allow core to call cache maintenance routine without
needing to rel

core: move cache_operation() out of SVC cache services

cache_operation() is moved to a specific tee/cache.c source file.
This will allow core to call cache maintenance routine without
needing to rely on the cache maintenance SVC services.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: move svc_cache.h from local directory to generic includes

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by:

core: move svc_cache.h from local directory to generic includes

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: rename type t_cache_operation_id

Rename defined enumerate type "t_cache_operation_id" into
"enum cache_op".

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome F

core: rename type t_cache_operation_id

Rename defined enumerate type "t_cache_operation_id" into
"enum cache_op".

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: FS: remove ta_dir_mutex

Removes the mutex that's supposed to protect directory operations in
secure storage. The mutex is redundant as each FS implementation has
its own internal mutex for all

core: FS: remove ta_dir_mutex

Removes the mutex that's supposed to protect directory operations in
secure storage. The mutex is redundant as each FS implementation has
its own internal mutex for all operations.

Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260)
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (FVP)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

plat-zynq7k: fix NSACR initialization

Bits #9..#0 of CPU register NSACR are specified by ARM as SBZP ("Set
Bit to Zero or Preserve on write"). This change fixes plat-zynq7k to
conform with the specs

plat-zynq7k: fix NSACR initialization

Bits #9..#0 of CPU register NSACR are specified by ARM as SBZP ("Set
Bit to Zero or Preserve on write"). This change fixes plat-zynq7k to
conform with the specs.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

plat-ls: fix comments for ACTRL and NSACR initialization

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

core: use mov_imm instead of movw/movt

Suggested-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklan

core: use mov_imm instead of movw/movt

Suggested-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

plat-zynq7k: fix cpu power control register init

Before this change, a reserved bit was set in the PCR instead of
enabling the clock gating support, as configured in other supported
Cortex-A9 platfo

plat-zynq7k: fix cpu power control register init

Before this change, a reserved bit was set in the PCR instead of
enabling the clock gating support, as configured in other supported
Cortex-A9 platforms.

Reported-by: Yves Lefloch <YvesMarie_Lefloch@sigmadesigns.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: introduce TA_FLAG_SECURE_DATA_PATH

Rename TA_FLAG_UNSAFE_NW_PARAMS into TA_FLAG_SECURE_DATA_PATH.

This change does NOT able secure data path support in OP-TEE. It is
rather a pre-requisite fo

core: introduce TA_FLAG_SECURE_DATA_PATH

Rename TA_FLAG_UNSAFE_NW_PARAMS into TA_FLAG_SECURE_DATA_PATH.

This change does NOT able secure data path support in OP-TEE. It is
rather a pre-requisite for later changes in OP-TEE regarding SDP
support.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

core: fix plat_cpu_reset_early weak definition

The plat_cpu_reset_early() function is invoked from early start-up
code even before the stack is setup. Therefore it is not correct
to define this func

core: fix plat_cpu_reset_early weak definition

The plat_cpu_reset_early() function is invoked from early start-up
code even before the stack is setup. Therefore it is not correct
to define this function in C. This change moves the weak function
from C source to assembly source implementation.

Signed-off-by: Soby Mathew <soby.mathew@arm.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: arm: ignore ~OPTEE_SMC_NSEC_CAP_UNIPROCESSOR

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklan

core: arm: ignore ~OPTEE_SMC_NSEC_CAP_UNIPROCESSOR

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: prng: Don't lock a mutex from rpc_cmd_nolock()

Avoids a recursive indirect call to rpc_cmd_nolock() from
plat_prng_add_jitter_entropy_norpc() by not calling
plat_prng_add_jitter_entropy_norpc(

core: prng: Don't lock a mutex from rpc_cmd_nolock()

Avoids a recursive indirect call to rpc_cmd_nolock() from
plat_prng_add_jitter_entropy_norpc() by not calling
plat_prng_add_jitter_entropy_norpc() for RPC related to mutex
wait/wakeup.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (HiKey)
Fixes: 82f97f19fe2d ("prng: call plat_prng_add_jitter_entropy() at PRNG init and before NW RPC")
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: mutex: owner of lock in debug prints

Include the owner of the mutex in debug print issued when waiting for a
mutex.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by:

core: mutex: owner of lock in debug prints

Include the owner of the mutex in debug print issued when waiting for a
mutex.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: SQL FS: bugfix sql_fs_ftruncate_internal()

Fixes uninitialized use of return variable.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklande

core: SQL FS: bugfix sql_fs_ftruncate_internal()

Fixes uninitialized use of return variable.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: pta_socket: bugfix: avoid use after free

Avoids use after free by retrieving the instance id when the session is
opened instead of retrieving it again each time it's needed.

Reviewed-by: Jero

core: pta_socket: bugfix: avoid use after free

Avoids use after free by retrieving the instance id when the session is
opened instead of retrieving it again each time it's needed.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: arm: sm: fix PSCI reset

PSCI reset entry must call psci_system_reset(), not
psci_system_off().

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.or

core: arm: sm: fix PSCI reset

PSCI reset entry must call psci_system_reset(), not
psci_system_off().

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
[jf: Rebase, reword commit message]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: FS: fix htree memory leakage

Fixes problem with memory leakage in tee_fs_htree_sync_to_storage()
when the hash tree doesn't need to be synced to storage.

Tested-by: Jens Wiklander <jens.wikla

core: FS: fix htree memory leakage

Fixes problem with memory leakage in tee_fs_htree_sync_to_storage()
when the hash tree doesn't need to be synced to storage.

Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: plat_prng_add_jitter_entropy() logging

Changes the DMSG() logging to FMSG() to avoid flooding the logs when
debug logs are enabled.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

core: plat_prng_add_jitter_entropy() logging

Changes the DMSG() logging to FMSG() to avoid flooding the logs when
debug logs are enabled.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

libutee: demote allocation traces from DEBUG to FLOW

When CFG_TEE_CORE_USER_MEM_DEBUG=1 (which is the default, enables
additional checks in tee_user_mem.c and also enables traces) and
CFG_TEE_TA_LOG

libutee: demote allocation traces from DEBUG to FLOW

When CFG_TEE_CORE_USER_MEM_DEBUG=1 (which is the default, enables
additional checks in tee_user_mem.c and also enables traces) and
CFG_TEE_TA_LOG_LEVEL=3 (DEBUG), libutee logs messages for each and
every allocation and deallocation, as follows:

DEBUG: USER-TA: tee_user_mem_alloc:343: Allocate: link:[0x1211a0], buf:[0x1211b0:12]
DEBUG: USER-TA: tee_user_mem_free:442: Free: link:[0x1211a0], buf:[0x1211b0:12]
...

That's annoying and pretty much useless so let's change them to use
the lower TRACE_FLOW level (CFG_TEE_TA_LOG_LEVEL=4) instead.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

core: prng: Don't try to read REE time when it's not possible

The commit referenced below extends entropy gathering to two locations
where it is unfortunately not OK to invoke Normal World through R

core: prng: Don't try to read REE time when it's not possible

The commit referenced below extends entropy gathering to two locations
where it is unfortunately not OK to invoke Normal World through RPC:

1. tee_ltc_prng_init(), because at this point the RPC subsystem has not
yet been initialized,
2. rpc_cmd_nolock(), because doing so would cause recursion and would
be inefficient (doubling the number of RPC calls).

The problem is: if CFG_SECURE_TIME_SOURCE_REE=y and if the platform
does not override plat_prng_add_jitter_entropy(), the function will end
up calling the RPC service where it's not permitted and the TEE will
crash.

This commit introduces plat_prng_add_jitter_entropy_norpc() and
provides a default implementation which does nothing if the time source
is the REE, thus fixing the issue while still allowing platform code to
implement a specific behavior.

Fixes: 82f97f19fe2d ("prng: call plat_prng_add_jitter_entropy() at PRNG init and before NW RPC")
Reported-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

[Review] core: prng: Don't try to read REE time when it's not possible

Remove useless return.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

documentation: sync with secure storage implementation

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wi

documentation: sync with secure storage implementation

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: remove unused FS key manager features

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

core: remove obsolete FS key manager tests

Removes the now obsolete FS key manager tests. The FS hash tree interface
has taken over much och the FS key manager tasks.

Acked-by: Jerome Forissier <je

core: remove obsolete FS key manager tests

Removes the now obsolete FS key manager tests. The FS hash tree interface
has taken over much och the FS key manager tasks.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...