Add STAILQ_HEAD() and STAILQ_ENTRY() to typedefs.checkpatch

When using BSD queues from <sys/queues.h>, a singly linked tail queue
entry is declared with a macro:

STAILQ_ENTRY(type) var;

This makes

Add STAILQ_HEAD() and STAILQ_ENTRY() to typedefs.checkpatch

When using BSD queues from <sys/queues.h>, a singly linked tail queue
entry is declared with a macro:

STAILQ_ENTRY(type) var;

This makes checkpatch.pl unhappy because the type is unknown:

WARNING: Missing a blank line after declarations
+ struct file *file;
+ STAILQ_ENTRY(load_seg) link;

Checkpatch has the same problem with the macro STAILQ_HEAD().

This patch adds a regular expression to typedefs.checkpatch that
matches the macro part, thus fixing the warning.

Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ldelf, libutee: add minimal Thread Local Storage support

Preparing for C++ support in TAs.

Adds enough runtime Thread Local Storage (TLS) support for the GNU C++
compilers (arm-linux-gnueabihf-g++,

ldelf, libutee: add minimal Thread Local Storage support

Preparing for C++ support in TAs.

Adds enough runtime Thread Local Storage (TLS) support for the GNU C++
compilers (arm-linux-gnueabihf-g++, aarch64-linux-gnu-g++) to work with
OP-TEE. That is:

- A Thread Control Block,
- The __tls_get_addr() and dl_iterate_phdr() functions.

Note that __tls_get_addr() is an ABI helper so it has no prototype in a
user-accessible header file. dl_iterate_phdr() however is defined in
<link.h> and may be used in a TA. The file lib/libutee/include/link.h is
borrowed from Android's Bionic [1] with minor changes (added the
required #include statement and named the function parameters). A
similar <link.h> header is provided by other C libraries such as GNU
libc, musl and FreeBSD/NetBSD/OpenBSD.

Link: [1] https://android.googlesource.com/platform/bionic/+/master/libc/include/link.h
Signed-off-by: Jerome Forissier <jerome@forissier.org>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Add SLIST_HEAD() and SLIST_ENTRY() to typedefs.checkpatch

When using BSD queues from <sys/queues.h>, a simple list entry is declared
with a macro:

SLIST_ENTRY(type) var;

This makes checkpatch.pl u

Add SLIST_HEAD() and SLIST_ENTRY() to typedefs.checkpatch

When using BSD queues from <sys/queues.h>, a simple list entry is declared
with a macro:

SLIST_ENTRY(type) var;

This makes checkpatch.pl unhappy because the type is unknown:

WARNING: Missing a blank line after declarations
+ struct file *file;
+ SLIST_ENTRY(load_seg) link;

Checkpatch has the same problem with the macro SLIST_HEAD().

This patch adds a regular expression to typedefs.chackpatch that
matches the macro part, thus fixing the warning.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Add TAILQ_ENTRY() to typedefs.checkpatch

When using BSD queues from <sys/queues.h>, a queue entry is declared
with a macro:

TAILQ_ENTRY(type) var;

This makes checkpatch.pl unhappy because the typ

Add TAILQ_ENTRY() to typedefs.checkpatch

When using BSD queues from <sys/queues.h>, a queue entry is declared
with a macro:

TAILQ_ENTRY(type) var;

This makes checkpatch.pl unhappy because the type is unknown:

WARNING: Missing a blank line after declarations
#52: FILE: core/arch/arm/include/mm/tee_pager.h:32:
+ struct pgt *pgt;
+ TAILQ_ENTRY(tee_pager_area) link;

This patch adds a regular expression to typedefs.chackpatch that
matches the macro part, thus fixing the warning.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Add mbed TLS types to typedefs.checkpatch

Adds a couple of mbed TLS types to typedefs.checkpatch to avoid the
following warning:

WARNING: Missing a blank line after declarations
#100: FILE: lib/l

Add mbed TLS types to typedefs.checkpatch

Adds a couple of mbed TLS types to typedefs.checkpatch to avoid the
following warning:

WARNING: Missing a blank line after declarations
#100: FILE: lib/libutee/tee_api_arith_mpi.c:105:
+ const struct bigint_hdr *hdr = (struct bigint_hdr *)bigInt;
+ const mbedtls_mpi_uint *p = (const mbedtls_mpi_uint *)(hdr + 1);

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Update typedefs.checkpatch

Adds missing typedefs from lib/libutee/include/tee_api_types.h to
typedefs.checkpatch. This fixes checkpatch errors such as:

ERROR: need consistent spacing around '*' (c

Update typedefs.checkpatch

Adds missing typedefs from lib/libutee/include/tee_api_types.h to
typedefs.checkpatch. This fixes checkpatch errors such as:

ERROR: need consistent spacing around '*' (ctx:WxV)
#807: FILE: lib/libutee/tee_api_arith_mpi.c:773:
+void TEE_BigIntInitFMMContext(TEE_BigIntFMMContext *context __unused,
^
The file is sorted in reverse alphabetical order, otherwise checkpatch
would ignore some entries that have a common radix (such as TEE_BigInt/
TEE_BigIntFMM/TEE_BigIntFMMContext). Not sure if it is expected or if it
will be fixed in upstream checkpatch at some point.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Take some GP types into account when running patch check tool

When running checkpatch on the OP-TEE code, for instance during the
Travis checks, it happens that we get false warnings and errors caus

Take some GP types into account when running patch check tool

When running checkpatch on the OP-TEE code, for instance during the
Travis checks, it happens that we get false warnings and errors caused
by the use of GlobalPlatform typedefs. In the following example, the
patch introduces pointers to functions returning TEE_Result, but
checkpatch won't accept it as a valid type:

$ ./scripts/checkpatch.sh d776721 | tail -1
total: 1 errors, 5 warnings, 555 lines checked

To address such issues, declare our custom types in a local file
(typedefs.checkpatch) and use the new --typedefsfile option provided by
checkpatch.pl.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...