ci: notify_maintainers: do not print message without any handle

In case all handles have been filtered out from handles_to_mention, do
not print any message at all. This avoids posting a useless "FY

ci: notify_maintainers: do not print message without any handle

In case all handles have been filtered out from handles_to_mention, do
not print any message at all. This avoids posting a useless "FYI
<nothing>" comment.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ci: notify_maintainers: simplify scripts and use actions/github-script

Attempting once more to fix a 403 error in the notify_maintainers job.
Simplify the notify_maintainers.py script which now assu

ci: notify_maintainers: simplify scripts and use actions/github-script

Attempting once more to fix a 403 error in the notify_maintainers job.
Simplify the notify_maintainers.py script which now assumes the GitHub
environment with parameters passed as environment variables only and
make it output the message to stdout. It is then the responsibility of
the notify_maintainers job to post it, via the actions/github-script
action. In the tests I performed, the comment was successfully posted
by "github-actions (bot)".

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ci: scripts/notify_maintainers.py: use non-deprecated API

Supplying a token to the GitHub class constructor is deprecated. Use an
Auth object instead.

Signed-off-by: Jerome Forissier <jerome.foriss

ci: scripts/notify_maintainers.py: use non-deprecated API

Supplying a token to the GitHub class constructor is deprecated. Use an
Auth object instead.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ci: scripts/notify_maintainers.py: improve debug traces

Print the message before sending it via the GitHub API so that it
appears in the logs in case pr.create_issue_comment() raises an
exception.

ci: scripts/notify_maintainers.py: improve debug traces

Print the message before sending it via the GitHub API so that it
appears in the logs in case pr.create_issue_comment() raises an
exception.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ci: scripts/notify_maintainers.py: fix GitHub handle regexp

When looking for GitHub handles in the PR comments (i.e., people
already mentioned), include the hyphen character so that handles of the
f

ci: scripts/notify_maintainers.py: fix GitHub handle regexp

When looking for GitHub handles in the PR comments (i.e., people
already mentioned), include the hyphen character so that handles of the
form '@foo-bar' are properly matched.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

ci: scripts/notify_maintainers.py: fix undefined variable error

Fix error:

File "scripts/notify_maintainers.py", line 132, in main
" ".join(f"@{h}" for h in new_handles))

ci: scripts/notify_maintainers.py: fix undefined variable error

Fix error:

File "scripts/notify_maintainers.py", line 132, in main
" ".join(f"@{h}" for h in new_handles))
^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'new_handles' where it
is not associated with a value

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ci: mention reviewers/maintainers from MAINTAINERS

Introduce a new Python script: notify_maintainers.py and run it in CI
as part of a new job. When invoked in the context of a pull request
against t

ci: mention reviewers/maintainers from MAINTAINERS

Introduce a new Python script: notify_maintainers.py and run it in CI
as part of a new job. When invoked in the context of a pull request
against the OP-TEE OS official project, it invokes get_maintainer.py
to find out the GitHub handles of the people to whom the change in the
PR is relevant. It then posts a comment so that these people may be
notified via email. People are mentioned only once per PR (they
normally receive subsequent messages automatically). The PR author,
assignees and requested reviewers (if any) are skipped since they are
already notified, as well as the default maintainers ("THE REST") who
are assumed to receive all PRs. The format of the comment is:

github-actions (bot) commented ...

FYI <handle1> <handle2>...

Note: Subsystem/platform maintainers who have their GitHub handle in
MAINTAINERS and who already "watch" the project will receive two emails
upon creation of a PR that touches their area of expertise: one when
the PR is created, and one shortly after when the script runs and the
GitHub bot tags them in a comment. Hopefully it is only a minor
inconvenience.

Note 2: The script was written with the help of generative AI. It was
reviewed, tested and modified by me.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
Reviewed-by: Rouven Czerwinski <rouven.czerwinski@linaro.org>

show more ...