drivers: asu: guard wfe() with IRQ-mask check and add response timeout

The wfe()-based response loop in asu_update_queue_buffer_n_send_ipi()
assumes THREAD_EXCP_NATIVE_INTR is clear at every call si

drivers: asu: guard wfe() with IRQ-mask check and add response timeout

The wfe()-based response loop in asu_update_queue_buffer_n_send_ipi()
assumes THREAD_EXCP_NATIVE_INTR is clear at every call site. This
does not hold during early boot: boot_init_primary_final() re-masks all
exceptions including THREAD_EXCP_NATIVE_INTR at boot.c:1103 before
calling thread_update_canaries() -> hw_get_random_bytes(). With
PSTATE.I=1 the GIC cannot deliver SPI 89 (ASU doorbell),
asu_resp_handler() never fires, sev() is never called, and wfe() blocks
indefinitely.

Fix the response loop with two changes:

1. Arm a 2s safety timeout unconditionally before the loop so ASU
firmware failures surface as TEE_ERROR_TARGET_DEAD rather than a
silent hang.

2. Sample thread_get_exceptions() immediately before each wfe() call
with no intervening code between the check and the instruction.
This closes the TOCTOU window where the exception mask could change
between a snapshot taken before the loop and the actual wfe().
- THREAD_EXCP_NATIVE_INTR clear (IRQs unmasked): wfe() yields the
CPU; asu_resp_handler() fires sev() to wake it on response.
- THREAD_EXCP_NATIVE_INTR set (IRQs masked): udelay(10) throttles
the busy-poll, avoiding both a wfe() hang and uncontrolled bus
hammering.

asu_resp_handler() retains its sev() call to support the wfe() path.

Fixes: 7f2d4e10736f ("drivers: amd: Add ASU support")
Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

crypto: asu: fix command header length and race condition

- Updated asu_create_header() to pass command length in words
(sizeof(*cp)/sizeof(uint32_t)) instead of zero, to align with
ASUFW requir

crypto: asu: fix command header length and race condition

- Updated asu_create_header() to pass command length in words
(sizeof(*cp)/sizeof(uint32_t)) instead of zero, to align with
ASUFW requirements for proper command parsing.
- Multiple crypto drivers can submit request to shared buffer.
Make sure all queue parameters are update in spin_lock.

Fixes: 7f2d4e10736f ("drivers: amd: Add ASU support")
Signed-off-by: Harish Ediga <harish.ediga@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

drivers: amd: Add ASU support

Add support for the AMD Application Security Unit (ASU), the on-chip
Hardware Security Module (HSM) for Versal Gen 2.
The ASU manages all device-level security services

drivers: amd: Add ASU support

Add support for the AMD Application Security Unit (ASU), the on-chip
Hardware Security Module (HSM) for Versal Gen 2.
The ASU manages all device-level security services for user
applications, extending beyond accelerator-centric tasks.
Its firmware also exposes several software-based cryptographic
primitives, including:
- Key transfer
- RSA authentication (multiple padding schemes)
- HMAC
- Key Derivation Function (KDF)
- Key wrap / unwrap

Co-developed-by: Harsh Jain <h.jain@amd.com>
Signed-off-by: Harsh Jain <h.jain@amd.com>
Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...