stm32mp1: simplify stm32mp_periph_is_*()

As per design shared resources explicitly registered as secure are
assigned to the secure world while other are defacto assigned to the
non-secure world.

Th

stm32mp1: simplify stm32mp_periph_is_*()

As per design shared resources explicitly registered as secure are
assigned to the secure world while other are defacto assigned to the
non-secure world.

This change remove functions stm32mp_periph_is_unregistered() and
stm32mp_periph_is_non_secure() and keeps only stm32mp_periph_is_secure()
which return value reflects whether the resource is assigned to the
secure or non-secure world.

Suggested-by: Jérôme Forissier <jerome.forissier@linaro.org>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

stm32mp1: remove info traces on shared resource registering

Change verbosity of shared resource registration traces from info
to debug log level.

Signed-off-by: Etienne Carriere <etienne.carriere@l

stm32mp1: remove info traces on shared resource registering

Change verbosity of shared resource registration traces from info
to debug log level.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: thread: use READ_ONCE() when accessing data in shared memory

In some places we read a value from shared memory, then based on the
value we take some actions. When multiple tests are done, we s

core: thread: use READ_ONCE() when accessing data in shared memory

In some places we read a value from shared memory, then based on the
value we take some actions. When multiple tests are done, we should make
sure that the value is not read multiple times because there is no
guarantee that Normal World has not changed the value in the mean time,
which could break the logic. Consider for instance:

if (shared && shared->value)
do_something();

If "shared" resides in shared memory, it might change between
"if (shared)" and "if (shared->value)". If it happens to be set to NULL
for example, the code will crash.
To ensure consistency, a temporary variable has to be used to hold the
value, and the READ_ONCE() macro is required to prevent the compiler
from emitting multiple loads of the memory location.

Reported-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

core: verify size of allocated shared memory

Makes sure that normal world cannot change the size of allocated shared
memory, resulting in a smaller buffer being allocated.

Suggested-by: Bastien Sim

core: verify size of allocated shared memory

Makes sure that normal world cannot change the size of allocated shared
memory, resulting in a smaller buffer being allocated.

Suggested-by: Bastien Simondi <bsimondi@netflix.com> [1.1]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

core: scrub user-tainted memory returned by alloc_temp_sec_mem()

This is a security fix for TA-to-TA calls.

In syscall_open_ta_session() and syscall_invoke_ta_command(), caller TA
can reference som

core: scrub user-tainted memory returned by alloc_temp_sec_mem()

This is a security fix for TA-to-TA calls.

In syscall_open_ta_session() and syscall_invoke_ta_command(), caller TA
can reference some private memory, in which case the kernel makes a
temporary copy. Unfortunately, memory allocated through
alloc_temp_sec_mem() is not cleared when returned. One could leverage
this to copy arbitrary data into this secure memory pool or to snoop
former data from a previous call done by another TA (e.g., using
TEE_PARAM_TYPE_MEMREF_OUTPUT allows to map the data while not overwriting
it, hence accessing to what is already there).

This patch introduces mobj_free_wipe() to clear and free an mobj.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com> [1.5]
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

stm32mp1: default embedded RNG driver

Default enable CFG_STM32_RNG in the platform configuration.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech

stm32mp1: default embedded RNG driver

Default enable CFG_STM32_RNG in the platform configuration.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

stm32mp1: fix missing RNG1 non-secure mapping

RNG1 may be assigned to the non-secure world while secure world do
use the resource. In such case, secure world is responsible for
accessing the periphe

stm32mp1: fix missing RNG1 non-secure mapping

RNG1 may be assigned to the non-secure world while secure world do
use the resource. In such case, secure world is responsible for
accessing the peripheral in a system state where non-secure world
cannot execute of interfere in RNG1 state. secure world will uses RNG1
even if non-secure, during OP-TEE initialization and some power states
transitions, when non-secure world is not executed.

This change corrects the missing mapping of RNG1 IO memory with
non-secure access attributes.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

core: share sections of loaded elf

Uses the file interface to share read-only parts of loaded binary
content of an ELF. This means that multiple instances of one TA will
share the read-only data/cod

core: share sections of loaded elf

Uses the file interface to share read-only parts of loaded binary
content of an ELF. This means that multiple instances of one TA will
share the read-only data/code of each ELF.

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey960, GP)
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_mmu_map_param(): clean mapped params

If tee_mmu_map_param() fails, clean mapped params by calling
tee_mmu_clean_param() in case some mappings succeeded.

Reviewed-by: Jerome Forissier <jer

core: tee_mmu_map_param(): clean mapped params

If tee_mmu_map_param() fails, clean mapped params by calling
tee_mmu_clean_param() in case some mappings succeeded.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix assertion '(*pgt)->vabase == pg_info->va_base'

Fixes assertion in set_pg_region() which is triggered by holes in a vm
map spanning over at least one complete page table.

Acked-by: Jerome

core: fix assertion '(*pgt)->vabase == pg_info->va_base'

Fixes assertion in set_pg_region() which is triggered by holes in a vm
map spanning over at least one complete page table.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_pager_set_uta_area_attr(): check same context

Prior to this patch it was assumed that only one area could be using a
fobj unless it was shared between multiple context. This isn't true, If

core: tee_pager_set_uta_area_attr(): check same context

Prior to this patch it was assumed that only one area could be using a
fobj unless it was shared between multiple context. This isn't true, If
an area happens to span two page tables it will be split into two areas
connected to the same fobj. This patch fixes this by checking that all
areas using a fobj has the context.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_mmu.c: only free unused page tables

When freeing page tables or a partially used pages make sure that other
parts of the page tables are unused.

Acked-by: Jerome Forissier <jerome.forissi

core: tee_mmu.c: only free unused page tables

When freeing page tables or a partially used pages make sure that other
parts of the page tables are unused.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: pgt_flush_ctx_range(): check arg pgt_cache

In pgt_flush_ctx_range() check that the argument pgt_cache isn't NULL
before traversing the list.

Acked-by: Jerome Forissier <jerome.forissier@linar

core: pgt_flush_ctx_range(): check arg pgt_cache

In pgt_flush_ctx_range() check that the argument pgt_cache isn't NULL
before traversing the list.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_ta_init_user_ta_session(): flush pgt on error

If tee_ta_init_user_ta_session() fails to initialize the user TA, call
pgt_flush_ctx() on cleanup to make sure that all used page entries are

core: tee_ta_init_user_ta_session(): flush pgt on error

If tee_ta_init_user_ta_session() fails to initialize the user TA, call
pgt_flush_ctx() on cleanup to make sure that all used page entries are
released since some page fault may have been served already.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: free_elf_states(): clear elf->elf_state

Clear elf->elf_state in free_elf_states() to avoid leaving a dangling
pointer.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-b

core: free_elf_states(): clear elf->elf_state

Clear elf->elf_state in free_elf_states() to avoid leaving a dangling
pointer.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: invalidate entire icache

Invalidates entire icache when icache invalidation could be needed. This
invalidates more entries than strictly needed. The advantage is stable
paging. Next step is to

core: invalidate entire icache

Invalidates entire icache when icache invalidation could be needed. This
invalidates more entries than strictly needed. The advantage is stable
paging. Next step is to locate places where tlb and icache invalidations
can be relaxed.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: elf_flags_to_mattr(): add privileged bits

Adds the privileged bits TEE_MATTR_PW and TEE_MATTR_PR when setting the
corresponding user bits TEE_MATTR_UW and TEE_MATTR_UR respectively. This
resul

core: elf_flags_to_mattr(): add privileged bits

Adds the privileged bits TEE_MATTR_PW and TEE_MATTR_PR when setting the
corresponding user bits TEE_MATTR_UW and TEE_MATTR_UR respectively. This
results in tee_pager_add_uta_area() initializing allocated struct
tee_pager_area with the same protection bits as if the protection bits
was set with vm_set_prot(). As a consequence will vm_set_prot() only
make changes if effective protection bits are changed.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_pager_set_uta_area_attr(): save flags

Prior to this patch is tee_pager_set_uta_area_attr() saving the mattr
bits instead of just the protection bits derived from the flags
parameter. This

core: tee_pager_set_uta_area_attr(): save flags

Prior to this patch is tee_pager_set_uta_area_attr() saving the mattr
bits instead of just the protection bits derived from the flags
parameter. This leads to tee_pager_set_uta_area_attr() updating
permission even when not needed. With this patch is only the effective
protection bits saved in the different struct tee_pager_area which are
updated when changing permissions.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add get_tag() to struct user_ta_store_ops

Adds get_tag() method to struct user_ta_store_ops.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wi

core: add get_tag() to struct user_ta_store_ops

Adds get_tag() method to struct user_ta_store_ops.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add prot arg to tee_pager_add_uta_area()

Adds a prot argument to tee_pager_add_uta_area() to set the initial
protection instead of the previous TEE_MATTR_PRW | TEE_MATTR_URWX;

Reviewed-by: Et

core: add prot arg to tee_pager_add_uta_area()

Adds a prot argument to tee_pager_add_uta_area() to set the initial
protection instead of the previous TEE_MATTR_PRW | TEE_MATTR_URWX;

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: remove unused tee_pager_transfer_uta_region()

Removes the now unused function tee_pager_transfer_uta_region()

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wikl

core: remove unused tee_pager_transfer_uta_region()

Removes the now unused function tee_pager_transfer_uta_region()

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: remove unused pgt_transfer()

Removes the now unused function pgt_transfer()

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

core: user_ta: support mapping paged parameters

Supports mapping shared paged parameters for user TA.

vm_map() is modified to map objects with the TEE_MATTR_EPHEMERAL
attribute which is an indicati

core: user_ta: support mapping paged parameters

Supports mapping shared paged parameters for user TA.

vm_map() is modified to map objects with the TEE_MATTR_EPHEMERAL
attribute which is an indication that it's a parameter instead of TA
code/data or permanent mapping.

tee_mmu_clean_param() is added to clean out all parameters added with
tee_mmu_map_param().

In tee_mmu_map_param() instead of clearing out any old parameters
there's a check to see that there's no old parameters hanging around.

Finally mobj_update_mapping() is removed since the pager now supports
shared mappings.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add get_fobj() to mobj_seccpy_shm

Adds get_fobj() method to the mobj_seccpy_shm object.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wikland

core: add get_fobj() to mobj_seccpy_shm

Adds get_fobj() method to the mobj_seccpy_shm object.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: pager: record fobj in pmem instead of area

Records the fobj backing the physical page represented by a pmem instead
of struct tee_pager_area which was used prior to this patch. Each fobj
can

core: pager: record fobj in pmem instead of area

Records the fobj backing the physical page represented by a pmem instead
of struct tee_pager_area which was used prior to this patch. Each fobj
can be used by several unrelated areas in the end allowing real shared
memory between multiple user context.

Reference counting for the page tables is increasing in activity since
entries which are hidden/unhidden also decrease/increase the count. This
is because there's no difference between unhiding a pmem or just mapping
it again in another page table.

The memory sharing is not fully taken advantage of in this patch.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...