xref: /rkbin/scripts/checkpatch.sh (revision 00951929625876f7874a74855ad9324674ce8562)
1#!/bin/bash
2set -e
3
4ARG_COMMIT=$1
5DIFF_SUBSET="scripts/.diff_*"
6DIFF_DOC_ALL="scripts/.diff_all.txt"
7DIFF_DOC_FIXED="scripts/.diff_fixed.txt"
8LAST_SEVERITY=
9LAST_DOC=
10
11function check_doc()
12{
13	local TOP_SEVERITY LANGUAGE=$1
14
15	if [ "${LANGUAGE}" == "EN" ] ; then
16		SVT_CRITIAL="critical"
17		SVT_IMPORTANT="important"
18		SVT_MODERATE="moderate"
19		DOC=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_EN\.md/p"`
20	else
21		SVT_CRITIAL="紧急"
22		SVT_IMPORTANT="重要"
23		SVT_MODERATE="普通"
24		DOC=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_CN\.md/p"`
25	fi
26
27	echo "Checking doc: ${DOC}"
28
29	# check DOS encoding
30	git show ${ARG_COMMIT} -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}
31	git show ${ARG_COMMIT} -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}.dos
32	dos2unix ${DIFF_DOC_ALL}.dos >/dev/null 2>&1
33	CSUM1=`md5sum ${DIFF_DOC_ALL} | awk '{ print $1 }'`
34	CSUM2=`md5sum ${DIFF_DOC_ALL}.dos | awk '{ print $1 }'`
35	if [ "${CSUM1}" != "${CSUM2}" ]; then
36		echo "ERROR: ${DOC} is DOS encoding. Fix it by: 'dos2unix ${DOC}'"
37		exit 1
38	fi
39
40	TITLE=`sed -n "/^+## /p" ${DIFF_DOC_ALL} | tr -d " +#"`
41	DATE=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $2 }'`
42	YEAR=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $2 }' | awk -F "-" '{ print $1 }'`
43	FILE=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $3 }'`
44	COMMIT=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $4 }'`
45	SEVERITY=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $5 }'`
46	END_LINE_3=`tail -n 3 ${DIFF_DOC_ALL} | sed -n '1p'`
47	END_LINE_2=`tail -n 3 ${DIFF_DOC_ALL} | sed -n '2p'`
48	END_LINE_1=`tail -n 3 ${DIFF_DOC_ALL} | sed -n '3p'`
49	HOST_YEAR=`date +%Y`
50	# echo "### ${COMMIT}, ${SEVERITY}, ${TITLE}, ${FILE}"
51
52	# check blank line after Heading 1
53	HEADING_1=`sed -n '1p' ${DOC}`
54	if sed -n '2p' ${DOC} | grep -q [a-z,A-Z] ; then
55		echo "ERROR: ${DOC}: Please add blank line after '${HEADING_1}'"
56		exit 1
57	fi
58
59	# check space
60	if sed -n "/##/p" ${DOC} | grep -v '## [a-z,A-Z]' ; then
61		echo "ERROR: ${DOC}: Please only 1 space between '#' and word"
62		exit 1
63	fi
64
65	# check new content location
66	if ! git show ${ARG_COMMIT} -1 ${DOC} | grep -q 'Release Note' ; then
67		echo "ERROR: ${DOC}: Please add new content at the top but not bottom"
68		exit 1
69	fi
70
71	# check title
72	if grep -Eq '### NEW|### new' ${DIFF_DOC_ALL} ; then
73		echo "ERROR: ${DOC}: Please use '### New'"
74		exit 1
75	fi
76
77	if grep -Eq '### FIXED|### fixed' ${DIFF_DOC_ALL} ; then
78		echo "ERROR: ${DOC}: Please use '### Fixed'"
79		exit 1
80	fi
81
82	# check year
83	if [ "${HOST_YEAR}" != "${YEAR}" ]; then
84		echo "ERROR: ${DOC}: '${DATE}' is wrong, the year should be ${HOST_YEAR}"
85		exit 1
86	fi
87
88	# check TAB before index of 'New' body
89	if grep -q $'\t[0-9]' ${DOC} ; then
90		echo "ERROR: ${DOC}: Don't add TAB before index:"
91		grep $'\t[0-9]' ${DOC}
92		exit 1
93	fi
94
95	# check upper case and line end
96	if [ "${LANGUAGE}" == "EN" ] ; then
97		if grep -q '^[0-9]\. [a-z]' ${DOC} ; then
98			echo "ERROR: ${DOC}: Please use upper case of first word(i.e. \"1. add ..\" => \"1. Add ...\"):"
99			grep '^[0-9]\. [a-z]' ${DOC}
100			exit 1
101		fi
102
103		# check end with '.'
104		if sed -n '/^[0-9]\. [A-Z]/p' ${DOC} | grep -q '[^.]$' ; then
105			echo "ERROR: ${DOC}: Please end line with '.'"
106			grep '^[0-9]\. [A-Z]' ${DOC} | grep '[^.]$'
107			exit 1
108		fi
109
110		# check Chinese language
111		if grep -P '[\x{4e00}-\x{9fa5}]' ${DOC} ; then
112			echo "ERROR: ${DOC}: The Chinese language was found"
113			exit 1
114		fi
115	else
116		# check end with '。'
117		if sed -n '/^[0-9]\. /p' ${DOC} | grep -q '[^。]$' ; then
118			echo "ERROR: ${DOC}: Please end line with '。'"
119			grep '^[0-9]\. ' ${DOC} | grep '[^。]$'
120			exit 1
121		fi
122	fi
123
124	# check space after index of 'New' body
125	SUM1=`grep '^[0-9]\.' ${DOC} | wc -l`
126	SUM2=`grep '^[0-9]\.[[:blank:]]' ${DOC} | wc -l`
127	if [ "$SUM1" != "$SUM2" ]; then
128		echo "ERROR: ${DOC}: Please add space after index (e.g: '1. ' but not '1.'):"
129		grep '^+[0-9]\.' ${DIFF_DOC_ALL}
130		exit 1
131	fi
132
133	# check standalone file
134	if ! echo ${FILE} | grep -Eq '\.bin|\.elf|\.img' ; then
135		echo "ERROR: ${DOC}: '${FILE}' missing the file format suffix"
136		exit 1
137	fi
138	if ! echo ${FILE} | grep -q { ; then
139		if ! git log ${ARG_COMMIT} -1 --name-only | grep -q ${FILE}; then
140			echo "ERROR: ${DOC}: '${FILE}' is not updated in this patch"
141			exit 1
142		fi
143	fi
144
145	# check title
146	if [ "${TITLE}" != "${FILE}" ]; then
147		echo "ERROR: ${DOC}: Title '${TITLE}' is not match with '${FILE}'"
148		exit 1
149	fi
150
151	# check commit
152	COMMIT=${COMMIT//#/ }
153	for LIST in ${COMMIT}; do
154		CMT=`echo ${LIST} | cut -d : -f 2`
155		if ! git log ${ARG_COMMIT} -1 | grep -q ${CMT} ; then
156			echo "ERROR: ${DOC}: '${CMT}' is not match in commit message"
157			exit 1
158		fi
159
160		if ! echo ${FILE} | grep -q { ; then
161			if echo ${FILE} | grep -Eq 'spl_|tpl_|bl31_|bl32_|tee_' ; then
162				FILE_PATH=`find -name ${FILE}`
163				if [ -z "${FILE_PATH}" ]; then
164					echo "ERROR: ${DOC}: No ${FILE}"
165					exit 1
166				fi
167				if ! strings ${FILE_PATH} | grep -q ${CMT} ; then
168					echo "ERROR: ${DOC}: ${FILE} is not build from '${CMT}'"
169					exit 1
170				fi
171			fi
172		fi
173	done
174
175	# check severity
176	if [ "${SEVERITY}" != "${SVT_CRITIAL}" -a "${SEVERITY}" != "${SVT_IMPORTANT}" -a "${SEVERITY}" != "${SVT_MODERATE}" ]; then
177		echo "ERROR: ${DOC}: Unknown main severity: ${SEVERITY}"
178		exit 1
179	fi
180
181	# check horizontal line
182	if [ "${END_LINE_2}" != "+------" ]; then
183		echo "ERROR: ${DOC}: Please add horizontal line '------' at the last of new content"
184		exit 1
185	fi
186	if [ "${END_LINE_3}" != "+" ]; then
187		echo "ERROR: ${DOC}: Please add blank line before horizontal line '------'"
188		exit 1
189	fi
190	if [ "${END_LINE_1}" != "+" ]; then
191		echo "ERROR: ${DOC}: Please add blank line after horizontal line '------'"
192		exit 1
193	fi
194
195	# check 'Fixed' content
196	if grep -q "^+### Fixed" ${DIFF_DOC_ALL} ; then
197		awk -v RS='### Fixed' 'END{printf "%s", $0}' ${DIFF_DOC_ALL} > ${DIFF_DOC_FIXED}
198		sed -i "/^$/d"    ${DIFF_DOC_FIXED}
199		sed -i "/Index/d" ${DIFF_DOC_FIXED}
200		sed -i "/---/d"   ${DIFF_DOC_FIXED}
201		sed -i "/^+$/d"   ${DIFF_DOC_FIXED}
202
203		while read LINE
204		do
205			EACH_SEVERITY=`echo "${LINE}" | awk -F "|" '{ print $3 }' | tr -d " "`
206			if [ "${EACH_SEVERITY}" != "${SVT_CRITIAL}" -a "${EACH_SEVERITY}" != "${SVT_IMPORTANT}" -a "${EACH_SEVERITY}" != "${SVT_MODERATE}" ]; then
207				if [ -z "${EACH_SEVERITY}" ]; then
208					echo "ERROR: ${DOC}: No severity found, please use Table to list what you '### Fixed'"
209				else
210					echo "ERROR: ${DOC}: Unknown severity: ${EACH_SEVERITY}"
211				fi
212				exit 1
213			fi
214
215			# echo "## EACH: $EACH_SEVERITY"
216			if [ -z "${TOP_SEVERITY}" ]; then
217				TOP_SEVERITY="${EACH_SEVERITY}"
218			elif [ "${TOP_SEVERITY}" == "${SVT_MODERATE}" ]; then
219				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" -o "${EACH_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
220					TOP_SEVERITY="${EACH_SEVERITY}"
221				fi
222			elif [ "${TOP_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
223				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" ]; then
224					TOP_SEVERITY="${EACH_SEVERITY}"
225				fi
226			fi
227		done < ${DIFF_DOC_FIXED}
228
229		if [ "${SEVERITY}" != "${TOP_SEVERITY}" ]; then
230			echo "ERROR: ${DOC}: Top severity should be '${TOP_SEVERITY}' as it's the highest level of all sub severity"
231			exit 1
232		fi
233
234		# check top severity miss match
235		if [ ! -z ${LAST_SEVERITY} ]; then
236			if [ "${LAST_SEVERITY}" == "普通" -a "${TOP_SEVERITY}" != "moderate" ]; then
237				MISS_MATCH="y"
238			elif [ "${LAST_SEVERITY}" == "重要" -a "${TOP_SEVERITY}" != "important" ]; then
239				MISS_MATCH="y"
240			elif [ "${LAST_SEVERITY}" == "紧急" -a "${TOP_SEVERITY}" != "critical" ]; then
241				MISS_MATCH="y"
242			elif [ "${LAST_SEVERITY}" == "moderate" -a "${TOP_SEVERITY}" != "普通" ]; then
243				MISS_MATCH="y"
244			elif [ "${LAST_SEVERITY}" == "important" -a "${TOP_SEVERITY}" != "重要" ]; then
245				MISS_MATCH="y"
246			elif [ "${LAST_SEVERITY}" == "critical" -a "${TOP_SEVERITY}" != "紧急" ]; then
247				MISS_MATCH="y"
248			fi
249
250			if [ "${MISS_MATCH}" == "y" ]; then
251				echo "ERROR: ${DOC}: top Severity is '${SEVERITY}', while ${LAST_DOC}: top Severity is '${LAST_SEVERITY}'"
252				echo "       Available Severity types are: moderate(普通), important(重要), critical(紧急)"
253				exit 1
254			fi
255		fi
256
257		LAST_SEVERITY="${SEVERITY}"
258		LAST_DOC="${DOC}"
259	fi
260}
261
262function check_docs()
263{
264	if git log ${ARG_COMMIT} -1 --name-only | sed -n '5p' | grep -Eq '^    Revert "' ; then
265		return;
266	fi
267
268	if git log ${ARG_COMMIT} -1 --name-only | grep -Eq '\.bin|\.elf' ; then
269		DOC_CN=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_CN\.md/p"`
270		DOC_EN=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_EN\.md/p"`
271		if [ -z "${DOC_CN}" -o -z "${DOC_EN}" ]; then
272			echo "ERROR: Should update CN and EN Release-Note when .bin/elf changed"
273			exit 1
274		fi
275
276		NUM=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/\.md/p" | wc -l`
277		if [ ${NUM} -gt 2 ]; then
278			echo "ERROR: More than 2 release note are updated"
279			exit 1
280		fi
281
282		if ! which dos2unix > /dev/null 2>&1 ; then
283			echo "ERROR: No 'dos2unix'. Fix by: sudo apt-get install dos2unix"
284			exit 1
285		fi
286
287		check_doc CN
288		check_doc EN
289	fi
290
291	rm -f ${DIFF_SUBSET}
292}
293
294function pack_loader_image()
295{
296	for FILE in `ls ./RKBOOT/*MINIALL*.ini`
297	do
298		if [ "${FILE}" = "./RKBOOT/RK302AMINIALL.ini" -o \
299			 "${FILE}" = "./RKBOOT/RK30BMINIALL.ini" -o \
300			 "${FILE}" = "./RKBOOT/RK30MINIALL.ini" -o \
301			 "${FILE}" = "./RKBOOT/RK310BMINIALL.ini" ]; then
302			continue;
303		fi
304
305		if grep -q '^PATH=img/' ${FILE}; then
306			continue;
307		fi
308
309		echo "Pack loader: ${FILE}"
310		./tools/boot_merger ${FILE}
311		rm -f *loader*.bin *download*.bin *idblock*.img
312		echo
313	done
314}
315
316function pack_trust_image()
317{
318	# Pack 32-bit trust
319	for FILE in `ls ./RKTRUST/*TOS*.ini`
320	do
321		if ! test -s ${FILE}; then
322			continue;
323		elif ! grep -q 'TOS' ${FILE}; then
324			continue;
325		elif grep -q '^PATH=img/' ${FILE}; then
326			continue;
327		fi
328
329		echo "Pack trust: ${FILE}"
330		# Parse orignal path
331		TOS=`sed -n "/TOS=/s/TOS=//p" ${FILE}|tr -d '\r'`
332		TOS_TA=`sed -n "/TOSTA=/s/TOSTA=//p" ${FILE}|tr -d '\r'`
333
334		# replace "./tools/rk_tools/" with "./" to compatible legacy ini content of rkdevelop branch
335		TOS=$(echo ${TOS} | sed "s/tools\/rk_tools\//\.\//g")
336		TOS_TA=$(echo ${TOS_TA} | sed "s/tools\/rk_tools\//\.\//g")
337
338		if [ x${TOS_TA} != x -a x${TOS} != x ]; then
339			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
340			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust_with_ta.img 0x68400000
341		elif [ ${TOS} ]; then
342			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
343		elif [ ${TOS_TA} ]; then
344			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust.img 0x68400000
345		else
346			exit 1
347		fi
348		rm -f trust*.img
349		echo
350	done
351
352	# Pack 64-bit trust
353	for FILE in `ls ./RKTRUST/*TRUST*.ini`
354	do
355		if grep -q '^PATH=img/' ${FILE}; then
356			continue;
357		fi
358
359		echo "Pack trust: ${FILE}"
360		./tools/trust_merger ${FILE}
361		rm -f trust*.img
362		echo
363	done
364}
365
366function check_dirty()
367{
368	for FILE in `find -name '*spl*.bin' -o -name '*tpl*.bin' -o -name '*usbplug*.bin' -o -name '*bl31*.elf' -o -name '*bl32*.bin'`; do
369		echo "Checking clean: ${FILE}"
370		if strings ${FILE} | grep '\-dirty ' ; then
371			echo "ERROR: ${FILE} is dirty"
372			exit 1
373		fi
374	done
375}
376
377function check_stripped()
378{
379	for FILE in `find -name '*bl31*.elf'`; do
380		echo "Checking strip: ${FILE}"
381		INFO=`file ${FILE}`
382		if echo ${INFO} | grep -q "not stripped" ; then
383			echo "ERROR: ${FILE} is not stripped"
384			exit 1
385		fi
386	done
387}
388
389function check_mode()
390{
391	echo "Checking file mode..."
392	if git whatchanged ${ARG_COMMIT} -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | awk '{ print $2 }' | grep -q 755 ; then
393		git whatchanged ${ARG_COMMIT} -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | grep 755
394		echo "ERROR: Set 644 file permission but not 755."
395		exit 1
396	fi
397}
398
399function finish()
400{
401	echo "OK, everything is nice."
402	echo
403}
404
405check_mode
406check_docs
407check_dirty
408check_stripped
409pack_loader_image
410pack_trust_image
411finish
412