xref: /rkbin/scripts/checkpatch.sh (revision acf80986efe16c0a51295cf61c046729bda83253)
124a8c2d6SJoseph Chen#!/bin/bash
224a8c2d6SJoseph Chenset -e
324a8c2d6SJoseph Chen
4*acf80986SJoseph ChenARG_COMMIT=$1
56f2bc86dSJoseph ChenDIFF_SUBSET="scripts/.diff_*"
6f3572ad9SJoseph ChenDIFF_DOC_ALL="scripts/.diff_all.txt"
7f3572ad9SJoseph ChenDIFF_DOC_FIXED="scripts/.diff_fixed.txt"
8f3572ad9SJoseph Chen
9f3572ad9SJoseph Chenfunction check_doc()
10f3572ad9SJoseph Chen{
11f3572ad9SJoseph Chen	local TOP_SEVERITY LANGUAGE=$1
12f3572ad9SJoseph Chen
13f3572ad9SJoseph Chen	if [ "${LANGUAGE}" == "EN" ] ; then
14f3572ad9SJoseph Chen		SVT_CRITIAL="critical"
15f3572ad9SJoseph Chen		SVT_IMPORTANT="important"
16f3572ad9SJoseph Chen		SVT_MODERATE="moderate"
17*acf80986SJoseph Chen		DOC=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_EN\.md/p"`
18f3572ad9SJoseph Chen	else
19f3572ad9SJoseph Chen		SVT_CRITIAL="紧急"
20f3572ad9SJoseph Chen		SVT_IMPORTANT="重要"
21f3572ad9SJoseph Chen		SVT_MODERATE="普通"
22*acf80986SJoseph Chen		DOC=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_CN\.md/p"`
23f3572ad9SJoseph Chen	fi
24f3572ad9SJoseph Chen
25f3572ad9SJoseph Chen	echo "Checking doc: ${DOC}"
26f3572ad9SJoseph Chen
276f2bc86dSJoseph Chen	# check DOS encoding
28*acf80986SJoseph Chen	git show ${ARG_COMMIT} -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}
29*acf80986SJoseph Chen	git show ${ARG_COMMIT} -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}.dos
306f2bc86dSJoseph Chen	dos2unix ${DIFF_DOC_ALL}.dos >/dev/null 2>&1
316f2bc86dSJoseph Chen	CSUM1=`md5sum ${DIFF_DOC_ALL} | awk '{ print $1 }'`
326f2bc86dSJoseph Chen	CSUM2=`md5sum ${DIFF_DOC_ALL}.dos | awk '{ print $1 }'`
336f2bc86dSJoseph Chen	if [ "${CSUM1}" != "${CSUM2}" ]; then
346f2bc86dSJoseph Chen		echo "ERROR: ${DOC} is DOS encoding. Fix it by: 'dos2unix ${DOC}'"
356f2bc86dSJoseph Chen		exit 1
366f2bc86dSJoseph Chen	fi
376f2bc86dSJoseph Chen
38f3572ad9SJoseph Chen	TITLE=`sed -n "/^+## /p" ${DIFF_DOC_ALL} | tr -d " +#"`
39f3572ad9SJoseph Chen	FILE=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $3 }'`
40f3572ad9SJoseph Chen	COMMIT=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $4 }'`
41f3572ad9SJoseph Chen	SEVERITY=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $5 }'`
42f3572ad9SJoseph Chen	HORIZONTAL_LINE=`sed -n "/^+------$/p" ${DIFF_DOC_ALL}`
43f3572ad9SJoseph Chen	# echo "### ${COMMIT}, ${SEVERITY}, ${TITLE}, ${FILE}"
44f3572ad9SJoseph Chen
450287fa94SJoseph Chen	# check new content location
46*acf80986SJoseph Chen	if ! git show ${ARG_COMMIT} -1 ${DOC} | grep -q 'Release Note' ; then
470287fa94SJoseph Chen		echo "ERROR: ${DOC}: Adding new content at the top but not bottom"
480287fa94SJoseph Chen		exit 1
490287fa94SJoseph Chen	fi
500287fa94SJoseph Chen
510287fa94SJoseph Chen	# check TAB before index of 'New' body
520287fa94SJoseph Chen	if grep -q $'\t[0-9]' ${DOC} ; then
530287fa94SJoseph Chen		echo "ERROR: ${DOC}: Don't add TAB before index:"
540287fa94SJoseph Chen		grep $'\t[0-9]' ${DOC}
550287fa94SJoseph Chen		exit 1
560287fa94SJoseph Chen	fi
570287fa94SJoseph Chen
58f3572ad9SJoseph Chen	# check standalone file
59f3572ad9SJoseph Chen	if ! echo ${FILE} | grep -q { ; then
60*acf80986SJoseph Chen		if ! git log ${ARG_COMMIT} -1 --name-only | grep -q ${FILE}; then
610f8ea74fSJoseph Chen			echo "ERROR: ${DOC}: '${FILE}' is not updated in this patch"
62f3572ad9SJoseph Chen			exit 1
63f3572ad9SJoseph Chen		fi
64f3572ad9SJoseph Chen	fi
65f3572ad9SJoseph Chen
66f3572ad9SJoseph Chen	# check title
67f3572ad9SJoseph Chen	if [ "${TITLE}" != "${FILE}" ]; then
68f3572ad9SJoseph Chen		echo "ERROR: ${DOC}: Title '${TITLE}' is not match with '${FILE}'"
69f3572ad9SJoseph Chen		exit 1
70f3572ad9SJoseph Chen	fi
71f3572ad9SJoseph Chen
72f3572ad9SJoseph Chen	# check commit
73f3572ad9SJoseph Chen	COMMIT=${COMMIT//#/ }
74f3572ad9SJoseph Chen	for LIST in ${COMMIT}; do
75f3572ad9SJoseph Chen		CMT=`echo ${LIST} | cut -d : -f 2`
76*acf80986SJoseph Chen		if ! git log ${ARG_COMMIT} -1 | grep -q ${CMT} ; then
77*acf80986SJoseph Chen			echo "ERROR: ${DOC}: '${CMT}' is not match in ARG_COMMIT message"
78f3572ad9SJoseph Chen			exit 1
79f3572ad9SJoseph Chen		fi
8039bfe203SJoseph Chen
8139bfe203SJoseph Chen		if ! echo ${FILE} | grep -q { ; then
8239bfe203SJoseph Chen			if echo ${FILE} | grep -Eq 'spl_|tpl_|bl31_|bl32_|tee_' ; then
8339bfe203SJoseph Chen				FILE_PATH=`find -name ${FILE}`
84*acf80986SJoseph Chen				if [ -z "${FILE_PATH}" ]; then
85*acf80986SJoseph Chen					echo "ERROR: ${DOC}: No ${FILE}"
86*acf80986SJoseph Chen					exit 1
87*acf80986SJoseph Chen				fi
8839bfe203SJoseph Chen				if ! strings ${FILE_PATH} | grep -q ${CMT} ; then
8939bfe203SJoseph Chen					echo "ERROR: ${DOC}: ${FILE} is not build from '${CMT}'"
9039bfe203SJoseph Chen					exit 1
9139bfe203SJoseph Chen				fi
9239bfe203SJoseph Chen			fi
9339bfe203SJoseph Chen		fi
94f3572ad9SJoseph Chen	done
95f3572ad9SJoseph Chen
96f3572ad9SJoseph Chen	# check severity
97f3572ad9SJoseph Chen	if [ "${SEVERITY}" != "${SVT_CRITIAL}" -a "${SEVERITY}" != "${SVT_IMPORTANT}" -a "${SEVERITY}" != "${SVT_MODERATE}" ]; then
98f3572ad9SJoseph Chen		echo "ERROR: ${DOC}: Unknown main severity: ${SEVERITY}"
99f3572ad9SJoseph Chen		exit 1
100f3572ad9SJoseph Chen	fi
101f3572ad9SJoseph Chen
102f3572ad9SJoseph Chen	# check horizontal line
103f3572ad9SJoseph Chen	if [ -z "${HORIZONTAL_LINE}" ]; then
1040f8ea74fSJoseph Chen		echo "ERROR: ${DOC}: No horizontal line '------' at the last of new content"
105f3572ad9SJoseph Chen		exit 1
106f3572ad9SJoseph Chen	fi
107f3572ad9SJoseph Chen
108f3572ad9SJoseph Chen	# check 'Fixed' content
109f3572ad9SJoseph Chen	if grep -q "^+### Fixed" ${DIFF_DOC_ALL} ; then
110f3572ad9SJoseph Chen		awk -v RS='### Fixed' 'END{printf "%s", $0}' ${DIFF_DOC_ALL} > ${DIFF_DOC_FIXED}
111f3572ad9SJoseph Chen		sed -i "/^$/d"    ${DIFF_DOC_FIXED}
112f3572ad9SJoseph Chen		sed -i "/Index/d" ${DIFF_DOC_FIXED}
113f3572ad9SJoseph Chen		sed -i "/---/d"   ${DIFF_DOC_FIXED}
114f3572ad9SJoseph Chen		sed -i "/^+$/d"   ${DIFF_DOC_FIXED}
115f3572ad9SJoseph Chen
116f3572ad9SJoseph Chen		while read LINE
117f3572ad9SJoseph Chen		do
118f3572ad9SJoseph Chen			EACH_SEVERITY=`echo "${LINE}" | awk -F "|" '{ print $3 }' | tr -d " "`
119f3572ad9SJoseph Chen			if [ "${EACH_SEVERITY}" != "${SVT_CRITIAL}" -a "${EACH_SEVERITY}" != "${SVT_IMPORTANT}" -a "${EACH_SEVERITY}" != "${SVT_MODERATE}" ]; then
120f3572ad9SJoseph Chen				echo "ERROR: ${DOC}: Unknown severity: ${EACH_SEVERITY}"
121f3572ad9SJoseph Chen				exit 1
122f3572ad9SJoseph Chen			fi
123f3572ad9SJoseph Chen
124f3572ad9SJoseph Chen			# echo "## EACH: $EACH_SEVERITY"
125f3572ad9SJoseph Chen			if [ -z "${TOP_SEVERITY}" ]; then
126f3572ad9SJoseph Chen				TOP_SEVERITY="${EACH_SEVERITY}"
127f3572ad9SJoseph Chen			elif [ "${TOP_SEVERITY}" == "${SVT_MODERATE}" ]; then
128f3572ad9SJoseph Chen				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" -o "${EACH_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
129f3572ad9SJoseph Chen						TOP_SEVERITY="${EACH_SEVERITY}"
130f3572ad9SJoseph Chen				fi
131f3572ad9SJoseph Chen			elif [ "${TOP_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
132f3572ad9SJoseph Chen				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" ]; then
133f3572ad9SJoseph Chen						TOP_SEVERITY="${EACH_SEVERITY}"
134f3572ad9SJoseph Chen				fi
135f3572ad9SJoseph Chen			fi
136f3572ad9SJoseph Chen		done < ${DIFF_DOC_FIXED}
137f3572ad9SJoseph Chen
138f3572ad9SJoseph Chen		if [ "${SEVERITY}" != "${TOP_SEVERITY}" ]; then
139f3572ad9SJoseph Chen			echo "ERROR: ${DOC}: Main severity should be '${TOP_SEVERITY}'"
140f3572ad9SJoseph Chen			exit 1
141f3572ad9SJoseph Chen		fi
142f3572ad9SJoseph Chen	fi
143f3572ad9SJoseph Chen}
144f3572ad9SJoseph Chen
145f3572ad9SJoseph Chenfunction check_docs()
146f3572ad9SJoseph Chen{
147*acf80986SJoseph Chen	if git log ${ARG_COMMIT} -1 --name-only | grep -Eq '\.bin|\.elf' ; then
148*acf80986SJoseph Chen		DOC_CN=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_CN\.md/p"`
149*acf80986SJoseph Chen		DOC_EN=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_EN\.md/p"`
150f3572ad9SJoseph Chen		if [ -z "${DOC_CN}" -o -z "${DOC_EN}" ]; then
151*acf80986SJoseph Chen			echo "ERROR: Should update CN and EN Release-Note when .bin/elf changed"
152f3572ad9SJoseph Chen			exit 1
153f3572ad9SJoseph Chen		fi
154755bd534SJoseph Chen
155755bd534SJoseph Chen		if ! which dos2unix > /dev/null 2>&1 ; then
156755bd534SJoseph Chen			echo "ERROR: No 'dos2unix'. Fix by: sudo apt-get install dos2unix"
157755bd534SJoseph Chen			exit 1
158755bd534SJoseph Chen		fi
159755bd534SJoseph Chen
160f3572ad9SJoseph Chen		check_doc CN
161f3572ad9SJoseph Chen		check_doc EN
162f3572ad9SJoseph Chen	fi
1636f2bc86dSJoseph Chen
1646f2bc86dSJoseph Chen	rm -f ${DIFF_SUBSET}
165f3572ad9SJoseph Chen}
166f3572ad9SJoseph Chen
16715aaf94fSJoseph Chenfunction pack_loader_image()
16824a8c2d6SJoseph Chen{
16915aaf94fSJoseph Chen	for FILE in `ls ./RKBOOT/*MINIALL*.ini`
17024a8c2d6SJoseph Chen	do
17115aaf94fSJoseph Chen		if [ "${FILE}" = "./RKBOOT/RK302AMINIALL.ini" -o \
17215aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK30BMINIALL.ini" -o \
17315aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK30MINIALL.ini" -o \
17415aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK310BMINIALL.ini" ]; then
17524a8c2d6SJoseph Chen			continue;
17624a8c2d6SJoseph Chen		fi
17724a8c2d6SJoseph Chen
17815aaf94fSJoseph Chen		if grep -q '^PATH=img/' ${FILE}; then
17907c86261SJoseph Chen			continue;
18007c86261SJoseph Chen		fi
18107c86261SJoseph Chen
18215aaf94fSJoseph Chen		echo "Pack loader: ${FILE}"
18315aaf94fSJoseph Chen		./tools/boot_merger ${FILE}
184f3822d68SJoseph Chen		rm -f *loader*.bin *download*.bin *idblock*.img
18524a8c2d6SJoseph Chen		echo
18624a8c2d6SJoseph Chen	done
18724a8c2d6SJoseph Chen}
18824a8c2d6SJoseph Chen
18915aaf94fSJoseph Chenfunction pack_trust_image()
19024a8c2d6SJoseph Chen{
19124a8c2d6SJoseph Chen	# Pack 32-bit trust
19215aaf94fSJoseph Chen	for FILE in `ls ./RKTRUST/*TOS*.ini`
19324a8c2d6SJoseph Chen	do
19415aaf94fSJoseph Chen		if ! test -s ${FILE}; then
195075296bdSJoseph Chen			continue;
19615aaf94fSJoseph Chen		elif ! grep -q 'TOS' ${FILE}; then
197d4bf7444SJoseph Chen			continue;
19815aaf94fSJoseph Chen		elif grep -q '^PATH=img/' ${FILE}; then
19907c86261SJoseph Chen			continue;
20007c86261SJoseph Chen		fi
20107c86261SJoseph Chen
20215aaf94fSJoseph Chen		echo "Pack trust: ${FILE}"
20324a8c2d6SJoseph Chen		# Parse orignal path
20415aaf94fSJoseph Chen		TOS=`sed -n "/TOS=/s/TOS=//p" ${FILE}|tr -d '\r'`
20515aaf94fSJoseph Chen		TOS_TA=`sed -n "/TOSTA=/s/TOSTA=//p" ${FILE}|tr -d '\r'`
20624a8c2d6SJoseph Chen
20724a8c2d6SJoseph Chen		# replace "./tools/rk_tools/" with "./" to compatible legacy ini content of rkdevelop branch
20824a8c2d6SJoseph Chen		TOS=$(echo ${TOS} | sed "s/tools\/rk_tools\//\.\//g")
20924a8c2d6SJoseph Chen		TOS_TA=$(echo ${TOS_TA} | sed "s/tools\/rk_tools\//\.\//g")
21024a8c2d6SJoseph Chen
2119d00b70aSJoseph Chen		if [ x${TOS_TA} != x -a x${TOS} != x ]; then
21224a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
21324a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust_with_ta.img 0x68400000
2149d00b70aSJoseph Chen		elif [ ${TOS} ]; then
21524a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
2169d00b70aSJoseph Chen		elif [ ${TOS_TA} ]; then
21724a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust.img 0x68400000
21824a8c2d6SJoseph Chen		else
21924a8c2d6SJoseph Chen			exit 1
22024a8c2d6SJoseph Chen		fi
221f3822d68SJoseph Chen		rm -f trust*.img
22224a8c2d6SJoseph Chen		echo
22324a8c2d6SJoseph Chen	done
22424a8c2d6SJoseph Chen
22524a8c2d6SJoseph Chen	# Pack 64-bit trust
22615aaf94fSJoseph Chen	for FILE in `ls ./RKTRUST/*TRUST*.ini`
22724a8c2d6SJoseph Chen	do
22815aaf94fSJoseph Chen		if grep -q '^PATH=img/' ${FILE}; then
22907c86261SJoseph Chen			continue;
23007c86261SJoseph Chen		fi
23107c86261SJoseph Chen
23215aaf94fSJoseph Chen		echo "Pack trust: ${FILE}"
23315aaf94fSJoseph Chen		./tools/trust_merger ${FILE}
23415aaf94fSJoseph Chen		rm -f trust*.img
23524a8c2d6SJoseph Chen		echo
23624a8c2d6SJoseph Chen	done
23724a8c2d6SJoseph Chen}
23824a8c2d6SJoseph Chen
23915aaf94fSJoseph Chenfunction check_dirty()
2407448aaf2SJoseph Chen{
241f3572ad9SJoseph Chen	for FILE in `find -name '*spl*.bin' -o -name '*tpl*.bin' -o -name '*usbplug*.bin' -o -name '*bl31*.elf' -o -name '*bl32*.bin'`; do
242f3572ad9SJoseph Chen		echo "Checking clean: ${FILE}"
24315aaf94fSJoseph Chen		if strings ${FILE} | grep '\-dirty ' ; then
24415aaf94fSJoseph Chen			echo "ERROR: ${FILE} is dirty"
2457448aaf2SJoseph Chen			exit 1
2467448aaf2SJoseph Chen		fi
2477448aaf2SJoseph Chen	done
2487448aaf2SJoseph Chen}
2497448aaf2SJoseph Chen
25015aaf94fSJoseph Chenfunction check_stripped()
251c0efc7efSJoseph Chen{
25215aaf94fSJoseph Chen	for FILE in `find -name '*bl31*.elf'`; do
25315aaf94fSJoseph Chen		echo "Checking strip: ${FILE}"
25415aaf94fSJoseph Chen		INFO=`file ${FILE}`
25515aaf94fSJoseph Chen		if echo ${INFO} | grep -q "not stripped" ; then
25615aaf94fSJoseph Chen			echo "ERROR: ${FILE} is not stripped"
257c0efc7efSJoseph Chen			exit 1
258c0efc7efSJoseph Chen		fi
259c0efc7efSJoseph Chen	done
260c0efc7efSJoseph Chen}
261c0efc7efSJoseph Chen
262f3572ad9SJoseph Chenfunction check_mode()
263f3572ad9SJoseph Chen{
264f3572ad9SJoseph Chen	echo "Checking file mode..."
265*acf80986SJoseph Chen	if git whatchanged ${ARG_COMMIT} -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | awk '{ print $2 }' | grep -q 755 ; then
266*acf80986SJoseph Chen		git whatchanged ${ARG_COMMIT} -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | grep 755
2670f8ea74fSJoseph Chen		echo "ERROR: Set 644 file permission but not 755."
268f3572ad9SJoseph Chen		exit 1
269f3572ad9SJoseph Chen	fi
270f3572ad9SJoseph Chen}
271f3572ad9SJoseph Chen
27215aaf94fSJoseph Chenfunction finish()
27324a8c2d6SJoseph Chen{
274f3572ad9SJoseph Chen	echo "OK, everything is nice."
27524a8c2d6SJoseph Chen	echo
27624a8c2d6SJoseph Chen}
27724a8c2d6SJoseph Chen
278f3572ad9SJoseph Chencheck_mode
279f3572ad9SJoseph Chencheck_docs
2807448aaf2SJoseph Chencheck_dirty
281c0efc7efSJoseph Chencheck_stripped
28224a8c2d6SJoseph Chenpack_loader_image
28324a8c2d6SJoseph Chenpack_trust_image
28424a8c2d6SJoseph Chenfinish
285