xref: /rkbin/scripts/checkpatch.sh (revision 2d300a6d27f7744c45d2de054774433633b9c19b)
124a8c2d6SJoseph Chen#!/bin/bash
224a8c2d6SJoseph Chenset -e
324a8c2d6SJoseph Chen
4acf80986SJoseph ChenARG_COMMIT=$1
56f2bc86dSJoseph ChenDIFF_SUBSET="scripts/.diff_*"
6f3572ad9SJoseph ChenDIFF_DOC_ALL="scripts/.diff_all.txt"
7f3572ad9SJoseph ChenDIFF_DOC_FIXED="scripts/.diff_fixed.txt"
8f3572ad9SJoseph Chen
9f3572ad9SJoseph Chenfunction check_doc()
10f3572ad9SJoseph Chen{
11f3572ad9SJoseph Chen	local TOP_SEVERITY LANGUAGE=$1
12f3572ad9SJoseph Chen
13f3572ad9SJoseph Chen	if [ "${LANGUAGE}" == "EN" ] ; then
14f3572ad9SJoseph Chen		SVT_CRITIAL="critical"
15f3572ad9SJoseph Chen		SVT_IMPORTANT="important"
16f3572ad9SJoseph Chen		SVT_MODERATE="moderate"
17acf80986SJoseph Chen		DOC=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_EN\.md/p"`
18f3572ad9SJoseph Chen	else
19f3572ad9SJoseph Chen		SVT_CRITIAL="紧急"
20f3572ad9SJoseph Chen		SVT_IMPORTANT="重要"
21f3572ad9SJoseph Chen		SVT_MODERATE="普通"
22acf80986SJoseph Chen		DOC=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_CN\.md/p"`
23f3572ad9SJoseph Chen	fi
24f3572ad9SJoseph Chen
25f3572ad9SJoseph Chen	echo "Checking doc: ${DOC}"
26f3572ad9SJoseph Chen
276f2bc86dSJoseph Chen	# check DOS encoding
28acf80986SJoseph Chen	git show ${ARG_COMMIT} -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}
29acf80986SJoseph Chen	git show ${ARG_COMMIT} -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}.dos
306f2bc86dSJoseph Chen	dos2unix ${DIFF_DOC_ALL}.dos >/dev/null 2>&1
316f2bc86dSJoseph Chen	CSUM1=`md5sum ${DIFF_DOC_ALL} | awk '{ print $1 }'`
326f2bc86dSJoseph Chen	CSUM2=`md5sum ${DIFF_DOC_ALL}.dos | awk '{ print $1 }'`
336f2bc86dSJoseph Chen	if [ "${CSUM1}" != "${CSUM2}" ]; then
346f2bc86dSJoseph Chen		echo "ERROR: ${DOC} is DOS encoding. Fix it by: 'dos2unix ${DOC}'"
356f2bc86dSJoseph Chen		exit 1
366f2bc86dSJoseph Chen	fi
376f2bc86dSJoseph Chen
38f3572ad9SJoseph Chen	TITLE=`sed -n "/^+## /p" ${DIFF_DOC_ALL} | tr -d " +#"`
39f3572ad9SJoseph Chen	FILE=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $3 }'`
40f3572ad9SJoseph Chen	COMMIT=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $4 }'`
41f3572ad9SJoseph Chen	SEVERITY=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $5 }'`
42f3572ad9SJoseph Chen	HORIZONTAL_LINE=`sed -n "/^+------$/p" ${DIFF_DOC_ALL}`
43f3572ad9SJoseph Chen	# echo "### ${COMMIT}, ${SEVERITY}, ${TITLE}, ${FILE}"
44f3572ad9SJoseph Chen
45407510a0SJoseph Chen	# check blank line after Heading 1
46407510a0SJoseph Chen	HEADING_1=`sed -n '1p' ${DOC}`
47407510a0SJoseph Chen	if sed -n '2p' ${DOC} | grep -q [a-z,A-Z] ; then
48407510a0SJoseph Chen		echo "ERROR: ${DOC}: Should reserve blank line after '${HEADING_1}'"
49407510a0SJoseph Chen		exit 1
50407510a0SJoseph Chen	fi
51407510a0SJoseph Chen
528e4858bdSJoseph Chen	# check space
538e4858bdSJoseph Chen	if sed -n "/##/p" ${DOC} | grep -v '## [a-z,A-Z]' ; then
548e4858bdSJoseph Chen		echo "ERROR: ${DOC}: Should only 1 space between '#' and word"
558e4858bdSJoseph Chen		exit 1
568e4858bdSJoseph Chen	fi
578e4858bdSJoseph Chen
580287fa94SJoseph Chen	# check new content location
59acf80986SJoseph Chen	if ! git show ${ARG_COMMIT} -1 ${DOC} | grep -q 'Release Note' ; then
600287fa94SJoseph Chen		echo "ERROR: ${DOC}: Adding new content at the top but not bottom"
610287fa94SJoseph Chen		exit 1
620287fa94SJoseph Chen	fi
630287fa94SJoseph Chen
640287fa94SJoseph Chen	# check TAB before index of 'New' body
650287fa94SJoseph Chen	if grep -q $'\t[0-9]' ${DOC} ; then
660287fa94SJoseph Chen		echo "ERROR: ${DOC}: Don't add TAB before index:"
670287fa94SJoseph Chen		grep $'\t[0-9]' ${DOC}
680287fa94SJoseph Chen		exit 1
690287fa94SJoseph Chen	fi
700287fa94SJoseph Chen
71*2d300a6dSJoseph Chen	# check space after index of 'New' body
72*2d300a6dSJoseph Chen	SUM1=`grep '^[0-9]\.' ${DOC} | wc -l`
73*2d300a6dSJoseph Chen	SUM2=`grep '^[0-9]\.[[:blank:]]' ${DOC} | wc -l`
74*2d300a6dSJoseph Chen	if [ "$SUM1" != "$SUM2" ]; then
75*2d300a6dSJoseph Chen		echo "ERROR: ${DOC}: Please add space after index (e.g: '1. ' but not '1.'):"
76*2d300a6dSJoseph Chen		grep '^+[0-9]\.' ${DIFF_DOC_ALL}
77*2d300a6dSJoseph Chen		exit 1
78*2d300a6dSJoseph Chen	fi
79*2d300a6dSJoseph Chen
80f3572ad9SJoseph Chen	# check standalone file
81fd99385aSJoseph Chen	if ! echo ${FILE} | grep -Eq '\.bin|\.elf|\.img' ; then
82fd99385aSJoseph Chen		echo "ERROR: ${DOC}: '${FILE}' missing the file format suffix"
83fd99385aSJoseph Chen		exit 1
84fd99385aSJoseph Chen	fi
85f3572ad9SJoseph Chen	if ! echo ${FILE} | grep -q { ; then
86acf80986SJoseph Chen		if ! git log ${ARG_COMMIT} -1 --name-only | grep -q ${FILE}; then
870f8ea74fSJoseph Chen			echo "ERROR: ${DOC}: '${FILE}' is not updated in this patch"
88f3572ad9SJoseph Chen			exit 1
89f3572ad9SJoseph Chen		fi
90f3572ad9SJoseph Chen	fi
91f3572ad9SJoseph Chen
92f3572ad9SJoseph Chen	# check title
93f3572ad9SJoseph Chen	if [ "${TITLE}" != "${FILE}" ]; then
94f3572ad9SJoseph Chen		echo "ERROR: ${DOC}: Title '${TITLE}' is not match with '${FILE}'"
95f3572ad9SJoseph Chen		exit 1
96f3572ad9SJoseph Chen	fi
97f3572ad9SJoseph Chen
98f3572ad9SJoseph Chen	# check commit
99f3572ad9SJoseph Chen	COMMIT=${COMMIT//#/ }
100f3572ad9SJoseph Chen	for LIST in ${COMMIT}; do
101f3572ad9SJoseph Chen		CMT=`echo ${LIST} | cut -d : -f 2`
102acf80986SJoseph Chen		if ! git log ${ARG_COMMIT} -1 | grep -q ${CMT} ; then
103*2d300a6dSJoseph Chen			echo "ERROR: ${DOC}: '${CMT}' is not match in commit message"
104f3572ad9SJoseph Chen			exit 1
105f3572ad9SJoseph Chen		fi
10639bfe203SJoseph Chen
10739bfe203SJoseph Chen		if ! echo ${FILE} | grep -q { ; then
10839bfe203SJoseph Chen			if echo ${FILE} | grep -Eq 'spl_|tpl_|bl31_|bl32_|tee_' ; then
10939bfe203SJoseph Chen				FILE_PATH=`find -name ${FILE}`
110acf80986SJoseph Chen				if [ -z "${FILE_PATH}" ]; then
111acf80986SJoseph Chen					echo "ERROR: ${DOC}: No ${FILE}"
112acf80986SJoseph Chen					exit 1
113acf80986SJoseph Chen				fi
11439bfe203SJoseph Chen				if ! strings ${FILE_PATH} | grep -q ${CMT} ; then
11539bfe203SJoseph Chen					echo "ERROR: ${DOC}: ${FILE} is not build from '${CMT}'"
11639bfe203SJoseph Chen					exit 1
11739bfe203SJoseph Chen				fi
11839bfe203SJoseph Chen			fi
11939bfe203SJoseph Chen		fi
120f3572ad9SJoseph Chen	done
121f3572ad9SJoseph Chen
122f3572ad9SJoseph Chen	# check severity
123f3572ad9SJoseph Chen	if [ "${SEVERITY}" != "${SVT_CRITIAL}" -a "${SEVERITY}" != "${SVT_IMPORTANT}" -a "${SEVERITY}" != "${SVT_MODERATE}" ]; then
124f3572ad9SJoseph Chen		echo "ERROR: ${DOC}: Unknown main severity: ${SEVERITY}"
125f3572ad9SJoseph Chen		exit 1
126f3572ad9SJoseph Chen	fi
127f3572ad9SJoseph Chen
128f3572ad9SJoseph Chen	# check horizontal line
129f3572ad9SJoseph Chen	if [ -z "${HORIZONTAL_LINE}" ]; then
1300f8ea74fSJoseph Chen		echo "ERROR: ${DOC}: No horizontal line '------' at the last of new content"
131f3572ad9SJoseph Chen		exit 1
132f3572ad9SJoseph Chen	fi
133f3572ad9SJoseph Chen
134f3572ad9SJoseph Chen	# check 'Fixed' content
135f3572ad9SJoseph Chen	if grep -q "^+### Fixed" ${DIFF_DOC_ALL} ; then
136f3572ad9SJoseph Chen		awk -v RS='### Fixed' 'END{printf "%s", $0}' ${DIFF_DOC_ALL} > ${DIFF_DOC_FIXED}
137f3572ad9SJoseph Chen		sed -i "/^$/d"    ${DIFF_DOC_FIXED}
138f3572ad9SJoseph Chen		sed -i "/Index/d" ${DIFF_DOC_FIXED}
139f3572ad9SJoseph Chen		sed -i "/---/d"   ${DIFF_DOC_FIXED}
140f3572ad9SJoseph Chen		sed -i "/^+$/d"   ${DIFF_DOC_FIXED}
141f3572ad9SJoseph Chen
142f3572ad9SJoseph Chen		while read LINE
143f3572ad9SJoseph Chen		do
144f3572ad9SJoseph Chen			EACH_SEVERITY=`echo "${LINE}" | awk -F "|" '{ print $3 }' | tr -d " "`
145f3572ad9SJoseph Chen			if [ "${EACH_SEVERITY}" != "${SVT_CRITIAL}" -a "${EACH_SEVERITY}" != "${SVT_IMPORTANT}" -a "${EACH_SEVERITY}" != "${SVT_MODERATE}" ]; then
146f3572ad9SJoseph Chen				echo "ERROR: ${DOC}: Unknown severity: ${EACH_SEVERITY}"
147f3572ad9SJoseph Chen				exit 1
148f3572ad9SJoseph Chen			fi
149f3572ad9SJoseph Chen
150f3572ad9SJoseph Chen			# echo "## EACH: $EACH_SEVERITY"
151f3572ad9SJoseph Chen			if [ -z "${TOP_SEVERITY}" ]; then
152f3572ad9SJoseph Chen				TOP_SEVERITY="${EACH_SEVERITY}"
153f3572ad9SJoseph Chen			elif [ "${TOP_SEVERITY}" == "${SVT_MODERATE}" ]; then
154f3572ad9SJoseph Chen				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" -o "${EACH_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
155f3572ad9SJoseph Chen					TOP_SEVERITY="${EACH_SEVERITY}"
156f3572ad9SJoseph Chen				fi
157f3572ad9SJoseph Chen			elif [ "${TOP_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
158f3572ad9SJoseph Chen				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" ]; then
159f3572ad9SJoseph Chen					TOP_SEVERITY="${EACH_SEVERITY}"
160f3572ad9SJoseph Chen				fi
161f3572ad9SJoseph Chen			fi
162f3572ad9SJoseph Chen		done < ${DIFF_DOC_FIXED}
163f3572ad9SJoseph Chen
164f3572ad9SJoseph Chen		if [ "${SEVERITY}" != "${TOP_SEVERITY}" ]; then
165f3572ad9SJoseph Chen			echo "ERROR: ${DOC}: Main severity should be '${TOP_SEVERITY}'"
166f3572ad9SJoseph Chen			exit 1
167f3572ad9SJoseph Chen		fi
168f3572ad9SJoseph Chen	fi
169f3572ad9SJoseph Chen}
170f3572ad9SJoseph Chen
171f3572ad9SJoseph Chenfunction check_docs()
172f3572ad9SJoseph Chen{
173acf80986SJoseph Chen	if git log ${ARG_COMMIT} -1 --name-only | grep -Eq '\.bin|\.elf' ; then
174acf80986SJoseph Chen		DOC_CN=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_CN\.md/p"`
175acf80986SJoseph Chen		DOC_EN=`git log ${ARG_COMMIT} -1 --name-only | sed -n "/_EN\.md/p"`
176f3572ad9SJoseph Chen		if [ -z "${DOC_CN}" -o -z "${DOC_EN}" ]; then
177acf80986SJoseph Chen			echo "ERROR: Should update CN and EN Release-Note when .bin/elf changed"
178f3572ad9SJoseph Chen			exit 1
179f3572ad9SJoseph Chen		fi
180755bd534SJoseph Chen
181755bd534SJoseph Chen		if ! which dos2unix > /dev/null 2>&1 ; then
182755bd534SJoseph Chen			echo "ERROR: No 'dos2unix'. Fix by: sudo apt-get install dos2unix"
183755bd534SJoseph Chen			exit 1
184755bd534SJoseph Chen		fi
185755bd534SJoseph Chen
186f3572ad9SJoseph Chen		check_doc CN
187f3572ad9SJoseph Chen		check_doc EN
188f3572ad9SJoseph Chen	fi
1896f2bc86dSJoseph Chen
1906f2bc86dSJoseph Chen	rm -f ${DIFF_SUBSET}
191f3572ad9SJoseph Chen}
192f3572ad9SJoseph Chen
19315aaf94fSJoseph Chenfunction pack_loader_image()
19424a8c2d6SJoseph Chen{
19515aaf94fSJoseph Chen	for FILE in `ls ./RKBOOT/*MINIALL*.ini`
19624a8c2d6SJoseph Chen	do
19715aaf94fSJoseph Chen		if [ "${FILE}" = "./RKBOOT/RK302AMINIALL.ini" -o \
19815aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK30BMINIALL.ini" -o \
19915aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK30MINIALL.ini" -o \
20015aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK310BMINIALL.ini" ]; then
20124a8c2d6SJoseph Chen			continue;
20224a8c2d6SJoseph Chen		fi
20324a8c2d6SJoseph Chen
20415aaf94fSJoseph Chen		if grep -q '^PATH=img/' ${FILE}; then
20507c86261SJoseph Chen			continue;
20607c86261SJoseph Chen		fi
20707c86261SJoseph Chen
20815aaf94fSJoseph Chen		echo "Pack loader: ${FILE}"
20915aaf94fSJoseph Chen		./tools/boot_merger ${FILE}
210f3822d68SJoseph Chen		rm -f *loader*.bin *download*.bin *idblock*.img
21124a8c2d6SJoseph Chen		echo
21224a8c2d6SJoseph Chen	done
21324a8c2d6SJoseph Chen}
21424a8c2d6SJoseph Chen
21515aaf94fSJoseph Chenfunction pack_trust_image()
21624a8c2d6SJoseph Chen{
21724a8c2d6SJoseph Chen	# Pack 32-bit trust
21815aaf94fSJoseph Chen	for FILE in `ls ./RKTRUST/*TOS*.ini`
21924a8c2d6SJoseph Chen	do
22015aaf94fSJoseph Chen		if ! test -s ${FILE}; then
221075296bdSJoseph Chen			continue;
22215aaf94fSJoseph Chen		elif ! grep -q 'TOS' ${FILE}; then
223d4bf7444SJoseph Chen			continue;
22415aaf94fSJoseph Chen		elif grep -q '^PATH=img/' ${FILE}; then
22507c86261SJoseph Chen			continue;
22607c86261SJoseph Chen		fi
22707c86261SJoseph Chen
22815aaf94fSJoseph Chen		echo "Pack trust: ${FILE}"
22924a8c2d6SJoseph Chen		# Parse orignal path
23015aaf94fSJoseph Chen		TOS=`sed -n "/TOS=/s/TOS=//p" ${FILE}|tr -d '\r'`
23115aaf94fSJoseph Chen		TOS_TA=`sed -n "/TOSTA=/s/TOSTA=//p" ${FILE}|tr -d '\r'`
23224a8c2d6SJoseph Chen
23324a8c2d6SJoseph Chen		# replace "./tools/rk_tools/" with "./" to compatible legacy ini content of rkdevelop branch
23424a8c2d6SJoseph Chen		TOS=$(echo ${TOS} | sed "s/tools\/rk_tools\//\.\//g")
23524a8c2d6SJoseph Chen		TOS_TA=$(echo ${TOS_TA} | sed "s/tools\/rk_tools\//\.\//g")
23624a8c2d6SJoseph Chen
2379d00b70aSJoseph Chen		if [ x${TOS_TA} != x -a x${TOS} != x ]; then
23824a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
23924a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust_with_ta.img 0x68400000
2409d00b70aSJoseph Chen		elif [ ${TOS} ]; then
24124a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
2429d00b70aSJoseph Chen		elif [ ${TOS_TA} ]; then
24324a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust.img 0x68400000
24424a8c2d6SJoseph Chen		else
24524a8c2d6SJoseph Chen			exit 1
24624a8c2d6SJoseph Chen		fi
247f3822d68SJoseph Chen		rm -f trust*.img
24824a8c2d6SJoseph Chen		echo
24924a8c2d6SJoseph Chen	done
25024a8c2d6SJoseph Chen
25124a8c2d6SJoseph Chen	# Pack 64-bit trust
25215aaf94fSJoseph Chen	for FILE in `ls ./RKTRUST/*TRUST*.ini`
25324a8c2d6SJoseph Chen	do
25415aaf94fSJoseph Chen		if grep -q '^PATH=img/' ${FILE}; then
25507c86261SJoseph Chen			continue;
25607c86261SJoseph Chen		fi
25707c86261SJoseph Chen
25815aaf94fSJoseph Chen		echo "Pack trust: ${FILE}"
25915aaf94fSJoseph Chen		./tools/trust_merger ${FILE}
26015aaf94fSJoseph Chen		rm -f trust*.img
26124a8c2d6SJoseph Chen		echo
26224a8c2d6SJoseph Chen	done
26324a8c2d6SJoseph Chen}
26424a8c2d6SJoseph Chen
26515aaf94fSJoseph Chenfunction check_dirty()
2667448aaf2SJoseph Chen{
267f3572ad9SJoseph Chen	for FILE in `find -name '*spl*.bin' -o -name '*tpl*.bin' -o -name '*usbplug*.bin' -o -name '*bl31*.elf' -o -name '*bl32*.bin'`; do
268f3572ad9SJoseph Chen		echo "Checking clean: ${FILE}"
26915aaf94fSJoseph Chen		if strings ${FILE} | grep '\-dirty ' ; then
27015aaf94fSJoseph Chen			echo "ERROR: ${FILE} is dirty"
2717448aaf2SJoseph Chen			exit 1
2727448aaf2SJoseph Chen		fi
2737448aaf2SJoseph Chen	done
2747448aaf2SJoseph Chen}
2757448aaf2SJoseph Chen
27615aaf94fSJoseph Chenfunction check_stripped()
277c0efc7efSJoseph Chen{
27815aaf94fSJoseph Chen	for FILE in `find -name '*bl31*.elf'`; do
27915aaf94fSJoseph Chen		echo "Checking strip: ${FILE}"
28015aaf94fSJoseph Chen		INFO=`file ${FILE}`
28115aaf94fSJoseph Chen		if echo ${INFO} | grep -q "not stripped" ; then
28215aaf94fSJoseph Chen			echo "ERROR: ${FILE} is not stripped"
283c0efc7efSJoseph Chen			exit 1
284c0efc7efSJoseph Chen		fi
285c0efc7efSJoseph Chen	done
286c0efc7efSJoseph Chen}
287c0efc7efSJoseph Chen
288f3572ad9SJoseph Chenfunction check_mode()
289f3572ad9SJoseph Chen{
290f3572ad9SJoseph Chen	echo "Checking file mode..."
291acf80986SJoseph Chen	if git whatchanged ${ARG_COMMIT} -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | awk '{ print $2 }' | grep -q 755 ; then
292acf80986SJoseph Chen		git whatchanged ${ARG_COMMIT} -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | grep 755
2930f8ea74fSJoseph Chen		echo "ERROR: Set 644 file permission but not 755."
294f3572ad9SJoseph Chen		exit 1
295f3572ad9SJoseph Chen	fi
296f3572ad9SJoseph Chen}
297f3572ad9SJoseph Chen
29815aaf94fSJoseph Chenfunction finish()
29924a8c2d6SJoseph Chen{
300f3572ad9SJoseph Chen	echo "OK, everything is nice."
30124a8c2d6SJoseph Chen	echo
30224a8c2d6SJoseph Chen}
30324a8c2d6SJoseph Chen
304f3572ad9SJoseph Chencheck_mode
305f3572ad9SJoseph Chencheck_docs
3067448aaf2SJoseph Chencheck_dirty
307c0efc7efSJoseph Chencheck_stripped
30824a8c2d6SJoseph Chenpack_loader_image
30924a8c2d6SJoseph Chenpack_trust_image
31024a8c2d6SJoseph Chenfinish
311