xref: /rkbin/scripts/checkpatch.sh (revision 0287fa94cd1a303517dc5a7265f357fe39921dad)
124a8c2d6SJoseph Chen#!/bin/bash
224a8c2d6SJoseph Chenset -e
324a8c2d6SJoseph Chen
46f2bc86dSJoseph ChenDIFF_SUBSET="scripts/.diff_*"
5f3572ad9SJoseph ChenDIFF_DOC_ALL="scripts/.diff_all.txt"
6f3572ad9SJoseph ChenDIFF_DOC_FIXED="scripts/.diff_fixed.txt"
7f3572ad9SJoseph Chen
8f3572ad9SJoseph Chenfunction check_doc()
9f3572ad9SJoseph Chen{
10f3572ad9SJoseph Chen	local TOP_SEVERITY LANGUAGE=$1
11f3572ad9SJoseph Chen
12f3572ad9SJoseph Chen	if [ "${LANGUAGE}" == "EN" ] ; then
13f3572ad9SJoseph Chen		SVT_CRITIAL="critical"
14f3572ad9SJoseph Chen		SVT_IMPORTANT="important"
15f3572ad9SJoseph Chen		SVT_MODERATE="moderate"
16f3572ad9SJoseph Chen		DOC=`git log -1 --name-only | sed -n "/_EN\.md/p"`
17f3572ad9SJoseph Chen	else
18f3572ad9SJoseph Chen		SVT_CRITIAL="紧急"
19f3572ad9SJoseph Chen		SVT_IMPORTANT="重要"
20f3572ad9SJoseph Chen		SVT_MODERATE="普通"
21f3572ad9SJoseph Chen		DOC=`git log -1 --name-only | sed -n "/_CN\.md/p"`
22f3572ad9SJoseph Chen	fi
23f3572ad9SJoseph Chen
24f3572ad9SJoseph Chen	echo "Checking doc: ${DOC}"
25f3572ad9SJoseph Chen
266f2bc86dSJoseph Chen	# check DOS encoding
27f3572ad9SJoseph Chen	git show -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}
286f2bc86dSJoseph Chen	git show -1 ${DOC} | sed -n "/^+/p" > ${DIFF_DOC_ALL}.dos
296f2bc86dSJoseph Chen	dos2unix ${DIFF_DOC_ALL}.dos >/dev/null 2>&1
306f2bc86dSJoseph Chen	CSUM1=`md5sum ${DIFF_DOC_ALL} | awk '{ print $1 }'`
316f2bc86dSJoseph Chen	CSUM2=`md5sum ${DIFF_DOC_ALL}.dos | awk '{ print $1 }'`
326f2bc86dSJoseph Chen	if [ "${CSUM1}" != "${CSUM2}" ]; then
336f2bc86dSJoseph Chen		echo "ERROR: ${DOC} is DOS encoding. Fix it by: 'dos2unix ${DOC}'"
346f2bc86dSJoseph Chen		exit 1
356f2bc86dSJoseph Chen	fi
366f2bc86dSJoseph Chen
37f3572ad9SJoseph Chen	TITLE=`sed -n "/^+## /p" ${DIFF_DOC_ALL} | tr -d " +#"`
38f3572ad9SJoseph Chen	FILE=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $3 }'`
39f3572ad9SJoseph Chen	COMMIT=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $4 }'`
40f3572ad9SJoseph Chen	SEVERITY=`sed -n "/^+| 20[0-9][0-9]-/p" ${DIFF_DOC_ALL} | tr -d " " | awk -F "|" '{ print $5 }'`
41f3572ad9SJoseph Chen	HORIZONTAL_LINE=`sed -n "/^+------$/p" ${DIFF_DOC_ALL}`
42f3572ad9SJoseph Chen	# echo "### ${COMMIT}, ${SEVERITY}, ${TITLE}, ${FILE}"
43f3572ad9SJoseph Chen
44*0287fa94SJoseph Chen	# check new content location
45*0287fa94SJoseph Chen	if ! git show -1 ${DOC} | grep -q 'Release Note' ; then
46*0287fa94SJoseph Chen		echo "ERROR: ${DOC}: Adding new content at the top but not bottom"
47*0287fa94SJoseph Chen		exit 1
48*0287fa94SJoseph Chen	fi
49*0287fa94SJoseph Chen
50*0287fa94SJoseph Chen	# check TAB before index of 'New' body
51*0287fa94SJoseph Chen	if grep -q $'\t[0-9]' ${DOC} ; then
52*0287fa94SJoseph Chen		echo "ERROR: ${DOC}: Don't add TAB before index:"
53*0287fa94SJoseph Chen		grep $'\t[0-9]' ${DOC}
54*0287fa94SJoseph Chen		exit 1
55*0287fa94SJoseph Chen	fi
56*0287fa94SJoseph Chen
57f3572ad9SJoseph Chen	# check standalone file
58f3572ad9SJoseph Chen	if ! echo ${FILE} | grep -q { ; then
59f3572ad9SJoseph Chen		if ! git log -1 --name-only | grep -q ${FILE}; then
60f3572ad9SJoseph Chen			echo "ERROR: ${DOC}: '${FILE}' is not update in this patch"
61f3572ad9SJoseph Chen			exit 1
62f3572ad9SJoseph Chen		fi
63f3572ad9SJoseph Chen	fi
64f3572ad9SJoseph Chen
65f3572ad9SJoseph Chen	# check title
66f3572ad9SJoseph Chen	if [ "${TITLE}" != "${FILE}" ]; then
67f3572ad9SJoseph Chen		echo "ERROR: ${DOC}: Title '${TITLE}' is not match with '${FILE}'"
68f3572ad9SJoseph Chen		exit 1
69f3572ad9SJoseph Chen	fi
70f3572ad9SJoseph Chen
71f3572ad9SJoseph Chen	# check commit
72f3572ad9SJoseph Chen	COMMIT=${COMMIT//#/ }
73f3572ad9SJoseph Chen	for LIST in ${COMMIT}; do
74f3572ad9SJoseph Chen		CMT=`echo ${LIST} | cut -d : -f 2`
75f3572ad9SJoseph Chen		if ! git log -1 | grep -q ${CMT} ; then
76f3572ad9SJoseph Chen			echo "ERROR: ${DOC}: '${CMT}' is not match in commit message"
77f3572ad9SJoseph Chen			exit 1
78f3572ad9SJoseph Chen		fi
7939bfe203SJoseph Chen
8039bfe203SJoseph Chen		if ! echo ${FILE} | grep -q { ; then
8139bfe203SJoseph Chen			if echo ${FILE} | grep -Eq 'spl_|tpl_|bl31_|bl32_|tee_' ; then
8239bfe203SJoseph Chen				FILE_PATH=`find -name ${FILE}`
8339bfe203SJoseph Chen				if ! strings ${FILE_PATH} | grep -q ${CMT} ; then
8439bfe203SJoseph Chen					echo "ERROR: ${DOC}: ${FILE} is not build from '${CMT}'"
8539bfe203SJoseph Chen					exit 1
8639bfe203SJoseph Chen				fi
8739bfe203SJoseph Chen			fi
8839bfe203SJoseph Chen		fi
89f3572ad9SJoseph Chen	done
90f3572ad9SJoseph Chen
91f3572ad9SJoseph Chen	# check severity
92f3572ad9SJoseph Chen	if [ "${SEVERITY}" != "${SVT_CRITIAL}" -a "${SEVERITY}" != "${SVT_IMPORTANT}" -a "${SEVERITY}" != "${SVT_MODERATE}" ]; then
93f3572ad9SJoseph Chen		echo "ERROR: ${DOC}: Unknown main severity: ${SEVERITY}"
94f3572ad9SJoseph Chen		exit 1
95f3572ad9SJoseph Chen	fi
96f3572ad9SJoseph Chen
97f3572ad9SJoseph Chen	# check horizontal line
98f3572ad9SJoseph Chen	if [ -z "${HORIZONTAL_LINE}" ]; then
99f3572ad9SJoseph Chen		echo "ERROR: ${DOC}: No horizontal line '------' at the last"
100f3572ad9SJoseph Chen		exit 1
101f3572ad9SJoseph Chen	fi
102f3572ad9SJoseph Chen
103f3572ad9SJoseph Chen	# check 'Fixed' content
104f3572ad9SJoseph Chen	if grep -q "^+### Fixed" ${DIFF_DOC_ALL} ; then
105f3572ad9SJoseph Chen		awk -v RS='### Fixed' 'END{printf "%s", $0}' ${DIFF_DOC_ALL} > ${DIFF_DOC_FIXED}
106f3572ad9SJoseph Chen		sed -i "/^$/d"    ${DIFF_DOC_FIXED}
107f3572ad9SJoseph Chen		sed -i "/Index/d" ${DIFF_DOC_FIXED}
108f3572ad9SJoseph Chen		sed -i "/---/d"   ${DIFF_DOC_FIXED}
109f3572ad9SJoseph Chen		sed -i "/^+$/d"   ${DIFF_DOC_FIXED}
110f3572ad9SJoseph Chen
111f3572ad9SJoseph Chen		while read LINE
112f3572ad9SJoseph Chen		do
113f3572ad9SJoseph Chen			EACH_SEVERITY=`echo "${LINE}" | awk -F "|" '{ print $3 }' | tr -d " "`
114f3572ad9SJoseph Chen			if [ "${EACH_SEVERITY}" != "${SVT_CRITIAL}" -a "${EACH_SEVERITY}" != "${SVT_IMPORTANT}" -a "${EACH_SEVERITY}" != "${SVT_MODERATE}" ]; then
115f3572ad9SJoseph Chen				echo "ERROR: ${DOC}: Unknown severity: ${EACH_SEVERITY}"
116f3572ad9SJoseph Chen				exit 1
117f3572ad9SJoseph Chen			fi
118f3572ad9SJoseph Chen
119f3572ad9SJoseph Chen			# echo "## EACH: $EACH_SEVERITY"
120f3572ad9SJoseph Chen			if [ -z "${TOP_SEVERITY}" ]; then
121f3572ad9SJoseph Chen				TOP_SEVERITY="${EACH_SEVERITY}"
122f3572ad9SJoseph Chen			elif [ "${TOP_SEVERITY}" == "${SVT_MODERATE}" ]; then
123f3572ad9SJoseph Chen				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" -o "${EACH_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
124f3572ad9SJoseph Chen						TOP_SEVERITY="${EACH_SEVERITY}"
125f3572ad9SJoseph Chen				fi
126f3572ad9SJoseph Chen			elif [ "${TOP_SEVERITY}" == "${SVT_IMPORTANT}" ]; then
127f3572ad9SJoseph Chen				if [ "${EACH_SEVERITY}" == "${SVT_CRITIAL}" ]; then
128f3572ad9SJoseph Chen						TOP_SEVERITY="${EACH_SEVERITY}"
129f3572ad9SJoseph Chen				fi
130f3572ad9SJoseph Chen			fi
131f3572ad9SJoseph Chen		done < ${DIFF_DOC_FIXED}
132f3572ad9SJoseph Chen
133f3572ad9SJoseph Chen		if [ "${SEVERITY}" != "${TOP_SEVERITY}" ]; then
134f3572ad9SJoseph Chen			echo "ERROR: ${DOC}: Main severity should be '${TOP_SEVERITY}'"
135f3572ad9SJoseph Chen			exit 1
136f3572ad9SJoseph Chen		fi
137f3572ad9SJoseph Chen	fi
138f3572ad9SJoseph Chen}
139f3572ad9SJoseph Chen
140f3572ad9SJoseph Chenfunction check_docs()
141f3572ad9SJoseph Chen{
14239bfe203SJoseph Chen	if git log -1 --name-only | grep -Eq '\.bin|\.elf' ; then
143f3572ad9SJoseph Chen		DOC_CN=`git log -1 --name-only | sed -n "/_CN\.md/p"`
144f3572ad9SJoseph Chen		DOC_EN=`git log -1 --name-only | sed -n "/_EN\.md/p"`
145f3572ad9SJoseph Chen		if [ -z "${DOC_CN}" -o -z "${DOC_EN}" ]; then
146f3572ad9SJoseph Chen			echo "ERROR: Update CN/EN Release-Note when .bin or .elf changes"
147f3572ad9SJoseph Chen			exit 1
148f3572ad9SJoseph Chen		fi
149f3572ad9SJoseph Chen		check_doc CN
150f3572ad9SJoseph Chen		check_doc EN
151f3572ad9SJoseph Chen	fi
1526f2bc86dSJoseph Chen
1536f2bc86dSJoseph Chen	rm -f ${DIFF_SUBSET}
154f3572ad9SJoseph Chen}
155f3572ad9SJoseph Chen
15615aaf94fSJoseph Chenfunction pack_loader_image()
15724a8c2d6SJoseph Chen{
15815aaf94fSJoseph Chen	for FILE in `ls ./RKBOOT/*MINIALL*.ini`
15924a8c2d6SJoseph Chen	do
16015aaf94fSJoseph Chen		if [ "${FILE}" = "./RKBOOT/RK302AMINIALL.ini" -o \
16115aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK30BMINIALL.ini" -o \
16215aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK30MINIALL.ini" -o \
16315aaf94fSJoseph Chen			 "${FILE}" = "./RKBOOT/RK310BMINIALL.ini" ]; then
16424a8c2d6SJoseph Chen			continue;
16524a8c2d6SJoseph Chen		fi
16624a8c2d6SJoseph Chen
16715aaf94fSJoseph Chen		if grep -q '^PATH=img/' ${FILE}; then
16807c86261SJoseph Chen			continue;
16907c86261SJoseph Chen		fi
17007c86261SJoseph Chen
17115aaf94fSJoseph Chen		echo "Pack loader: ${FILE}"
17215aaf94fSJoseph Chen		./tools/boot_merger ${FILE}
173f3822d68SJoseph Chen		rm -f *loader*.bin *download*.bin *idblock*.img
17424a8c2d6SJoseph Chen		echo
17524a8c2d6SJoseph Chen	done
17624a8c2d6SJoseph Chen}
17724a8c2d6SJoseph Chen
17815aaf94fSJoseph Chenfunction pack_trust_image()
17924a8c2d6SJoseph Chen{
18024a8c2d6SJoseph Chen	# Pack 32-bit trust
18115aaf94fSJoseph Chen	for FILE in `ls ./RKTRUST/*TOS*.ini`
18224a8c2d6SJoseph Chen	do
18315aaf94fSJoseph Chen		if ! test -s ${FILE}; then
184075296bdSJoseph Chen			continue;
18515aaf94fSJoseph Chen		elif ! grep -q 'TOS' ${FILE}; then
186d4bf7444SJoseph Chen			continue;
18715aaf94fSJoseph Chen		elif grep -q '^PATH=img/' ${FILE}; then
18807c86261SJoseph Chen			continue;
18907c86261SJoseph Chen		fi
19007c86261SJoseph Chen
19115aaf94fSJoseph Chen		echo "Pack trust: ${FILE}"
19224a8c2d6SJoseph Chen		# Parse orignal path
19315aaf94fSJoseph Chen		TOS=`sed -n "/TOS=/s/TOS=//p" ${FILE}|tr -d '\r'`
19415aaf94fSJoseph Chen		TOS_TA=`sed -n "/TOSTA=/s/TOSTA=//p" ${FILE}|tr -d '\r'`
19524a8c2d6SJoseph Chen
19624a8c2d6SJoseph Chen		# replace "./tools/rk_tools/" with "./" to compatible legacy ini content of rkdevelop branch
19724a8c2d6SJoseph Chen		TOS=$(echo ${TOS} | sed "s/tools\/rk_tools\//\.\//g")
19824a8c2d6SJoseph Chen		TOS_TA=$(echo ${TOS_TA} | sed "s/tools\/rk_tools\//\.\//g")
19924a8c2d6SJoseph Chen
2009d00b70aSJoseph Chen		if [ x${TOS_TA} != x -a x${TOS} != x ]; then
20124a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
20224a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust_with_ta.img 0x68400000
2039d00b70aSJoseph Chen		elif [ ${TOS} ]; then
20424a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS} ./trust.img 0x68400000
2059d00b70aSJoseph Chen		elif [ ${TOS_TA} ]; then
20624a8c2d6SJoseph Chen			./tools/loaderimage --pack --trustos ${TOS_TA} ./trust.img 0x68400000
20724a8c2d6SJoseph Chen		else
20824a8c2d6SJoseph Chen			exit 1
20924a8c2d6SJoseph Chen		fi
210f3822d68SJoseph Chen		rm -f trust*.img
21124a8c2d6SJoseph Chen		echo
21224a8c2d6SJoseph Chen	done
21324a8c2d6SJoseph Chen
21424a8c2d6SJoseph Chen	# Pack 64-bit trust
21515aaf94fSJoseph Chen	for FILE in `ls ./RKTRUST/*TRUST*.ini`
21624a8c2d6SJoseph Chen	do
21715aaf94fSJoseph Chen		if grep -q '^PATH=img/' ${FILE}; then
21807c86261SJoseph Chen			continue;
21907c86261SJoseph Chen		fi
22007c86261SJoseph Chen
22115aaf94fSJoseph Chen		echo "Pack trust: ${FILE}"
22215aaf94fSJoseph Chen		./tools/trust_merger ${FILE}
22315aaf94fSJoseph Chen		rm -f trust*.img
22424a8c2d6SJoseph Chen		echo
22524a8c2d6SJoseph Chen	done
22624a8c2d6SJoseph Chen}
22724a8c2d6SJoseph Chen
22815aaf94fSJoseph Chenfunction check_dirty()
2297448aaf2SJoseph Chen{
230f3572ad9SJoseph Chen	for FILE in `find -name '*spl*.bin' -o -name '*tpl*.bin' -o -name '*usbplug*.bin' -o -name '*bl31*.elf' -o -name '*bl32*.bin'`; do
231f3572ad9SJoseph Chen		echo "Checking clean: ${FILE}"
23215aaf94fSJoseph Chen		if strings ${FILE} | grep '\-dirty ' ; then
23315aaf94fSJoseph Chen			echo "ERROR: ${FILE} is dirty"
2347448aaf2SJoseph Chen			exit 1
2357448aaf2SJoseph Chen		fi
2367448aaf2SJoseph Chen	done
2377448aaf2SJoseph Chen}
2387448aaf2SJoseph Chen
23915aaf94fSJoseph Chenfunction check_stripped()
240c0efc7efSJoseph Chen{
24115aaf94fSJoseph Chen	for FILE in `find -name '*bl31*.elf'`; do
24215aaf94fSJoseph Chen		echo "Checking strip: ${FILE}"
24315aaf94fSJoseph Chen		INFO=`file ${FILE}`
24415aaf94fSJoseph Chen		if echo ${INFO} | grep -q "not stripped" ; then
24515aaf94fSJoseph Chen			echo "ERROR: ${FILE} is not stripped"
246c0efc7efSJoseph Chen			exit 1
247c0efc7efSJoseph Chen		fi
248c0efc7efSJoseph Chen	done
249c0efc7efSJoseph Chen}
250c0efc7efSJoseph Chen
251f3572ad9SJoseph Chenfunction check_mode()
252f3572ad9SJoseph Chen{
253f3572ad9SJoseph Chen	echo "Checking file mode..."
254f3572ad9SJoseph Chen	if git whatchanged -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | awk '{ print $2 }' | grep -q 755 ; then
255f3572ad9SJoseph Chen		git whatchanged -1 --oneline | sed -n '/RKBOOT\//p; /RKTRUST\//p; /bin\//p; /doc\//p;' | grep 755
256f3572ad9SJoseph Chen		echo "ERROR: Set 644 permission but not 755."
257f3572ad9SJoseph Chen		exit 1
258f3572ad9SJoseph Chen	fi
259f3572ad9SJoseph Chen}
260f3572ad9SJoseph Chen
26115aaf94fSJoseph Chenfunction finish()
26224a8c2d6SJoseph Chen{
263f3572ad9SJoseph Chen	echo "OK, everything is nice."
26424a8c2d6SJoseph Chen	echo
26524a8c2d6SJoseph Chen}
26624a8c2d6SJoseph Chen
267f3572ad9SJoseph Chencheck_mode
268f3572ad9SJoseph Chencheck_docs
2697448aaf2SJoseph Chencheck_dirty
270c0efc7efSJoseph Chencheck_stripped
27124a8c2d6SJoseph Chenpack_loader_image
27224a8c2d6SJoseph Chenpack_trust_image
27324a8c2d6SJoseph Chenfinish
274