17581c01aSSimon Glass#!/usr/bin/python 27581c01aSSimon Glass# 37581c01aSSimon Glass# Copyright (C) 2017 Google, Inc 47581c01aSSimon Glass# Written by Simon Glass <sjg@chromium.org> 57581c01aSSimon Glass# 67581c01aSSimon Glass# SPDX-License-Identifier: GPL-2.0+ 77581c01aSSimon Glass# 87581c01aSSimon Glass 92be282caSSimon Glass"""Device tree to platform data class 102be282caSSimon Glass 112be282caSSimon GlassThis supports converting device tree data to C structures definitions and 122be282caSSimon Glassstatic data. 132be282caSSimon Glass""" 142be282caSSimon Glass 157581c01aSSimon Glassimport copy 162be282caSSimon Glassimport sys 177581c01aSSimon Glass 187581c01aSSimon Glassimport fdt 197581c01aSSimon Glassimport fdt_util 207581c01aSSimon Glass 217581c01aSSimon Glass# When we see these properties we ignore them - i.e. do not create a structure member 227581c01aSSimon GlassPROP_IGNORE_LIST = [ 237581c01aSSimon Glass '#address-cells', 247581c01aSSimon Glass '#gpio-cells', 257581c01aSSimon Glass '#size-cells', 267581c01aSSimon Glass 'compatible', 277581c01aSSimon Glass 'linux,phandle', 287581c01aSSimon Glass "status", 297581c01aSSimon Glass 'phandle', 307581c01aSSimon Glass 'u-boot,dm-pre-reloc', 317581c01aSSimon Glass 'u-boot,dm-tpl', 327581c01aSSimon Glass 'u-boot,dm-spl', 337581c01aSSimon Glass] 347581c01aSSimon Glass 357581c01aSSimon Glass# C type declarations for the tyues we support 367581c01aSSimon GlassTYPE_NAMES = { 377581c01aSSimon Glass fdt.TYPE_INT: 'fdt32_t', 387581c01aSSimon Glass fdt.TYPE_BYTE: 'unsigned char', 397581c01aSSimon Glass fdt.TYPE_STRING: 'const char *', 407581c01aSSimon Glass fdt.TYPE_BOOL: 'bool', 412be282caSSimon Glass} 427581c01aSSimon Glass 437581c01aSSimon GlassSTRUCT_PREFIX = 'dtd_' 447581c01aSSimon GlassVAL_PREFIX = 'dtv_' 457581c01aSSimon Glass 462be282caSSimon Glassdef conv_name_to_c(name): 477581c01aSSimon Glass """Convert a device-tree name to a C identifier 487581c01aSSimon Glass 497581c01aSSimon Glass Args: 507581c01aSSimon Glass name: Name to convert 517581c01aSSimon Glass Return: 527581c01aSSimon Glass String containing the C version of this name 537581c01aSSimon Glass """ 542be282caSSimon Glass new = name.replace('@', '_at_') 552be282caSSimon Glass new = new.replace('-', '_') 562be282caSSimon Glass new = new.replace(',', '_') 572be282caSSimon Glass new = new.replace('.', '_') 582be282caSSimon Glass return new 597581c01aSSimon Glass 602be282caSSimon Glassdef tab_to(num_tabs, line): 612be282caSSimon Glass """Append tabs to a line of text to reach a tab stop. 627581c01aSSimon Glass 632be282caSSimon Glass Args: 642be282caSSimon Glass num_tabs: Tab stop to obtain (0 = column 0, 1 = column 8, etc.) 652be282caSSimon Glass line: Line of text to append to 662be282caSSimon Glass 672be282caSSimon Glass Returns: 682be282caSSimon Glass line with the correct number of tabs appeneded. If the line already 692be282caSSimon Glass extends past that tab stop then a single space is appended. 702be282caSSimon Glass """ 712be282caSSimon Glass if len(line) >= num_tabs * 8: 722be282caSSimon Glass return line + ' ' 732be282caSSimon Glass return line + '\t' * (num_tabs - len(line) // 8) 742be282caSSimon Glass 752be282caSSimon Glassclass DtbPlatdata(object): 767581c01aSSimon Glass """Provide a means to convert device tree binary data to platform data 777581c01aSSimon Glass 787581c01aSSimon Glass The output of this process is C structures which can be used in space- 797581c01aSSimon Glass constrained encvironments where the ~3KB code overhead of device tree 807581c01aSSimon Glass code is not affordable. 817581c01aSSimon Glass 827581c01aSSimon Glass Properties: 832be282caSSimon Glass _fdt: Fdt object, referencing the device tree 847581c01aSSimon Glass _dtb_fname: Filename of the input device tree binary file 857581c01aSSimon Glass _valid_nodes: A list of Node object with compatible strings 86*e36024b0SSimon Glass _include_disabled: true to include nodes marked status = "disabled" 872be282caSSimon Glass _phandle_nodes: A dict of nodes indexed by phandle number (1, 2...) 887581c01aSSimon Glass _outfile: The current output file (sys.stdout or a real file) 897581c01aSSimon Glass _lines: Stashed list of output lines for outputting in the future 902be282caSSimon Glass _phandle_nodes: A dict of Nodes indexed by phandle (an integer) 917581c01aSSimon Glass """ 92*e36024b0SSimon Glass def __init__(self, dtb_fname, include_disabled): 932be282caSSimon Glass self._fdt = None 947581c01aSSimon Glass self._dtb_fname = dtb_fname 957581c01aSSimon Glass self._valid_nodes = None 96*e36024b0SSimon Glass self._include_disabled = include_disabled 972be282caSSimon Glass self._phandle_nodes = {} 987581c01aSSimon Glass self._outfile = None 997581c01aSSimon Glass self._lines = [] 1007581c01aSSimon Glass self._aliases = {} 1017581c01aSSimon Glass 1022be282caSSimon Glass def setup_output(self, fname): 1037581c01aSSimon Glass """Set up the output destination 1047581c01aSSimon Glass 1052be282caSSimon Glass Once this is done, future calls to self.out() will output to this 1067581c01aSSimon Glass file. 1077581c01aSSimon Glass 1087581c01aSSimon Glass Args: 1097581c01aSSimon Glass fname: Filename to send output to, or '-' for stdout 1107581c01aSSimon Glass """ 1117581c01aSSimon Glass if fname == '-': 1127581c01aSSimon Glass self._outfile = sys.stdout 1137581c01aSSimon Glass else: 1147581c01aSSimon Glass self._outfile = open(fname, 'w') 1157581c01aSSimon Glass 1162be282caSSimon Glass def out(self, line): 1177581c01aSSimon Glass """Output a string to the output file 1187581c01aSSimon Glass 1197581c01aSSimon Glass Args: 1202be282caSSimon Glass line: String to output 1217581c01aSSimon Glass """ 1222be282caSSimon Glass self._outfile.write(line) 1237581c01aSSimon Glass 1242be282caSSimon Glass def buf(self, line): 1257581c01aSSimon Glass """Buffer up a string to send later 1267581c01aSSimon Glass 1277581c01aSSimon Glass Args: 1282be282caSSimon Glass line: String to add to our 'buffer' list 1297581c01aSSimon Glass """ 1302be282caSSimon Glass self._lines.append(line) 1317581c01aSSimon Glass 1322be282caSSimon Glass def get_buf(self): 1337581c01aSSimon Glass """Get the contents of the output buffer, and clear it 1347581c01aSSimon Glass 1357581c01aSSimon Glass Returns: 1367581c01aSSimon Glass The output buffer, which is then cleared for future use 1377581c01aSSimon Glass """ 1387581c01aSSimon Glass lines = self._lines 1397581c01aSSimon Glass self._lines = [] 1407581c01aSSimon Glass return lines 1417581c01aSSimon Glass 1422be282caSSimon Glass @staticmethod 1432be282caSSimon Glass def get_value(ftype, value): 1447581c01aSSimon Glass """Get a value as a C expression 1457581c01aSSimon Glass 1467581c01aSSimon Glass For integers this returns a byte-swapped (little-endian) hex string 1477581c01aSSimon Glass For bytes this returns a hex string, e.g. 0x12 1487581c01aSSimon Glass For strings this returns a literal string enclosed in quotes 1497581c01aSSimon Glass For booleans this return 'true' 1507581c01aSSimon Glass 1517581c01aSSimon Glass Args: 1527581c01aSSimon Glass type: Data type (fdt_util) 1537581c01aSSimon Glass value: Data value, as a string of bytes 1547581c01aSSimon Glass """ 1552be282caSSimon Glass if ftype == fdt.TYPE_INT: 1567581c01aSSimon Glass return '%#x' % fdt_util.fdt32_to_cpu(value) 1572be282caSSimon Glass elif ftype == fdt.TYPE_BYTE: 1587581c01aSSimon Glass return '%#x' % ord(value[0]) 1592be282caSSimon Glass elif ftype == fdt.TYPE_STRING: 1607581c01aSSimon Glass return '"%s"' % value 1612be282caSSimon Glass elif ftype == fdt.TYPE_BOOL: 1627581c01aSSimon Glass return 'true' 1637581c01aSSimon Glass 1642be282caSSimon Glass @staticmethod 1652be282caSSimon Glass def get_compat_name(node): 1667581c01aSSimon Glass """Get a node's first compatible string as a C identifier 1677581c01aSSimon Glass 1687581c01aSSimon Glass Args: 1697581c01aSSimon Glass node: Node object to check 1707581c01aSSimon Glass Return: 1717581c01aSSimon Glass C identifier for the first compatible string 1727581c01aSSimon Glass """ 1737581c01aSSimon Glass compat = node.props['compatible'].value 1747581c01aSSimon Glass aliases = [] 1752be282caSSimon Glass if isinstance(compat, list): 1767581c01aSSimon Glass compat, aliases = compat[0], compat[1:] 1772be282caSSimon Glass return conv_name_to_c(compat), [conv_name_to_c(a) for a in aliases] 1787581c01aSSimon Glass 1792be282caSSimon Glass def scan_dtb(self): 1807581c01aSSimon Glass """Scan the device tree to obtain a tree of notes and properties 1817581c01aSSimon Glass 1822be282caSSimon Glass Once this is done, self._fdt.GetRoot() can be called to obtain the 1837581c01aSSimon Glass device tree root node, and progress from there. 1847581c01aSSimon Glass """ 1852be282caSSimon Glass self._fdt = fdt.FdtScan(self._dtb_fname) 1867581c01aSSimon Glass 1872be282caSSimon Glass def scan_node(self, root): 1882be282caSSimon Glass """Scan a node and subnodes to build a tree of node and phandle info 1892be282caSSimon Glass 1902be282caSSimon Glass This adds each node to self._valid_nodes and each phandle to 1912be282caSSimon Glass self._phandle_nodes. 1922be282caSSimon Glass 1932be282caSSimon Glass Args: 1942be282caSSimon Glass root: Root node for scan 1952be282caSSimon Glass """ 1967581c01aSSimon Glass for node in root.subnodes: 1977581c01aSSimon Glass if 'compatible' in node.props: 1987581c01aSSimon Glass status = node.props.get('status') 199*e36024b0SSimon Glass if (not self._include_disabled and not status or 2007581c01aSSimon Glass status.value != 'disabled'): 2017581c01aSSimon Glass self._valid_nodes.append(node) 2027581c01aSSimon Glass phandle_prop = node.props.get('phandle') 2037581c01aSSimon Glass if phandle_prop: 2047581c01aSSimon Glass phandle = phandle_prop.GetPhandle() 2052be282caSSimon Glass self._phandle_nodes[phandle] = node 2067581c01aSSimon Glass 2077581c01aSSimon Glass # recurse to handle any subnodes 2082be282caSSimon Glass self.scan_node(node) 2097581c01aSSimon Glass 2102be282caSSimon Glass def scan_tree(self): 2117581c01aSSimon Glass """Scan the device tree for useful information 2127581c01aSSimon Glass 2137581c01aSSimon Glass This fills in the following properties: 2142be282caSSimon Glass _phandle_nodes: A dict of Nodes indexed by phandle (an integer) 2157581c01aSSimon Glass _valid_nodes: A list of nodes we wish to consider include in the 2167581c01aSSimon Glass platform data 2177581c01aSSimon Glass """ 2182be282caSSimon Glass self._phandle_nodes = {} 2197581c01aSSimon Glass self._valid_nodes = [] 2202be282caSSimon Glass return self.scan_node(self._fdt.GetRoot()) 2217581c01aSSimon Glass 2222be282caSSimon Glass @staticmethod 2232be282caSSimon Glass def is_phandle(prop): 2247581c01aSSimon Glass """Check if a node contains phandles 2257581c01aSSimon Glass 2267581c01aSSimon Glass We have no reliable way of detecting whether a node uses a phandle 2277581c01aSSimon Glass or not. As an interim measure, use a list of known property names. 2287581c01aSSimon Glass 2297581c01aSSimon Glass Args: 2307581c01aSSimon Glass prop: Prop object to check 2317581c01aSSimon Glass Return: 2327581c01aSSimon Glass True if the object value contains phandles, else False 2337581c01aSSimon Glass """ 2347581c01aSSimon Glass if prop.name in ['clocks']: 2357581c01aSSimon Glass return True 2367581c01aSSimon Glass return False 2377581c01aSSimon Glass 2382be282caSSimon Glass def scan_structs(self): 2397581c01aSSimon Glass """Scan the device tree building up the C structures we will use. 2407581c01aSSimon Glass 2417581c01aSSimon Glass Build a dict keyed by C struct name containing a dict of Prop 2427581c01aSSimon Glass object for each struct field (keyed by property name). Where the 2437581c01aSSimon Glass same struct appears multiple times, try to use the 'widest' 2447581c01aSSimon Glass property, i.e. the one with a type which can express all others. 2457581c01aSSimon Glass 2467581c01aSSimon Glass Once the widest property is determined, all other properties are 2477581c01aSSimon Glass updated to match that width. 2487581c01aSSimon Glass """ 2497581c01aSSimon Glass structs = {} 2507581c01aSSimon Glass for node in self._valid_nodes: 2512be282caSSimon Glass node_name, _ = self.get_compat_name(node) 2527581c01aSSimon Glass fields = {} 2537581c01aSSimon Glass 2547581c01aSSimon Glass # Get a list of all the valid properties in this node. 2557581c01aSSimon Glass for name, prop in node.props.items(): 2567581c01aSSimon Glass if name not in PROP_IGNORE_LIST and name[0] != '#': 2577581c01aSSimon Glass fields[name] = copy.deepcopy(prop) 2587581c01aSSimon Glass 2597581c01aSSimon Glass # If we've seen this node_name before, update the existing struct. 2607581c01aSSimon Glass if node_name in structs: 2617581c01aSSimon Glass struct = structs[node_name] 2627581c01aSSimon Glass for name, prop in fields.items(): 2637581c01aSSimon Glass oldprop = struct.get(name) 2647581c01aSSimon Glass if oldprop: 2657581c01aSSimon Glass oldprop.Widen(prop) 2667581c01aSSimon Glass else: 2677581c01aSSimon Glass struct[name] = prop 2687581c01aSSimon Glass 2697581c01aSSimon Glass # Otherwise store this as a new struct. 2707581c01aSSimon Glass else: 2717581c01aSSimon Glass structs[node_name] = fields 2727581c01aSSimon Glass 2737581c01aSSimon Glass upto = 0 2747581c01aSSimon Glass for node in self._valid_nodes: 2752be282caSSimon Glass node_name, _ = self.get_compat_name(node) 2767581c01aSSimon Glass struct = structs[node_name] 2777581c01aSSimon Glass for name, prop in node.props.items(): 2787581c01aSSimon Glass if name not in PROP_IGNORE_LIST and name[0] != '#': 2797581c01aSSimon Glass prop.Widen(struct[name]) 2807581c01aSSimon Glass upto += 1 2817581c01aSSimon Glass 2822be282caSSimon Glass struct_name, aliases = self.get_compat_name(node) 2837581c01aSSimon Glass for alias in aliases: 2847581c01aSSimon Glass self._aliases[alias] = struct_name 2857581c01aSSimon Glass 2867581c01aSSimon Glass return structs 2877581c01aSSimon Glass 2882be282caSSimon Glass def scan_phandles(self): 2897581c01aSSimon Glass """Figure out what phandles each node uses 2907581c01aSSimon Glass 2917581c01aSSimon Glass We need to be careful when outputing nodes that use phandles since 2927581c01aSSimon Glass they must come after the declaration of the phandles in the C file. 2937581c01aSSimon Glass Otherwise we get a compiler error since the phandle struct is not yet 2947581c01aSSimon Glass declared. 2957581c01aSSimon Glass 2967581c01aSSimon Glass This function adds to each node a list of phandle nodes that the node 2977581c01aSSimon Glass depends on. This allows us to output things in the right order. 2987581c01aSSimon Glass """ 2997581c01aSSimon Glass for node in self._valid_nodes: 3007581c01aSSimon Glass node.phandles = set() 3017581c01aSSimon Glass for pname, prop in node.props.items(): 3027581c01aSSimon Glass if pname in PROP_IGNORE_LIST or pname[0] == '#': 3037581c01aSSimon Glass continue 3042be282caSSimon Glass if isinstance(prop.value, list): 3052be282caSSimon Glass if self.is_phandle(prop): 3067581c01aSSimon Glass # Process the list as pairs of (phandle, id) 3072be282caSSimon Glass value_it = iter(prop.value) 3082be282caSSimon Glass for phandle_cell, _ in zip(value_it, value_it): 3097581c01aSSimon Glass phandle = fdt_util.fdt32_to_cpu(phandle_cell) 3102be282caSSimon Glass target_node = self._phandle_nodes[phandle] 3117581c01aSSimon Glass node.phandles.add(target_node) 3127581c01aSSimon Glass 3137581c01aSSimon Glass 3142be282caSSimon Glass def generate_structs(self, structs): 3157581c01aSSimon Glass """Generate struct defintions for the platform data 3167581c01aSSimon Glass 3177581c01aSSimon Glass This writes out the body of a header file consisting of structure 3187581c01aSSimon Glass definitions for node in self._valid_nodes. See the documentation in 3197581c01aSSimon Glass README.of-plat for more information. 3207581c01aSSimon Glass """ 3212be282caSSimon Glass self.out('#include <stdbool.h>\n') 3222be282caSSimon Glass self.out('#include <libfdt.h>\n') 3237581c01aSSimon Glass 3247581c01aSSimon Glass # Output the struct definition 3257581c01aSSimon Glass for name in sorted(structs): 3262be282caSSimon Glass self.out('struct %s%s {\n' % (STRUCT_PREFIX, name)) 3277581c01aSSimon Glass for pname in sorted(structs[name]): 3287581c01aSSimon Glass prop = structs[name][pname] 3292be282caSSimon Glass if self.is_phandle(prop): 3307581c01aSSimon Glass # For phandles, include a reference to the target 3312be282caSSimon Glass self.out('\t%s%s[%d]' % (tab_to(2, 'struct phandle_2_cell'), 3322be282caSSimon Glass conv_name_to_c(prop.name), 3337581c01aSSimon Glass len(prop.value) / 2)) 3347581c01aSSimon Glass else: 3357581c01aSSimon Glass ptype = TYPE_NAMES[prop.type] 3362be282caSSimon Glass self.out('\t%s%s' % (tab_to(2, ptype), 3372be282caSSimon Glass conv_name_to_c(prop.name))) 3382be282caSSimon Glass if isinstance(prop.value, list): 3392be282caSSimon Glass self.out('[%d]' % len(prop.value)) 3402be282caSSimon Glass self.out(';\n') 3412be282caSSimon Glass self.out('};\n') 3427581c01aSSimon Glass 3437581c01aSSimon Glass for alias, struct_name in self._aliases.iteritems(): 3442be282caSSimon Glass self.out('#define %s%s %s%s\n'% (STRUCT_PREFIX, alias, 3457581c01aSSimon Glass STRUCT_PREFIX, struct_name)) 3467581c01aSSimon Glass 3472be282caSSimon Glass def output_node(self, node): 3487581c01aSSimon Glass """Output the C code for a node 3497581c01aSSimon Glass 3507581c01aSSimon Glass Args: 3517581c01aSSimon Glass node: node to output 3527581c01aSSimon Glass """ 3532be282caSSimon Glass struct_name, _ = self.get_compat_name(node) 3542be282caSSimon Glass var_name = conv_name_to_c(node.name) 3552be282caSSimon Glass self.buf('static struct %s%s %s%s = {\n' % 3567581c01aSSimon Glass (STRUCT_PREFIX, struct_name, VAL_PREFIX, var_name)) 3577581c01aSSimon Glass for pname, prop in node.props.items(): 3587581c01aSSimon Glass if pname in PROP_IGNORE_LIST or pname[0] == '#': 3597581c01aSSimon Glass continue 3602be282caSSimon Glass member_name = conv_name_to_c(prop.name) 3612be282caSSimon Glass self.buf('\t%s= ' % tab_to(3, '.' + member_name)) 3627581c01aSSimon Glass 3637581c01aSSimon Glass # Special handling for lists 3642be282caSSimon Glass if isinstance(prop.value, list): 3652be282caSSimon Glass self.buf('{') 3667581c01aSSimon Glass vals = [] 3677581c01aSSimon Glass # For phandles, output a reference to the platform data 3687581c01aSSimon Glass # of the target node. 3692be282caSSimon Glass if self.is_phandle(prop): 3707581c01aSSimon Glass # Process the list as pairs of (phandle, id) 3712be282caSSimon Glass value_it = iter(prop.value) 3722be282caSSimon Glass for phandle_cell, id_cell in zip(value_it, value_it): 3737581c01aSSimon Glass phandle = fdt_util.fdt32_to_cpu(phandle_cell) 3742be282caSSimon Glass id_num = fdt_util.fdt32_to_cpu(id_cell) 3752be282caSSimon Glass target_node = self._phandle_nodes[phandle] 3762be282caSSimon Glass name = conv_name_to_c(target_node.name) 3772be282caSSimon Glass vals.append('{&%s%s, %d}' % (VAL_PREFIX, name, id_num)) 3787581c01aSSimon Glass else: 3797581c01aSSimon Glass for val in prop.value: 3802be282caSSimon Glass vals.append(self.get_value(prop.type, val)) 3812be282caSSimon Glass self.buf(', '.join(vals)) 3822be282caSSimon Glass self.buf('}') 3837581c01aSSimon Glass else: 3842be282caSSimon Glass self.buf(self.get_value(prop.type, prop.value)) 3852be282caSSimon Glass self.buf(',\n') 3862be282caSSimon Glass self.buf('};\n') 3877581c01aSSimon Glass 3887581c01aSSimon Glass # Add a device declaration 3892be282caSSimon Glass self.buf('U_BOOT_DEVICE(%s) = {\n' % var_name) 3902be282caSSimon Glass self.buf('\t.name\t\t= "%s",\n' % struct_name) 3912be282caSSimon Glass self.buf('\t.platdata\t= &%s%s,\n' % (VAL_PREFIX, var_name)) 3922be282caSSimon Glass self.buf('\t.platdata_size\t= sizeof(%s%s),\n' % (VAL_PREFIX, var_name)) 3932be282caSSimon Glass self.buf('};\n') 3942be282caSSimon Glass self.buf('\n') 3957581c01aSSimon Glass 3962be282caSSimon Glass self.out(''.join(self.get_buf())) 3977581c01aSSimon Glass 3982be282caSSimon Glass def generate_tables(self): 3997581c01aSSimon Glass """Generate device defintions for the platform data 4007581c01aSSimon Glass 4017581c01aSSimon Glass This writes out C platform data initialisation data and 4027581c01aSSimon Glass U_BOOT_DEVICE() declarations for each valid node. Where a node has 4037581c01aSSimon Glass multiple compatible strings, a #define is used to make them equivalent. 4047581c01aSSimon Glass 4057581c01aSSimon Glass See the documentation in doc/driver-model/of-plat.txt for more 4067581c01aSSimon Glass information. 4077581c01aSSimon Glass """ 4082be282caSSimon Glass self.out('#include <common.h>\n') 4092be282caSSimon Glass self.out('#include <dm.h>\n') 4102be282caSSimon Glass self.out('#include <dt-structs.h>\n') 4112be282caSSimon Glass self.out('\n') 4127581c01aSSimon Glass nodes_to_output = list(self._valid_nodes) 4137581c01aSSimon Glass 4147581c01aSSimon Glass # Keep outputing nodes until there is none left 4157581c01aSSimon Glass while nodes_to_output: 4167581c01aSSimon Glass node = nodes_to_output[0] 4177581c01aSSimon Glass # Output all the node's dependencies first 4187581c01aSSimon Glass for req_node in node.phandles: 4197581c01aSSimon Glass if req_node in nodes_to_output: 4202be282caSSimon Glass self.output_node(req_node) 4217581c01aSSimon Glass nodes_to_output.remove(req_node) 4222be282caSSimon Glass self.output_node(node) 4237581c01aSSimon Glass nodes_to_output.remove(node) 424