xref: /rk3399_rockchip-uboot/tools/buildman/builder.py (revision 960421ecb3db9220609b6f1dbcb9f972dbca9975)
1fc3fe1c2SSimon Glass# Copyright (c) 2013 The Chromium OS Authors.
2fc3fe1c2SSimon Glass#
3fc3fe1c2SSimon Glass# Bloat-o-meter code used here Copyright 2004 Matt Mackall <mpm@selenic.com>
4fc3fe1c2SSimon Glass#
51a459660SWolfgang Denk# SPDX-License-Identifier:	GPL-2.0+
6fc3fe1c2SSimon Glass#
7fc3fe1c2SSimon Glass
8fc3fe1c2SSimon Glassimport collections
9fc3fe1c2SSimon Glassfrom datetime import datetime, timedelta
10fc3fe1c2SSimon Glassimport glob
11fc3fe1c2SSimon Glassimport os
12fc3fe1c2SSimon Glassimport re
13fc3fe1c2SSimon Glassimport Queue
14fc3fe1c2SSimon Glassimport shutil
152f256648SSimon Glassimport signal
16fc3fe1c2SSimon Glassimport string
17fc3fe1c2SSimon Glassimport sys
18d436e381SSimon Glassimport threading
19fc3fe1c2SSimon Glassimport time
20fc3fe1c2SSimon Glass
21190064b4SSimon Glassimport builderthread
22fc3fe1c2SSimon Glassimport command
23fc3fe1c2SSimon Glassimport gitutil
24fc3fe1c2SSimon Glassimport terminal
254653a882SSimon Glassfrom terminal import Print
26fc3fe1c2SSimon Glassimport toolchain
27fc3fe1c2SSimon Glass
28fc3fe1c2SSimon Glass
29fc3fe1c2SSimon Glass"""
30fc3fe1c2SSimon GlassTheory of Operation
31fc3fe1c2SSimon Glass
32fc3fe1c2SSimon GlassPlease see README for user documentation, and you should be familiar with
33fc3fe1c2SSimon Glassthat before trying to make sense of this.
34fc3fe1c2SSimon Glass
35fc3fe1c2SSimon GlassBuildman works by keeping the machine as busy as possible, building different
36fc3fe1c2SSimon Glasscommits for different boards on multiple CPUs at once.
37fc3fe1c2SSimon Glass
38fc3fe1c2SSimon GlassThe source repo (self.git_dir) contains all the commits to be built. Each
39fc3fe1c2SSimon Glassthread works on a single board at a time. It checks out the first commit,
40fc3fe1c2SSimon Glassconfigures it for that board, then builds it. Then it checks out the next
41fc3fe1c2SSimon Glasscommit and builds it (typically without re-configuring). When it runs out
42fc3fe1c2SSimon Glassof commits, it gets another job from the builder and starts again with that
43fc3fe1c2SSimon Glassboard.
44fc3fe1c2SSimon Glass
45fc3fe1c2SSimon GlassClearly the builder threads could work either way - they could check out a
46fc3fe1c2SSimon Glasscommit and then built it for all boards. Using separate directories for each
47fc3fe1c2SSimon Glasscommit/board pair they could leave their build product around afterwards
48fc3fe1c2SSimon Glassalso.
49fc3fe1c2SSimon Glass
50fc3fe1c2SSimon GlassThe intent behind building a single board for multiple commits, is to make
51fc3fe1c2SSimon Glassuse of incremental builds. Since each commit is built incrementally from
52fc3fe1c2SSimon Glassthe previous one, builds are faster. Reconfiguring for a different board
53fc3fe1c2SSimon Glassremoves all intermediate object files.
54fc3fe1c2SSimon Glass
55fc3fe1c2SSimon GlassMany threads can be working at once, but each has its own working directory.
56fc3fe1c2SSimon GlassWhen a thread finishes a build, it puts the output files into a result
57fc3fe1c2SSimon Glassdirectory.
58fc3fe1c2SSimon Glass
59fc3fe1c2SSimon GlassThe base directory used by buildman is normally '../<branch>', i.e.
60fc3fe1c2SSimon Glassa directory higher than the source repository and named after the branch
61fc3fe1c2SSimon Glassbeing built.
62fc3fe1c2SSimon Glass
63fc3fe1c2SSimon GlassWithin the base directory, we have one subdirectory for each commit. Within
64fc3fe1c2SSimon Glassthat is one subdirectory for each board. Within that is the build output for
65fc3fe1c2SSimon Glassthat commit/board combination.
66fc3fe1c2SSimon Glass
67fc3fe1c2SSimon GlassBuildman also create working directories for each thread, in a .bm-work/
68fc3fe1c2SSimon Glasssubdirectory in the base dir.
69fc3fe1c2SSimon Glass
70fc3fe1c2SSimon GlassAs an example, say we are building branch 'us-net' for boards 'sandbox' and
71fc3fe1c2SSimon Glass'seaboard', and say that us-net has two commits. We will have directories
72fc3fe1c2SSimon Glasslike this:
73fc3fe1c2SSimon Glass
74fc3fe1c2SSimon Glassus-net/             base directory
75fc3fe1c2SSimon Glass    01_of_02_g4ed4ebc_net--Add-tftp-speed-/
76fc3fe1c2SSimon Glass        sandbox/
77fc3fe1c2SSimon Glass            u-boot.bin
78fc3fe1c2SSimon Glass        seaboard/
79fc3fe1c2SSimon Glass            u-boot.bin
80fc3fe1c2SSimon Glass    02_of_02_g4ed4ebc_net--Check-tftp-comp/
81fc3fe1c2SSimon Glass        sandbox/
82fc3fe1c2SSimon Glass            u-boot.bin
83fc3fe1c2SSimon Glass        seaboard/
84fc3fe1c2SSimon Glass            u-boot.bin
85fc3fe1c2SSimon Glass    .bm-work/
86fc3fe1c2SSimon Glass        00/         working directory for thread 0 (contains source checkout)
87fc3fe1c2SSimon Glass            build/  build output
88fc3fe1c2SSimon Glass        01/         working directory for thread 1
89fc3fe1c2SSimon Glass            build/  build output
90fc3fe1c2SSimon Glass        ...
91fc3fe1c2SSimon Glassu-boot/             source directory
92fc3fe1c2SSimon Glass    .git/           repository
93fc3fe1c2SSimon Glass"""
94fc3fe1c2SSimon Glass
95fc3fe1c2SSimon Glass# Possible build outcomes
96fc3fe1c2SSimon GlassOUTCOME_OK, OUTCOME_WARNING, OUTCOME_ERROR, OUTCOME_UNKNOWN = range(4)
97fc3fe1c2SSimon Glass
98fc3fe1c2SSimon Glass# Translate a commit subject into a valid filename
99fc3fe1c2SSimon Glasstrans_valid_chars = string.maketrans("/: ", "---")
100fc3fe1c2SSimon Glass
101b464f8e7SSimon GlassBASE_CONFIG_FILENAMES = [
102b464f8e7SSimon Glass    'u-boot.cfg', 'u-boot-spl.cfg', 'u-boot-tpl.cfg'
103b464f8e7SSimon Glass]
104b464f8e7SSimon Glass
105b464f8e7SSimon GlassEXTRA_CONFIG_FILENAMES = [
106843312dcSSimon Glass    '.config', '.config-spl', '.config-tpl',
107843312dcSSimon Glass    'autoconf.mk', 'autoconf-spl.mk', 'autoconf-tpl.mk',
108843312dcSSimon Glass    'autoconf.h', 'autoconf-spl.h','autoconf-tpl.h',
109843312dcSSimon Glass]
110843312dcSSimon Glass
1118270e3c1SSimon Glassclass Config:
1128270e3c1SSimon Glass    """Holds information about configuration settings for a board."""
113b464f8e7SSimon Glass    def __init__(self, config_filename, target):
1148270e3c1SSimon Glass        self.target = target
1158270e3c1SSimon Glass        self.config = {}
116b464f8e7SSimon Glass        for fname in config_filename:
1178270e3c1SSimon Glass            self.config[fname] = {}
1188270e3c1SSimon Glass
1198270e3c1SSimon Glass    def Add(self, fname, key, value):
1208270e3c1SSimon Glass        self.config[fname][key] = value
1218270e3c1SSimon Glass
1228270e3c1SSimon Glass    def __hash__(self):
1238270e3c1SSimon Glass        val = 0
1248270e3c1SSimon Glass        for fname in self.config:
1258270e3c1SSimon Glass            for key, value in self.config[fname].iteritems():
1268270e3c1SSimon Glass                print key, value
1278270e3c1SSimon Glass                val = val ^ hash(key) & hash(value)
1288270e3c1SSimon Glass        return val
129fc3fe1c2SSimon Glass
130fc3fe1c2SSimon Glassclass Builder:
131fc3fe1c2SSimon Glass    """Class for building U-Boot for a particular commit.
132fc3fe1c2SSimon Glass
133fc3fe1c2SSimon Glass    Public members: (many should ->private)
134fc3fe1c2SSimon Glass        already_done: Number of builds already completed
135fc3fe1c2SSimon Glass        base_dir: Base directory to use for builder
136fc3fe1c2SSimon Glass        checkout: True to check out source, False to skip that step.
137fc3fe1c2SSimon Glass            This is used for testing.
138fc3fe1c2SSimon Glass        col: terminal.Color() object
139fc3fe1c2SSimon Glass        count: Number of commits to build
140fc3fe1c2SSimon Glass        do_make: Method to call to invoke Make
141fc3fe1c2SSimon Glass        fail: Number of builds that failed due to error
142fc3fe1c2SSimon Glass        force_build: Force building even if a build already exists
143fc3fe1c2SSimon Glass        force_config_on_failure: If a commit fails for a board, disable
144fc3fe1c2SSimon Glass            incremental building for the next commit we build for that
145fc3fe1c2SSimon Glass            board, so that we will see all warnings/errors again.
1464266dc28SSimon Glass        force_build_failures: If a previously-built build (i.e. built on
1474266dc28SSimon Glass            a previous run of buildman) is marked as failed, rebuild it.
148fc3fe1c2SSimon Glass        git_dir: Git directory containing source repository
149fc3fe1c2SSimon Glass        last_line_len: Length of the last line we printed (used for erasing
150fc3fe1c2SSimon Glass            it with new progress information)
151fc3fe1c2SSimon Glass        num_jobs: Number of jobs to run at once (passed to make as -j)
152fc3fe1c2SSimon Glass        num_threads: Number of builder threads to run
153fc3fe1c2SSimon Glass        out_queue: Queue of results to process
154fc3fe1c2SSimon Glass        re_make_err: Compiled regular expression for ignore_lines
155fc3fe1c2SSimon Glass        queue: Queue of jobs to run
156fc3fe1c2SSimon Glass        threads: List of active threads
157fc3fe1c2SSimon Glass        toolchains: Toolchains object to use for building
158fc3fe1c2SSimon Glass        upto: Current commit number we are building (0.count-1)
159fc3fe1c2SSimon Glass        warned: Number of builds that produced at least one warning
16097e91526SSimon Glass        force_reconfig: Reconfigure U-Boot on each comiit. This disables
16197e91526SSimon Glass            incremental building, where buildman reconfigures on the first
16297e91526SSimon Glass            commit for a baord, and then just does an incremental build for
16397e91526SSimon Glass            the following commits. In fact buildman will reconfigure and
16497e91526SSimon Glass            retry for any failing commits, so generally the only effect of
16597e91526SSimon Glass            this option is to slow things down.
166189a4968SSimon Glass        in_tree: Build U-Boot in-tree instead of specifying an output
167189a4968SSimon Glass            directory separate from the source code. This option is really
168189a4968SSimon Glass            only useful for testing in-tree builds.
169fc3fe1c2SSimon Glass
170fc3fe1c2SSimon Glass    Private members:
171fc3fe1c2SSimon Glass        _base_board_dict: Last-summarised Dict of boards
172fc3fe1c2SSimon Glass        _base_err_lines: Last-summarised list of errors
173e30965dbSSimon Glass        _base_warn_lines: Last-summarised list of warnings
174fc3fe1c2SSimon Glass        _build_period_us: Time taken for a single build (float object).
175fc3fe1c2SSimon Glass        _complete_delay: Expected delay until completion (timedelta)
176fc3fe1c2SSimon Glass        _next_delay_update: Next time we plan to display a progress update
177fc3fe1c2SSimon Glass                (datatime)
178fc3fe1c2SSimon Glass        _show_unknown: Show unknown boards (those not built) in summary
179fc3fe1c2SSimon Glass        _timestamps: List of timestamps for the completion of the last
180fc3fe1c2SSimon Glass            last _timestamp_count builds. Each is a datetime object.
181fc3fe1c2SSimon Glass        _timestamp_count: Number of timestamps to keep in our list.
182fc3fe1c2SSimon Glass        _working_dir: Base working directory containing all threads
183fc3fe1c2SSimon Glass    """
184fc3fe1c2SSimon Glass    class Outcome:
185fc3fe1c2SSimon Glass        """Records a build outcome for a single make invocation
186fc3fe1c2SSimon Glass
187fc3fe1c2SSimon Glass        Public Members:
188fc3fe1c2SSimon Glass            rc: Outcome value (OUTCOME_...)
189fc3fe1c2SSimon Glass            err_lines: List of error lines or [] if none
190fc3fe1c2SSimon Glass            sizes: Dictionary of image size information, keyed by filename
191fc3fe1c2SSimon Glass                - Each value is itself a dictionary containing
192fc3fe1c2SSimon Glass                    values for 'text', 'data' and 'bss', being the integer
193fc3fe1c2SSimon Glass                    size in bytes of each section.
194fc3fe1c2SSimon Glass            func_sizes: Dictionary keyed by filename - e.g. 'u-boot'. Each
195fc3fe1c2SSimon Glass                    value is itself a dictionary:
196fc3fe1c2SSimon Glass                        key: function name
197fc3fe1c2SSimon Glass                        value: Size of function in bytes
198843312dcSSimon Glass            config: Dictionary keyed by filename - e.g. '.config'. Each
199843312dcSSimon Glass                    value is itself a dictionary:
200843312dcSSimon Glass                        key: config name
201843312dcSSimon Glass                        value: config value
202fc3fe1c2SSimon Glass        """
203843312dcSSimon Glass        def __init__(self, rc, err_lines, sizes, func_sizes, config):
204fc3fe1c2SSimon Glass            self.rc = rc
205fc3fe1c2SSimon Glass            self.err_lines = err_lines
206fc3fe1c2SSimon Glass            self.sizes = sizes
207fc3fe1c2SSimon Glass            self.func_sizes = func_sizes
208843312dcSSimon Glass            self.config = config
209fc3fe1c2SSimon Glass
210fc3fe1c2SSimon Glass    def __init__(self, toolchains, base_dir, git_dir, num_threads, num_jobs,
2115971ab5cSSimon Glass                 gnu_make='make', checkout=True, show_unknown=True, step=1,
212f79f1e0cSStephen Warren                 no_subdirs=False, full_path=False, verbose_build=False,
213b50113f3SSimon Glass                 incremental=False, per_board_out_dir=False,
214b464f8e7SSimon Glass                 config_only=False, squash_config_y=False):
215fc3fe1c2SSimon Glass        """Create a new Builder object
216fc3fe1c2SSimon Glass
217fc3fe1c2SSimon Glass        Args:
218fc3fe1c2SSimon Glass            toolchains: Toolchains object to use for building
219fc3fe1c2SSimon Glass            base_dir: Base directory to use for builder
220fc3fe1c2SSimon Glass            git_dir: Git directory containing source repository
221fc3fe1c2SSimon Glass            num_threads: Number of builder threads to run
222fc3fe1c2SSimon Glass            num_jobs: Number of jobs to run at once (passed to make as -j)
22399796923SMasahiro Yamada            gnu_make: the command name of GNU Make.
224fc3fe1c2SSimon Glass            checkout: True to check out source, False to skip that step.
225fc3fe1c2SSimon Glass                This is used for testing.
226fc3fe1c2SSimon Glass            show_unknown: Show unknown boards (those not built) in summary
227fc3fe1c2SSimon Glass            step: 1 to process every commit, n to process every nth commit
228bb1501f2SSimon Glass            no_subdirs: Don't create subdirectories when building current
229bb1501f2SSimon Glass                source for a single board
230bb1501f2SSimon Glass            full_path: Return the full path in CROSS_COMPILE and don't set
231bb1501f2SSimon Glass                PATH
232d2ce658dSSimon Glass            verbose_build: Run build with V=1 and don't use 'make -s'
233f79f1e0cSStephen Warren            incremental: Always perform incremental builds; don't run make
234f79f1e0cSStephen Warren                mrproper when configuring
235f79f1e0cSStephen Warren            per_board_out_dir: Build in a separate persistent directory per
236f79f1e0cSStephen Warren                board rather than a thread-specific directory
237b50113f3SSimon Glass            config_only: Only configure each build, don't build it
238b464f8e7SSimon Glass            squash_config_y: Convert CONFIG options with the value 'y' to '1'
239fc3fe1c2SSimon Glass        """
240fc3fe1c2SSimon Glass        self.toolchains = toolchains
241fc3fe1c2SSimon Glass        self.base_dir = base_dir
242fc3fe1c2SSimon Glass        self._working_dir = os.path.join(base_dir, '.bm-work')
243fc3fe1c2SSimon Glass        self.threads = []
244fc3fe1c2SSimon Glass        self.do_make = self.Make
24599796923SMasahiro Yamada        self.gnu_make = gnu_make
246fc3fe1c2SSimon Glass        self.checkout = checkout
247fc3fe1c2SSimon Glass        self.num_threads = num_threads
248fc3fe1c2SSimon Glass        self.num_jobs = num_jobs
249fc3fe1c2SSimon Glass        self.already_done = 0
250fc3fe1c2SSimon Glass        self.force_build = False
251fc3fe1c2SSimon Glass        self.git_dir = git_dir
252fc3fe1c2SSimon Glass        self._show_unknown = show_unknown
253fc3fe1c2SSimon Glass        self._timestamp_count = 10
254fc3fe1c2SSimon Glass        self._build_period_us = None
255fc3fe1c2SSimon Glass        self._complete_delay = None
256fc3fe1c2SSimon Glass        self._next_delay_update = datetime.now()
257fc3fe1c2SSimon Glass        self.force_config_on_failure = True
2584266dc28SSimon Glass        self.force_build_failures = False
25997e91526SSimon Glass        self.force_reconfig = False
260fc3fe1c2SSimon Glass        self._step = step
261189a4968SSimon Glass        self.in_tree = False
26228370c1bSSimon Glass        self._error_lines = 0
2635971ab5cSSimon Glass        self.no_subdirs = no_subdirs
264bb1501f2SSimon Glass        self.full_path = full_path
265d2ce658dSSimon Glass        self.verbose_build = verbose_build
266b50113f3SSimon Glass        self.config_only = config_only
267b464f8e7SSimon Glass        self.squash_config_y = squash_config_y
268b464f8e7SSimon Glass        self.config_filenames = BASE_CONFIG_FILENAMES
269b464f8e7SSimon Glass        if not self.squash_config_y:
270b464f8e7SSimon Glass            self.config_filenames += EXTRA_CONFIG_FILENAMES
271fc3fe1c2SSimon Glass
272fc3fe1c2SSimon Glass        self.col = terminal.Color()
273fc3fe1c2SSimon Glass
274e30965dbSSimon Glass        self._re_function = re.compile('(.*): In function.*')
275e30965dbSSimon Glass        self._re_files = re.compile('In file included from.*')
276e30965dbSSimon Glass        self._re_warning = re.compile('(.*):(\d*):(\d*): warning: .*')
277e30965dbSSimon Glass        self._re_note = re.compile('(.*):(\d*):(\d*): note: this is the location of the previous.*')
278e30965dbSSimon Glass
279fc3fe1c2SSimon Glass        self.queue = Queue.Queue()
280fc3fe1c2SSimon Glass        self.out_queue = Queue.Queue()
281fc3fe1c2SSimon Glass        for i in range(self.num_threads):
282f79f1e0cSStephen Warren            t = builderthread.BuilderThread(self, i, incremental,
283f79f1e0cSStephen Warren                    per_board_out_dir)
284fc3fe1c2SSimon Glass            t.setDaemon(True)
285fc3fe1c2SSimon Glass            t.start()
286fc3fe1c2SSimon Glass            self.threads.append(t)
287fc3fe1c2SSimon Glass
288fc3fe1c2SSimon Glass        self.last_line_len = 0
289190064b4SSimon Glass        t = builderthread.ResultThread(self)
290fc3fe1c2SSimon Glass        t.setDaemon(True)
291fc3fe1c2SSimon Glass        t.start()
292fc3fe1c2SSimon Glass        self.threads.append(t)
293fc3fe1c2SSimon Glass
294fc3fe1c2SSimon Glass        ignore_lines = ['(make.*Waiting for unfinished)', '(Segmentation fault)']
295fc3fe1c2SSimon Glass        self.re_make_err = re.compile('|'.join(ignore_lines))
296fc3fe1c2SSimon Glass
2972f256648SSimon Glass        # Handle existing graceful with SIGINT / Ctrl-C
2982f256648SSimon Glass        signal.signal(signal.SIGINT, self.signal_handler)
2992f256648SSimon Glass
300fc3fe1c2SSimon Glass    def __del__(self):
301fc3fe1c2SSimon Glass        """Get rid of all threads created by the builder"""
302fc3fe1c2SSimon Glass        for t in self.threads:
303fc3fe1c2SSimon Glass            del t
304fc3fe1c2SSimon Glass
3052f256648SSimon Glass    def signal_handler(self, signal, frame):
3062f256648SSimon Glass        sys.exit(1)
3072f256648SSimon Glass
308b2ea7ab2SSimon Glass    def SetDisplayOptions(self, show_errors=False, show_sizes=False,
309ed966657SSimon Glass                          show_detail=False, show_bloat=False,
310843312dcSSimon Glass                          list_error_boards=False, show_config=False):
311b2ea7ab2SSimon Glass        """Setup display options for the builder.
312b2ea7ab2SSimon Glass
313b2ea7ab2SSimon Glass        show_errors: True to show summarised error/warning info
314b2ea7ab2SSimon Glass        show_sizes: Show size deltas
315b2ea7ab2SSimon Glass        show_detail: Show detail for each board
316b2ea7ab2SSimon Glass        show_bloat: Show detail for each function
317ed966657SSimon Glass        list_error_boards: Show the boards which caused each error/warning
318843312dcSSimon Glass        show_config: Show config deltas
319b2ea7ab2SSimon Glass        """
320b2ea7ab2SSimon Glass        self._show_errors = show_errors
321b2ea7ab2SSimon Glass        self._show_sizes = show_sizes
322b2ea7ab2SSimon Glass        self._show_detail = show_detail
323b2ea7ab2SSimon Glass        self._show_bloat = show_bloat
324ed966657SSimon Glass        self._list_error_boards = list_error_boards
325843312dcSSimon Glass        self._show_config = show_config
326b2ea7ab2SSimon Glass
327fc3fe1c2SSimon Glass    def _AddTimestamp(self):
328fc3fe1c2SSimon Glass        """Add a new timestamp to the list and record the build period.
329fc3fe1c2SSimon Glass
330fc3fe1c2SSimon Glass        The build period is the length of time taken to perform a single
331fc3fe1c2SSimon Glass        build (one board, one commit).
332fc3fe1c2SSimon Glass        """
333fc3fe1c2SSimon Glass        now = datetime.now()
334fc3fe1c2SSimon Glass        self._timestamps.append(now)
335fc3fe1c2SSimon Glass        count = len(self._timestamps)
336fc3fe1c2SSimon Glass        delta = self._timestamps[-1] - self._timestamps[0]
337fc3fe1c2SSimon Glass        seconds = delta.total_seconds()
338fc3fe1c2SSimon Glass
339fc3fe1c2SSimon Glass        # If we have enough data, estimate build period (time taken for a
340fc3fe1c2SSimon Glass        # single build) and therefore completion time.
341fc3fe1c2SSimon Glass        if count > 1 and self._next_delay_update < now:
342fc3fe1c2SSimon Glass            self._next_delay_update = now + timedelta(seconds=2)
343fc3fe1c2SSimon Glass            if seconds > 0:
344fc3fe1c2SSimon Glass                self._build_period = float(seconds) / count
345fc3fe1c2SSimon Glass                todo = self.count - self.upto
346fc3fe1c2SSimon Glass                self._complete_delay = timedelta(microseconds=
347fc3fe1c2SSimon Glass                        self._build_period * todo * 1000000)
348fc3fe1c2SSimon Glass                # Round it
349fc3fe1c2SSimon Glass                self._complete_delay -= timedelta(
350fc3fe1c2SSimon Glass                        microseconds=self._complete_delay.microseconds)
351fc3fe1c2SSimon Glass
352fc3fe1c2SSimon Glass        if seconds > 60:
353fc3fe1c2SSimon Glass            self._timestamps.popleft()
354fc3fe1c2SSimon Glass            count -= 1
355fc3fe1c2SSimon Glass
356fc3fe1c2SSimon Glass    def ClearLine(self, length):
357fc3fe1c2SSimon Glass        """Clear any characters on the current line
358fc3fe1c2SSimon Glass
359fc3fe1c2SSimon Glass        Make way for a new line of length 'length', by outputting enough
360fc3fe1c2SSimon Glass        spaces to clear out the old line. Then remember the new length for
361fc3fe1c2SSimon Glass        next time.
362fc3fe1c2SSimon Glass
363fc3fe1c2SSimon Glass        Args:
364fc3fe1c2SSimon Glass            length: Length of new line, in characters
365fc3fe1c2SSimon Glass        """
366fc3fe1c2SSimon Glass        if length < self.last_line_len:
3674653a882SSimon Glass            Print(' ' * (self.last_line_len - length), newline=False)
3684653a882SSimon Glass            Print('\r', newline=False)
369fc3fe1c2SSimon Glass        self.last_line_len = length
370fc3fe1c2SSimon Glass        sys.stdout.flush()
371fc3fe1c2SSimon Glass
372fc3fe1c2SSimon Glass    def SelectCommit(self, commit, checkout=True):
373fc3fe1c2SSimon Glass        """Checkout the selected commit for this build
374fc3fe1c2SSimon Glass        """
375fc3fe1c2SSimon Glass        self.commit = commit
376fc3fe1c2SSimon Glass        if checkout and self.checkout:
377fc3fe1c2SSimon Glass            gitutil.Checkout(commit.hash)
378fc3fe1c2SSimon Glass
379fc3fe1c2SSimon Glass    def Make(self, commit, brd, stage, cwd, *args, **kwargs):
380fc3fe1c2SSimon Glass        """Run make
381fc3fe1c2SSimon Glass
382fc3fe1c2SSimon Glass        Args:
383fc3fe1c2SSimon Glass            commit: Commit object that is being built
384fc3fe1c2SSimon Glass            brd: Board object that is being built
385fd18a89eSRoger Meier            stage: Stage that we are at (mrproper, config, build)
386fc3fe1c2SSimon Glass            cwd: Directory where make should be run
387fc3fe1c2SSimon Glass            args: Arguments to pass to make
388fc3fe1c2SSimon Glass            kwargs: Arguments to pass to command.RunPipe()
389fc3fe1c2SSimon Glass        """
39099796923SMasahiro Yamada        cmd = [self.gnu_make] + list(args)
391fc3fe1c2SSimon Glass        result = command.RunPipe([cmd], capture=True, capture_stderr=True,
392fc3fe1c2SSimon Glass                cwd=cwd, raise_on_error=False, **kwargs)
39340f11fceSSimon Glass        if self.verbose_build:
39440f11fceSSimon Glass            result.stdout = '%s\n' % (' '.join(cmd)) + result.stdout
39540f11fceSSimon Glass            result.combined = '%s\n' % (' '.join(cmd)) + result.combined
396fc3fe1c2SSimon Glass        return result
397fc3fe1c2SSimon Glass
398fc3fe1c2SSimon Glass    def ProcessResult(self, result):
399fc3fe1c2SSimon Glass        """Process the result of a build, showing progress information
400fc3fe1c2SSimon Glass
401fc3fe1c2SSimon Glass        Args:
402e5a0e5d8SSimon Glass            result: A CommandResult object, which indicates the result for
403e5a0e5d8SSimon Glass                    a single build
404fc3fe1c2SSimon Glass        """
405fc3fe1c2SSimon Glass        col = terminal.Color()
406fc3fe1c2SSimon Glass        if result:
407fc3fe1c2SSimon Glass            target = result.brd.target
408fc3fe1c2SSimon Glass
409fc3fe1c2SSimon Glass            self.upto += 1
410fc3fe1c2SSimon Glass            if result.return_code != 0:
411fc3fe1c2SSimon Glass                self.fail += 1
412fc3fe1c2SSimon Glass            elif result.stderr:
413fc3fe1c2SSimon Glass                self.warned += 1
414fc3fe1c2SSimon Glass            if result.already_done:
415fc3fe1c2SSimon Glass                self.already_done += 1
416e5a0e5d8SSimon Glass            if self._verbose:
4174653a882SSimon Glass                Print('\r', newline=False)
418e5a0e5d8SSimon Glass                self.ClearLine(0)
419e5a0e5d8SSimon Glass                boards_selected = {target : result.brd}
420e5a0e5d8SSimon Glass                self.ResetResultSummary(boards_selected)
421e5a0e5d8SSimon Glass                self.ProduceResultSummary(result.commit_upto, self.commits,
422e5a0e5d8SSimon Glass                                          boards_selected)
423fc3fe1c2SSimon Glass        else:
424fc3fe1c2SSimon Glass            target = '(starting)'
425fc3fe1c2SSimon Glass
426fc3fe1c2SSimon Glass        # Display separate counts for ok, warned and fail
427fc3fe1c2SSimon Glass        ok = self.upto - self.warned - self.fail
428fc3fe1c2SSimon Glass        line = '\r' + self.col.Color(self.col.GREEN, '%5d' % ok)
429fc3fe1c2SSimon Glass        line += self.col.Color(self.col.YELLOW, '%5d' % self.warned)
430fc3fe1c2SSimon Glass        line += self.col.Color(self.col.RED, '%5d' % self.fail)
431fc3fe1c2SSimon Glass
432fc3fe1c2SSimon Glass        name = ' /%-5d  ' % self.count
433fc3fe1c2SSimon Glass
434fc3fe1c2SSimon Glass        # Add our current completion time estimate
435fc3fe1c2SSimon Glass        self._AddTimestamp()
436fc3fe1c2SSimon Glass        if self._complete_delay:
437fc3fe1c2SSimon Glass            name += '%s  : ' % self._complete_delay
438fc3fe1c2SSimon Glass        # When building all boards for a commit, we can print a commit
439fc3fe1c2SSimon Glass        # progress message.
440fc3fe1c2SSimon Glass        if result and result.commit_upto is None:
441fc3fe1c2SSimon Glass            name += 'commit %2d/%-3d' % (self.commit_upto + 1,
442fc3fe1c2SSimon Glass                    self.commit_count)
443fc3fe1c2SSimon Glass
444fc3fe1c2SSimon Glass        name += target
4454653a882SSimon Glass        Print(line + name, newline=False)
446*960421ecSSimon Glass        length = 16 + len(name)
447fc3fe1c2SSimon Glass        self.ClearLine(length)
448fc3fe1c2SSimon Glass
449fc3fe1c2SSimon Glass    def _GetOutputDir(self, commit_upto):
450fc3fe1c2SSimon Glass        """Get the name of the output directory for a commit number
451fc3fe1c2SSimon Glass
452fc3fe1c2SSimon Glass        The output directory is typically .../<branch>/<commit>.
453fc3fe1c2SSimon Glass
454fc3fe1c2SSimon Glass        Args:
455fc3fe1c2SSimon Glass            commit_upto: Commit number to use (0..self.count-1)
456fc3fe1c2SSimon Glass        """
4575971ab5cSSimon Glass        commit_dir = None
458fea5858eSSimon Glass        if self.commits:
459fc3fe1c2SSimon Glass            commit = self.commits[commit_upto]
460fc3fe1c2SSimon Glass            subject = commit.subject.translate(trans_valid_chars)
461fc3fe1c2SSimon Glass            commit_dir = ('%02d_of_%02d_g%s_%s' % (commit_upto + 1,
462fc3fe1c2SSimon Glass                    self.commit_count, commit.hash, subject[:20]))
4635971ab5cSSimon Glass        elif not self.no_subdirs:
464fea5858eSSimon Glass            commit_dir = 'current'
4655971ab5cSSimon Glass        if not commit_dir:
4665971ab5cSSimon Glass            return self.base_dir
4675971ab5cSSimon Glass        return os.path.join(self.base_dir, commit_dir)
468fc3fe1c2SSimon Glass
469fc3fe1c2SSimon Glass    def GetBuildDir(self, commit_upto, target):
470fc3fe1c2SSimon Glass        """Get the name of the build directory for a commit number
471fc3fe1c2SSimon Glass
472fc3fe1c2SSimon Glass        The build directory is typically .../<branch>/<commit>/<target>.
473fc3fe1c2SSimon Glass
474fc3fe1c2SSimon Glass        Args:
475fc3fe1c2SSimon Glass            commit_upto: Commit number to use (0..self.count-1)
476fc3fe1c2SSimon Glass            target: Target name
477fc3fe1c2SSimon Glass        """
478fc3fe1c2SSimon Glass        output_dir = self._GetOutputDir(commit_upto)
479fc3fe1c2SSimon Glass        return os.path.join(output_dir, target)
480fc3fe1c2SSimon Glass
481fc3fe1c2SSimon Glass    def GetDoneFile(self, commit_upto, target):
482fc3fe1c2SSimon Glass        """Get the name of the done file for a commit number
483fc3fe1c2SSimon Glass
484fc3fe1c2SSimon Glass        Args:
485fc3fe1c2SSimon Glass            commit_upto: Commit number to use (0..self.count-1)
486fc3fe1c2SSimon Glass            target: Target name
487fc3fe1c2SSimon Glass        """
488fc3fe1c2SSimon Glass        return os.path.join(self.GetBuildDir(commit_upto, target), 'done')
489fc3fe1c2SSimon Glass
490fc3fe1c2SSimon Glass    def GetSizesFile(self, commit_upto, target):
491fc3fe1c2SSimon Glass        """Get the name of the sizes file for a commit number
492fc3fe1c2SSimon Glass
493fc3fe1c2SSimon Glass        Args:
494fc3fe1c2SSimon Glass            commit_upto: Commit number to use (0..self.count-1)
495fc3fe1c2SSimon Glass            target: Target name
496fc3fe1c2SSimon Glass        """
497fc3fe1c2SSimon Glass        return os.path.join(self.GetBuildDir(commit_upto, target), 'sizes')
498fc3fe1c2SSimon Glass
499fc3fe1c2SSimon Glass    def GetFuncSizesFile(self, commit_upto, target, elf_fname):
500fc3fe1c2SSimon Glass        """Get the name of the funcsizes file for a commit number and ELF file
501fc3fe1c2SSimon Glass
502fc3fe1c2SSimon Glass        Args:
503fc3fe1c2SSimon Glass            commit_upto: Commit number to use (0..self.count-1)
504fc3fe1c2SSimon Glass            target: Target name
505fc3fe1c2SSimon Glass            elf_fname: Filename of elf image
506fc3fe1c2SSimon Glass        """
507fc3fe1c2SSimon Glass        return os.path.join(self.GetBuildDir(commit_upto, target),
508fc3fe1c2SSimon Glass                            '%s.sizes' % elf_fname.replace('/', '-'))
509fc3fe1c2SSimon Glass
510fc3fe1c2SSimon Glass    def GetObjdumpFile(self, commit_upto, target, elf_fname):
511fc3fe1c2SSimon Glass        """Get the name of the objdump file for a commit number and ELF file
512fc3fe1c2SSimon Glass
513fc3fe1c2SSimon Glass        Args:
514fc3fe1c2SSimon Glass            commit_upto: Commit number to use (0..self.count-1)
515fc3fe1c2SSimon Glass            target: Target name
516fc3fe1c2SSimon Glass            elf_fname: Filename of elf image
517fc3fe1c2SSimon Glass        """
518fc3fe1c2SSimon Glass        return os.path.join(self.GetBuildDir(commit_upto, target),
519fc3fe1c2SSimon Glass                            '%s.objdump' % elf_fname.replace('/', '-'))
520fc3fe1c2SSimon Glass
521fc3fe1c2SSimon Glass    def GetErrFile(self, commit_upto, target):
522fc3fe1c2SSimon Glass        """Get the name of the err file for a commit number
523fc3fe1c2SSimon Glass
524fc3fe1c2SSimon Glass        Args:
525fc3fe1c2SSimon Glass            commit_upto: Commit number to use (0..self.count-1)
526fc3fe1c2SSimon Glass            target: Target name
527fc3fe1c2SSimon Glass        """
528fc3fe1c2SSimon Glass        output_dir = self.GetBuildDir(commit_upto, target)
529fc3fe1c2SSimon Glass        return os.path.join(output_dir, 'err')
530fc3fe1c2SSimon Glass
531fc3fe1c2SSimon Glass    def FilterErrors(self, lines):
532fc3fe1c2SSimon Glass        """Filter out errors in which we have no interest
533fc3fe1c2SSimon Glass
534fc3fe1c2SSimon Glass        We should probably use map().
535fc3fe1c2SSimon Glass
536fc3fe1c2SSimon Glass        Args:
537fc3fe1c2SSimon Glass            lines: List of error lines, each a string
538fc3fe1c2SSimon Glass        Returns:
539fc3fe1c2SSimon Glass            New list with only interesting lines included
540fc3fe1c2SSimon Glass        """
541fc3fe1c2SSimon Glass        out_lines = []
542fc3fe1c2SSimon Glass        for line in lines:
543fc3fe1c2SSimon Glass            if not self.re_make_err.search(line):
544fc3fe1c2SSimon Glass                out_lines.append(line)
545fc3fe1c2SSimon Glass        return out_lines
546fc3fe1c2SSimon Glass
547fc3fe1c2SSimon Glass    def ReadFuncSizes(self, fname, fd):
548fc3fe1c2SSimon Glass        """Read function sizes from the output of 'nm'
549fc3fe1c2SSimon Glass
550fc3fe1c2SSimon Glass        Args:
551fc3fe1c2SSimon Glass            fd: File containing data to read
552fc3fe1c2SSimon Glass            fname: Filename we are reading from (just for errors)
553fc3fe1c2SSimon Glass
554fc3fe1c2SSimon Glass        Returns:
555fc3fe1c2SSimon Glass            Dictionary containing size of each function in bytes, indexed by
556fc3fe1c2SSimon Glass            function name.
557fc3fe1c2SSimon Glass        """
558fc3fe1c2SSimon Glass        sym = {}
559fc3fe1c2SSimon Glass        for line in fd.readlines():
560fc3fe1c2SSimon Glass            try:
561fc3fe1c2SSimon Glass                size, type, name = line[:-1].split()
562fc3fe1c2SSimon Glass            except:
5634653a882SSimon Glass                Print("Invalid line in file '%s': '%s'" % (fname, line[:-1]))
564fc3fe1c2SSimon Glass                continue
565fc3fe1c2SSimon Glass            if type in 'tTdDbB':
566fc3fe1c2SSimon Glass                # function names begin with '.' on 64-bit powerpc
567fc3fe1c2SSimon Glass                if '.' in name[1:]:
568fc3fe1c2SSimon Glass                    name = 'static.' + name.split('.')[0]
569fc3fe1c2SSimon Glass                sym[name] = sym.get(name, 0) + int(size, 16)
570fc3fe1c2SSimon Glass        return sym
571fc3fe1c2SSimon Glass
572843312dcSSimon Glass    def _ProcessConfig(self, fname):
573843312dcSSimon Glass        """Read in a .config, autoconf.mk or autoconf.h file
574843312dcSSimon Glass
575843312dcSSimon Glass        This function handles all config file types. It ignores comments and
576843312dcSSimon Glass        any #defines which don't start with CONFIG_.
577843312dcSSimon Glass
578843312dcSSimon Glass        Args:
579843312dcSSimon Glass            fname: Filename to read
580843312dcSSimon Glass
581843312dcSSimon Glass        Returns:
582843312dcSSimon Glass            Dictionary:
583843312dcSSimon Glass                key: Config name (e.g. CONFIG_DM)
584843312dcSSimon Glass                value: Config value (e.g. 1)
585843312dcSSimon Glass        """
586843312dcSSimon Glass        config = {}
587843312dcSSimon Glass        if os.path.exists(fname):
588843312dcSSimon Glass            with open(fname) as fd:
589843312dcSSimon Glass                for line in fd:
590843312dcSSimon Glass                    line = line.strip()
591843312dcSSimon Glass                    if line.startswith('#define'):
592843312dcSSimon Glass                        values = line[8:].split(' ', 1)
593843312dcSSimon Glass                        if len(values) > 1:
594843312dcSSimon Glass                            key, value = values
595843312dcSSimon Glass                        else:
596843312dcSSimon Glass                            key = values[0]
597b464f8e7SSimon Glass                            value = '1' if self.squash_config_y else ''
598843312dcSSimon Glass                        if not key.startswith('CONFIG_'):
599843312dcSSimon Glass                            continue
600843312dcSSimon Glass                    elif not line or line[0] in ['#', '*', '/']:
601843312dcSSimon Glass                        continue
602843312dcSSimon Glass                    else:
603843312dcSSimon Glass                        key, value = line.split('=', 1)
604b464f8e7SSimon Glass                    if self.squash_config_y and value == 'y':
605b464f8e7SSimon Glass                        value = '1'
606843312dcSSimon Glass                    config[key] = value
607843312dcSSimon Glass        return config
608843312dcSSimon Glass
609843312dcSSimon Glass    def GetBuildOutcome(self, commit_upto, target, read_func_sizes,
610843312dcSSimon Glass                        read_config):
611fc3fe1c2SSimon Glass        """Work out the outcome of a build.
612fc3fe1c2SSimon Glass
613fc3fe1c2SSimon Glass        Args:
614fc3fe1c2SSimon Glass            commit_upto: Commit number to check (0..n-1)
615fc3fe1c2SSimon Glass            target: Target board to check
616fc3fe1c2SSimon Glass            read_func_sizes: True to read function size information
617843312dcSSimon Glass            read_config: True to read .config and autoconf.h files
618fc3fe1c2SSimon Glass
619fc3fe1c2SSimon Glass        Returns:
620fc3fe1c2SSimon Glass            Outcome object
621fc3fe1c2SSimon Glass        """
622fc3fe1c2SSimon Glass        done_file = self.GetDoneFile(commit_upto, target)
623fc3fe1c2SSimon Glass        sizes_file = self.GetSizesFile(commit_upto, target)
624fc3fe1c2SSimon Glass        sizes = {}
625fc3fe1c2SSimon Glass        func_sizes = {}
626843312dcSSimon Glass        config = {}
627fc3fe1c2SSimon Glass        if os.path.exists(done_file):
628fc3fe1c2SSimon Glass            with open(done_file, 'r') as fd:
629fc3fe1c2SSimon Glass                return_code = int(fd.readline())
630fc3fe1c2SSimon Glass                err_lines = []
631fc3fe1c2SSimon Glass                err_file = self.GetErrFile(commit_upto, target)
632fc3fe1c2SSimon Glass                if os.path.exists(err_file):
633fc3fe1c2SSimon Glass                    with open(err_file, 'r') as fd:
634fc3fe1c2SSimon Glass                        err_lines = self.FilterErrors(fd.readlines())
635fc3fe1c2SSimon Glass
636fc3fe1c2SSimon Glass                # Decide whether the build was ok, failed or created warnings
637fc3fe1c2SSimon Glass                if return_code:
638fc3fe1c2SSimon Glass                    rc = OUTCOME_ERROR
639fc3fe1c2SSimon Glass                elif len(err_lines):
640fc3fe1c2SSimon Glass                    rc = OUTCOME_WARNING
641fc3fe1c2SSimon Glass                else:
642fc3fe1c2SSimon Glass                    rc = OUTCOME_OK
643fc3fe1c2SSimon Glass
644fc3fe1c2SSimon Glass                # Convert size information to our simple format
645fc3fe1c2SSimon Glass                if os.path.exists(sizes_file):
646fc3fe1c2SSimon Glass                    with open(sizes_file, 'r') as fd:
647fc3fe1c2SSimon Glass                        for line in fd.readlines():
648fc3fe1c2SSimon Glass                            values = line.split()
649fc3fe1c2SSimon Glass                            rodata = 0
650fc3fe1c2SSimon Glass                            if len(values) > 6:
651fc3fe1c2SSimon Glass                                rodata = int(values[6], 16)
652fc3fe1c2SSimon Glass                            size_dict = {
653fc3fe1c2SSimon Glass                                'all' : int(values[0]) + int(values[1]) +
654fc3fe1c2SSimon Glass                                        int(values[2]),
655fc3fe1c2SSimon Glass                                'text' : int(values[0]) - rodata,
656fc3fe1c2SSimon Glass                                'data' : int(values[1]),
657fc3fe1c2SSimon Glass                                'bss' : int(values[2]),
658fc3fe1c2SSimon Glass                                'rodata' : rodata,
659fc3fe1c2SSimon Glass                            }
660fc3fe1c2SSimon Glass                            sizes[values[5]] = size_dict
661fc3fe1c2SSimon Glass
662fc3fe1c2SSimon Glass            if read_func_sizes:
663fc3fe1c2SSimon Glass                pattern = self.GetFuncSizesFile(commit_upto, target, '*')
664fc3fe1c2SSimon Glass                for fname in glob.glob(pattern):
665fc3fe1c2SSimon Glass                    with open(fname, 'r') as fd:
666fc3fe1c2SSimon Glass                        dict_name = os.path.basename(fname).replace('.sizes',
667fc3fe1c2SSimon Glass                                                                    '')
668fc3fe1c2SSimon Glass                        func_sizes[dict_name] = self.ReadFuncSizes(fname, fd)
669fc3fe1c2SSimon Glass
670843312dcSSimon Glass            if read_config:
671843312dcSSimon Glass                output_dir = self.GetBuildDir(commit_upto, target)
672b464f8e7SSimon Glass                for name in self.config_filenames:
673843312dcSSimon Glass                    fname = os.path.join(output_dir, name)
674843312dcSSimon Glass                    config[name] = self._ProcessConfig(fname)
675fc3fe1c2SSimon Glass
676843312dcSSimon Glass            return Builder.Outcome(rc, err_lines, sizes, func_sizes, config)
677fc3fe1c2SSimon Glass
678843312dcSSimon Glass        return Builder.Outcome(OUTCOME_UNKNOWN, [], {}, {}, {})
679843312dcSSimon Glass
680843312dcSSimon Glass    def GetResultSummary(self, boards_selected, commit_upto, read_func_sizes,
681843312dcSSimon Glass                         read_config):
682fc3fe1c2SSimon Glass        """Calculate a summary of the results of building a commit.
683fc3fe1c2SSimon Glass
684fc3fe1c2SSimon Glass        Args:
685fc3fe1c2SSimon Glass            board_selected: Dict containing boards to summarise
686fc3fe1c2SSimon Glass            commit_upto: Commit number to summarize (0..self.count-1)
687fc3fe1c2SSimon Glass            read_func_sizes: True to read function size information
688843312dcSSimon Glass            read_config: True to read .config and autoconf.h files
689fc3fe1c2SSimon Glass
690fc3fe1c2SSimon Glass        Returns:
691fc3fe1c2SSimon Glass            Tuple:
692fc3fe1c2SSimon Glass                Dict containing boards which passed building this commit.
693fc3fe1c2SSimon Glass                    keyed by board.target
694e30965dbSSimon Glass                List containing a summary of error lines
695ed966657SSimon Glass                Dict keyed by error line, containing a list of the Board
696ed966657SSimon Glass                    objects with that error
697e30965dbSSimon Glass                List containing a summary of warning lines
698e30965dbSSimon Glass                Dict keyed by error line, containing a list of the Board
699e30965dbSSimon Glass                    objects with that warning
7008270e3c1SSimon Glass                Dictionary keyed by board.target. Each value is a dictionary:
7018270e3c1SSimon Glass                    key: filename - e.g. '.config'
702843312dcSSimon Glass                    value is itself a dictionary:
703843312dcSSimon Glass                        key: config name
704843312dcSSimon Glass                        value: config value
705fc3fe1c2SSimon Glass        """
706e30965dbSSimon Glass        def AddLine(lines_summary, lines_boards, line, board):
707e30965dbSSimon Glass            line = line.rstrip()
708e30965dbSSimon Glass            if line in lines_boards:
709e30965dbSSimon Glass                lines_boards[line].append(board)
710e30965dbSSimon Glass            else:
711e30965dbSSimon Glass                lines_boards[line] = [board]
712e30965dbSSimon Glass                lines_summary.append(line)
713e30965dbSSimon Glass
714fc3fe1c2SSimon Glass        board_dict = {}
715fc3fe1c2SSimon Glass        err_lines_summary = []
716ed966657SSimon Glass        err_lines_boards = {}
717e30965dbSSimon Glass        warn_lines_summary = []
718e30965dbSSimon Glass        warn_lines_boards = {}
719843312dcSSimon Glass        config = {}
720fc3fe1c2SSimon Glass
721fc3fe1c2SSimon Glass        for board in boards_selected.itervalues():
722fc3fe1c2SSimon Glass            outcome = self.GetBuildOutcome(commit_upto, board.target,
723843312dcSSimon Glass                                           read_func_sizes, read_config)
724fc3fe1c2SSimon Glass            board_dict[board.target] = outcome
725e30965dbSSimon Glass            last_func = None
726e30965dbSSimon Glass            last_was_warning = False
727e30965dbSSimon Glass            for line in outcome.err_lines:
728e30965dbSSimon Glass                if line:
729e30965dbSSimon Glass                    if (self._re_function.match(line) or
730e30965dbSSimon Glass                            self._re_files.match(line)):
731e30965dbSSimon Glass                        last_func = line
732ed966657SSimon Glass                    else:
733e30965dbSSimon Glass                        is_warning = self._re_warning.match(line)
734e30965dbSSimon Glass                        is_note = self._re_note.match(line)
735e30965dbSSimon Glass                        if is_warning or (last_was_warning and is_note):
736e30965dbSSimon Glass                            if last_func:
737e30965dbSSimon Glass                                AddLine(warn_lines_summary, warn_lines_boards,
738e30965dbSSimon Glass                                        last_func, board)
739e30965dbSSimon Glass                            AddLine(warn_lines_summary, warn_lines_boards,
740e30965dbSSimon Glass                                    line, board)
741e30965dbSSimon Glass                        else:
742e30965dbSSimon Glass                            if last_func:
743e30965dbSSimon Glass                                AddLine(err_lines_summary, err_lines_boards,
744e30965dbSSimon Glass                                        last_func, board)
745e30965dbSSimon Glass                            AddLine(err_lines_summary, err_lines_boards,
746e30965dbSSimon Glass                                    line, board)
747e30965dbSSimon Glass                        last_was_warning = is_warning
748e30965dbSSimon Glass                        last_func = None
749b464f8e7SSimon Glass            tconfig = Config(self.config_filenames, board.target)
750b464f8e7SSimon Glass            for fname in self.config_filenames:
751843312dcSSimon Glass                if outcome.config:
752843312dcSSimon Glass                    for key, value in outcome.config[fname].iteritems():
7538270e3c1SSimon Glass                        tconfig.Add(fname, key, value)
7548270e3c1SSimon Glass            config[board.target] = tconfig
755843312dcSSimon Glass
756e30965dbSSimon Glass        return (board_dict, err_lines_summary, err_lines_boards,
757843312dcSSimon Glass                warn_lines_summary, warn_lines_boards, config)
758fc3fe1c2SSimon Glass
759fc3fe1c2SSimon Glass    def AddOutcome(self, board_dict, arch_list, changes, char, color):
760fc3fe1c2SSimon Glass        """Add an output to our list of outcomes for each architecture
761fc3fe1c2SSimon Glass
762fc3fe1c2SSimon Glass        This simple function adds failing boards (changes) to the
763fc3fe1c2SSimon Glass        relevant architecture string, so we can print the results out
764fc3fe1c2SSimon Glass        sorted by architecture.
765fc3fe1c2SSimon Glass
766fc3fe1c2SSimon Glass        Args:
767fc3fe1c2SSimon Glass             board_dict: Dict containing all boards
768fc3fe1c2SSimon Glass             arch_list: Dict keyed by arch name. Value is a string containing
769fc3fe1c2SSimon Glass                    a list of board names which failed for that arch.
770fc3fe1c2SSimon Glass             changes: List of boards to add to arch_list
771fc3fe1c2SSimon Glass             color: terminal.Colour object
772fc3fe1c2SSimon Glass        """
773fc3fe1c2SSimon Glass        done_arch = {}
774fc3fe1c2SSimon Glass        for target in changes:
775fc3fe1c2SSimon Glass            if target in board_dict:
776fc3fe1c2SSimon Glass                arch = board_dict[target].arch
777fc3fe1c2SSimon Glass            else:
778fc3fe1c2SSimon Glass                arch = 'unknown'
779fc3fe1c2SSimon Glass            str = self.col.Color(color, ' ' + target)
780fc3fe1c2SSimon Glass            if not arch in done_arch:
78163c619eeSSimon Glass                str = ' %s  %s' % (self.col.Color(color, char), str)
782fc3fe1c2SSimon Glass                done_arch[arch] = True
783fc3fe1c2SSimon Glass            if not arch in arch_list:
784fc3fe1c2SSimon Glass                arch_list[arch] = str
785fc3fe1c2SSimon Glass            else:
786fc3fe1c2SSimon Glass                arch_list[arch] += str
787fc3fe1c2SSimon Glass
788fc3fe1c2SSimon Glass
789fc3fe1c2SSimon Glass    def ColourNum(self, num):
790fc3fe1c2SSimon Glass        color = self.col.RED if num > 0 else self.col.GREEN
791fc3fe1c2SSimon Glass        if num == 0:
792fc3fe1c2SSimon Glass            return '0'
793fc3fe1c2SSimon Glass        return self.col.Color(color, str(num))
794fc3fe1c2SSimon Glass
795fc3fe1c2SSimon Glass    def ResetResultSummary(self, board_selected):
796fc3fe1c2SSimon Glass        """Reset the results summary ready for use.
797fc3fe1c2SSimon Glass
798fc3fe1c2SSimon Glass        Set up the base board list to be all those selected, and set the
799fc3fe1c2SSimon Glass        error lines to empty.
800fc3fe1c2SSimon Glass
801fc3fe1c2SSimon Glass        Following this, calls to PrintResultSummary() will use this
802fc3fe1c2SSimon Glass        information to work out what has changed.
803fc3fe1c2SSimon Glass
804fc3fe1c2SSimon Glass        Args:
805fc3fe1c2SSimon Glass            board_selected: Dict containing boards to summarise, keyed by
806fc3fe1c2SSimon Glass                board.target
807fc3fe1c2SSimon Glass        """
808fc3fe1c2SSimon Glass        self._base_board_dict = {}
809fc3fe1c2SSimon Glass        for board in board_selected:
810843312dcSSimon Glass            self._base_board_dict[board] = Builder.Outcome(0, [], [], {}, {})
811fc3fe1c2SSimon Glass        self._base_err_lines = []
812e30965dbSSimon Glass        self._base_warn_lines = []
813e30965dbSSimon Glass        self._base_err_line_boards = {}
814e30965dbSSimon Glass        self._base_warn_line_boards = {}
8158270e3c1SSimon Glass        self._base_config = None
816fc3fe1c2SSimon Glass
817fc3fe1c2SSimon Glass    def PrintFuncSizeDetail(self, fname, old, new):
818fc3fe1c2SSimon Glass        grow, shrink, add, remove, up, down = 0, 0, 0, 0, 0, 0
819fc3fe1c2SSimon Glass        delta, common = [], {}
820fc3fe1c2SSimon Glass
821fc3fe1c2SSimon Glass        for a in old:
822fc3fe1c2SSimon Glass            if a in new:
823fc3fe1c2SSimon Glass                common[a] = 1
824fc3fe1c2SSimon Glass
825fc3fe1c2SSimon Glass        for name in old:
826fc3fe1c2SSimon Glass            if name not in common:
827fc3fe1c2SSimon Glass                remove += 1
828fc3fe1c2SSimon Glass                down += old[name]
829fc3fe1c2SSimon Glass                delta.append([-old[name], name])
830fc3fe1c2SSimon Glass
831fc3fe1c2SSimon Glass        for name in new:
832fc3fe1c2SSimon Glass            if name not in common:
833fc3fe1c2SSimon Glass                add += 1
834fc3fe1c2SSimon Glass                up += new[name]
835fc3fe1c2SSimon Glass                delta.append([new[name], name])
836fc3fe1c2SSimon Glass
837fc3fe1c2SSimon Glass        for name in common:
838fc3fe1c2SSimon Glass                diff = new.get(name, 0) - old.get(name, 0)
839fc3fe1c2SSimon Glass                if diff > 0:
840fc3fe1c2SSimon Glass                    grow, up = grow + 1, up + diff
841fc3fe1c2SSimon Glass                elif diff < 0:
842fc3fe1c2SSimon Glass                    shrink, down = shrink + 1, down - diff
843fc3fe1c2SSimon Glass                delta.append([diff, name])
844fc3fe1c2SSimon Glass
845fc3fe1c2SSimon Glass        delta.sort()
846fc3fe1c2SSimon Glass        delta.reverse()
847fc3fe1c2SSimon Glass
848fc3fe1c2SSimon Glass        args = [add, -remove, grow, -shrink, up, -down, up - down]
849fc3fe1c2SSimon Glass        if max(args) == 0:
850fc3fe1c2SSimon Glass            return
851fc3fe1c2SSimon Glass        args = [self.ColourNum(x) for x in args]
852fc3fe1c2SSimon Glass        indent = ' ' * 15
8534653a882SSimon Glass        Print('%s%s: add: %s/%s, grow: %s/%s bytes: %s/%s (%s)' %
854fc3fe1c2SSimon Glass              tuple([indent, self.col.Color(self.col.YELLOW, fname)] + args))
8554653a882SSimon Glass        Print('%s  %-38s %7s %7s %+7s' % (indent, 'function', 'old', 'new',
8564653a882SSimon Glass                                         'delta'))
857fc3fe1c2SSimon Glass        for diff, name in delta:
858fc3fe1c2SSimon Glass            if diff:
859fc3fe1c2SSimon Glass                color = self.col.RED if diff > 0 else self.col.GREEN
860fc3fe1c2SSimon Glass                msg = '%s  %-38s %7s %7s %+7d' % (indent, name,
861fc3fe1c2SSimon Glass                        old.get(name, '-'), new.get(name,'-'), diff)
8624653a882SSimon Glass                Print(msg, colour=color)
863fc3fe1c2SSimon Glass
864fc3fe1c2SSimon Glass
865fc3fe1c2SSimon Glass    def PrintSizeDetail(self, target_list, show_bloat):
866fc3fe1c2SSimon Glass        """Show details size information for each board
867fc3fe1c2SSimon Glass
868fc3fe1c2SSimon Glass        Args:
869fc3fe1c2SSimon Glass            target_list: List of targets, each a dict containing:
870fc3fe1c2SSimon Glass                    'target': Target name
871fc3fe1c2SSimon Glass                    'total_diff': Total difference in bytes across all areas
872fc3fe1c2SSimon Glass                    <part_name>: Difference for that part
873fc3fe1c2SSimon Glass            show_bloat: Show detail for each function
874fc3fe1c2SSimon Glass        """
875fc3fe1c2SSimon Glass        targets_by_diff = sorted(target_list, reverse=True,
876fc3fe1c2SSimon Glass        key=lambda x: x['_total_diff'])
877fc3fe1c2SSimon Glass        for result in targets_by_diff:
878fc3fe1c2SSimon Glass            printed_target = False
879fc3fe1c2SSimon Glass            for name in sorted(result):
880fc3fe1c2SSimon Glass                diff = result[name]
881fc3fe1c2SSimon Glass                if name.startswith('_'):
882fc3fe1c2SSimon Glass                    continue
883fc3fe1c2SSimon Glass                if diff != 0:
884fc3fe1c2SSimon Glass                    color = self.col.RED if diff > 0 else self.col.GREEN
885fc3fe1c2SSimon Glass                msg = ' %s %+d' % (name, diff)
886fc3fe1c2SSimon Glass                if not printed_target:
8874653a882SSimon Glass                    Print('%10s  %-15s:' % ('', result['_target']),
8884653a882SSimon Glass                          newline=False)
889fc3fe1c2SSimon Glass                    printed_target = True
8904653a882SSimon Glass                Print(msg, colour=color, newline=False)
891fc3fe1c2SSimon Glass            if printed_target:
8924653a882SSimon Glass                Print()
893fc3fe1c2SSimon Glass                if show_bloat:
894fc3fe1c2SSimon Glass                    target = result['_target']
895fc3fe1c2SSimon Glass                    outcome = result['_outcome']
896fc3fe1c2SSimon Glass                    base_outcome = self._base_board_dict[target]
897fc3fe1c2SSimon Glass                    for fname in outcome.func_sizes:
898fc3fe1c2SSimon Glass                        self.PrintFuncSizeDetail(fname,
899fc3fe1c2SSimon Glass                                                 base_outcome.func_sizes[fname],
900fc3fe1c2SSimon Glass                                                 outcome.func_sizes[fname])
901fc3fe1c2SSimon Glass
902fc3fe1c2SSimon Glass
903fc3fe1c2SSimon Glass    def PrintSizeSummary(self, board_selected, board_dict, show_detail,
904fc3fe1c2SSimon Glass                         show_bloat):
905fc3fe1c2SSimon Glass        """Print a summary of image sizes broken down by section.
906fc3fe1c2SSimon Glass
907fc3fe1c2SSimon Glass        The summary takes the form of one line per architecture. The
908fc3fe1c2SSimon Glass        line contains deltas for each of the sections (+ means the section
909fc3fe1c2SSimon Glass        got bigger, - means smaller). The nunmbers are the average number
910fc3fe1c2SSimon Glass        of bytes that a board in this section increased by.
911fc3fe1c2SSimon Glass
912fc3fe1c2SSimon Glass        For example:
913fc3fe1c2SSimon Glass           powerpc: (622 boards)   text -0.0
914fc3fe1c2SSimon Glass          arm: (285 boards)   text -0.0
915fc3fe1c2SSimon Glass          nds32: (3 boards)   text -8.0
916fc3fe1c2SSimon Glass
917fc3fe1c2SSimon Glass        Args:
918fc3fe1c2SSimon Glass            board_selected: Dict containing boards to summarise, keyed by
919fc3fe1c2SSimon Glass                board.target
920fc3fe1c2SSimon Glass            board_dict: Dict containing boards for which we built this
921fc3fe1c2SSimon Glass                commit, keyed by board.target. The value is an Outcome object.
922fc3fe1c2SSimon Glass            show_detail: Show detail for each board
923fc3fe1c2SSimon Glass            show_bloat: Show detail for each function
924fc3fe1c2SSimon Glass        """
925fc3fe1c2SSimon Glass        arch_list = {}
926fc3fe1c2SSimon Glass        arch_count = {}
927fc3fe1c2SSimon Glass
928fc3fe1c2SSimon Glass        # Calculate changes in size for different image parts
929fc3fe1c2SSimon Glass        # The previous sizes are in Board.sizes, for each board
930fc3fe1c2SSimon Glass        for target in board_dict:
931fc3fe1c2SSimon Glass            if target not in board_selected:
932fc3fe1c2SSimon Glass                continue
933fc3fe1c2SSimon Glass            base_sizes = self._base_board_dict[target].sizes
934fc3fe1c2SSimon Glass            outcome = board_dict[target]
935fc3fe1c2SSimon Glass            sizes = outcome.sizes
936fc3fe1c2SSimon Glass
937fc3fe1c2SSimon Glass            # Loop through the list of images, creating a dict of size
938fc3fe1c2SSimon Glass            # changes for each image/part. We end up with something like
939fc3fe1c2SSimon Glass            # {'target' : 'snapper9g45, 'data' : 5, 'u-boot-spl:text' : -4}
940fc3fe1c2SSimon Glass            # which means that U-Boot data increased by 5 bytes and SPL
941fc3fe1c2SSimon Glass            # text decreased by 4.
942fc3fe1c2SSimon Glass            err = {'_target' : target}
943fc3fe1c2SSimon Glass            for image in sizes:
944fc3fe1c2SSimon Glass                if image in base_sizes:
945fc3fe1c2SSimon Glass                    base_image = base_sizes[image]
946fc3fe1c2SSimon Glass                    # Loop through the text, data, bss parts
947fc3fe1c2SSimon Glass                    for part in sorted(sizes[image]):
948fc3fe1c2SSimon Glass                        diff = sizes[image][part] - base_image[part]
949fc3fe1c2SSimon Glass                        col = None
950fc3fe1c2SSimon Glass                        if diff:
951fc3fe1c2SSimon Glass                            if image == 'u-boot':
952fc3fe1c2SSimon Glass                                name = part
953fc3fe1c2SSimon Glass                            else:
954fc3fe1c2SSimon Glass                                name = image + ':' + part
955fc3fe1c2SSimon Glass                            err[name] = diff
956fc3fe1c2SSimon Glass            arch = board_selected[target].arch
957fc3fe1c2SSimon Glass            if not arch in arch_count:
958fc3fe1c2SSimon Glass                arch_count[arch] = 1
959fc3fe1c2SSimon Glass            else:
960fc3fe1c2SSimon Glass                arch_count[arch] += 1
961fc3fe1c2SSimon Glass            if not sizes:
962fc3fe1c2SSimon Glass                pass    # Only add to our list when we have some stats
963fc3fe1c2SSimon Glass            elif not arch in arch_list:
964fc3fe1c2SSimon Glass                arch_list[arch] = [err]
965fc3fe1c2SSimon Glass            else:
966fc3fe1c2SSimon Glass                arch_list[arch].append(err)
967fc3fe1c2SSimon Glass
968fc3fe1c2SSimon Glass        # We now have a list of image size changes sorted by arch
969fc3fe1c2SSimon Glass        # Print out a summary of these
970fc3fe1c2SSimon Glass        for arch, target_list in arch_list.iteritems():
971fc3fe1c2SSimon Glass            # Get total difference for each type
972fc3fe1c2SSimon Glass            totals = {}
973fc3fe1c2SSimon Glass            for result in target_list:
974fc3fe1c2SSimon Glass                total = 0
975fc3fe1c2SSimon Glass                for name, diff in result.iteritems():
976fc3fe1c2SSimon Glass                    if name.startswith('_'):
977fc3fe1c2SSimon Glass                        continue
978fc3fe1c2SSimon Glass                    total += diff
979fc3fe1c2SSimon Glass                    if name in totals:
980fc3fe1c2SSimon Glass                        totals[name] += diff
981fc3fe1c2SSimon Glass                    else:
982fc3fe1c2SSimon Glass                        totals[name] = diff
983fc3fe1c2SSimon Glass                result['_total_diff'] = total
984fc3fe1c2SSimon Glass                result['_outcome'] = board_dict[result['_target']]
985fc3fe1c2SSimon Glass
986fc3fe1c2SSimon Glass            count = len(target_list)
987fc3fe1c2SSimon Glass            printed_arch = False
988fc3fe1c2SSimon Glass            for name in sorted(totals):
989fc3fe1c2SSimon Glass                diff = totals[name]
990fc3fe1c2SSimon Glass                if diff:
991fc3fe1c2SSimon Glass                    # Display the average difference in this name for this
992fc3fe1c2SSimon Glass                    # architecture
993fc3fe1c2SSimon Glass                    avg_diff = float(diff) / count
994fc3fe1c2SSimon Glass                    color = self.col.RED if avg_diff > 0 else self.col.GREEN
995fc3fe1c2SSimon Glass                    msg = ' %s %+1.1f' % (name, avg_diff)
996fc3fe1c2SSimon Glass                    if not printed_arch:
9974653a882SSimon Glass                        Print('%10s: (for %d/%d boards)' % (arch, count,
9984653a882SSimon Glass                              arch_count[arch]), newline=False)
999fc3fe1c2SSimon Glass                        printed_arch = True
10004653a882SSimon Glass                    Print(msg, colour=color, newline=False)
1001fc3fe1c2SSimon Glass
1002fc3fe1c2SSimon Glass            if printed_arch:
10034653a882SSimon Glass                Print()
1004fc3fe1c2SSimon Glass                if show_detail:
1005fc3fe1c2SSimon Glass                    self.PrintSizeDetail(target_list, show_bloat)
1006fc3fe1c2SSimon Glass
1007fc3fe1c2SSimon Glass
1008fc3fe1c2SSimon Glass    def PrintResultSummary(self, board_selected, board_dict, err_lines,
1009e30965dbSSimon Glass                           err_line_boards, warn_lines, warn_line_boards,
1010843312dcSSimon Glass                           config, show_sizes, show_detail, show_bloat,
1011843312dcSSimon Glass                           show_config):
1012fc3fe1c2SSimon Glass        """Compare results with the base results and display delta.
1013fc3fe1c2SSimon Glass
1014fc3fe1c2SSimon Glass        Only boards mentioned in board_selected will be considered. This
1015fc3fe1c2SSimon Glass        function is intended to be called repeatedly with the results of
1016fc3fe1c2SSimon Glass        each commit. It therefore shows a 'diff' between what it saw in
1017fc3fe1c2SSimon Glass        the last call and what it sees now.
1018fc3fe1c2SSimon Glass
1019fc3fe1c2SSimon Glass        Args:
1020fc3fe1c2SSimon Glass            board_selected: Dict containing boards to summarise, keyed by
1021fc3fe1c2SSimon Glass                board.target
1022fc3fe1c2SSimon Glass            board_dict: Dict containing boards for which we built this
1023fc3fe1c2SSimon Glass                commit, keyed by board.target. The value is an Outcome object.
1024fc3fe1c2SSimon Glass            err_lines: A list of errors for this commit, or [] if there is
1025fc3fe1c2SSimon Glass                none, or we don't want to print errors
1026ed966657SSimon Glass            err_line_boards: Dict keyed by error line, containing a list of
1027ed966657SSimon Glass                the Board objects with that error
1028e30965dbSSimon Glass            warn_lines: A list of warnings for this commit, or [] if there is
1029e30965dbSSimon Glass                none, or we don't want to print errors
1030e30965dbSSimon Glass            warn_line_boards: Dict keyed by warning line, containing a list of
1031e30965dbSSimon Glass                the Board objects with that warning
1032843312dcSSimon Glass            config: Dictionary keyed by filename - e.g. '.config'. Each
1033843312dcSSimon Glass                    value is itself a dictionary:
1034843312dcSSimon Glass                        key: config name
1035843312dcSSimon Glass                        value: config value
1036fc3fe1c2SSimon Glass            show_sizes: Show image size deltas
1037fc3fe1c2SSimon Glass            show_detail: Show detail for each board
1038fc3fe1c2SSimon Glass            show_bloat: Show detail for each function
1039843312dcSSimon Glass            show_config: Show config changes
1040fc3fe1c2SSimon Glass        """
1041e30965dbSSimon Glass        def _BoardList(line, line_boards):
1042ed966657SSimon Glass            """Helper function to get a line of boards containing a line
1043ed966657SSimon Glass
1044ed966657SSimon Glass            Args:
1045ed966657SSimon Glass                line: Error line to search for
1046ed966657SSimon Glass            Return:
1047ed966657SSimon Glass                String containing a list of boards with that error line, or
1048ed966657SSimon Glass                '' if the user has not requested such a list
1049ed966657SSimon Glass            """
1050ed966657SSimon Glass            if self._list_error_boards:
1051ed966657SSimon Glass                names = []
1052e30965dbSSimon Glass                for board in line_boards[line]:
1053f66153beSSimon Glass                    if not board.target in names:
1054ed966657SSimon Glass                        names.append(board.target)
1055ed966657SSimon Glass                names_str = '(%s) ' % ','.join(names)
1056ed966657SSimon Glass            else:
1057ed966657SSimon Glass                names_str = ''
1058ed966657SSimon Glass            return names_str
1059ed966657SSimon Glass
1060e30965dbSSimon Glass        def _CalcErrorDelta(base_lines, base_line_boards, lines, line_boards,
1061e30965dbSSimon Glass                            char):
1062e30965dbSSimon Glass            better_lines = []
1063e30965dbSSimon Glass            worse_lines = []
1064e30965dbSSimon Glass            for line in lines:
1065e30965dbSSimon Glass                if line not in base_lines:
1066e30965dbSSimon Glass                    worse_lines.append(char + '+' +
1067e30965dbSSimon Glass                            _BoardList(line, line_boards) + line)
1068e30965dbSSimon Glass            for line in base_lines:
1069e30965dbSSimon Glass                if line not in lines:
1070e30965dbSSimon Glass                    better_lines.append(char + '-' +
1071e30965dbSSimon Glass                            _BoardList(line, base_line_boards) + line)
1072e30965dbSSimon Glass            return better_lines, worse_lines
1073e30965dbSSimon Glass
1074843312dcSSimon Glass        def _CalcConfig(delta, name, config):
1075843312dcSSimon Glass            """Calculate configuration changes
1076843312dcSSimon Glass
1077843312dcSSimon Glass            Args:
1078843312dcSSimon Glass                delta: Type of the delta, e.g. '+'
1079843312dcSSimon Glass                name: name of the file which changed (e.g. .config)
1080843312dcSSimon Glass                config: configuration change dictionary
1081843312dcSSimon Glass                    key: config name
1082843312dcSSimon Glass                    value: config value
1083843312dcSSimon Glass            Returns:
1084843312dcSSimon Glass                String containing the configuration changes which can be
1085843312dcSSimon Glass                    printed
1086843312dcSSimon Glass            """
1087843312dcSSimon Glass            out = ''
1088843312dcSSimon Glass            for key in sorted(config.keys()):
1089843312dcSSimon Glass                out += '%s=%s ' % (key, config[key])
10908270e3c1SSimon Glass            return '%s %s: %s' % (delta, name, out)
1091843312dcSSimon Glass
10928270e3c1SSimon Glass        def _AddConfig(lines, name, config_plus, config_minus, config_change):
10938270e3c1SSimon Glass            """Add changes in configuration to a list
1094843312dcSSimon Glass
1095843312dcSSimon Glass            Args:
10968270e3c1SSimon Glass                lines: list to add to
10978270e3c1SSimon Glass                name: config file name
1098843312dcSSimon Glass                config_plus: configurations added, dictionary
1099843312dcSSimon Glass                    key: config name
1100843312dcSSimon Glass                    value: config value
1101843312dcSSimon Glass                config_minus: configurations removed, dictionary
1102843312dcSSimon Glass                    key: config name
1103843312dcSSimon Glass                    value: config value
1104843312dcSSimon Glass                config_change: configurations changed, dictionary
1105843312dcSSimon Glass                    key: config name
1106843312dcSSimon Glass                    value: config value
1107843312dcSSimon Glass            """
1108843312dcSSimon Glass            if config_plus:
11098270e3c1SSimon Glass                lines.append(_CalcConfig('+', name, config_plus))
1110843312dcSSimon Glass            if config_minus:
11118270e3c1SSimon Glass                lines.append(_CalcConfig('-', name, config_minus))
1112843312dcSSimon Glass            if config_change:
11138270e3c1SSimon Glass                lines.append(_CalcConfig('c', name, config_change))
11148270e3c1SSimon Glass
11158270e3c1SSimon Glass        def _OutputConfigInfo(lines):
11168270e3c1SSimon Glass            for line in lines:
11178270e3c1SSimon Glass                if not line:
11188270e3c1SSimon Glass                    continue
11198270e3c1SSimon Glass                if line[0] == '+':
11208270e3c1SSimon Glass                    col = self.col.GREEN
11218270e3c1SSimon Glass                elif line[0] == '-':
11228270e3c1SSimon Glass                    col = self.col.RED
11238270e3c1SSimon Glass                elif line[0] == 'c':
11248270e3c1SSimon Glass                    col = self.col.YELLOW
11258270e3c1SSimon Glass                Print('   ' + line, newline=True, colour=col)
11268270e3c1SSimon Glass
1127843312dcSSimon Glass
1128fc3fe1c2SSimon Glass        better = []     # List of boards fixed since last commit
1129fc3fe1c2SSimon Glass        worse = []      # List of new broken boards since last commit
1130fc3fe1c2SSimon Glass        new = []        # List of boards that didn't exist last time
1131fc3fe1c2SSimon Glass        unknown = []    # List of boards that were not built
1132fc3fe1c2SSimon Glass
1133fc3fe1c2SSimon Glass        for target in board_dict:
1134fc3fe1c2SSimon Glass            if target not in board_selected:
1135fc3fe1c2SSimon Glass                continue
1136fc3fe1c2SSimon Glass
1137fc3fe1c2SSimon Glass            # If the board was built last time, add its outcome to a list
1138fc3fe1c2SSimon Glass            if target in self._base_board_dict:
1139fc3fe1c2SSimon Glass                base_outcome = self._base_board_dict[target].rc
1140fc3fe1c2SSimon Glass                outcome = board_dict[target]
1141fc3fe1c2SSimon Glass                if outcome.rc == OUTCOME_UNKNOWN:
1142fc3fe1c2SSimon Glass                    unknown.append(target)
1143fc3fe1c2SSimon Glass                elif outcome.rc < base_outcome:
1144fc3fe1c2SSimon Glass                    better.append(target)
1145fc3fe1c2SSimon Glass                elif outcome.rc > base_outcome:
1146fc3fe1c2SSimon Glass                    worse.append(target)
1147fc3fe1c2SSimon Glass            else:
1148fc3fe1c2SSimon Glass                new.append(target)
1149fc3fe1c2SSimon Glass
1150fc3fe1c2SSimon Glass        # Get a list of errors that have appeared, and disappeared
1151e30965dbSSimon Glass        better_err, worse_err = _CalcErrorDelta(self._base_err_lines,
1152e30965dbSSimon Glass                self._base_err_line_boards, err_lines, err_line_boards, '')
1153e30965dbSSimon Glass        better_warn, worse_warn = _CalcErrorDelta(self._base_warn_lines,
1154e30965dbSSimon Glass                self._base_warn_line_boards, warn_lines, warn_line_boards, 'w')
1155fc3fe1c2SSimon Glass
1156fc3fe1c2SSimon Glass        # Display results by arch
1157e30965dbSSimon Glass        if (better or worse or unknown or new or worse_err or better_err
1158e30965dbSSimon Glass                or worse_warn or better_warn):
1159fc3fe1c2SSimon Glass            arch_list = {}
1160fc3fe1c2SSimon Glass            self.AddOutcome(board_selected, arch_list, better, '',
1161fc3fe1c2SSimon Glass                    self.col.GREEN)
1162fc3fe1c2SSimon Glass            self.AddOutcome(board_selected, arch_list, worse, '+',
1163fc3fe1c2SSimon Glass                    self.col.RED)
1164fc3fe1c2SSimon Glass            self.AddOutcome(board_selected, arch_list, new, '*', self.col.BLUE)
1165fc3fe1c2SSimon Glass            if self._show_unknown:
1166fc3fe1c2SSimon Glass                self.AddOutcome(board_selected, arch_list, unknown, '?',
1167fc3fe1c2SSimon Glass                        self.col.MAGENTA)
1168fc3fe1c2SSimon Glass            for arch, target_list in arch_list.iteritems():
11694653a882SSimon Glass                Print('%10s: %s' % (arch, target_list))
117028370c1bSSimon Glass                self._error_lines += 1
1171fc3fe1c2SSimon Glass            if better_err:
11724653a882SSimon Glass                Print('\n'.join(better_err), colour=self.col.GREEN)
117328370c1bSSimon Glass                self._error_lines += 1
1174fc3fe1c2SSimon Glass            if worse_err:
11754653a882SSimon Glass                Print('\n'.join(worse_err), colour=self.col.RED)
117628370c1bSSimon Glass                self._error_lines += 1
1177e30965dbSSimon Glass            if better_warn:
11784653a882SSimon Glass                Print('\n'.join(better_warn), colour=self.col.CYAN)
1179e30965dbSSimon Glass                self._error_lines += 1
1180e30965dbSSimon Glass            if worse_warn:
11814653a882SSimon Glass                Print('\n'.join(worse_warn), colour=self.col.MAGENTA)
1182e30965dbSSimon Glass                self._error_lines += 1
1183fc3fe1c2SSimon Glass
1184fc3fe1c2SSimon Glass        if show_sizes:
1185fc3fe1c2SSimon Glass            self.PrintSizeSummary(board_selected, board_dict, show_detail,
1186fc3fe1c2SSimon Glass                                  show_bloat)
1187fc3fe1c2SSimon Glass
11888270e3c1SSimon Glass        if show_config and self._base_config:
11898270e3c1SSimon Glass            summary = {}
11908270e3c1SSimon Glass            arch_config_plus = {}
11918270e3c1SSimon Glass            arch_config_minus = {}
11928270e3c1SSimon Glass            arch_config_change = {}
11938270e3c1SSimon Glass            arch_list = []
11948270e3c1SSimon Glass
11958270e3c1SSimon Glass            for target in board_dict:
11968270e3c1SSimon Glass                if target not in board_selected:
11978270e3c1SSimon Glass                    continue
11988270e3c1SSimon Glass                arch = board_selected[target].arch
11998270e3c1SSimon Glass                if arch not in arch_list:
12008270e3c1SSimon Glass                    arch_list.append(arch)
12018270e3c1SSimon Glass
12028270e3c1SSimon Glass            for arch in arch_list:
12038270e3c1SSimon Glass                arch_config_plus[arch] = {}
12048270e3c1SSimon Glass                arch_config_minus[arch] = {}
12058270e3c1SSimon Glass                arch_config_change[arch] = {}
1206b464f8e7SSimon Glass                for name in self.config_filenames:
12078270e3c1SSimon Glass                    arch_config_plus[arch][name] = {}
12088270e3c1SSimon Glass                    arch_config_minus[arch][name] = {}
12098270e3c1SSimon Glass                    arch_config_change[arch][name] = {}
12108270e3c1SSimon Glass
12118270e3c1SSimon Glass            for target in board_dict:
12128270e3c1SSimon Glass                if target not in board_selected:
12138270e3c1SSimon Glass                    continue
12148270e3c1SSimon Glass
12158270e3c1SSimon Glass                arch = board_selected[target].arch
12168270e3c1SSimon Glass
1217843312dcSSimon Glass                all_config_plus = {}
1218843312dcSSimon Glass                all_config_minus = {}
1219843312dcSSimon Glass                all_config_change = {}
12208270e3c1SSimon Glass                tbase = self._base_config[target]
12218270e3c1SSimon Glass                tconfig = config[target]
12228270e3c1SSimon Glass                lines = []
1223b464f8e7SSimon Glass                for name in self.config_filenames:
12248270e3c1SSimon Glass                    if not tconfig.config[name]:
1225843312dcSSimon Glass                        continue
1226843312dcSSimon Glass                    config_plus = {}
1227843312dcSSimon Glass                    config_minus = {}
1228843312dcSSimon Glass                    config_change = {}
12298270e3c1SSimon Glass                    base = tbase.config[name]
12308270e3c1SSimon Glass                    for key, value in tconfig.config[name].iteritems():
1231843312dcSSimon Glass                        if key not in base:
1232843312dcSSimon Glass                            config_plus[key] = value
1233843312dcSSimon Glass                            all_config_plus[key] = value
1234843312dcSSimon Glass                    for key, value in base.iteritems():
12358270e3c1SSimon Glass                        if key not in tconfig.config[name]:
1236843312dcSSimon Glass                            config_minus[key] = value
1237843312dcSSimon Glass                            all_config_minus[key] = value
1238843312dcSSimon Glass                    for key, value in base.iteritems():
12398270e3c1SSimon Glass                        new_value = tconfig.config.get(key)
12408270e3c1SSimon Glass                        if new_value and value != new_value:
1241843312dcSSimon Glass                            desc = '%s -> %s' % (value, new_value)
1242843312dcSSimon Glass                            config_change[key] = desc
1243843312dcSSimon Glass                            all_config_change[key] = desc
12448270e3c1SSimon Glass
12458270e3c1SSimon Glass                    arch_config_plus[arch][name].update(config_plus)
12468270e3c1SSimon Glass                    arch_config_minus[arch][name].update(config_minus)
12478270e3c1SSimon Glass                    arch_config_change[arch][name].update(config_change)
12488270e3c1SSimon Glass
12498270e3c1SSimon Glass                    _AddConfig(lines, name, config_plus, config_minus,
12508270e3c1SSimon Glass                               config_change)
12518270e3c1SSimon Glass                _AddConfig(lines, 'all', all_config_plus, all_config_minus,
1252843312dcSSimon Glass                           all_config_change)
12538270e3c1SSimon Glass                summary[target] = '\n'.join(lines)
12548270e3c1SSimon Glass
12558270e3c1SSimon Glass            lines_by_target = {}
12568270e3c1SSimon Glass            for target, lines in summary.iteritems():
12578270e3c1SSimon Glass                if lines in lines_by_target:
12588270e3c1SSimon Glass                    lines_by_target[lines].append(target)
12598270e3c1SSimon Glass                else:
12608270e3c1SSimon Glass                    lines_by_target[lines] = [target]
12618270e3c1SSimon Glass
12628270e3c1SSimon Glass            for arch in arch_list:
12638270e3c1SSimon Glass                lines = []
12648270e3c1SSimon Glass                all_plus = {}
12658270e3c1SSimon Glass                all_minus = {}
12668270e3c1SSimon Glass                all_change = {}
1267b464f8e7SSimon Glass                for name in self.config_filenames:
12688270e3c1SSimon Glass                    all_plus.update(arch_config_plus[arch][name])
12698270e3c1SSimon Glass                    all_minus.update(arch_config_minus[arch][name])
12708270e3c1SSimon Glass                    all_change.update(arch_config_change[arch][name])
12718270e3c1SSimon Glass                    _AddConfig(lines, name, arch_config_plus[arch][name],
12728270e3c1SSimon Glass                               arch_config_minus[arch][name],
12738270e3c1SSimon Glass                               arch_config_change[arch][name])
12748270e3c1SSimon Glass                _AddConfig(lines, 'all', all_plus, all_minus, all_change)
12758270e3c1SSimon Glass                #arch_summary[target] = '\n'.join(lines)
12768270e3c1SSimon Glass                if lines:
12778270e3c1SSimon Glass                    Print('%s:' % arch)
12788270e3c1SSimon Glass                    _OutputConfigInfo(lines)
12798270e3c1SSimon Glass
12808270e3c1SSimon Glass            for lines, targets in lines_by_target.iteritems():
12818270e3c1SSimon Glass                if not lines:
12828270e3c1SSimon Glass                    continue
12838270e3c1SSimon Glass                Print('%s :' % ' '.join(sorted(targets)))
12848270e3c1SSimon Glass                _OutputConfigInfo(lines.split('\n'))
12858270e3c1SSimon Glass
1286843312dcSSimon Glass
1287fc3fe1c2SSimon Glass        # Save our updated information for the next call to this function
1288fc3fe1c2SSimon Glass        self._base_board_dict = board_dict
1289fc3fe1c2SSimon Glass        self._base_err_lines = err_lines
1290e30965dbSSimon Glass        self._base_warn_lines = warn_lines
1291e30965dbSSimon Glass        self._base_err_line_boards = err_line_boards
1292e30965dbSSimon Glass        self._base_warn_line_boards = warn_line_boards
1293843312dcSSimon Glass        self._base_config = config
1294fc3fe1c2SSimon Glass
1295fc3fe1c2SSimon Glass        # Get a list of boards that did not get built, if needed
1296fc3fe1c2SSimon Glass        not_built = []
1297fc3fe1c2SSimon Glass        for board in board_selected:
1298fc3fe1c2SSimon Glass            if not board in board_dict:
1299fc3fe1c2SSimon Glass                not_built.append(board)
1300fc3fe1c2SSimon Glass        if not_built:
13014653a882SSimon Glass            Print("Boards not built (%d): %s" % (len(not_built),
13024653a882SSimon Glass                  ', '.join(not_built)))
1303fc3fe1c2SSimon Glass
1304b2ea7ab2SSimon Glass    def ProduceResultSummary(self, commit_upto, commits, board_selected):
1305e30965dbSSimon Glass            (board_dict, err_lines, err_line_boards, warn_lines,
1306843312dcSSimon Glass                    warn_line_boards, config) = self.GetResultSummary(
1307ed966657SSimon Glass                    board_selected, commit_upto,
1308843312dcSSimon Glass                    read_func_sizes=self._show_bloat,
1309843312dcSSimon Glass                    read_config=self._show_config)
1310b2ea7ab2SSimon Glass            if commits:
1311b2ea7ab2SSimon Glass                msg = '%02d: %s' % (commit_upto + 1,
1312b2ea7ab2SSimon Glass                        commits[commit_upto].subject)
13134653a882SSimon Glass                Print(msg, colour=self.col.BLUE)
1314b2ea7ab2SSimon Glass            self.PrintResultSummary(board_selected, board_dict,
1315ed966657SSimon Glass                    err_lines if self._show_errors else [], err_line_boards,
1316e30965dbSSimon Glass                    warn_lines if self._show_errors else [], warn_line_boards,
1317843312dcSSimon Glass                    config, self._show_sizes, self._show_detail,
1318843312dcSSimon Glass                    self._show_bloat, self._show_config)
1319fc3fe1c2SSimon Glass
1320b2ea7ab2SSimon Glass    def ShowSummary(self, commits, board_selected):
1321fc3fe1c2SSimon Glass        """Show a build summary for U-Boot for a given board list.
1322fc3fe1c2SSimon Glass
1323fc3fe1c2SSimon Glass        Reset the result summary, then repeatedly call GetResultSummary on
1324fc3fe1c2SSimon Glass        each commit's results, then display the differences we see.
1325fc3fe1c2SSimon Glass
1326fc3fe1c2SSimon Glass        Args:
1327fc3fe1c2SSimon Glass            commit: Commit objects to summarise
1328fc3fe1c2SSimon Glass            board_selected: Dict containing boards to summarise
1329fc3fe1c2SSimon Glass        """
1330fea5858eSSimon Glass        self.commit_count = len(commits) if commits else 1
1331fc3fe1c2SSimon Glass        self.commits = commits
1332fc3fe1c2SSimon Glass        self.ResetResultSummary(board_selected)
133328370c1bSSimon Glass        self._error_lines = 0
1334fc3fe1c2SSimon Glass
1335fc3fe1c2SSimon Glass        for commit_upto in range(0, self.commit_count, self._step):
1336b2ea7ab2SSimon Glass            self.ProduceResultSummary(commit_upto, commits, board_selected)
133728370c1bSSimon Glass        if not self._error_lines:
13384653a882SSimon Glass            Print('(no errors to report)', colour=self.col.GREEN)
1339fc3fe1c2SSimon Glass
1340fc3fe1c2SSimon Glass
1341fc3fe1c2SSimon Glass    def SetupBuild(self, board_selected, commits):
1342fc3fe1c2SSimon Glass        """Set up ready to start a build.
1343fc3fe1c2SSimon Glass
1344fc3fe1c2SSimon Glass        Args:
1345fc3fe1c2SSimon Glass            board_selected: Selected boards to build
1346fc3fe1c2SSimon Glass            commits: Selected commits to build
1347fc3fe1c2SSimon Glass        """
1348fc3fe1c2SSimon Glass        # First work out how many commits we will build
1349fea5858eSSimon Glass        count = (self.commit_count + self._step - 1) / self._step
1350fc3fe1c2SSimon Glass        self.count = len(board_selected) * count
1351fc3fe1c2SSimon Glass        self.upto = self.warned = self.fail = 0
1352fc3fe1c2SSimon Glass        self._timestamps = collections.deque()
1353fc3fe1c2SSimon Glass
1354fc3fe1c2SSimon Glass    def GetThreadDir(self, thread_num):
1355fc3fe1c2SSimon Glass        """Get the directory path to the working dir for a thread.
1356fc3fe1c2SSimon Glass
1357fc3fe1c2SSimon Glass        Args:
1358fc3fe1c2SSimon Glass            thread_num: Number of thread to check.
1359fc3fe1c2SSimon Glass        """
1360fc3fe1c2SSimon Glass        return os.path.join(self._working_dir, '%02d' % thread_num)
1361fc3fe1c2SSimon Glass
1362fea5858eSSimon Glass    def _PrepareThread(self, thread_num, setup_git):
1363fc3fe1c2SSimon Glass        """Prepare the working directory for a thread.
1364fc3fe1c2SSimon Glass
1365fc3fe1c2SSimon Glass        This clones or fetches the repo into the thread's work directory.
1366fc3fe1c2SSimon Glass
1367fc3fe1c2SSimon Glass        Args:
1368fc3fe1c2SSimon Glass            thread_num: Thread number (0, 1, ...)
1369fea5858eSSimon Glass            setup_git: True to set up a git repo clone
1370fc3fe1c2SSimon Glass        """
1371fc3fe1c2SSimon Glass        thread_dir = self.GetThreadDir(thread_num)
1372190064b4SSimon Glass        builderthread.Mkdir(thread_dir)
1373fc3fe1c2SSimon Glass        git_dir = os.path.join(thread_dir, '.git')
1374fc3fe1c2SSimon Glass
1375fc3fe1c2SSimon Glass        # Clone the repo if it doesn't already exist
1376fc3fe1c2SSimon Glass        # TODO(sjg@chromium): Perhaps some git hackery to symlink instead, so
1377fc3fe1c2SSimon Glass        # we have a private index but uses the origin repo's contents?
1378fea5858eSSimon Glass        if setup_git and self.git_dir:
1379fc3fe1c2SSimon Glass            src_dir = os.path.abspath(self.git_dir)
1380fc3fe1c2SSimon Glass            if os.path.exists(git_dir):
1381fc3fe1c2SSimon Glass                gitutil.Fetch(git_dir, thread_dir)
1382fc3fe1c2SSimon Glass            else:
138321f0eb33SSimon Glass                Print('\rCloning repo for thread %d' % thread_num,
138421f0eb33SSimon Glass                      newline=False)
1385fc3fe1c2SSimon Glass                gitutil.Clone(src_dir, thread_dir)
138621f0eb33SSimon Glass                Print('\r%s\r' % (' ' * 30), newline=False)
1387fc3fe1c2SSimon Glass
1388fea5858eSSimon Glass    def _PrepareWorkingSpace(self, max_threads, setup_git):
1389fc3fe1c2SSimon Glass        """Prepare the working directory for use.
1390fc3fe1c2SSimon Glass
1391fc3fe1c2SSimon Glass        Set up the git repo for each thread.
1392fc3fe1c2SSimon Glass
1393fc3fe1c2SSimon Glass        Args:
1394fc3fe1c2SSimon Glass            max_threads: Maximum number of threads we expect to need.
1395fea5858eSSimon Glass            setup_git: True to set up a git repo clone
1396fc3fe1c2SSimon Glass        """
1397190064b4SSimon Glass        builderthread.Mkdir(self._working_dir)
1398fc3fe1c2SSimon Glass        for thread in range(max_threads):
1399fea5858eSSimon Glass            self._PrepareThread(thread, setup_git)
1400fc3fe1c2SSimon Glass
1401fc3fe1c2SSimon Glass    def _PrepareOutputSpace(self):
1402fc3fe1c2SSimon Glass        """Get the output directories ready to receive files.
1403fc3fe1c2SSimon Glass
1404fc3fe1c2SSimon Glass        We delete any output directories which look like ones we need to
1405fc3fe1c2SSimon Glass        create. Having left over directories is confusing when the user wants
1406fc3fe1c2SSimon Glass        to check the output manually.
1407fc3fe1c2SSimon Glass        """
14081a915675SSimon Glass        if not self.commits:
14091a915675SSimon Glass            return
1410fc3fe1c2SSimon Glass        dir_list = []
1411fc3fe1c2SSimon Glass        for commit_upto in range(self.commit_count):
1412fc3fe1c2SSimon Glass            dir_list.append(self._GetOutputDir(commit_upto))
1413fc3fe1c2SSimon Glass
1414b222abe7SSimon Glass        to_remove = []
1415fc3fe1c2SSimon Glass        for dirname in glob.glob(os.path.join(self.base_dir, '*')):
1416fc3fe1c2SSimon Glass            if dirname not in dir_list:
1417b222abe7SSimon Glass                to_remove.append(dirname)
1418b222abe7SSimon Glass        if to_remove:
1419b222abe7SSimon Glass            Print('Removing %d old build directories' % len(to_remove),
1420b222abe7SSimon Glass                  newline=False)
1421b222abe7SSimon Glass            for dirname in to_remove:
1422fc3fe1c2SSimon Glass                shutil.rmtree(dirname)
1423fc3fe1c2SSimon Glass
1424e5a0e5d8SSimon Glass    def BuildBoards(self, commits, board_selected, keep_outputs, verbose):
1425fc3fe1c2SSimon Glass        """Build all commits for a list of boards
1426fc3fe1c2SSimon Glass
1427fc3fe1c2SSimon Glass        Args:
1428fc3fe1c2SSimon Glass            commits: List of commits to be build, each a Commit object
1429fc3fe1c2SSimon Glass            boards_selected: Dict of selected boards, key is target name,
1430fc3fe1c2SSimon Glass                    value is Board object
1431fc3fe1c2SSimon Glass            keep_outputs: True to save build output files
1432e5a0e5d8SSimon Glass            verbose: Display build results as they are completed
14332c3deb97SSimon Glass        Returns:
14342c3deb97SSimon Glass            Tuple containing:
14352c3deb97SSimon Glass                - number of boards that failed to build
14362c3deb97SSimon Glass                - number of boards that issued warnings
1437fc3fe1c2SSimon Glass        """
1438fea5858eSSimon Glass        self.commit_count = len(commits) if commits else 1
1439fc3fe1c2SSimon Glass        self.commits = commits
1440e5a0e5d8SSimon Glass        self._verbose = verbose
1441fc3fe1c2SSimon Glass
1442fc3fe1c2SSimon Glass        self.ResetResultSummary(board_selected)
1443f3d015cbSThierry Reding        builderthread.Mkdir(self.base_dir, parents = True)
1444fea5858eSSimon Glass        self._PrepareWorkingSpace(min(self.num_threads, len(board_selected)),
1445fea5858eSSimon Glass                commits is not None)
1446fc3fe1c2SSimon Glass        self._PrepareOutputSpace()
1447745b395aSSimon Glass        Print('\rStarting build...', newline=False)
1448fc3fe1c2SSimon Glass        self.SetupBuild(board_selected, commits)
1449fc3fe1c2SSimon Glass        self.ProcessResult(None)
1450fc3fe1c2SSimon Glass
1451fc3fe1c2SSimon Glass        # Create jobs to build all commits for each board
1452fc3fe1c2SSimon Glass        for brd in board_selected.itervalues():
1453190064b4SSimon Glass            job = builderthread.BuilderJob()
1454fc3fe1c2SSimon Glass            job.board = brd
1455fc3fe1c2SSimon Glass            job.commits = commits
1456fc3fe1c2SSimon Glass            job.keep_outputs = keep_outputs
1457fc3fe1c2SSimon Glass            job.step = self._step
1458fc3fe1c2SSimon Glass            self.queue.put(job)
1459fc3fe1c2SSimon Glass
1460d436e381SSimon Glass        term = threading.Thread(target=self.queue.join)
1461d436e381SSimon Glass        term.setDaemon(True)
1462d436e381SSimon Glass        term.start()
1463d436e381SSimon Glass        while term.isAlive():
1464d436e381SSimon Glass            term.join(100)
1465fc3fe1c2SSimon Glass
1466fc3fe1c2SSimon Glass        # Wait until we have processed all output
1467fc3fe1c2SSimon Glass        self.out_queue.join()
14684653a882SSimon Glass        Print()
1469fc3fe1c2SSimon Glass        self.ClearLine(0)
14702c3deb97SSimon Glass        return (self.fail, self.warned)
1471