xref: /rk3399_rockchip-uboot/common/spl/spl_fit.c (revision 8ec8d58eeb2a43c1d2630d9ef41fac2a7c482082)

/*
 * Copyright (C) 2016 Google, Inc
 * Written by Simon Glass <sjg@chromium.org>
 *
 * SPDX-License-Identifier:	GPL-2.0+
 */

#include <common.h>
#include <boot_rkimg.h>
#include <errno.h>
#include <image.h>
#include <linux/libfdt.h>
#include <spl.h>
#include <malloc.h>

#ifndef CONFIG_SYS_BOOTM_LEN
#define CONFIG_SYS_BOOTM_LEN	(64 << 20)
#endif

/**
 * spl_fit_get_image_name(): By using the matching configuration subnode,
 * retrieve the name of an image, specified by a property name and an index
 * into that.
 * @fit:	Pointer to the FDT blob.
 * @images:	Offset of the /images subnode.
 * @type:	Name of the property within the configuration subnode.
 * @index:	Index into the list of strings in this property.
 * @outname:	Name of the image
 *
 * Return:	0 on success, or a negative error number
 */
static int spl_fit_get_image_name(const void *fit, int images,
				  const char *type, int index,
				  char **outname)
{
	const char *name, *str;
	__maybe_unused int node;
	int conf_node;
	int len, i;

	conf_node = fit_find_config_node(fit);
	if (conf_node < 0) {
#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
		printf("No matching DT out of these options:\n");
		for (node = fdt_first_subnode(fit, conf_node);
		     node >= 0;
		     node = fdt_next_subnode(fit, node)) {
			name = fdt_getprop(fit, node, "description", &len);
			printf("   %s\n", name);
		}
#endif
		return conf_node;
	}

	name = fdt_getprop(fit, conf_node, type, &len);
	if (!name) {
		debug("cannot find property '%s': %d\n", type, len);
		return -EINVAL;
	}

	str = name;
	for (i = 0; i < index; i++) {
		str = strchr(str, '\0') + 1;
		if (!str || (str - name >= len)) {
			debug("no string for index %d\n", index);
			return -E2BIG;
		}
	}

	*outname = (char *)str;
	return 0;
}

/**
 * spl_fit_get_image_node(): By using the matching configuration subnode,
 * retrieve the name of an image, specified by a property name and an index
 * into that.
 * @fit:	Pointer to the FDT blob.
 * @images:	Offset of the /images subnode.
 * @type:	Name of the property within the configuration subnode.
 * @index:	Index into the list of strings in this property.
 *
 * Return:	the node offset of the respective image node or a negative
 *		error number.
 */
static int spl_fit_get_image_node(const void *fit, int images,
				  const char *type, int index)
{
	char *str;
	int err;
	int node;

	err = spl_fit_get_image_name(fit, images, type, index, &str);
	if (err)
		return err;

	debug("%s: '%s'\n", type, str);

	node = fdt_subnode_offset(fit, images, str);
	if (node < 0) {
		debug("cannot find image node '%s': %d\n", str, node);
		return -EINVAL;
	}

	return node;
}

static int get_aligned_image_offset(struct spl_load_info *info, int offset)
{
	/*
	 * If it is a FS read, get the first address before offset which is
	 * aligned to ARCH_DMA_MINALIGN. If it is raw read return the
	 * block number to which offset belongs.
	 */
	if (info->filename)
		return offset & ~(ARCH_DMA_MINALIGN - 1);

	return offset / info->bl_len;
}

static int get_aligned_image_overhead(struct spl_load_info *info, int offset)
{
	/*
	 * If it is a FS read, get the difference between the offset and
	 * the first address before offset which is aligned to
	 * ARCH_DMA_MINALIGN. If it is raw read return the offset within the
	 * block.
	 */
	if (info->filename)
		return offset & (ARCH_DMA_MINALIGN - 1);

	return offset % info->bl_len;
}

static int get_aligned_image_size(struct spl_load_info *info, int data_size,
				  int offset)
{
	data_size = data_size + get_aligned_image_overhead(info, offset);

	if (info->filename)
		return data_size;

	return (data_size + info->bl_len - 1) / info->bl_len;
}

/**
 * spl_load_fit_image(): load the image described in a certain FIT node
 * @info:	points to information about the device to load data from
 * @sector:	the start sector of the FIT image on the device
 * @fit:	points to the flattened device tree blob describing the FIT
 *		image
 * @base_offset: the beginning of the data area containing the actual
 *		image data, relative to the beginning of the FIT
 * @node:	offset of the DT node describing the image to load (relative
 *		to @fit)
 * @image_info:	will be filled with information about the loaded image
 *		If the FIT node does not contain a "load" (address) property,
 *		the image gets loaded to the address pointed to by the
 *		load_addr member in this struct.
 *
 * Return:	0 on success or a negative error number.
 */
static int spl_load_fit_image(struct spl_load_info *info, ulong sector,
			      void *fit, ulong base_offset, int node,
			      struct spl_image_info *image_info)
{
	int offset;
	size_t length;
	int len;
	ulong size;
	ulong comp_addr, load_addr, load_ptr;
	void *src;
	ulong overhead;
	int nr_sectors;
	int align_len = ARCH_DMA_MINALIGN - 1;
	uint8_t image_comp = -1, type = -1;
	const void *data;
	bool external_data = false;

	if (IS_ENABLED(CONFIG_SPL_OS_BOOT) && IS_ENABLED(CONFIG_SPL_GZIP)) {
		if (fit_image_get_comp(fit, node, &image_comp))
			puts("Cannot get image compression format.\n");
		else
			debug("%s ", genimg_get_comp_name(image_comp));

		if (fit_image_get_type(fit, node, &type))
			puts("Cannot get image type.\n");
		else
			debug("%s ", genimg_get_type_name(type));
	} else {
		fit_image_get_comp(fit, node, &image_comp);
	}

	if (fit_image_get_load(fit, node, &load_addr))
		load_addr = image_info->load_addr;

	if (image_comp != IH_COMP_NONE && image_comp != IH_COMP_ZIMAGE) {
		/* Empirically, 1MB is enough for U-Boot, tee and atf */
		if (fit_image_get_comp_addr(fit, node, &comp_addr))
			comp_addr = load_addr + SZ_1M;
	} else {
		comp_addr = load_addr;
	}

	if (!fit_image_get_data_position(fit, node, &offset)) {
		external_data = true;
	} else if (!fit_image_get_data_offset(fit, node, &offset)) {
		offset += base_offset;
		external_data = true;
	}

	if (external_data) {
		/* External data */
		if (fit_image_get_data_size(fit, node, &len))
			return -ENOENT;

		load_ptr = (comp_addr + align_len) & ~align_len;
#if  defined(CONFIG_ARCH_ROCKCHIP)
		if ((load_ptr < CONFIG_SYS_SDRAM_BASE) ||
		     (load_ptr >= CONFIG_SYS_SDRAM_BASE + SDRAM_MAX_SIZE))
			load_ptr = (ulong)memalign(ARCH_DMA_MINALIGN, len);
#endif
		length = len;

		overhead = get_aligned_image_overhead(info, offset);
		nr_sectors = get_aligned_image_size(info, length, offset);

		if (info->read(info,
			       sector + get_aligned_image_offset(info, offset),
			       nr_sectors, (void *)load_ptr) != nr_sectors)
			return -EIO;

		debug("External data: dst=%lx, offset=%x, size=%lx\n",
		      load_ptr, offset, (unsigned long)length);
		src = (void *)load_ptr + overhead;
	} else {
		/* Embedded data */
		if (fit_image_get_data(fit, node, &data, &length)) {
			puts("Cannot get image data/size\n");
			return -ENOENT;
		}
		debug("Embedded data: dst=%lx, size=%lx\n", load_addr,
		      (unsigned long)length);
		src = (void *)data;
	}

	/* Check hashes and signature */
	if (image_comp != IH_COMP_NONE && image_comp != IH_COMP_ZIMAGE)
		printf("## Checking %s 0x%08lx (%s @0x%08lx) ... ",
		       fit_get_name(fit, node, NULL), load_addr,
		       (char *)fdt_getprop(fit, node, FIT_COMP_PROP, NULL),
		       (long)src);
	else
		printf("## Checking %s 0x%08lx ... ",
		       fit_get_name(fit, node, NULL), load_addr);

#ifdef CONFIG_FIT_SPL_PRINT
	printf("\n");
	fit_image_print(fit, node, "");
#endif
	if (!fit_image_verify_with_data(fit, node,
					 src, length))
		return -EPERM;

#ifdef CONFIG_SPL_FIT_IMAGE_POST_PROCESS
	board_fit_image_post_process(fit, node, (ulong *)&load_addr,
				     (ulong **)&src, &length);
#endif
	puts("OK\n");

	if (IS_ENABLED(CONFIG_SPL_OS_BOOT)	&&
	    IS_ENABLED(CONFIG_SPL_GZIP)		&&
	    image_comp == IH_COMP_GZIP		&&
	    type == IH_TYPE_KERNEL) {
		size = length;
		if (gunzip((void *)load_addr, CONFIG_SYS_BOOTM_LEN,
			   src, &size)) {
			puts("Uncompressing error\n");
			return -EIO;
		}
		length = size;
	} else {
		memcpy((void *)load_addr, src, length);
	}

	if (image_info) {
		image_info->load_addr = load_addr;
		image_info->size = length;
		image_info->entry_point = fdt_getprop_u32(fit, node, "entry");
	}

	return 0;
}

static int spl_fit_append_fdt(struct spl_image_info *spl_image,
			      struct spl_load_info *info, ulong sector,
			      void *fit, int images, ulong base_offset)
{
	struct spl_image_info image_info;
	int node, ret;

	/* Figure out which device tree the board wants to use */
	node = spl_fit_get_image_node(fit, images, FIT_FDT_PROP, 0);
	if (node < 0) {
		debug("%s: cannot find FDT node\n", __func__);
		return node;
	}

	/*
	 * Read the device tree and place it after the image.
	 * Align the destination address to ARCH_DMA_MINALIGN.
	 */
	image_info.load_addr = spl_image->load_addr + spl_image->size;
	ret = spl_load_fit_image(info, sector, fit, base_offset, node,
				 &image_info);

	if (ret < 0)
		return ret;

	/* Make the load-address of the FDT available for the SPL framework */
	spl_image->fdt_addr = (void *)image_info.load_addr;
#if !CONFIG_IS_ENABLED(FIT_IMAGE_TINY)
	/* Try to make space, so we can inject details on the loadables */
	ret = fdt_shrink_to_minimum(spl_image->fdt_addr, 8192);
#endif

	/*
	 * If need, load kernel FDT right after U-Boot FDT.
	 *
	 * kernel FDT is for U-Boot if there is not valid one
	 * from images, ie: resource.img, boot.img or recovery.img.
	 */
	node = fdt_subnode_offset(fit, images, FIT_KERNEL_FDT_PROP);
	if (node < 0)
		return ret;

	image_info.load_addr =
		(ulong)spl_image->fdt_addr + fdt_totalsize(spl_image->fdt_addr);
	ret = spl_load_fit_image(info, sector, fit, base_offset, node,
				 &image_info);

	return ret;
}

static int spl_fit_record_loadable(const void *fit, int images, int index,
				   void *blob, struct spl_image_info *image)
{
	int ret = 0;
#if !CONFIG_IS_ENABLED(FIT_IMAGE_TINY)
	char *name;
	int node;

	ret = spl_fit_get_image_name(fit, images, "loadables",
				     index, &name);
	if (ret < 0)
		return ret;

	node = spl_fit_get_image_node(fit, images, "loadables", index);

	ret = fdt_record_loadable(blob, index, name, image->load_addr,
				  image->size, image->entry_point,
				  fdt_getprop(fit, node, "type", NULL),
				  fdt_getprop(fit, node, "os", NULL));
#endif
	return ret;
}

static int spl_fit_image_get_os(const void *fit, int noffset, uint8_t *os)
{
#if CONFIG_IS_ENABLED(FIT_IMAGE_TINY)
	return -ENOTSUPP;
#else
	return fit_image_get_os(fit, noffset, os);
#endif
}

__weak int spl_fit_standalone_release(uintptr_t entry_point)
{
	return 0;
}

static void *spl_fit_load_blob(struct spl_load_info *info,
			       ulong sector, void *fit_header,
			       int *base_offset)
{
	int align_len = ARCH_DMA_MINALIGN - 1;
	ulong count;
	ulong size;
	int sectors;
	void *fit;

	/*
	 * For FIT with external data, figure out where the external images
	 * start. This is the base for the data-offset properties in each
	 * image.
	 */
	size = fdt_totalsize(fit_header);
	size = FIT_ALIGN(size);
	*base_offset = FIT_ALIGN(size);

	/*
	 * So far we only have one block of data from the FIT. Read the entire
	 * thing, including that first block, placing it so it finishes before
	 * where we will load the image.
	 *
	 * Note that we will load the image such that its first byte will be
	 * at the load address. Since that byte may be part-way through a
	 * block, we may load the image up to one block before the load
	 * address. So take account of that here by subtracting an addition
	 * block length from the FIT start position.
	 *
	 * In fact the FIT has its own load address, but we assume it cannot
	 * be before CONFIG_SYS_TEXT_BASE.
	 *
	 * For FIT with data embedded, data is loaded as part of FIT image.
	 * For FIT with external data, data is not loaded in this step.
	 */
	fit = (void *)((CONFIG_SYS_TEXT_BASE - size - info->bl_len -
			align_len) & ~align_len);
	sectors = get_aligned_image_size(info, size, 0);
	count = info->read(info, sector, sectors, fit);
	debug("fit read sector %lx, sectors=%d, dst=%p, count=%lu\n",
	      sector, sectors, fit, count);
	if (count == 0)
		return NULL;

	return fit;
}

#ifdef CONFIG_SPL_KERNEL_BOOT
#ifdef CONFIG_SPL_LIBDISK_SUPPORT
__weak const char *spl_kernel_partition(struct spl_image_info *spl,
					struct spl_load_info *info)
{
	return PART_BOOT;
}
#endif

static int spl_load_kernel_fit(struct spl_image_info *spl_image,
			       struct spl_load_info *info)
{
	/*
	 * Never change the image order.
	 *
	 * Considering thunder-boot feature, there maybe asynchronous
	 * loading operation of these images and ramdisk is usually to
	 * be the last one.
	 *
	 * The .its content rule of kernel fit image follows U-Boot proper.
	 */
	const char *images[] = { FIT_FDT_PROP, FIT_KERNEL_PROP, FIT_RAMDISK_PROP, };
	struct spl_image_info image_info;
	char fit_header[info->bl_len];
	int images_noffset;
	int base_offset;
	int sector;
	int node, ret, i;
	void *fit;

	if (spl_image->next_stage != SPL_NEXT_STAGE_KERNEL)
		return 0;

#ifdef CONFIG_SPL_LIBDISK_SUPPORT
	const char *part_name = PART_BOOT;
	disk_partition_t part_info;

	part_name = spl_kernel_partition(spl_image, info);
	if (part_get_info_by_name(info->dev, part_name, &part_info) <= 0) {
		printf("%s: no partition\n", __func__);
		return -EINVAL;
	}
	sector = part_info.start;
#else
	sector = CONFIG_SPL_KERNEL_BOOT_SECTOR;
#endif
	if (info->read(info, sector, 1, &fit_header) != 1) {
		debug("%s: Failed to read header\n", __func__);
		return -EIO;
	}

	if (image_get_magic((void *)&fit_header) != FDT_MAGIC) {
		printf("%s: Not fit magic\n", __func__);
		return -EINVAL;
	}

	fit = spl_fit_load_blob(info, sector, fit_header, &base_offset);
	if (!fit) {
		debug("%s: Cannot load blob\n", __func__);
		return -ENODEV;
	}

	/* verify the configure node by keys, if required */
#ifdef CONFIG_SPL_FIT_SIGNATURE
	int conf_noffset;

	conf_noffset = fit_conf_get_node(fit, NULL);
	if (conf_noffset <= 0) {
		printf("No default config node\n");
		return -EINVAL;
	}

	ret = fit_config_verify(fit, conf_noffset);
	if (ret) {
		printf("fit verify configure failed, ret=%d\n", ret);
		return ret;
	}
	printf("\n");
#endif
	images_noffset = fdt_path_offset(fit, FIT_IMAGES_PATH);
	if (images_noffset < 0) {
		debug("%s: Cannot find /images node: %d\n",
		      __func__, images_noffset);
		return images_noffset;
	}

	for (i = 0; i < ARRAY_SIZE(images); i++) {
		node = spl_fit_get_image_node(fit, images_noffset,
					      images[i], 0);
		if (node < 0) {
			debug("No image: %s\n", images[i]);
			continue;
		}

		ret = spl_load_fit_image(info, sector, fit, base_offset,
					 node, &image_info);
		if (ret)
			return ret;

		/* initial addr or entry point */
		if (!strcmp(images[i], FIT_FDT_PROP))
			spl_image->fdt_addr = (void *)image_info.load_addr;
		else if (!strcmp(images[i], FIT_KERNEL_PROP))
#if CONFIG_IS_ENABLED(OPTEE)
			spl_image->entry_point_os = image_info.load_addr;
#endif
#if CONFIG_IS_ENABLED(ATF)
			spl_image->entry_point_bl33 = image_info.load_addr;
#endif
	}

	debug("fdt_addr=0x%08lx, entry_point=0x%08lx, entry_point_os=0x%08lx\n",
	      (ulong)spl_image->fdt_addr,
	      spl_image->entry_point,
#if CONFIG_IS_ENABLED(OPTEE)
	      spl_image->entry_point_os);
#endif
#if CONFIG_IS_ENABLED(ATF)
	      spl_image->entry_point_bl33);
#endif

	return 0;
}
#endif

static int spl_internal_load_simple_fit(struct spl_image_info *spl_image,
					struct spl_load_info *info,
					ulong sector, void *fit_header)
{
	struct spl_image_info image_info;
	int base_offset;
	int images, ret;
	int index = 0;
	int node = -1;
	void *fit;

	fit = spl_fit_load_blob(info, sector, fit_header, &base_offset);
	if (!fit) {
		debug("%s: Cannot load blob\n", __func__);
		return -1;
	}

	/* find the node holding the images information */
	images = fdt_path_offset(fit, FIT_IMAGES_PATH);
	if (images < 0) {
		debug("%s: Cannot find /images node: %d\n", __func__, images);
		return -1;
	}

	/* if board sigs verify required, check self */
	if (fit_board_verify_required_sigs() &&
	    !IS_ENABLED(CONFIG_SPL_FIT_SIGNATURE)) {
		printf("Verified-boot requires CONFIG_SPL_FIT_SIGNATURE enabled\n");
		hang();
	}

	/* verify the configure node by keys, if required */
#ifdef CONFIG_SPL_FIT_SIGNATURE
	int conf_noffset;

	conf_noffset = fit_conf_get_node(fit, NULL);
	if (conf_noffset <= 0) {
		printf("No default config node\n");
		return -EINVAL;
	}

	ret = fit_config_verify(fit, conf_noffset);
	if (ret) {
		printf("fit verify configure failed, ret=%d\n", ret);
		return ret;
	}
	printf("\n");

#ifdef CONFIG_SPL_FIT_ROLLBACK_PROTECT
	uint32_t this_index, min_index;

	ret = fit_rollback_index_verify(fit, FIT_ROLLBACK_INDEX_SPL,
					&this_index, &min_index);
	if (ret) {
		printf("fit failed to get rollback index, ret=%d\n", ret);
		return ret;
	} else if (this_index < min_index) {
		printf("fit reject rollback: %d < %d(min)\n",
		       this_index, min_index);
		return -EINVAL;
	}

	printf("rollback index: %d >= %d(min), OK\n", this_index, min_index);
#endif
#endif

	/*
	 * If required to start the other core before load "loadables"
	 * firmwares, use the config "standalone" to load the other core's
	 * firmware, then start it.
	 * Normally, different cores' firmware is attach to the config
	 * "loadables" and load them together.
	 */
	if (node < 0)
		node = spl_fit_get_image_node(fit, images, FIT_STANDALONE_PROP,
					      0);
	if (node > 0) {
		/* Load the image and set up the spl_image structure */
		ret = spl_load_fit_image(info, sector, fit, base_offset, node,
					 &image_info);
		if (!ret) {
			if (image_info.entry_point == FDT_ERROR)
				image_info.entry_point = image_info.load_addr;

			ret = spl_fit_standalone_release(image_info.entry_point);
			if (ret)
				printf("Start standalone fail, ret = %d\n",
				       ret);
		}

		/* standalone is special one, continue to find others */
		node = -1;
	}

	/*
	 * Find the U-Boot image using the following search order:
	 *   - start at 'firmware' (e.g. an ARM Trusted Firmware)
	 *   - fall back 'kernel' (e.g. a Falcon-mode OS boot
	 *   - fall back to using the first 'loadables' entry
	 */
	if (node < 0)
		node = spl_fit_get_image_node(fit, images, FIT_FIRMWARE_PROP,
					      0);
#ifdef CONFIG_SPL_OS_BOOT
	if (node < 0)
		node = spl_fit_get_image_node(fit, images, FIT_KERNEL_PROP, 0);
#endif
	if (node < 0) {
		debug("could not find firmware image, trying loadables...\n");
		node = spl_fit_get_image_node(fit, images, "loadables", 0);
		/*
		 * If we pick the U-Boot image from "loadables", start at
		 * the second image when later loading additional images.
		 */
		index = 1;
	}
	if (node < 0) {
		debug("%s: Cannot find u-boot image node: %d\n",
		      __func__, node);
		return -1;
	}

	/* Load the image and set up the spl_image structure */
	ret = spl_load_fit_image(info, sector, fit, base_offset, node,
				 spl_image);
	if (ret)
		return ret;

	/*
	 * For backward compatibility, we treat the first node that is
	 * as a U-Boot image, if no OS-type has been declared.
	 */
	if (!spl_fit_image_get_os(fit, node, &spl_image->os))
		debug("Image OS is %s\n", genimg_get_os_name(spl_image->os));
#if !defined(CONFIG_SPL_OS_BOOT)
	else
		spl_image->os = IH_OS_U_BOOT;
#endif

	/*
	 * Booting a next-stage U-Boot may require us to append the FDT.
	 * We allow this to fail, as the U-Boot image might embed its FDT.
	 */
	if (spl_image->os == IH_OS_U_BOOT)
		spl_fit_append_fdt(spl_image, info, sector, fit,
				   images, base_offset);

	/* Now check if there are more images for us to load */
	for (; ; index++) {
		uint8_t os_type = IH_OS_INVALID;

		node = spl_fit_get_image_node(fit, images, "loadables", index);
		if (node < 0)
			break;

		if (!spl_fit_image_get_os(fit, node, &os_type))
			debug("Loadable is %s\n", genimg_get_os_name(os_type));

		/* skip U-Boot ? */
		if (spl_image->next_stage == SPL_NEXT_STAGE_KERNEL &&
		    os_type == IH_OS_U_BOOT)
		    continue;

		ret = spl_load_fit_image(info, sector, fit, base_offset, node,
					 &image_info);
		if (ret < 0)
			continue;

		if (os_type == IH_OS_U_BOOT) {
			spl_fit_append_fdt(&image_info, info, sector,
					   fit, images, base_offset);
			spl_image->fdt_addr = image_info.fdt_addr;
		}

		/*
		 * If the "firmware" image did not provide an entry point,
		 * use the first valid entry point from the loadables.
		 */
		if (spl_image->entry_point == FDT_ERROR &&
		    image_info.entry_point != FDT_ERROR)
			spl_image->entry_point = image_info.entry_point;

		/* Record our loadables into the FDT */
		if (spl_image->fdt_addr)
			spl_fit_record_loadable(fit, images, index,
						spl_image->fdt_addr,
						&image_info);
	}

	/*
	 * If a platform does not provide CONFIG_SYS_UBOOT_START, U-Boot's
	 * Makefile will set it to 0 and it will end up as the entry point
	 * here. What it actually means is: use the load address.
	 */
	if (spl_image->entry_point == FDT_ERROR || spl_image->entry_point == 0)
		spl_image->entry_point = spl_image->load_addr;

	return 0;
}

int spl_load_simple_fit(struct spl_image_info *spl_image,
			struct spl_load_info *info, ulong sector, void *fit)
{
	ulong sector_offs = sector;
	int ret = -EINVAL;
	int i;

	for (i = 0; i < CONFIG_SPL_FIT_IMAGE_MULTIPLE; i++) {
		if (i > 0) {
			sector_offs +=
			   i * ((CONFIG_SPL_FIT_IMAGE_KB << 10) / info->bl_len);
			printf("Trying fit image at 0x%lx sector\n", sector_offs);
			if (info->read(info, sector_offs, 1, fit) != 1) {
				printf("IO error\n");
				continue;
			}
		}

		if (image_get_magic(fit) != FDT_MAGIC) {
			printf("Not fit magic\n");
			continue;
		}

		ret = spl_internal_load_simple_fit(spl_image, info,
						   sector_offs, fit);
		if (!ret) {
#ifdef CONFIG_SPL_KERNEL_BOOT
			ret = spl_load_kernel_fit(spl_image, info);
#endif
			return ret;
		}
	}

	return ret;
}