xref: /rk3399_ARM-atf/services/std_svc/rmmd/rmmd_main.c (revision f19dc624a17c9df6aa444e33568b1f70ff4e9341)
177c27753SZelalem Aweke /*
277c27753SZelalem Aweke  * Copyright (c) 2021, ARM Limited and Contributors. All rights reserved.
377c27753SZelalem Aweke  *
477c27753SZelalem Aweke  * SPDX-License-Identifier: BSD-3-Clause
577c27753SZelalem Aweke  */
677c27753SZelalem Aweke 
777c27753SZelalem Aweke #include <assert.h>
877c27753SZelalem Aweke #include <errno.h>
977c27753SZelalem Aweke #include <string.h>
1077c27753SZelalem Aweke 
1177c27753SZelalem Aweke #include <arch_helpers.h>
1277c27753SZelalem Aweke #include <arch_features.h>
1377c27753SZelalem Aweke #include <bl31/bl31.h>
1477c27753SZelalem Aweke #include <common/debug.h>
1577c27753SZelalem Aweke #include <common/runtime_svc.h>
1677c27753SZelalem Aweke #include <context.h>
1777c27753SZelalem Aweke #include <lib/el3_runtime/context_mgmt.h>
1877c27753SZelalem Aweke #include <lib/el3_runtime/pubsub.h>
19*f19dc624Sjohpow01 #include <lib/gpt_rme/gpt_rme.h>
2077c27753SZelalem Aweke 
2177c27753SZelalem Aweke #include <lib/spinlock.h>
2277c27753SZelalem Aweke #include <lib/utils.h>
2377c27753SZelalem Aweke #include <lib/xlat_tables/xlat_tables_v2.h>
2477c27753SZelalem Aweke #include <plat/common/common_def.h>
2577c27753SZelalem Aweke #include <plat/common/platform.h>
2677c27753SZelalem Aweke #include <platform_def.h>
2777c27753SZelalem Aweke #include <services/gtsi_svc.h>
2877c27753SZelalem Aweke #include <services/rmi_svc.h>
2977c27753SZelalem Aweke #include <services/rmmd_svc.h>
3077c27753SZelalem Aweke #include <smccc_helpers.h>
3177c27753SZelalem Aweke #include "rmmd_initial_context.h"
3277c27753SZelalem Aweke #include "rmmd_private.h"
3377c27753SZelalem Aweke 
3477c27753SZelalem Aweke /*******************************************************************************
3577c27753SZelalem Aweke  * RMM context information.
3677c27753SZelalem Aweke  ******************************************************************************/
3777c27753SZelalem Aweke rmmd_rmm_context_t rmm_context[PLATFORM_CORE_COUNT];
3877c27753SZelalem Aweke 
3977c27753SZelalem Aweke /*******************************************************************************
4077c27753SZelalem Aweke  * RMM entry point information. Discovered on the primary core and reused
4177c27753SZelalem Aweke  * on secondary cores.
4277c27753SZelalem Aweke  ******************************************************************************/
4377c27753SZelalem Aweke static entry_point_info_t *rmm_ep_info;
4477c27753SZelalem Aweke 
4577c27753SZelalem Aweke /*******************************************************************************
4677c27753SZelalem Aweke  * Static function declaration.
4777c27753SZelalem Aweke  ******************************************************************************/
4877c27753SZelalem Aweke static int32_t rmm_init(void);
4977c27753SZelalem Aweke static uint64_t rmmd_smc_forward(uint32_t smc_fid, uint32_t src_sec_state,
5077c27753SZelalem Aweke 					uint32_t dst_sec_state, uint64_t x1,
5177c27753SZelalem Aweke 					uint64_t x2, uint64_t x3, uint64_t x4,
5277c27753SZelalem Aweke 					void *handle);
5377c27753SZelalem Aweke 
5477c27753SZelalem Aweke /*******************************************************************************
5577c27753SZelalem Aweke  * This function takes an RMM context pointer and performs a synchronous entry
5677c27753SZelalem Aweke  * into it.
5777c27753SZelalem Aweke  ******************************************************************************/
5877c27753SZelalem Aweke uint64_t rmmd_rmm_sync_entry(rmmd_rmm_context_t *rmm_ctx)
5977c27753SZelalem Aweke {
6077c27753SZelalem Aweke 	uint64_t rc;
6177c27753SZelalem Aweke 
6277c27753SZelalem Aweke 	assert(rmm_ctx != NULL);
6377c27753SZelalem Aweke 
6477c27753SZelalem Aweke 	cm_set_context(&(rmm_ctx->cpu_ctx), REALM);
6577c27753SZelalem Aweke 
6677c27753SZelalem Aweke 	/* Save the current el1/el2 context before loading realm context. */
6777c27753SZelalem Aweke 	cm_el1_sysregs_context_save(NON_SECURE);
6877c27753SZelalem Aweke 	cm_el2_sysregs_context_save(NON_SECURE);
6977c27753SZelalem Aweke 
7077c27753SZelalem Aweke 	/* Restore the realm context assigned above */
7177c27753SZelalem Aweke 	cm_el1_sysregs_context_restore(REALM);
7277c27753SZelalem Aweke 	cm_el2_sysregs_context_restore(REALM);
7377c27753SZelalem Aweke 	cm_set_next_eret_context(REALM);
7477c27753SZelalem Aweke 
7577c27753SZelalem Aweke 	/* Enter RMM */
7677c27753SZelalem Aweke 	rc = rmmd_rmm_enter(&rmm_ctx->c_rt_ctx);
7777c27753SZelalem Aweke 
7877c27753SZelalem Aweke 	/* Save realm context */
7977c27753SZelalem Aweke 	cm_el1_sysregs_context_save(REALM);
8077c27753SZelalem Aweke 	cm_el2_sysregs_context_save(REALM);
8177c27753SZelalem Aweke 
8277c27753SZelalem Aweke 	/* Restore the el1/el2 context again. */
8377c27753SZelalem Aweke 	cm_el1_sysregs_context_restore(NON_SECURE);
8477c27753SZelalem Aweke 	cm_el2_sysregs_context_restore(NON_SECURE);
8577c27753SZelalem Aweke 
8677c27753SZelalem Aweke 	return rc;
8777c27753SZelalem Aweke }
8877c27753SZelalem Aweke 
8977c27753SZelalem Aweke /*******************************************************************************
9077c27753SZelalem Aweke  * This function returns to the place where rmmd_rmm_sync_entry() was
9177c27753SZelalem Aweke  * called originally.
9277c27753SZelalem Aweke  ******************************************************************************/
9377c27753SZelalem Aweke __dead2 void rmmd_rmm_sync_exit(uint64_t rc)
9477c27753SZelalem Aweke {
9577c27753SZelalem Aweke 	rmmd_rmm_context_t *ctx = &rmm_context[plat_my_core_pos()];
9677c27753SZelalem Aweke 
9777c27753SZelalem Aweke 	/* Get context of the RMM in use by this CPU. */
9877c27753SZelalem Aweke 	assert(cm_get_context(REALM) == &(ctx->cpu_ctx));
9977c27753SZelalem Aweke 
10077c27753SZelalem Aweke 	/*
10177c27753SZelalem Aweke 	 * The RMMD must have initiated the original request through a
10277c27753SZelalem Aweke 	 * synchronous entry into RMM. Jump back to the original C runtime
10377c27753SZelalem Aweke 	 * context with the value of rc in x0;
10477c27753SZelalem Aweke 	 */
10577c27753SZelalem Aweke 	rmmd_rmm_exit(ctx->c_rt_ctx, rc);
10677c27753SZelalem Aweke 
10777c27753SZelalem Aweke 	panic();
10877c27753SZelalem Aweke }
10977c27753SZelalem Aweke 
11077c27753SZelalem Aweke static void rmm_el2_context_init(el2_sysregs_t *regs)
11177c27753SZelalem Aweke {
11277c27753SZelalem Aweke 	regs->ctx_regs[CTX_SPSR_EL2 >> 3] = REALM_SPSR_EL2;
11377c27753SZelalem Aweke 	regs->ctx_regs[CTX_SCTLR_EL2 >> 3] = SCTLR_EL2_RES1;
11477c27753SZelalem Aweke }
11577c27753SZelalem Aweke 
11677c27753SZelalem Aweke /*******************************************************************************
11777c27753SZelalem Aweke  * Jump to the RMM for the first time.
11877c27753SZelalem Aweke  ******************************************************************************/
11977c27753SZelalem Aweke static int32_t rmm_init(void)
12077c27753SZelalem Aweke {
12177c27753SZelalem Aweke 
12277c27753SZelalem Aweke 	uint64_t rc;
12377c27753SZelalem Aweke 
12477c27753SZelalem Aweke 	rmmd_rmm_context_t *ctx = &rmm_context[plat_my_core_pos()];
12577c27753SZelalem Aweke 
12677c27753SZelalem Aweke 	INFO("RMM init start.\n");
12777c27753SZelalem Aweke 	ctx->state = RMM_STATE_RESET;
12877c27753SZelalem Aweke 
12977c27753SZelalem Aweke 	/* Initialize RMM EL2 context. */
13077c27753SZelalem Aweke 	rmm_el2_context_init(&ctx->cpu_ctx.el2_sysregs_ctx);
13177c27753SZelalem Aweke 
13277c27753SZelalem Aweke 	rc = rmmd_rmm_sync_entry(ctx);
13377c27753SZelalem Aweke 	if (rc != 0ULL) {
13477c27753SZelalem Aweke 		ERROR("RMM initialisation failed 0x%llx\n", rc);
13577c27753SZelalem Aweke 		panic();
13677c27753SZelalem Aweke 	}
13777c27753SZelalem Aweke 
13877c27753SZelalem Aweke 	ctx->state = RMM_STATE_IDLE;
13977c27753SZelalem Aweke 	INFO("RMM init end.\n");
14077c27753SZelalem Aweke 
14177c27753SZelalem Aweke 	return 1;
14277c27753SZelalem Aweke }
14377c27753SZelalem Aweke 
14477c27753SZelalem Aweke /*******************************************************************************
14577c27753SZelalem Aweke  * Load and read RMM manifest, setup RMM.
14677c27753SZelalem Aweke  ******************************************************************************/
14777c27753SZelalem Aweke int rmmd_setup(void)
14877c27753SZelalem Aweke {
14977c27753SZelalem Aweke 	uint32_t ep_attr;
15077c27753SZelalem Aweke 	unsigned int linear_id = plat_my_core_pos();
15177c27753SZelalem Aweke 	rmmd_rmm_context_t *rmm_ctx = &rmm_context[linear_id];
15277c27753SZelalem Aweke 
15377c27753SZelalem Aweke 	/* Make sure RME is supported. */
15477c27753SZelalem Aweke 	assert(get_armv9_2_feat_rme_support() != 0U);
15577c27753SZelalem Aweke 
15677c27753SZelalem Aweke 	rmm_ep_info = bl31_plat_get_next_image_ep_info(REALM);
15777c27753SZelalem Aweke 	if (rmm_ep_info == NULL) {
15877c27753SZelalem Aweke 		WARN("No RMM image provided by BL2 boot loader, Booting "
15977c27753SZelalem Aweke 		     "device without RMM initialization. SMCs destined for "
16077c27753SZelalem Aweke 		     "RMM will return SMC_UNK\n");
16177c27753SZelalem Aweke 		return -ENOENT;
16277c27753SZelalem Aweke 	}
16377c27753SZelalem Aweke 
16477c27753SZelalem Aweke 	/* Under no circumstances will this parameter be 0 */
16577c27753SZelalem Aweke 	assert(rmm_ep_info->pc == RMM_BASE);
16677c27753SZelalem Aweke 
16777c27753SZelalem Aweke 	/* Initialise an entrypoint to set up the CPU context */
16877c27753SZelalem Aweke 	ep_attr = EP_REALM;
16977c27753SZelalem Aweke 	if ((read_sctlr_el3() & SCTLR_EE_BIT) != 0U) {
17077c27753SZelalem Aweke 		ep_attr |= EP_EE_BIG;
17177c27753SZelalem Aweke 	}
17277c27753SZelalem Aweke 
17377c27753SZelalem Aweke 	SET_PARAM_HEAD(rmm_ep_info, PARAM_EP, VERSION_1, ep_attr);
17477c27753SZelalem Aweke 	rmm_ep_info->spsr = SPSR_64(MODE_EL2,
17577c27753SZelalem Aweke 					MODE_SP_ELX,
17677c27753SZelalem Aweke 					DISABLE_ALL_EXCEPTIONS);
17777c27753SZelalem Aweke 
17877c27753SZelalem Aweke 	/* Initialise RMM context with this entry point information */
17977c27753SZelalem Aweke 	cm_setup_context(&rmm_ctx->cpu_ctx, rmm_ep_info);
18077c27753SZelalem Aweke 
18177c27753SZelalem Aweke 	INFO("RMM setup done.\n");
18277c27753SZelalem Aweke 
18377c27753SZelalem Aweke 	/* Register init function for deferred init.  */
18477c27753SZelalem Aweke 	bl31_register_rmm_init(&rmm_init);
18577c27753SZelalem Aweke 
18677c27753SZelalem Aweke 	return 0;
18777c27753SZelalem Aweke }
18877c27753SZelalem Aweke 
18977c27753SZelalem Aweke /*******************************************************************************
19077c27753SZelalem Aweke  * Forward SMC to the other security state
19177c27753SZelalem Aweke  ******************************************************************************/
19277c27753SZelalem Aweke static uint64_t	rmmd_smc_forward(uint32_t smc_fid, uint32_t src_sec_state,
19377c27753SZelalem Aweke 					uint32_t dst_sec_state, uint64_t x1,
19477c27753SZelalem Aweke 					uint64_t x2, uint64_t x3, uint64_t x4,
19577c27753SZelalem Aweke 					void *handle)
19677c27753SZelalem Aweke {
19777c27753SZelalem Aweke 	/* Save incoming security state */
19877c27753SZelalem Aweke 	cm_el1_sysregs_context_save(src_sec_state);
19977c27753SZelalem Aweke 	cm_el2_sysregs_context_save(src_sec_state);
20077c27753SZelalem Aweke 
20177c27753SZelalem Aweke 	/* Restore outgoing security state */
20277c27753SZelalem Aweke 	cm_el1_sysregs_context_restore(dst_sec_state);
20377c27753SZelalem Aweke 	cm_el2_sysregs_context_restore(dst_sec_state);
20477c27753SZelalem Aweke 	cm_set_next_eret_context(dst_sec_state);
20577c27753SZelalem Aweke 
20677c27753SZelalem Aweke 	SMC_RET8(cm_get_context(dst_sec_state), smc_fid, x1, x2, x3, x4,
20777c27753SZelalem Aweke 			SMC_GET_GP(handle, CTX_GPREG_X5),
20877c27753SZelalem Aweke 			SMC_GET_GP(handle, CTX_GPREG_X6),
20977c27753SZelalem Aweke 			SMC_GET_GP(handle, CTX_GPREG_X7));
21077c27753SZelalem Aweke }
21177c27753SZelalem Aweke 
21277c27753SZelalem Aweke /*******************************************************************************
21377c27753SZelalem Aweke  * This function handles all SMCs in the range reserved for RMI. Each call is
21477c27753SZelalem Aweke  * either forwarded to the other security state or handled by the RMM dispatcher
21577c27753SZelalem Aweke  ******************************************************************************/
21677c27753SZelalem Aweke uint64_t rmmd_rmi_handler(uint32_t smc_fid, uint64_t x1, uint64_t x2,
21777c27753SZelalem Aweke 				uint64_t x3, uint64_t x4, void *cookie,
21877c27753SZelalem Aweke 				void *handle, uint64_t flags)
21977c27753SZelalem Aweke {
22077c27753SZelalem Aweke 	rmmd_rmm_context_t *ctx = &rmm_context[plat_my_core_pos()];
22177c27753SZelalem Aweke 	uint32_t src_sec_state;
22277c27753SZelalem Aweke 
22377c27753SZelalem Aweke 	/* Determine which security state this SMC originated from */
22477c27753SZelalem Aweke 	src_sec_state = caller_sec_state(flags);
22577c27753SZelalem Aweke 
22677c27753SZelalem Aweke 	/* RMI must not be invoked by the Secure world */
22777c27753SZelalem Aweke 	if (src_sec_state == SMC_FROM_SECURE) {
22877c27753SZelalem Aweke 		WARN("RMM: RMI invoked by secure world.\n");
22977c27753SZelalem Aweke 		SMC_RET1(handle, SMC_UNK);
23077c27753SZelalem Aweke 	}
23177c27753SZelalem Aweke 
23277c27753SZelalem Aweke 	/*
23377c27753SZelalem Aweke 	 * Forward an RMI call from the Normal world to the Realm world as it
23477c27753SZelalem Aweke 	 * is.
23577c27753SZelalem Aweke 	 */
23677c27753SZelalem Aweke 	if (src_sec_state == SMC_FROM_NON_SECURE) {
23777c27753SZelalem Aweke 		VERBOSE("RMM: RMI call from non-secure world.\n");
23877c27753SZelalem Aweke 		return rmmd_smc_forward(smc_fid, NON_SECURE, REALM,
23977c27753SZelalem Aweke 					x1, x2, x3, x4, handle);
24077c27753SZelalem Aweke 	}
24177c27753SZelalem Aweke 
24277c27753SZelalem Aweke 	assert(src_sec_state == SMC_FROM_REALM);
24377c27753SZelalem Aweke 
24477c27753SZelalem Aweke 	switch (smc_fid) {
24577c27753SZelalem Aweke 	case RMI_RMM_REQ_COMPLETE:
24677c27753SZelalem Aweke 		if (ctx->state == RMM_STATE_RESET) {
24777c27753SZelalem Aweke 			VERBOSE("RMM: running rmmd_rmm_sync_exit\n");
24877c27753SZelalem Aweke 			rmmd_rmm_sync_exit(x1);
24977c27753SZelalem Aweke 		}
25077c27753SZelalem Aweke 
25177c27753SZelalem Aweke 		return rmmd_smc_forward(x1, REALM, NON_SECURE,
25277c27753SZelalem Aweke 					x2, x3, x4, 0, handle);
25377c27753SZelalem Aweke 
25477c27753SZelalem Aweke 	default:
25577c27753SZelalem Aweke 		WARN("RMM: Unsupported RMM call 0x%08x\n", smc_fid);
25677c27753SZelalem Aweke 		SMC_RET1(handle, SMC_UNK);
25777c27753SZelalem Aweke 	}
25877c27753SZelalem Aweke }
25977c27753SZelalem Aweke 
26077c27753SZelalem Aweke /*******************************************************************************
26177c27753SZelalem Aweke  * This cpu has been turned on. Enter RMM to initialise R-EL2.  Entry into RMM
26277c27753SZelalem Aweke  * is done after initialising minimal architectural state that guarantees safe
26377c27753SZelalem Aweke  * execution.
26477c27753SZelalem Aweke  ******************************************************************************/
26577c27753SZelalem Aweke static void *rmmd_cpu_on_finish_handler(const void *arg)
26677c27753SZelalem Aweke {
26777c27753SZelalem Aweke 	int32_t rc;
26877c27753SZelalem Aweke 	uint32_t linear_id = plat_my_core_pos();
26977c27753SZelalem Aweke 	rmmd_rmm_context_t *ctx = &rmm_context[linear_id];
27077c27753SZelalem Aweke 
27177c27753SZelalem Aweke 	ctx->state = RMM_STATE_RESET;
27277c27753SZelalem Aweke 
27377c27753SZelalem Aweke 	/* Initialise RMM context with this entry point information */
27477c27753SZelalem Aweke 	cm_setup_context(&ctx->cpu_ctx, rmm_ep_info);
27577c27753SZelalem Aweke 
27677c27753SZelalem Aweke 	/* Initialize RMM EL2 context. */
27777c27753SZelalem Aweke 	rmm_el2_context_init(&ctx->cpu_ctx.el2_sysregs_ctx);
27877c27753SZelalem Aweke 
27977c27753SZelalem Aweke 	rc = rmmd_rmm_sync_entry(ctx);
28077c27753SZelalem Aweke 	if (rc != 0) {
28177c27753SZelalem Aweke 		ERROR("RMM initialisation failed (%d) on CPU%d\n", rc,
28277c27753SZelalem Aweke 		      linear_id);
28377c27753SZelalem Aweke 		panic();
28477c27753SZelalem Aweke 	}
28577c27753SZelalem Aweke 
28677c27753SZelalem Aweke 	ctx->state = RMM_STATE_IDLE;
28777c27753SZelalem Aweke 	return NULL;
28877c27753SZelalem Aweke }
28977c27753SZelalem Aweke 
29077c27753SZelalem Aweke /* Subscribe to PSCI CPU on to initialize RMM on secondary */
29177c27753SZelalem Aweke SUBSCRIBE_TO_EVENT(psci_cpu_on_finish, rmmd_cpu_on_finish_handler);
29277c27753SZelalem Aweke 
29377c27753SZelalem Aweke static int gtsi_transition_granule(uint64_t pa,
29477c27753SZelalem Aweke 					unsigned int src_sec_state,
29577c27753SZelalem Aweke 					unsigned int target_pas)
29677c27753SZelalem Aweke {
29777c27753SZelalem Aweke 	int ret;
29877c27753SZelalem Aweke 
299*f19dc624Sjohpow01 	ret = gpt_transition_pas(pa, PAGE_SIZE_4KB, src_sec_state, target_pas);
30077c27753SZelalem Aweke 
30177c27753SZelalem Aweke 	/* Convert TF-A error codes into GTSI error codes */
30277c27753SZelalem Aweke 	if (ret == -EINVAL) {
303*f19dc624Sjohpow01 		ERROR("[GTSI] Transition failed: invalid %s\n", "address");
304*f19dc624Sjohpow01 		ERROR("       PA: 0x%llx, SRC: %d, PAS: %d\n", pa,
305*f19dc624Sjohpow01 		      src_sec_state, target_pas);
30677c27753SZelalem Aweke 		ret = GRAN_TRANS_RET_BAD_ADDR;
30777c27753SZelalem Aweke 	} else if (ret == -EPERM) {
308*f19dc624Sjohpow01 		ERROR("[GTSI] Transition failed: invalid %s\n", "caller/PAS");
309*f19dc624Sjohpow01 		ERROR("       PA: 0x%llx, SRC: %d, PAS: %d\n", pa,
310*f19dc624Sjohpow01 		      src_sec_state, target_pas);
31177c27753SZelalem Aweke 		ret = GRAN_TRANS_RET_BAD_PAS;
31277c27753SZelalem Aweke 	}
31377c27753SZelalem Aweke 
31477c27753SZelalem Aweke 	return ret;
31577c27753SZelalem Aweke }
31677c27753SZelalem Aweke 
31777c27753SZelalem Aweke /*******************************************************************************
31877c27753SZelalem Aweke  * This function handles all SMCs in the range reserved for GTF.
31977c27753SZelalem Aweke  ******************************************************************************/
32077c27753SZelalem Aweke uint64_t rmmd_gtsi_handler(uint32_t smc_fid, uint64_t x1, uint64_t x2,
32177c27753SZelalem Aweke 				uint64_t x3, uint64_t x4, void *cookie,
32277c27753SZelalem Aweke 				void *handle, uint64_t flags)
32377c27753SZelalem Aweke {
32477c27753SZelalem Aweke 	uint32_t src_sec_state;
32577c27753SZelalem Aweke 
32677c27753SZelalem Aweke 	/* Determine which security state this SMC originated from */
32777c27753SZelalem Aweke 	src_sec_state = caller_sec_state(flags);
32877c27753SZelalem Aweke 
32977c27753SZelalem Aweke 	if (src_sec_state != SMC_FROM_REALM) {
33077c27753SZelalem Aweke 		WARN("RMM: GTF call originated from secure or normal world\n");
33177c27753SZelalem Aweke 		SMC_RET1(handle, SMC_UNK);
33277c27753SZelalem Aweke 	}
33377c27753SZelalem Aweke 
33477c27753SZelalem Aweke 	switch (smc_fid) {
33577c27753SZelalem Aweke 	case SMC_ASC_MARK_REALM:
33677c27753SZelalem Aweke 		SMC_RET1(handle, gtsi_transition_granule(x1, SMC_FROM_REALM,
337*f19dc624Sjohpow01 								GPT_GPI_REALM));
33877c27753SZelalem Aweke 	case SMC_ASC_MARK_NONSECURE:
33977c27753SZelalem Aweke 		SMC_RET1(handle, gtsi_transition_granule(x1, SMC_FROM_REALM,
340*f19dc624Sjohpow01 								GPT_GPI_NS));
34177c27753SZelalem Aweke 	default:
34277c27753SZelalem Aweke 		WARN("RMM: Unsupported GTF call 0x%08x\n", smc_fid);
34377c27753SZelalem Aweke 		SMC_RET1(handle, SMC_UNK);
34477c27753SZelalem Aweke 	}
34577c27753SZelalem Aweke }
346