17d37aa17SJuan Castillo /* 2ed38366fSNicolas Toromanoff * Copyright (c) 2015-2022, ARM Limited and Contributors. All rights reserved. 37d37aa17SJuan Castillo * 482cb2c1aSdp-arm * SPDX-License-Identifier: BSD-3-Clause 57d37aa17SJuan Castillo */ 67d37aa17SJuan Castillo 77d37aa17SJuan Castillo /* 8649dbf6fSJuan Castillo * X509 parser based on mbed TLS 97d37aa17SJuan Castillo * 107d37aa17SJuan Castillo * This module implements functions to check the integrity of a X509v3 117d37aa17SJuan Castillo * certificate ASN.1 structure and extract authentication parameters from the 127d37aa17SJuan Castillo * extensions field, such as an image hash or a public key. 137d37aa17SJuan Castillo */ 147d37aa17SJuan Castillo 157d37aa17SJuan Castillo #include <assert.h> 167d37aa17SJuan Castillo #include <stddef.h> 177d37aa17SJuan Castillo #include <stdint.h> 187d37aa17SJuan Castillo #include <string.h> 197d37aa17SJuan Castillo 207d37aa17SJuan Castillo /* mbed TLS headers */ 21649dbf6fSJuan Castillo #include <mbedtls/asn1.h> 22649dbf6fSJuan Castillo #include <mbedtls/oid.h> 23649dbf6fSJuan Castillo #include <mbedtls/platform.h> 247d37aa17SJuan Castillo 2509d40e0eSAntonio Nino Diaz #include <arch_helpers.h> 2609d40e0eSAntonio Nino Diaz #include <drivers/auth/img_parser_mod.h> 2709d40e0eSAntonio Nino Diaz #include <drivers/auth/mbedtls/mbedtls_common.h> 2809d40e0eSAntonio Nino Diaz #include <lib/utils.h> 2909d40e0eSAntonio Nino Diaz 307d37aa17SJuan Castillo /* Maximum OID string length ("a.b.c.d.e.f ...") */ 317d37aa17SJuan Castillo #define MAX_OID_STR_LEN 64 327d37aa17SJuan Castillo 337d37aa17SJuan Castillo #define LIB_NAME "mbed TLS X509v3" 347d37aa17SJuan Castillo 357d37aa17SJuan Castillo /* Temporary variables to speed up the authentication parameters search. These 367d37aa17SJuan Castillo * variables are assigned once during the integrity check and used any time an 377d37aa17SJuan Castillo * authentication parameter is requested, so we do not have to parse the image 387d37aa17SJuan Castillo * again */ 39649dbf6fSJuan Castillo static mbedtls_asn1_buf tbs; 40649dbf6fSJuan Castillo static mbedtls_asn1_buf v3_ext; 41649dbf6fSJuan Castillo static mbedtls_asn1_buf pk; 42649dbf6fSJuan Castillo static mbedtls_asn1_buf sig_alg; 43649dbf6fSJuan Castillo static mbedtls_asn1_buf signature; 447d37aa17SJuan Castillo 457d37aa17SJuan Castillo /* 4651c5e1a2SAntonio Nino Diaz * Clear all static temporary variables. 4751c5e1a2SAntonio Nino Diaz */ 4851c5e1a2SAntonio Nino Diaz static void clear_temp_vars(void) 4951c5e1a2SAntonio Nino Diaz { 5051c5e1a2SAntonio Nino Diaz #define ZERO_AND_CLEAN(x) \ 5151c5e1a2SAntonio Nino Diaz do { \ 5232f0d3c6SDouglas Raillard zeromem(&x, sizeof(x)); \ 5351c5e1a2SAntonio Nino Diaz clean_dcache_range((uintptr_t)&x, sizeof(x)); \ 5451c5e1a2SAntonio Nino Diaz } while (0); 5551c5e1a2SAntonio Nino Diaz 5651c5e1a2SAntonio Nino Diaz ZERO_AND_CLEAN(tbs) 5751c5e1a2SAntonio Nino Diaz ZERO_AND_CLEAN(v3_ext); 5851c5e1a2SAntonio Nino Diaz ZERO_AND_CLEAN(pk); 5951c5e1a2SAntonio Nino Diaz ZERO_AND_CLEAN(sig_alg); 6051c5e1a2SAntonio Nino Diaz ZERO_AND_CLEAN(signature); 6151c5e1a2SAntonio Nino Diaz 6251c5e1a2SAntonio Nino Diaz #undef ZERO_AND_CLEAN 6351c5e1a2SAntonio Nino Diaz } 6451c5e1a2SAntonio Nino Diaz 6551c5e1a2SAntonio Nino Diaz /* 667d37aa17SJuan Castillo * Get X509v3 extension 677d37aa17SJuan Castillo * 687d37aa17SJuan Castillo * Global variable 'v3_ext' must point to the extensions region 697d37aa17SJuan Castillo * in the certificate. No need to check for errors since the image has passed 707d37aa17SJuan Castillo * the integrity check. 717d37aa17SJuan Castillo */ 727d37aa17SJuan Castillo static int get_ext(const char *oid, void **ext, unsigned int *ext_len) 737d37aa17SJuan Castillo { 747d37aa17SJuan Castillo int oid_len; 757d37aa17SJuan Castillo size_t len; 767d37aa17SJuan Castillo unsigned char *end_ext_data, *end_ext_octet; 777d37aa17SJuan Castillo unsigned char *p; 787d37aa17SJuan Castillo const unsigned char *end; 797d37aa17SJuan Castillo char oid_str[MAX_OID_STR_LEN]; 80649dbf6fSJuan Castillo mbedtls_asn1_buf extn_oid; 817d37aa17SJuan Castillo int is_critical; 827d37aa17SJuan Castillo 837d37aa17SJuan Castillo assert(oid != NULL); 847d37aa17SJuan Castillo 857d37aa17SJuan Castillo p = v3_ext.p; 867d37aa17SJuan Castillo end = v3_ext.p + v3_ext.len; 877d37aa17SJuan Castillo 88649dbf6fSJuan Castillo mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 89649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 907d37aa17SJuan Castillo 917d37aa17SJuan Castillo while (p < end) { 9232f0d3c6SDouglas Raillard zeromem(&extn_oid, sizeof(extn_oid)); 937d37aa17SJuan Castillo is_critical = 0; /* DEFAULT FALSE */ 947d37aa17SJuan Castillo 95649dbf6fSJuan Castillo mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 96649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 977d37aa17SJuan Castillo end_ext_data = p + len; 987d37aa17SJuan Castillo 997d37aa17SJuan Castillo /* Get extension ID */ 1007d37aa17SJuan Castillo extn_oid.tag = *p; 101649dbf6fSJuan Castillo mbedtls_asn1_get_tag(&p, end, &extn_oid.len, MBEDTLS_ASN1_OID); 1027d37aa17SJuan Castillo extn_oid.p = p; 1037d37aa17SJuan Castillo p += extn_oid.len; 1047d37aa17SJuan Castillo 1057d37aa17SJuan Castillo /* Get optional critical */ 106649dbf6fSJuan Castillo mbedtls_asn1_get_bool(&p, end_ext_data, &is_critical); 1077d37aa17SJuan Castillo 1087d37aa17SJuan Castillo /* Extension data */ 109649dbf6fSJuan Castillo mbedtls_asn1_get_tag(&p, end_ext_data, &len, 110649dbf6fSJuan Castillo MBEDTLS_ASN1_OCTET_STRING); 1117d37aa17SJuan Castillo end_ext_octet = p + len; 1127d37aa17SJuan Castillo 1137d37aa17SJuan Castillo /* Detect requested extension */ 114649dbf6fSJuan Castillo oid_len = mbedtls_oid_get_numeric_string(oid_str, 115649dbf6fSJuan Castillo MAX_OID_STR_LEN, 116649dbf6fSJuan Castillo &extn_oid); 117ed38366fSNicolas Toromanoff if ((oid_len == MBEDTLS_ERR_OID_BUF_TOO_SMALL) || (oid_len < 0)) { 1187d37aa17SJuan Castillo return IMG_PARSER_ERR; 1197d37aa17SJuan Castillo } 120ed38366fSNicolas Toromanoff if (((size_t)oid_len == strlen(oid_str)) && !strcmp(oid, oid_str)) { 1217d37aa17SJuan Castillo *ext = (void *)p; 1227d37aa17SJuan Castillo *ext_len = (unsigned int)len; 1237d37aa17SJuan Castillo return IMG_PARSER_OK; 1247d37aa17SJuan Castillo } 1257d37aa17SJuan Castillo 1267d37aa17SJuan Castillo /* Next */ 1277d37aa17SJuan Castillo p = end_ext_octet; 1287d37aa17SJuan Castillo } 1297d37aa17SJuan Castillo 1307d37aa17SJuan Castillo return IMG_PARSER_ERR_NOT_FOUND; 1317d37aa17SJuan Castillo } 1327d37aa17SJuan Castillo 1337d37aa17SJuan Castillo 1347d37aa17SJuan Castillo /* 1357d37aa17SJuan Castillo * Check the integrity of the certificate ASN.1 structure. 13651c5e1a2SAntonio Nino Diaz * 1377d37aa17SJuan Castillo * Extract the relevant data that will be used later during authentication. 13851c5e1a2SAntonio Nino Diaz * 13951c5e1a2SAntonio Nino Diaz * This function doesn't clear the static variables located on the top of this 14051c5e1a2SAntonio Nino Diaz * file in case of an error. It is only called from check_integrity(), which 14151c5e1a2SAntonio Nino Diaz * performs the cleanup if necessary. 1427d37aa17SJuan Castillo */ 1437d37aa17SJuan Castillo static int cert_parse(void *img, unsigned int img_len) 1447d37aa17SJuan Castillo { 1457d37aa17SJuan Castillo int ret, is_critical; 1467d37aa17SJuan Castillo size_t len; 14794c0cfbbSDemi Marie Obenour unsigned char *p, *end, *crt_end, *pk_end; 148649dbf6fSJuan Castillo mbedtls_asn1_buf sig_alg1, sig_alg2; 149e9e4a2a6SDemi Marie Obenour /* 150e9e4a2a6SDemi Marie Obenour * The unique ASN.1 DER encoding of [0] EXPLICIT INTEGER { v3(2} }. 151e9e4a2a6SDemi Marie Obenour */ 152e9e4a2a6SDemi Marie Obenour static const char v3[] = { 153e9e4a2a6SDemi Marie Obenour /* The outer CONTEXT SPECIFIC 0 tag */ 154e9e4a2a6SDemi Marie Obenour MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_CONTEXT_SPECIFIC | 0, 155e9e4a2a6SDemi Marie Obenour /* The number bytes used to encode the inner INTEGER */ 156e9e4a2a6SDemi Marie Obenour 3, 157e9e4a2a6SDemi Marie Obenour /* The tag of the inner INTEGER */ 158e9e4a2a6SDemi Marie Obenour MBEDTLS_ASN1_INTEGER, 159e9e4a2a6SDemi Marie Obenour /* The number of bytes needed to represent 2 */ 160e9e4a2a6SDemi Marie Obenour 1, 161e9e4a2a6SDemi Marie Obenour /* The actual value 2 */ 162e9e4a2a6SDemi Marie Obenour 2, 163e9e4a2a6SDemi Marie Obenour }; 1647d37aa17SJuan Castillo 1657d37aa17SJuan Castillo p = (unsigned char *)img; 1667d37aa17SJuan Castillo len = img_len; 1677d37aa17SJuan Castillo end = p + len; 1687d37aa17SJuan Castillo 1697d37aa17SJuan Castillo /* 1707d37aa17SJuan Castillo * Certificate ::= SEQUENCE { 1717d37aa17SJuan Castillo * tbsCertificate TBSCertificate, 1727d37aa17SJuan Castillo * signatureAlgorithm AlgorithmIdentifier, 1737d37aa17SJuan Castillo * signatureValue BIT STRING } 1747d37aa17SJuan Castillo */ 175649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 176649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 1777d37aa17SJuan Castillo if (ret != 0) { 1787d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 1797d37aa17SJuan Castillo } 1807d37aa17SJuan Castillo 181*ca34dbc0SDemi Marie Obenour if (len != (size_t)(end - p)) { 1827d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 1837d37aa17SJuan Castillo } 1847d37aa17SJuan Castillo crt_end = p + len; 1857d37aa17SJuan Castillo 1867d37aa17SJuan Castillo /* 1877d37aa17SJuan Castillo * TBSCertificate ::= SEQUENCE { 1887d37aa17SJuan Castillo */ 1897d37aa17SJuan Castillo tbs.p = p; 190649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 191649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 1927d37aa17SJuan Castillo if (ret != 0) { 1937d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 1947d37aa17SJuan Castillo } 1957d37aa17SJuan Castillo end = p + len; 1967d37aa17SJuan Castillo tbs.len = end - tbs.p; 1977d37aa17SJuan Castillo 1987d37aa17SJuan Castillo /* 199e9e4a2a6SDemi Marie Obenour * Version ::= [0] EXPLICIT INTEGER { v1(0), v2(1), v3(2) } 200e9e4a2a6SDemi Marie Obenour * -- only v3 accepted 2017d37aa17SJuan Castillo */ 202e9e4a2a6SDemi Marie Obenour if (((end - p) <= (ptrdiff_t)sizeof(v3)) || 203e9e4a2a6SDemi Marie Obenour (memcmp(p, v3, sizeof(v3)) != 0)) { 2047d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2057d37aa17SJuan Castillo } 206e9e4a2a6SDemi Marie Obenour p += sizeof(v3); 2077d37aa17SJuan Castillo 2087d37aa17SJuan Castillo /* 2097d37aa17SJuan Castillo * CertificateSerialNumber ::= INTEGER 2107d37aa17SJuan Castillo */ 211649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_INTEGER); 2127d37aa17SJuan Castillo if (ret != 0) { 2137d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2147d37aa17SJuan Castillo } 2157d37aa17SJuan Castillo p += len; 2167d37aa17SJuan Castillo 2177d37aa17SJuan Castillo /* 2187d37aa17SJuan Castillo * signature AlgorithmIdentifier 2197d37aa17SJuan Castillo */ 2207d37aa17SJuan Castillo sig_alg1.p = p; 221649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 222649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 2237d37aa17SJuan Castillo if (ret != 0) { 2247d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2257d37aa17SJuan Castillo } 2267d37aa17SJuan Castillo if ((end - p) < 1) { 2277d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2287d37aa17SJuan Castillo } 2297d37aa17SJuan Castillo sig_alg1.len = (p + len) - sig_alg1.p; 2307d37aa17SJuan Castillo p += len; 2317d37aa17SJuan Castillo 2327d37aa17SJuan Castillo /* 2337d37aa17SJuan Castillo * issuer Name 2347d37aa17SJuan Castillo */ 235649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 236649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 2377d37aa17SJuan Castillo if (ret != 0) { 2387d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2397d37aa17SJuan Castillo } 2407d37aa17SJuan Castillo p += len; 2417d37aa17SJuan Castillo 2427d37aa17SJuan Castillo /* 2437d37aa17SJuan Castillo * Validity ::= SEQUENCE { 2447d37aa17SJuan Castillo * notBefore Time, 2457d37aa17SJuan Castillo * notAfter Time } 2467d37aa17SJuan Castillo * 2477d37aa17SJuan Castillo */ 248649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 249649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 2507d37aa17SJuan Castillo if (ret != 0) { 2517d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2527d37aa17SJuan Castillo } 2537d37aa17SJuan Castillo p += len; 2547d37aa17SJuan Castillo 2557d37aa17SJuan Castillo /* 2567d37aa17SJuan Castillo * subject Name 2577d37aa17SJuan Castillo */ 258649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 259649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 2607d37aa17SJuan Castillo if (ret != 0) { 2617d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2627d37aa17SJuan Castillo } 2637d37aa17SJuan Castillo p += len; 2647d37aa17SJuan Castillo 2657d37aa17SJuan Castillo /* 2667d37aa17SJuan Castillo * SubjectPublicKeyInfo 2677d37aa17SJuan Castillo */ 2687d37aa17SJuan Castillo pk.p = p; 269649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 270649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 2717d37aa17SJuan Castillo if (ret != 0) { 2727d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 2737d37aa17SJuan Castillo } 27494c0cfbbSDemi Marie Obenour pk_end = p + len; 27594c0cfbbSDemi Marie Obenour pk.len = pk_end - pk.p; 27694c0cfbbSDemi Marie Obenour 27794c0cfbbSDemi Marie Obenour ret = mbedtls_asn1_get_tag(&p, pk_end, &len, MBEDTLS_ASN1_CONSTRUCTED | 27894c0cfbbSDemi Marie Obenour MBEDTLS_ASN1_SEQUENCE); 27994c0cfbbSDemi Marie Obenour if (ret != 0) { 28094c0cfbbSDemi Marie Obenour return IMG_PARSER_ERR_FORMAT; 28194c0cfbbSDemi Marie Obenour } 2827d37aa17SJuan Castillo p += len; 2837d37aa17SJuan Castillo 2848816dbb3SDemi Marie Obenour /* Key is a BIT STRING and must use all bytes in SubjectPublicKeyInfo */ 2858816dbb3SDemi Marie Obenour ret = mbedtls_asn1_get_bitstring_null(&p, pk_end, &len); 28694c0cfbbSDemi Marie Obenour if ((ret != 0) || (p + len != pk_end)) { 28794c0cfbbSDemi Marie Obenour return IMG_PARSER_ERR_FORMAT; 28894c0cfbbSDemi Marie Obenour } 28994c0cfbbSDemi Marie Obenour p = pk_end; 29094c0cfbbSDemi Marie Obenour 2917d37aa17SJuan Castillo /* 2927d37aa17SJuan Castillo * issuerUniqueID [1] IMPLICIT UniqueIdentifier OPTIONAL, 2937d37aa17SJuan Castillo */ 294649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, 295649dbf6fSJuan Castillo MBEDTLS_ASN1_CONTEXT_SPECIFIC | 296649dbf6fSJuan Castillo MBEDTLS_ASN1_CONSTRUCTED | 1); 2977d37aa17SJuan Castillo if (ret != 0) { 298649dbf6fSJuan Castillo if (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG) { 2997d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3007d37aa17SJuan Castillo } 3017d37aa17SJuan Castillo } else { 3027d37aa17SJuan Castillo p += len; 3037d37aa17SJuan Castillo } 3047d37aa17SJuan Castillo 3057d37aa17SJuan Castillo /* 3067d37aa17SJuan Castillo * subjectUniqueID [2] IMPLICIT UniqueIdentifier OPTIONAL, 3077d37aa17SJuan Castillo */ 308649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, 309649dbf6fSJuan Castillo MBEDTLS_ASN1_CONTEXT_SPECIFIC | 310649dbf6fSJuan Castillo MBEDTLS_ASN1_CONSTRUCTED | 2); 3117d37aa17SJuan Castillo if (ret != 0) { 312649dbf6fSJuan Castillo if (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG) { 3137d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3147d37aa17SJuan Castillo } 3157d37aa17SJuan Castillo } else { 3167d37aa17SJuan Castillo p += len; 3177d37aa17SJuan Castillo } 3187d37aa17SJuan Castillo 3197d37aa17SJuan Castillo /* 3207d37aa17SJuan Castillo * extensions [3] EXPLICIT Extensions OPTIONAL 32172460f50SDemi Marie Obenour * } 32272460f50SDemi Marie Obenour * 32372460f50SDemi Marie Obenour * X.509 and RFC5280 allow omitting the extensions entirely. 32472460f50SDemi Marie Obenour * However, in TF-A, a certificate with no extensions would 32572460f50SDemi Marie Obenour * always fail later on, as the extensions contain the 32672460f50SDemi Marie Obenour * information needed to authenticate the next stage in the 32772460f50SDemi Marie Obenour * boot chain. Furthermore, get_ext() assumes that the 32872460f50SDemi Marie Obenour * extensions have been parsed into v3_ext, and allowing 32972460f50SDemi Marie Obenour * there to be no extensions would pointlessly complicate 33072460f50SDemi Marie Obenour * the code. Therefore, just reject certificates without 33172460f50SDemi Marie Obenour * extensions. This is also why version 1 and 2 certificates 33272460f50SDemi Marie Obenour * are rejected above. 3337d37aa17SJuan Castillo */ 334649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, 335649dbf6fSJuan Castillo MBEDTLS_ASN1_CONTEXT_SPECIFIC | 336649dbf6fSJuan Castillo MBEDTLS_ASN1_CONSTRUCTED | 3); 337fd37982aSDemi Marie Obenour if ((ret != 0) || (len != (size_t)(end - p))) { 3387d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3397d37aa17SJuan Castillo } 3407d37aa17SJuan Castillo 3417d37aa17SJuan Castillo /* 3427d37aa17SJuan Castillo * Extensions ::= SEQUENCE SIZE (1..MAX) OF Extension 343fd37982aSDemi Marie Obenour * -- must use all remaining bytes in TBSCertificate 3447d37aa17SJuan Castillo */ 3457d37aa17SJuan Castillo v3_ext.p = p; 346649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 347649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 348fd37982aSDemi Marie Obenour if ((ret != 0) || (len != (size_t)(end - p))) { 3497d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3507d37aa17SJuan Castillo } 351fd37982aSDemi Marie Obenour v3_ext.len = end - v3_ext.p; 3527d37aa17SJuan Castillo 3537d37aa17SJuan Castillo /* 35472460f50SDemi Marie Obenour * Check extensions integrity. At least one extension is 35572460f50SDemi Marie Obenour * required: the ASN.1 specifies a minimum size of 1, and at 35672460f50SDemi Marie Obenour * least one extension is needed to authenticate the next stage 35772460f50SDemi Marie Obenour * in the boot chain. 3587d37aa17SJuan Castillo */ 35972460f50SDemi Marie Obenour do { 360649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, 361649dbf6fSJuan Castillo MBEDTLS_ASN1_CONSTRUCTED | 362649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 3637d37aa17SJuan Castillo if (ret != 0) { 3647d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3657d37aa17SJuan Castillo } 3667d37aa17SJuan Castillo 3677d37aa17SJuan Castillo /* Get extension ID */ 368649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_OID); 3697d37aa17SJuan Castillo if (ret != 0) { 3707d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3717d37aa17SJuan Castillo } 3727d37aa17SJuan Castillo p += len; 3737d37aa17SJuan Castillo 3747d37aa17SJuan Castillo /* Get optional critical */ 375649dbf6fSJuan Castillo ret = mbedtls_asn1_get_bool(&p, end, &is_critical); 376649dbf6fSJuan Castillo if ((ret != 0) && (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG)) { 3777d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3787d37aa17SJuan Castillo } 3797d37aa17SJuan Castillo 3807d37aa17SJuan Castillo /* Data should be octet string type */ 381649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, 382649dbf6fSJuan Castillo MBEDTLS_ASN1_OCTET_STRING); 3837d37aa17SJuan Castillo if (ret != 0) { 3847d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3857d37aa17SJuan Castillo } 3867d37aa17SJuan Castillo p += len; 38772460f50SDemi Marie Obenour } while (p < end); 3887d37aa17SJuan Castillo 3897d37aa17SJuan Castillo if (p != end) { 3907d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 3917d37aa17SJuan Castillo } 3927d37aa17SJuan Castillo 3937d37aa17SJuan Castillo end = crt_end; 3947d37aa17SJuan Castillo 3957d37aa17SJuan Castillo /* 3967d37aa17SJuan Castillo * } 3977d37aa17SJuan Castillo * -- end of TBSCertificate 3987d37aa17SJuan Castillo * 3997d37aa17SJuan Castillo * signatureAlgorithm AlgorithmIdentifier 4007d37aa17SJuan Castillo */ 4017d37aa17SJuan Castillo sig_alg2.p = p; 402649dbf6fSJuan Castillo ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED | 403649dbf6fSJuan Castillo MBEDTLS_ASN1_SEQUENCE); 4047d37aa17SJuan Castillo if (ret != 0) { 4057d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 4067d37aa17SJuan Castillo } 4077d37aa17SJuan Castillo if ((end - p) < 1) { 4087d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 4097d37aa17SJuan Castillo } 4107d37aa17SJuan Castillo sig_alg2.len = (p + len) - sig_alg2.p; 4117d37aa17SJuan Castillo p += len; 4127d37aa17SJuan Castillo 4137d37aa17SJuan Castillo /* Compare both signature algorithms */ 4147d37aa17SJuan Castillo if (sig_alg1.len != sig_alg2.len) { 4157d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 4167d37aa17SJuan Castillo } 417fabd21adSAntonio Nino Diaz if (0 != memcmp(sig_alg1.p, sig_alg2.p, sig_alg1.len)) { 4187d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 4197d37aa17SJuan Castillo } 4207d37aa17SJuan Castillo memcpy(&sig_alg, &sig_alg1, sizeof(sig_alg)); 4217d37aa17SJuan Castillo 4227d37aa17SJuan Castillo /* 4237d37aa17SJuan Castillo * signatureValue BIT STRING 4247d37aa17SJuan Castillo */ 4257d37aa17SJuan Castillo signature.p = p; 4268816dbb3SDemi Marie Obenour ret = mbedtls_asn1_get_bitstring_null(&p, end, &len); 4277d37aa17SJuan Castillo if (ret != 0) { 4287d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 4297d37aa17SJuan Castillo } 4307d37aa17SJuan Castillo signature.len = (p + len) - signature.p; 4317d37aa17SJuan Castillo p += len; 4327d37aa17SJuan Castillo 4337d37aa17SJuan Castillo /* Check certificate length */ 4347d37aa17SJuan Castillo if (p != end) { 4357d37aa17SJuan Castillo return IMG_PARSER_ERR_FORMAT; 4367d37aa17SJuan Castillo } 4377d37aa17SJuan Castillo 4387d37aa17SJuan Castillo return IMG_PARSER_OK; 4397d37aa17SJuan Castillo } 4407d37aa17SJuan Castillo 4417d37aa17SJuan Castillo 4427d37aa17SJuan Castillo /* Exported functions */ 4437d37aa17SJuan Castillo 4447d37aa17SJuan Castillo static void init(void) 4457d37aa17SJuan Castillo { 4467d37aa17SJuan Castillo mbedtls_init(); 4477d37aa17SJuan Castillo } 4487d37aa17SJuan Castillo 44951c5e1a2SAntonio Nino Diaz /* 45051c5e1a2SAntonio Nino Diaz * Wrapper for cert_parse() that clears the static variables used by it in case 45151c5e1a2SAntonio Nino Diaz * of an error. 45251c5e1a2SAntonio Nino Diaz */ 4537d37aa17SJuan Castillo static int check_integrity(void *img, unsigned int img_len) 4547d37aa17SJuan Castillo { 45551c5e1a2SAntonio Nino Diaz int rc = cert_parse(img, img_len); 45651c5e1a2SAntonio Nino Diaz 45751c5e1a2SAntonio Nino Diaz if (rc != IMG_PARSER_OK) 45851c5e1a2SAntonio Nino Diaz clear_temp_vars(); 45951c5e1a2SAntonio Nino Diaz 46051c5e1a2SAntonio Nino Diaz return rc; 4617d37aa17SJuan Castillo } 4627d37aa17SJuan Castillo 4637d37aa17SJuan Castillo /* 4647d37aa17SJuan Castillo * Extract an authentication parameter from an X509v3 certificate 46548279d52SJuan Castillo * 46648279d52SJuan Castillo * This function returns a pointer to the extracted data and its length. 46748279d52SJuan Castillo * Depending on the type of parameter, a pointer to the data stored in the 46848279d52SJuan Castillo * certificate may be returned (i.e. an octet string containing a hash). Other 46948279d52SJuan Castillo * data may need to be copied and formatted (i.e. integers). In the later case, 47048279d52SJuan Castillo * a buffer of the correct type needs to be statically allocated, filled and 47148279d52SJuan Castillo * returned. 4727d37aa17SJuan Castillo */ 4737d37aa17SJuan Castillo static int get_auth_param(const auth_param_type_desc_t *type_desc, 4747d37aa17SJuan Castillo void *img, unsigned int img_len, 4757d37aa17SJuan Castillo void **param, unsigned int *param_len) 4767d37aa17SJuan Castillo { 4777d37aa17SJuan Castillo int rc = IMG_PARSER_OK; 4787d37aa17SJuan Castillo 4797d37aa17SJuan Castillo /* We do not use img because the check_integrity function has already 4807d37aa17SJuan Castillo * extracted the relevant data (v3_ext, pk, sig_alg, etc) */ 4817d37aa17SJuan Castillo 4827d37aa17SJuan Castillo switch (type_desc->type) { 4837d37aa17SJuan Castillo case AUTH_PARAM_RAW_DATA: 4847d37aa17SJuan Castillo /* Data to be signed */ 4857d37aa17SJuan Castillo *param = (void *)tbs.p; 4867d37aa17SJuan Castillo *param_len = (unsigned int)tbs.len; 4877d37aa17SJuan Castillo break; 4887d37aa17SJuan Castillo case AUTH_PARAM_HASH: 48948279d52SJuan Castillo case AUTH_PARAM_NV_CTR: 4907d37aa17SJuan Castillo /* All these parameters are included as X509v3 extensions */ 4917d37aa17SJuan Castillo rc = get_ext(type_desc->cookie, param, param_len); 4927d37aa17SJuan Castillo break; 4937d37aa17SJuan Castillo case AUTH_PARAM_PUB_KEY: 4947d37aa17SJuan Castillo if (type_desc->cookie != 0) { 4957d37aa17SJuan Castillo /* Get public key from extension */ 4967d37aa17SJuan Castillo rc = get_ext(type_desc->cookie, param, param_len); 4977d37aa17SJuan Castillo } else { 4987d37aa17SJuan Castillo /* Get the subject public key */ 4997d37aa17SJuan Castillo *param = (void *)pk.p; 5007d37aa17SJuan Castillo *param_len = (unsigned int)pk.len; 5017d37aa17SJuan Castillo } 5027d37aa17SJuan Castillo break; 5037d37aa17SJuan Castillo case AUTH_PARAM_SIG_ALG: 5047d37aa17SJuan Castillo /* Get the certificate signature algorithm */ 5057d37aa17SJuan Castillo *param = (void *)sig_alg.p; 5067d37aa17SJuan Castillo *param_len = (unsigned int)sig_alg.len; 5077d37aa17SJuan Castillo break; 5087d37aa17SJuan Castillo case AUTH_PARAM_SIG: 5097d37aa17SJuan Castillo /* Get the certificate signature */ 5107d37aa17SJuan Castillo *param = (void *)signature.p; 5117d37aa17SJuan Castillo *param_len = (unsigned int)signature.len; 5127d37aa17SJuan Castillo break; 5137d37aa17SJuan Castillo default: 5147d37aa17SJuan Castillo rc = IMG_PARSER_ERR_NOT_FOUND; 5157d37aa17SJuan Castillo break; 5167d37aa17SJuan Castillo } 5177d37aa17SJuan Castillo 5187d37aa17SJuan Castillo return rc; 5197d37aa17SJuan Castillo } 5207d37aa17SJuan Castillo 5217d37aa17SJuan Castillo REGISTER_IMG_PARSER_LIB(IMG_CERT, LIB_NAME, init, \ 5227d37aa17SJuan Castillo check_integrity, get_auth_param); 523