xref: /rk3399_ARM-atf/drivers/auth/mbedtls/mbedtls_x509_parser.c (revision 9a90d720b8a027f11dc2d1b316f5df5318b0d367)
17d37aa17SJuan Castillo /*
2654b65b3SYann Gautier  * Copyright (c) 2015-2023, ARM Limited and Contributors. All rights reserved.
37d37aa17SJuan Castillo  *
482cb2c1aSdp-arm  * SPDX-License-Identifier: BSD-3-Clause
57d37aa17SJuan Castillo  */
67d37aa17SJuan Castillo 
77d37aa17SJuan Castillo /*
8649dbf6fSJuan Castillo  * X509 parser based on mbed TLS
97d37aa17SJuan Castillo  *
107d37aa17SJuan Castillo  * This module implements functions to check the integrity of a X509v3
117d37aa17SJuan Castillo  * certificate ASN.1 structure and extract authentication parameters from the
127d37aa17SJuan Castillo  * extensions field, such as an image hash or a public key.
137d37aa17SJuan Castillo  */
147d37aa17SJuan Castillo 
157d37aa17SJuan Castillo #include <assert.h>
167d37aa17SJuan Castillo #include <stddef.h>
177d37aa17SJuan Castillo #include <stdint.h>
187d37aa17SJuan Castillo #include <string.h>
197d37aa17SJuan Castillo 
207d37aa17SJuan Castillo /* mbed TLS headers */
21649dbf6fSJuan Castillo #include <mbedtls/asn1.h>
22649dbf6fSJuan Castillo #include <mbedtls/oid.h>
23649dbf6fSJuan Castillo #include <mbedtls/platform.h>
247d37aa17SJuan Castillo 
2509d40e0eSAntonio Nino Diaz #include <arch_helpers.h>
2609d40e0eSAntonio Nino Diaz #include <drivers/auth/img_parser_mod.h>
2709d40e0eSAntonio Nino Diaz #include <drivers/auth/mbedtls/mbedtls_common.h>
2809d40e0eSAntonio Nino Diaz #include <lib/utils.h>
2909d40e0eSAntonio Nino Diaz 
307d37aa17SJuan Castillo /* Maximum OID string length ("a.b.c.d.e.f ...") */
317d37aa17SJuan Castillo #define MAX_OID_STR_LEN			64
327d37aa17SJuan Castillo 
337d37aa17SJuan Castillo #define LIB_NAME	"mbed TLS X509v3"
347d37aa17SJuan Castillo 
357d37aa17SJuan Castillo /* Temporary variables to speed up the authentication parameters search. These
367d37aa17SJuan Castillo  * variables are assigned once during the integrity check and used any time an
377d37aa17SJuan Castillo  * authentication parameter is requested, so we do not have to parse the image
387d37aa17SJuan Castillo  * again */
39649dbf6fSJuan Castillo static mbedtls_asn1_buf tbs;
40649dbf6fSJuan Castillo static mbedtls_asn1_buf v3_ext;
41649dbf6fSJuan Castillo static mbedtls_asn1_buf pk;
42649dbf6fSJuan Castillo static mbedtls_asn1_buf sig_alg;
43649dbf6fSJuan Castillo static mbedtls_asn1_buf signature;
447d37aa17SJuan Castillo 
457d37aa17SJuan Castillo /*
4651c5e1a2SAntonio Nino Diaz  * Clear all static temporary variables.
4751c5e1a2SAntonio Nino Diaz  */
4851c5e1a2SAntonio Nino Diaz static void clear_temp_vars(void)
4951c5e1a2SAntonio Nino Diaz {
5051c5e1a2SAntonio Nino Diaz #define ZERO_AND_CLEAN(x)					\
5151c5e1a2SAntonio Nino Diaz 	do {							\
5232f0d3c6SDouglas Raillard 		zeromem(&x, sizeof(x));				\
5351c5e1a2SAntonio Nino Diaz 		clean_dcache_range((uintptr_t)&x, sizeof(x));	\
5451c5e1a2SAntonio Nino Diaz 	} while (0);
5551c5e1a2SAntonio Nino Diaz 
5651c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(tbs)
5751c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(v3_ext);
5851c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(pk);
5951c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(sig_alg);
6051c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(signature);
6151c5e1a2SAntonio Nino Diaz 
6251c5e1a2SAntonio Nino Diaz #undef ZERO_AND_CLEAN
6351c5e1a2SAntonio Nino Diaz }
6451c5e1a2SAntonio Nino Diaz 
6551c5e1a2SAntonio Nino Diaz /*
667d37aa17SJuan Castillo  * Get X509v3 extension
677d37aa17SJuan Castillo  *
687d37aa17SJuan Castillo  * Global variable 'v3_ext' must point to the extensions region
69a987b89dSDemi Marie Obenour  * in the certificate.  OID may be NULL to request that get_ext()
70a987b89dSDemi Marie Obenour  * is only being called for integrity checking.
717d37aa17SJuan Castillo  */
727d37aa17SJuan Castillo static int get_ext(const char *oid, void **ext, unsigned int *ext_len)
737d37aa17SJuan Castillo {
74a987b89dSDemi Marie Obenour 	int oid_len, ret, is_critical;
757d37aa17SJuan Castillo 	size_t len;
767d37aa17SJuan Castillo 	unsigned char *p;
777d37aa17SJuan Castillo 	const unsigned char *end;
787d37aa17SJuan Castillo 	char oid_str[MAX_OID_STR_LEN];
79649dbf6fSJuan Castillo 	mbedtls_asn1_buf extn_oid;
807d37aa17SJuan Castillo 
817d37aa17SJuan Castillo 	p = v3_ext.p;
827d37aa17SJuan Castillo 	end = v3_ext.p + v3_ext.len;
837d37aa17SJuan Castillo 
84a987b89dSDemi Marie Obenour 	/*
85a987b89dSDemi Marie Obenour 	 * Check extensions integrity.  At least one extension is
86a987b89dSDemi Marie Obenour 	 * required: the ASN.1 specifies a minimum size of 1, and at
87a987b89dSDemi Marie Obenour 	 * least one extension is needed to authenticate the next stage
88a987b89dSDemi Marie Obenour 	 * in the boot chain.
89a987b89dSDemi Marie Obenour 	 */
90a987b89dSDemi Marie Obenour 	do {
91a987b89dSDemi Marie Obenour 		unsigned char *end_ext_data;
927d37aa17SJuan Castillo 
93a987b89dSDemi Marie Obenour 		ret = mbedtls_asn1_get_tag(&p, end, &len,
94a987b89dSDemi Marie Obenour 					   MBEDTLS_ASN1_CONSTRUCTED |
95649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_SEQUENCE);
96a987b89dSDemi Marie Obenour 		if (ret != 0) {
97a987b89dSDemi Marie Obenour 			return IMG_PARSER_ERR_FORMAT;
98a987b89dSDemi Marie Obenour 		}
997d37aa17SJuan Castillo 		end_ext_data = p + len;
1007d37aa17SJuan Castillo 
1017d37aa17SJuan Castillo 		/* Get extension ID */
102a987b89dSDemi Marie Obenour 		ret = mbedtls_asn1_get_tag(&p, end_ext_data, &extn_oid.len,
103a987b89dSDemi Marie Obenour 					   MBEDTLS_ASN1_OID);
104a987b89dSDemi Marie Obenour 		if (ret != 0) {
105a987b89dSDemi Marie Obenour 			return IMG_PARSER_ERR_FORMAT;
106a987b89dSDemi Marie Obenour 		}
107a987b89dSDemi Marie Obenour 		extn_oid.tag = MBEDTLS_ASN1_OID;
1087d37aa17SJuan Castillo 		extn_oid.p = p;
1097d37aa17SJuan Castillo 		p += extn_oid.len;
1107d37aa17SJuan Castillo 
1117d37aa17SJuan Castillo 		/* Get optional critical */
112a987b89dSDemi Marie Obenour 		ret = mbedtls_asn1_get_bool(&p, end_ext_data, &is_critical);
113a987b89dSDemi Marie Obenour 		if ((ret != 0) && (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG)) {
114a987b89dSDemi Marie Obenour 			return IMG_PARSER_ERR_FORMAT;
115a987b89dSDemi Marie Obenour 		}
1167d37aa17SJuan Castillo 
117a987b89dSDemi Marie Obenour 		/*
118a987b89dSDemi Marie Obenour 		 * Data should be octet string type and must use all bytes in
119a987b89dSDemi Marie Obenour 		 * the Extension.
120a987b89dSDemi Marie Obenour 		 */
121a987b89dSDemi Marie Obenour 		ret = mbedtls_asn1_get_tag(&p, end_ext_data, &len,
122649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_OCTET_STRING);
123a987b89dSDemi Marie Obenour 		if ((ret != 0) || ((p + len) != end_ext_data)) {
124a987b89dSDemi Marie Obenour 			return IMG_PARSER_ERR_FORMAT;
125a987b89dSDemi Marie Obenour 		}
1267d37aa17SJuan Castillo 
1277d37aa17SJuan Castillo 		/* Detect requested extension */
128649dbf6fSJuan Castillo 		oid_len = mbedtls_oid_get_numeric_string(oid_str,
129649dbf6fSJuan Castillo 							 MAX_OID_STR_LEN,
130649dbf6fSJuan Castillo 							 &extn_oid);
131ed38366fSNicolas Toromanoff 		if ((oid_len == MBEDTLS_ERR_OID_BUF_TOO_SMALL) || (oid_len < 0)) {
1327d37aa17SJuan Castillo 			return IMG_PARSER_ERR;
1337d37aa17SJuan Castillo 		}
134a987b89dSDemi Marie Obenour 
135a987b89dSDemi Marie Obenour 		if ((oid != NULL) &&
136a987b89dSDemi Marie Obenour 		    ((size_t)oid_len == strlen(oid_str)) &&
137a987b89dSDemi Marie Obenour 		    (strcmp(oid, oid_str) == 0)) {
1387d37aa17SJuan Castillo 			*ext = (void *)p;
1397d37aa17SJuan Castillo 			*ext_len = (unsigned int)len;
1407d37aa17SJuan Castillo 			return IMG_PARSER_OK;
1417d37aa17SJuan Castillo 		}
1427d37aa17SJuan Castillo 
1437d37aa17SJuan Castillo 		/* Next */
144a987b89dSDemi Marie Obenour 		p = end_ext_data;
145a987b89dSDemi Marie Obenour 	} while (p < end);
1467d37aa17SJuan Castillo 
147a987b89dSDemi Marie Obenour 	return (oid == NULL) ? IMG_PARSER_OK : IMG_PARSER_ERR_NOT_FOUND;
1487d37aa17SJuan Castillo }
1497d37aa17SJuan Castillo 
1507d37aa17SJuan Castillo 
1517d37aa17SJuan Castillo /*
1527d37aa17SJuan Castillo  * Check the integrity of the certificate ASN.1 structure.
15351c5e1a2SAntonio Nino Diaz  *
1547d37aa17SJuan Castillo  * Extract the relevant data that will be used later during authentication.
15551c5e1a2SAntonio Nino Diaz  *
15651c5e1a2SAntonio Nino Diaz  * This function doesn't clear the static variables located on the top of this
15751c5e1a2SAntonio Nino Diaz  * file in case of an error. It is only called from check_integrity(), which
15851c5e1a2SAntonio Nino Diaz  * performs the cleanup if necessary.
1597d37aa17SJuan Castillo  */
1607d37aa17SJuan Castillo static int cert_parse(void *img, unsigned int img_len)
1617d37aa17SJuan Castillo {
162a987b89dSDemi Marie Obenour 	int ret;
1637d37aa17SJuan Castillo 	size_t len;
16494c0cfbbSDemi Marie Obenour 	unsigned char *p, *end, *crt_end, *pk_end;
16563cc49d0SDemi Marie Obenour 	mbedtls_asn1_buf sig_alg1;
166e9e4a2a6SDemi Marie Obenour 	/*
167e9e4a2a6SDemi Marie Obenour 	 * The unique ASN.1 DER encoding of [0] EXPLICIT INTEGER { v3(2} }.
168e9e4a2a6SDemi Marie Obenour 	 */
169e9e4a2a6SDemi Marie Obenour 	static const char v3[] = {
170e9e4a2a6SDemi Marie Obenour 		/* The outer CONTEXT SPECIFIC 0 tag */
171e9e4a2a6SDemi Marie Obenour 		MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_CONTEXT_SPECIFIC | 0,
172e9e4a2a6SDemi Marie Obenour 		/* The number bytes used to encode the inner INTEGER */
173e9e4a2a6SDemi Marie Obenour 		3,
174e9e4a2a6SDemi Marie Obenour 		/* The tag of the inner INTEGER */
175e9e4a2a6SDemi Marie Obenour 		MBEDTLS_ASN1_INTEGER,
176e9e4a2a6SDemi Marie Obenour 		/* The number of bytes needed to represent 2 */
177e9e4a2a6SDemi Marie Obenour 		1,
178e9e4a2a6SDemi Marie Obenour 		/* The actual value 2 */
179e9e4a2a6SDemi Marie Obenour 		2,
180e9e4a2a6SDemi Marie Obenour 	};
1817d37aa17SJuan Castillo 
1827d37aa17SJuan Castillo 	p = (unsigned char *)img;
1837d37aa17SJuan Castillo 	len = img_len;
184ddd9f675SDemi Marie Obenour 	crt_end = p + len;
185ddd9f675SDemi Marie Obenour 	end = crt_end;
1867d37aa17SJuan Castillo 
1877d37aa17SJuan Castillo 	/*
1887d37aa17SJuan Castillo 	 * Certificate  ::=  SEQUENCE  {
1897d37aa17SJuan Castillo 	 *      tbsCertificate       TBSCertificate,
1907d37aa17SJuan Castillo 	 *      signatureAlgorithm   AlgorithmIdentifier,
1917d37aa17SJuan Castillo 	 *      signatureValue       BIT STRING  }
1927d37aa17SJuan Castillo 	 */
193649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
194649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
195ddd9f675SDemi Marie Obenour 	if ((ret != 0) || ((p + len) != end)) {
1967d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1977d37aa17SJuan Castillo 	}
1987d37aa17SJuan Castillo 
1997d37aa17SJuan Castillo 	/*
2007d37aa17SJuan Castillo 	 * TBSCertificate  ::=  SEQUENCE  {
2017d37aa17SJuan Castillo 	 */
2027d37aa17SJuan Castillo 	tbs.p = p;
203649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
204649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2057d37aa17SJuan Castillo 	if (ret != 0) {
2067d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2077d37aa17SJuan Castillo 	}
2087d37aa17SJuan Castillo 	end = p + len;
2097d37aa17SJuan Castillo 	tbs.len = end - tbs.p;
2107d37aa17SJuan Castillo 
2117d37aa17SJuan Castillo 	/*
212e9e4a2a6SDemi Marie Obenour 	 * Version  ::=  [0] EXPLICIT INTEGER {  v1(0), v2(1), v3(2)  }
213e9e4a2a6SDemi Marie Obenour 	 * -- only v3 accepted
2147d37aa17SJuan Castillo 	 */
215e9e4a2a6SDemi Marie Obenour 	if (((end - p) <= (ptrdiff_t)sizeof(v3)) ||
216e9e4a2a6SDemi Marie Obenour 	    (memcmp(p, v3, sizeof(v3)) != 0)) {
2177d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2187d37aa17SJuan Castillo 	}
219e9e4a2a6SDemi Marie Obenour 	p += sizeof(v3);
2207d37aa17SJuan Castillo 
2217d37aa17SJuan Castillo 	/*
2227d37aa17SJuan Castillo 	 * CertificateSerialNumber  ::=  INTEGER
2237d37aa17SJuan Castillo 	 */
224649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_INTEGER);
2257d37aa17SJuan Castillo 	if (ret != 0) {
2267d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2277d37aa17SJuan Castillo 	}
2287d37aa17SJuan Castillo 	p += len;
2297d37aa17SJuan Castillo 
2307d37aa17SJuan Castillo 	/*
2317d37aa17SJuan Castillo 	 * signature            AlgorithmIdentifier
2327d37aa17SJuan Castillo 	 */
2337d37aa17SJuan Castillo 	sig_alg1.p = p;
234649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
235649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2367d37aa17SJuan Castillo 	if (ret != 0) {
2377d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2387d37aa17SJuan Castillo 	}
2397d37aa17SJuan Castillo 	sig_alg1.len = (p + len) - sig_alg1.p;
2407d37aa17SJuan Castillo 	p += len;
2417d37aa17SJuan Castillo 
2427d37aa17SJuan Castillo 	/*
2437d37aa17SJuan Castillo 	 * issuer               Name
2447d37aa17SJuan Castillo 	 */
245649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
246649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2477d37aa17SJuan Castillo 	if (ret != 0) {
2487d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2497d37aa17SJuan Castillo 	}
2507d37aa17SJuan Castillo 	p += len;
2517d37aa17SJuan Castillo 
2527d37aa17SJuan Castillo 	/*
2537d37aa17SJuan Castillo 	 * Validity ::= SEQUENCE {
2547d37aa17SJuan Castillo 	 *      notBefore      Time,
2557d37aa17SJuan Castillo 	 *      notAfter       Time }
2567d37aa17SJuan Castillo 	 *
2577d37aa17SJuan Castillo 	 */
258649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
259649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2607d37aa17SJuan Castillo 	if (ret != 0) {
2617d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2627d37aa17SJuan Castillo 	}
2637d37aa17SJuan Castillo 	p += len;
2647d37aa17SJuan Castillo 
2657d37aa17SJuan Castillo 	/*
2667d37aa17SJuan Castillo 	 * subject              Name
2677d37aa17SJuan Castillo 	 */
268649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
269649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2707d37aa17SJuan Castillo 	if (ret != 0) {
2717d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2727d37aa17SJuan Castillo 	}
2737d37aa17SJuan Castillo 	p += len;
2747d37aa17SJuan Castillo 
2757d37aa17SJuan Castillo 	/*
2767d37aa17SJuan Castillo 	 * SubjectPublicKeyInfo
2777d37aa17SJuan Castillo 	 */
2787d37aa17SJuan Castillo 	pk.p = p;
279649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
280649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2817d37aa17SJuan Castillo 	if (ret != 0) {
2827d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2837d37aa17SJuan Castillo 	}
28494c0cfbbSDemi Marie Obenour 	pk_end = p + len;
28594c0cfbbSDemi Marie Obenour 	pk.len = pk_end - pk.p;
28694c0cfbbSDemi Marie Obenour 
287ce882b53SDemi Marie Obenour 	/* algorithm */
28894c0cfbbSDemi Marie Obenour 	ret = mbedtls_asn1_get_tag(&p, pk_end, &len, MBEDTLS_ASN1_CONSTRUCTED |
28994c0cfbbSDemi Marie Obenour 				   MBEDTLS_ASN1_SEQUENCE);
29094c0cfbbSDemi Marie Obenour 	if (ret != 0) {
29194c0cfbbSDemi Marie Obenour 		return IMG_PARSER_ERR_FORMAT;
29294c0cfbbSDemi Marie Obenour 	}
2937d37aa17SJuan Castillo 	p += len;
2947d37aa17SJuan Castillo 
2958816dbb3SDemi Marie Obenour 	/* Key is a BIT STRING and must use all bytes in SubjectPublicKeyInfo */
2968816dbb3SDemi Marie Obenour 	ret = mbedtls_asn1_get_bitstring_null(&p, pk_end, &len);
29794c0cfbbSDemi Marie Obenour 	if ((ret != 0) || (p + len != pk_end)) {
29894c0cfbbSDemi Marie Obenour 		return IMG_PARSER_ERR_FORMAT;
29994c0cfbbSDemi Marie Obenour 	}
30094c0cfbbSDemi Marie Obenour 	p = pk_end;
30194c0cfbbSDemi Marie Obenour 
3027d37aa17SJuan Castillo 	/*
3037d37aa17SJuan Castillo 	 * issuerUniqueID  [1]  IMPLICIT UniqueIdentifier OPTIONAL,
3047d37aa17SJuan Castillo 	 * subjectUniqueID [2]  IMPLICIT UniqueIdentifier OPTIONAL,
3056a7104a3SDemi Marie Obenour 	 * -- technically these contain BIT STRINGs but that is not worth
3066a7104a3SDemi Marie Obenour 	 * -- validating
3077d37aa17SJuan Castillo 	 */
3086a7104a3SDemi Marie Obenour 	for (int i = 1; i < 3; i++) {
309649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_tag(&p, end, &len,
310649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
3116a7104a3SDemi Marie Obenour 					   MBEDTLS_ASN1_CONSTRUCTED | i);
3126a7104a3SDemi Marie Obenour 		/*
3136a7104a3SDemi Marie Obenour 		 * Unique IDs are obsolete, so MBEDTLS_ERR_ASN1_UNEXPECTED_TAG
3146a7104a3SDemi Marie Obenour 		 * is the common case.
3156a7104a3SDemi Marie Obenour 		 */
316649dbf6fSJuan Castillo 		if (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG) {
3176a7104a3SDemi Marie Obenour 			if (ret != 0) {
3187d37aa17SJuan Castillo 				return IMG_PARSER_ERR_FORMAT;
3197d37aa17SJuan Castillo 			}
3207d37aa17SJuan Castillo 			p += len;
3217d37aa17SJuan Castillo 		}
3226a7104a3SDemi Marie Obenour 	}
3237d37aa17SJuan Castillo 
3247d37aa17SJuan Castillo 	/*
3257d37aa17SJuan Castillo 	 * extensions      [3]  EXPLICIT Extensions OPTIONAL
32672460f50SDemi Marie Obenour 	 * }
32772460f50SDemi Marie Obenour 	 *
32872460f50SDemi Marie Obenour 	 * X.509 and RFC5280 allow omitting the extensions entirely.
32972460f50SDemi Marie Obenour 	 * However, in TF-A, a certificate with no extensions would
33072460f50SDemi Marie Obenour 	 * always fail later on, as the extensions contain the
33172460f50SDemi Marie Obenour 	 * information needed to authenticate the next stage in the
33272460f50SDemi Marie Obenour 	 * boot chain.  Furthermore, get_ext() assumes that the
33372460f50SDemi Marie Obenour 	 * extensions have been parsed into v3_ext, and allowing
33472460f50SDemi Marie Obenour 	 * there to be no extensions would pointlessly complicate
33572460f50SDemi Marie Obenour 	 * the code.  Therefore, just reject certificates without
33672460f50SDemi Marie Obenour 	 * extensions.  This is also why version 1 and 2 certificates
33772460f50SDemi Marie Obenour 	 * are rejected above.
3387d37aa17SJuan Castillo 	 */
339649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
340649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
341649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 3);
342fd37982aSDemi Marie Obenour 	if ((ret != 0) || (len != (size_t)(end - p))) {
3437d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3447d37aa17SJuan Castillo 	}
3457d37aa17SJuan Castillo 
3467d37aa17SJuan Castillo 	/*
3477d37aa17SJuan Castillo 	 * Extensions  ::=  SEQUENCE SIZE (1..MAX) OF Extension
348fd37982aSDemi Marie Obenour 	 * -- must use all remaining bytes in TBSCertificate
3497d37aa17SJuan Castillo 	 */
350649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
351649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
352fd37982aSDemi Marie Obenour 	if ((ret != 0) || (len != (size_t)(end - p))) {
3537d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3547d37aa17SJuan Castillo 	}
355ce882b53SDemi Marie Obenour 	v3_ext.p = p;
356ce882b53SDemi Marie Obenour 	v3_ext.len = len;
3577d37aa17SJuan Castillo 	p += len;
3587d37aa17SJuan Castillo 
359a987b89dSDemi Marie Obenour 	/* Check extensions integrity */
360a987b89dSDemi Marie Obenour 	ret = get_ext(NULL, NULL, NULL);
361a987b89dSDemi Marie Obenour 	if (ret != IMG_PARSER_OK) {
362a987b89dSDemi Marie Obenour 		return ret;
3637d37aa17SJuan Castillo 	}
3647d37aa17SJuan Castillo 
3657d37aa17SJuan Castillo 	end = crt_end;
3667d37aa17SJuan Castillo 
3677d37aa17SJuan Castillo 	/*
3687d37aa17SJuan Castillo 	 *  }
3697d37aa17SJuan Castillo 	 *  -- end of TBSCertificate
3707d37aa17SJuan Castillo 	 *
3717d37aa17SJuan Castillo 	 *  signatureAlgorithm   AlgorithmIdentifier
37263cc49d0SDemi Marie Obenour 	 *  -- Does not need to be parsed.  Ensuring it is bitwise
37363cc49d0SDemi Marie Obenour 	 *  -- identical (including the tag!) with the first signature
37463cc49d0SDemi Marie Obenour 	 *  -- algorithm is sufficient.
3757d37aa17SJuan Castillo 	 */
37663cc49d0SDemi Marie Obenour 	if ((sig_alg1.len >= (size_t)(end - p)) ||
37763cc49d0SDemi Marie Obenour 	    (0 != memcmp(sig_alg1.p, p, sig_alg1.len))) {
3787d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3797d37aa17SJuan Castillo 	}
38063cc49d0SDemi Marie Obenour 	p += sig_alg1.len;
3817d37aa17SJuan Castillo 	memcpy(&sig_alg, &sig_alg1, sizeof(sig_alg));
3827d37aa17SJuan Castillo 
3837d37aa17SJuan Castillo 	/*
3847d37aa17SJuan Castillo 	 * signatureValue       BIT STRING
385ddd9f675SDemi Marie Obenour 	 * } -- must consume all bytes
3867d37aa17SJuan Castillo 	 */
3877d37aa17SJuan Castillo 	signature.p = p;
3888816dbb3SDemi Marie Obenour 	ret = mbedtls_asn1_get_bitstring_null(&p, end, &len);
389ddd9f675SDemi Marie Obenour 	if ((ret != 0) || ((p + len) != end)) {
3907d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3917d37aa17SJuan Castillo 	}
392ddd9f675SDemi Marie Obenour 	signature.len = end - signature.p;
3937d37aa17SJuan Castillo 
3947d37aa17SJuan Castillo 	return IMG_PARSER_OK;
3957d37aa17SJuan Castillo }
3967d37aa17SJuan Castillo 
3977d37aa17SJuan Castillo 
3987d37aa17SJuan Castillo /* Exported functions */
3997d37aa17SJuan Castillo 
4007d37aa17SJuan Castillo static void init(void)
4017d37aa17SJuan Castillo {
4027d37aa17SJuan Castillo 	mbedtls_init();
4037d37aa17SJuan Castillo }
4047d37aa17SJuan Castillo 
40551c5e1a2SAntonio Nino Diaz /*
40651c5e1a2SAntonio Nino Diaz  * Wrapper for cert_parse() that clears the static variables used by it in case
40751c5e1a2SAntonio Nino Diaz  * of an error.
40851c5e1a2SAntonio Nino Diaz  */
4097d37aa17SJuan Castillo static int check_integrity(void *img, unsigned int img_len)
4107d37aa17SJuan Castillo {
41151c5e1a2SAntonio Nino Diaz 	int rc = cert_parse(img, img_len);
41251c5e1a2SAntonio Nino Diaz 
41351c5e1a2SAntonio Nino Diaz 	if (rc != IMG_PARSER_OK)
41451c5e1a2SAntonio Nino Diaz 		clear_temp_vars();
41551c5e1a2SAntonio Nino Diaz 
41651c5e1a2SAntonio Nino Diaz 	return rc;
4177d37aa17SJuan Castillo }
4187d37aa17SJuan Castillo 
4197d37aa17SJuan Castillo /*
4207d37aa17SJuan Castillo  * Extract an authentication parameter from an X509v3 certificate
42148279d52SJuan Castillo  *
42248279d52SJuan Castillo  * This function returns a pointer to the extracted data and its length.
42348279d52SJuan Castillo  * Depending on the type of parameter, a pointer to the data stored in the
42448279d52SJuan Castillo  * certificate may be returned (i.e. an octet string containing a hash). Other
42548279d52SJuan Castillo  * data may need to be copied and formatted (i.e. integers). In the later case,
42648279d52SJuan Castillo  * a buffer of the correct type needs to be statically allocated, filled and
42748279d52SJuan Castillo  * returned.
4287d37aa17SJuan Castillo  */
4297d37aa17SJuan Castillo static int get_auth_param(const auth_param_type_desc_t *type_desc,
4307d37aa17SJuan Castillo 		void *img, unsigned int img_len,
4317d37aa17SJuan Castillo 		void **param, unsigned int *param_len)
4327d37aa17SJuan Castillo {
4337d37aa17SJuan Castillo 	int rc = IMG_PARSER_OK;
4347d37aa17SJuan Castillo 
4357d37aa17SJuan Castillo 	/* We do not use img because the check_integrity function has already
4367d37aa17SJuan Castillo 	 * extracted the relevant data (v3_ext, pk, sig_alg, etc) */
4377d37aa17SJuan Castillo 
4387d37aa17SJuan Castillo 	switch (type_desc->type) {
4397d37aa17SJuan Castillo 	case AUTH_PARAM_RAW_DATA:
4407d37aa17SJuan Castillo 		/* Data to be signed */
4417d37aa17SJuan Castillo 		*param = (void *)tbs.p;
4427d37aa17SJuan Castillo 		*param_len = (unsigned int)tbs.len;
4437d37aa17SJuan Castillo 		break;
4447d37aa17SJuan Castillo 	case AUTH_PARAM_HASH:
44548279d52SJuan Castillo 	case AUTH_PARAM_NV_CTR:
4467d37aa17SJuan Castillo 		/* All these parameters are included as X509v3 extensions */
4477d37aa17SJuan Castillo 		rc = get_ext(type_desc->cookie, param, param_len);
4487d37aa17SJuan Castillo 		break;
4497d37aa17SJuan Castillo 	case AUTH_PARAM_PUB_KEY:
450654b65b3SYann Gautier 		if (type_desc->cookie != NULL) {
4517d37aa17SJuan Castillo 			/* Get public key from extension */
4527d37aa17SJuan Castillo 			rc = get_ext(type_desc->cookie, param, param_len);
4537d37aa17SJuan Castillo 		} else {
4547d37aa17SJuan Castillo 			/* Get the subject public key */
4557d37aa17SJuan Castillo 			*param = (void *)pk.p;
4567d37aa17SJuan Castillo 			*param_len = (unsigned int)pk.len;
4577d37aa17SJuan Castillo 		}
4587d37aa17SJuan Castillo 		break;
4597d37aa17SJuan Castillo 	case AUTH_PARAM_SIG_ALG:
4607d37aa17SJuan Castillo 		/* Get the certificate signature algorithm */
4617d37aa17SJuan Castillo 		*param = (void *)sig_alg.p;
4627d37aa17SJuan Castillo 		*param_len = (unsigned int)sig_alg.len;
4637d37aa17SJuan Castillo 		break;
4647d37aa17SJuan Castillo 	case AUTH_PARAM_SIG:
4657d37aa17SJuan Castillo 		/* Get the certificate signature */
4667d37aa17SJuan Castillo 		*param = (void *)signature.p;
4677d37aa17SJuan Castillo 		*param_len = (unsigned int)signature.len;
4687d37aa17SJuan Castillo 		break;
4697d37aa17SJuan Castillo 	default:
4707d37aa17SJuan Castillo 		rc = IMG_PARSER_ERR_NOT_FOUND;
4717d37aa17SJuan Castillo 		break;
4727d37aa17SJuan Castillo 	}
4737d37aa17SJuan Castillo 
4747d37aa17SJuan Castillo 	return rc;
4757d37aa17SJuan Castillo }
4767d37aa17SJuan Castillo 
477*9a90d720SElyes Haouas REGISTER_IMG_PARSER_LIB(IMG_CERT, LIB_NAME, init,
4787d37aa17SJuan Castillo 		       check_integrity, get_auth_param);
479