xref: /rk3399_ARM-atf/drivers/auth/mbedtls/mbedtls_x509_parser.c (revision 82cb2c1ad9897473743f08437d0a3995bed561b9)
17d37aa17SJuan Castillo /*
251c5e1a2SAntonio Nino Diaz  * Copyright (c) 2015-2017, ARM Limited and Contributors. All rights reserved.
37d37aa17SJuan Castillo  *
4*82cb2c1aSdp-arm  * SPDX-License-Identifier: BSD-3-Clause
57d37aa17SJuan Castillo  */
67d37aa17SJuan Castillo 
77d37aa17SJuan Castillo /*
8649dbf6fSJuan Castillo  * X509 parser based on mbed TLS
97d37aa17SJuan Castillo  *
107d37aa17SJuan Castillo  * This module implements functions to check the integrity of a X509v3
117d37aa17SJuan Castillo  * certificate ASN.1 structure and extract authentication parameters from the
127d37aa17SJuan Castillo  * extensions field, such as an image hash or a public key.
137d37aa17SJuan Castillo  */
147d37aa17SJuan Castillo 
1551c5e1a2SAntonio Nino Diaz #include <arch_helpers.h>
167d37aa17SJuan Castillo #include <assert.h>
177d37aa17SJuan Castillo #include <img_parser_mod.h>
187d37aa17SJuan Castillo #include <mbedtls_common.h>
197d37aa17SJuan Castillo #include <stddef.h>
207d37aa17SJuan Castillo #include <stdint.h>
217d37aa17SJuan Castillo #include <string.h>
2232f0d3c6SDouglas Raillard #include <utils.h>
237d37aa17SJuan Castillo 
247d37aa17SJuan Castillo /* mbed TLS headers */
25649dbf6fSJuan Castillo #include <mbedtls/asn1.h>
26649dbf6fSJuan Castillo #include <mbedtls/oid.h>
27649dbf6fSJuan Castillo #include <mbedtls/platform.h>
287d37aa17SJuan Castillo 
297d37aa17SJuan Castillo /* Maximum OID string length ("a.b.c.d.e.f ...") */
307d37aa17SJuan Castillo #define MAX_OID_STR_LEN			64
317d37aa17SJuan Castillo 
327d37aa17SJuan Castillo #define LIB_NAME	"mbed TLS X509v3"
337d37aa17SJuan Castillo 
347d37aa17SJuan Castillo /* Temporary variables to speed up the authentication parameters search. These
357d37aa17SJuan Castillo  * variables are assigned once during the integrity check and used any time an
367d37aa17SJuan Castillo  * authentication parameter is requested, so we do not have to parse the image
377d37aa17SJuan Castillo  * again */
38649dbf6fSJuan Castillo static mbedtls_asn1_buf tbs;
39649dbf6fSJuan Castillo static mbedtls_asn1_buf v3_ext;
40649dbf6fSJuan Castillo static mbedtls_asn1_buf pk;
41649dbf6fSJuan Castillo static mbedtls_asn1_buf sig_alg;
42649dbf6fSJuan Castillo static mbedtls_asn1_buf signature;
437d37aa17SJuan Castillo 
447d37aa17SJuan Castillo /*
4551c5e1a2SAntonio Nino Diaz  * Clear all static temporary variables.
4651c5e1a2SAntonio Nino Diaz  */
4751c5e1a2SAntonio Nino Diaz static void clear_temp_vars(void)
4851c5e1a2SAntonio Nino Diaz {
4951c5e1a2SAntonio Nino Diaz #define ZERO_AND_CLEAN(x)					\
5051c5e1a2SAntonio Nino Diaz 	do {							\
5132f0d3c6SDouglas Raillard 		zeromem(&x, sizeof(x));				\
5251c5e1a2SAntonio Nino Diaz 		clean_dcache_range((uintptr_t)&x, sizeof(x));	\
5351c5e1a2SAntonio Nino Diaz 	} while (0);
5451c5e1a2SAntonio Nino Diaz 
5551c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(tbs)
5651c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(v3_ext);
5751c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(pk);
5851c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(sig_alg);
5951c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(signature);
6051c5e1a2SAntonio Nino Diaz 
6151c5e1a2SAntonio Nino Diaz #undef ZERO_AND_CLEAN
6251c5e1a2SAntonio Nino Diaz }
6351c5e1a2SAntonio Nino Diaz 
6451c5e1a2SAntonio Nino Diaz /*
657d37aa17SJuan Castillo  * Get X509v3 extension
667d37aa17SJuan Castillo  *
677d37aa17SJuan Castillo  * Global variable 'v3_ext' must point to the extensions region
687d37aa17SJuan Castillo  * in the certificate. No need to check for errors since the image has passed
697d37aa17SJuan Castillo  * the integrity check.
707d37aa17SJuan Castillo  */
717d37aa17SJuan Castillo static int get_ext(const char *oid, void **ext, unsigned int *ext_len)
727d37aa17SJuan Castillo {
737d37aa17SJuan Castillo 	int oid_len;
747d37aa17SJuan Castillo 	size_t len;
757d37aa17SJuan Castillo 	unsigned char *end_ext_data, *end_ext_octet;
767d37aa17SJuan Castillo 	unsigned char *p;
777d37aa17SJuan Castillo 	const unsigned char *end;
787d37aa17SJuan Castillo 	char oid_str[MAX_OID_STR_LEN];
79649dbf6fSJuan Castillo 	mbedtls_asn1_buf extn_oid;
807d37aa17SJuan Castillo 	int is_critical;
817d37aa17SJuan Castillo 
827d37aa17SJuan Castillo 	assert(oid != NULL);
837d37aa17SJuan Castillo 
847d37aa17SJuan Castillo 	p = v3_ext.p;
857d37aa17SJuan Castillo 	end = v3_ext.p + v3_ext.len;
867d37aa17SJuan Castillo 
87649dbf6fSJuan Castillo 	mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
88649dbf6fSJuan Castillo 			     MBEDTLS_ASN1_SEQUENCE);
897d37aa17SJuan Castillo 
907d37aa17SJuan Castillo 	while (p < end) {
9132f0d3c6SDouglas Raillard 		zeromem(&extn_oid, sizeof(extn_oid));
927d37aa17SJuan Castillo 		is_critical = 0; /* DEFAULT FALSE */
937d37aa17SJuan Castillo 
94649dbf6fSJuan Castillo 		mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
95649dbf6fSJuan Castillo 				     MBEDTLS_ASN1_SEQUENCE);
967d37aa17SJuan Castillo 		end_ext_data = p + len;
977d37aa17SJuan Castillo 
987d37aa17SJuan Castillo 		/* Get extension ID */
997d37aa17SJuan Castillo 		extn_oid.tag = *p;
100649dbf6fSJuan Castillo 		mbedtls_asn1_get_tag(&p, end, &extn_oid.len, MBEDTLS_ASN1_OID);
1017d37aa17SJuan Castillo 		extn_oid.p = p;
1027d37aa17SJuan Castillo 		p += extn_oid.len;
1037d37aa17SJuan Castillo 
1047d37aa17SJuan Castillo 		/* Get optional critical */
105649dbf6fSJuan Castillo 		mbedtls_asn1_get_bool(&p, end_ext_data, &is_critical);
1067d37aa17SJuan Castillo 
1077d37aa17SJuan Castillo 		/* Extension data */
108649dbf6fSJuan Castillo 		mbedtls_asn1_get_tag(&p, end_ext_data, &len,
109649dbf6fSJuan Castillo 				     MBEDTLS_ASN1_OCTET_STRING);
1107d37aa17SJuan Castillo 		end_ext_octet = p + len;
1117d37aa17SJuan Castillo 
1127d37aa17SJuan Castillo 		/* Detect requested extension */
113649dbf6fSJuan Castillo 		oid_len = mbedtls_oid_get_numeric_string(oid_str,
114649dbf6fSJuan Castillo 							 MAX_OID_STR_LEN,
115649dbf6fSJuan Castillo 							 &extn_oid);
116649dbf6fSJuan Castillo 		if (oid_len == MBEDTLS_ERR_OID_BUF_TOO_SMALL) {
1177d37aa17SJuan Castillo 			return IMG_PARSER_ERR;
1187d37aa17SJuan Castillo 		}
1197d37aa17SJuan Castillo 		if ((oid_len == strlen(oid_str)) && !strcmp(oid, oid_str)) {
1207d37aa17SJuan Castillo 			*ext = (void *)p;
1217d37aa17SJuan Castillo 			*ext_len = (unsigned int)len;
1227d37aa17SJuan Castillo 			return IMG_PARSER_OK;
1237d37aa17SJuan Castillo 		}
1247d37aa17SJuan Castillo 
1257d37aa17SJuan Castillo 		/* Next */
1267d37aa17SJuan Castillo 		p = end_ext_octet;
1277d37aa17SJuan Castillo 	}
1287d37aa17SJuan Castillo 
1297d37aa17SJuan Castillo 	return IMG_PARSER_ERR_NOT_FOUND;
1307d37aa17SJuan Castillo }
1317d37aa17SJuan Castillo 
1327d37aa17SJuan Castillo 
1337d37aa17SJuan Castillo /*
1347d37aa17SJuan Castillo  * Check the integrity of the certificate ASN.1 structure.
13551c5e1a2SAntonio Nino Diaz  *
1367d37aa17SJuan Castillo  * Extract the relevant data that will be used later during authentication.
13751c5e1a2SAntonio Nino Diaz  *
13851c5e1a2SAntonio Nino Diaz  * This function doesn't clear the static variables located on the top of this
13951c5e1a2SAntonio Nino Diaz  * file in case of an error. It is only called from check_integrity(), which
14051c5e1a2SAntonio Nino Diaz  * performs the cleanup if necessary.
1417d37aa17SJuan Castillo  */
1427d37aa17SJuan Castillo static int cert_parse(void *img, unsigned int img_len)
1437d37aa17SJuan Castillo {
1447d37aa17SJuan Castillo 	int ret, is_critical;
1457d37aa17SJuan Castillo 	size_t len;
1467d37aa17SJuan Castillo 	unsigned char *p, *end, *crt_end;
147649dbf6fSJuan Castillo 	mbedtls_asn1_buf sig_alg1, sig_alg2;
1487d37aa17SJuan Castillo 
1497d37aa17SJuan Castillo 	p = (unsigned char *)img;
1507d37aa17SJuan Castillo 	len = img_len;
1517d37aa17SJuan Castillo 	end = p + len;
1527d37aa17SJuan Castillo 
1537d37aa17SJuan Castillo 	/*
1547d37aa17SJuan Castillo 	 * Certificate  ::=  SEQUENCE  {
1557d37aa17SJuan Castillo 	 *      tbsCertificate       TBSCertificate,
1567d37aa17SJuan Castillo 	 *      signatureAlgorithm   AlgorithmIdentifier,
1577d37aa17SJuan Castillo 	 *      signatureValue       BIT STRING  }
1587d37aa17SJuan Castillo 	 */
159649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
160649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
1617d37aa17SJuan Castillo 	if (ret != 0) {
1627d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1637d37aa17SJuan Castillo 	}
1647d37aa17SJuan Castillo 
1657d37aa17SJuan Castillo 	if (len > (size_t)(end - p)) {
1667d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1677d37aa17SJuan Castillo 	}
1687d37aa17SJuan Castillo 	crt_end = p + len;
1697d37aa17SJuan Castillo 
1707d37aa17SJuan Castillo 	/*
1717d37aa17SJuan Castillo 	 * TBSCertificate  ::=  SEQUENCE  {
1727d37aa17SJuan Castillo 	 */
1737d37aa17SJuan Castillo 	tbs.p = p;
174649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
175649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
1767d37aa17SJuan Castillo 	if (ret != 0) {
1777d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1787d37aa17SJuan Castillo 	}
1797d37aa17SJuan Castillo 	end = p + len;
1807d37aa17SJuan Castillo 	tbs.len = end - tbs.p;
1817d37aa17SJuan Castillo 
1827d37aa17SJuan Castillo 	/*
1837d37aa17SJuan Castillo 	 * Version  ::=  INTEGER  {  v1(0), v2(1), v3(2)  }
1847d37aa17SJuan Castillo 	 */
185649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
186649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
187649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 0);
1887d37aa17SJuan Castillo 	if (ret != 0) {
1897d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1907d37aa17SJuan Castillo 	}
1917d37aa17SJuan Castillo 	p += len;
1927d37aa17SJuan Castillo 
1937d37aa17SJuan Castillo 	/*
1947d37aa17SJuan Castillo 	 * CertificateSerialNumber  ::=  INTEGER
1957d37aa17SJuan Castillo 	 */
196649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_INTEGER);
1977d37aa17SJuan Castillo 	if (ret != 0) {
1987d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1997d37aa17SJuan Castillo 	}
2007d37aa17SJuan Castillo 	p += len;
2017d37aa17SJuan Castillo 
2027d37aa17SJuan Castillo 	/*
2037d37aa17SJuan Castillo 	 * signature            AlgorithmIdentifier
2047d37aa17SJuan Castillo 	 */
2057d37aa17SJuan Castillo 	sig_alg1.p = p;
206649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
207649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2087d37aa17SJuan Castillo 	if (ret != 0) {
2097d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2107d37aa17SJuan Castillo 	}
2117d37aa17SJuan Castillo 	if ((end - p) < 1) {
2127d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2137d37aa17SJuan Castillo 	}
2147d37aa17SJuan Castillo 	sig_alg1.len = (p + len) - sig_alg1.p;
2157d37aa17SJuan Castillo 	p += len;
2167d37aa17SJuan Castillo 
2177d37aa17SJuan Castillo 	/*
2187d37aa17SJuan Castillo 	 * issuer               Name
2197d37aa17SJuan Castillo 	 */
220649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
221649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2227d37aa17SJuan Castillo 	if (ret != 0) {
2237d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2247d37aa17SJuan Castillo 	}
2257d37aa17SJuan Castillo 	p += len;
2267d37aa17SJuan Castillo 
2277d37aa17SJuan Castillo 	/*
2287d37aa17SJuan Castillo 	 * Validity ::= SEQUENCE {
2297d37aa17SJuan Castillo 	 *      notBefore      Time,
2307d37aa17SJuan Castillo 	 *      notAfter       Time }
2317d37aa17SJuan Castillo 	 *
2327d37aa17SJuan Castillo 	 */
233649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
234649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2357d37aa17SJuan Castillo 	if (ret != 0) {
2367d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2377d37aa17SJuan Castillo 	}
2387d37aa17SJuan Castillo 	p += len;
2397d37aa17SJuan Castillo 
2407d37aa17SJuan Castillo 	/*
2417d37aa17SJuan Castillo 	 * subject              Name
2427d37aa17SJuan Castillo 	 */
243649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
244649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2457d37aa17SJuan Castillo 	if (ret != 0) {
2467d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2477d37aa17SJuan Castillo 	}
2487d37aa17SJuan Castillo 	p += len;
2497d37aa17SJuan Castillo 
2507d37aa17SJuan Castillo 	/*
2517d37aa17SJuan Castillo 	 * SubjectPublicKeyInfo
2527d37aa17SJuan Castillo 	 */
2537d37aa17SJuan Castillo 	pk.p = p;
254649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
255649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2567d37aa17SJuan Castillo 	if (ret != 0) {
2577d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2587d37aa17SJuan Castillo 	}
2597d37aa17SJuan Castillo 	pk.len = (p + len) - pk.p;
2607d37aa17SJuan Castillo 	p += len;
2617d37aa17SJuan Castillo 
2627d37aa17SJuan Castillo 	/*
2637d37aa17SJuan Castillo 	 * issuerUniqueID  [1]  IMPLICIT UniqueIdentifier OPTIONAL,
2647d37aa17SJuan Castillo 	 */
265649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
266649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
267649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 1);
2687d37aa17SJuan Castillo 	if (ret != 0) {
269649dbf6fSJuan Castillo 		if (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG) {
2707d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
2717d37aa17SJuan Castillo 		}
2727d37aa17SJuan Castillo 	} else {
2737d37aa17SJuan Castillo 		p += len;
2747d37aa17SJuan Castillo 	}
2757d37aa17SJuan Castillo 
2767d37aa17SJuan Castillo 	/*
2777d37aa17SJuan Castillo 	 * subjectUniqueID [2]  IMPLICIT UniqueIdentifier OPTIONAL,
2787d37aa17SJuan Castillo 	 */
279649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
280649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
281649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 2);
2827d37aa17SJuan Castillo 	if (ret != 0) {
283649dbf6fSJuan Castillo 		if (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG) {
2847d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
2857d37aa17SJuan Castillo 		}
2867d37aa17SJuan Castillo 	} else {
2877d37aa17SJuan Castillo 		p += len;
2887d37aa17SJuan Castillo 	}
2897d37aa17SJuan Castillo 
2907d37aa17SJuan Castillo 	/*
2917d37aa17SJuan Castillo 	 * extensions      [3]  EXPLICIT Extensions OPTIONAL
2927d37aa17SJuan Castillo 	 */
293649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
294649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
295649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 3);
2967d37aa17SJuan Castillo 	if (ret != 0) {
2977d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2987d37aa17SJuan Castillo 	}
2997d37aa17SJuan Castillo 
3007d37aa17SJuan Castillo 	/*
3017d37aa17SJuan Castillo 	 * Extensions  ::=  SEQUENCE SIZE (1..MAX) OF Extension
3027d37aa17SJuan Castillo 	 */
3037d37aa17SJuan Castillo 	v3_ext.p = p;
304649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
305649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
3067d37aa17SJuan Castillo 	if (ret != 0) {
3077d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3087d37aa17SJuan Castillo 	}
3097d37aa17SJuan Castillo 	v3_ext.len = (p + len) - v3_ext.p;
3107d37aa17SJuan Castillo 
3117d37aa17SJuan Castillo 	/*
3127d37aa17SJuan Castillo 	 * Check extensions integrity
3137d37aa17SJuan Castillo 	 */
3147d37aa17SJuan Castillo 	while (p < end) {
315649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_tag(&p, end, &len,
316649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_CONSTRUCTED |
317649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_SEQUENCE);
3187d37aa17SJuan Castillo 		if (ret != 0) {
3197d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3207d37aa17SJuan Castillo 		}
3217d37aa17SJuan Castillo 
3227d37aa17SJuan Castillo 		/* Get extension ID */
323649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_OID);
3247d37aa17SJuan Castillo 		if (ret != 0) {
3257d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3267d37aa17SJuan Castillo 		}
3277d37aa17SJuan Castillo 		p += len;
3287d37aa17SJuan Castillo 
3297d37aa17SJuan Castillo 		/* Get optional critical */
330649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_bool(&p, end, &is_critical);
331649dbf6fSJuan Castillo 		if ((ret != 0) && (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG)) {
3327d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3337d37aa17SJuan Castillo 		}
3347d37aa17SJuan Castillo 
3357d37aa17SJuan Castillo 		/* Data should be octet string type */
336649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_tag(&p, end, &len,
337649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_OCTET_STRING);
3387d37aa17SJuan Castillo 		if (ret != 0) {
3397d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3407d37aa17SJuan Castillo 		}
3417d37aa17SJuan Castillo 		p += len;
3427d37aa17SJuan Castillo 	}
3437d37aa17SJuan Castillo 
3447d37aa17SJuan Castillo 	if (p != end) {
3457d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3467d37aa17SJuan Castillo 	}
3477d37aa17SJuan Castillo 
3487d37aa17SJuan Castillo 	end = crt_end;
3497d37aa17SJuan Castillo 
3507d37aa17SJuan Castillo 	/*
3517d37aa17SJuan Castillo 	 *  }
3527d37aa17SJuan Castillo 	 *  -- end of TBSCertificate
3537d37aa17SJuan Castillo 	 *
3547d37aa17SJuan Castillo 	 *  signatureAlgorithm   AlgorithmIdentifier
3557d37aa17SJuan Castillo 	 */
3567d37aa17SJuan Castillo 	sig_alg2.p = p;
357649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
358649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
3597d37aa17SJuan Castillo 	if (ret != 0) {
3607d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3617d37aa17SJuan Castillo 	}
3627d37aa17SJuan Castillo 	if ((end - p) < 1) {
3637d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3647d37aa17SJuan Castillo 	}
3657d37aa17SJuan Castillo 	sig_alg2.len = (p + len) - sig_alg2.p;
3667d37aa17SJuan Castillo 	p += len;
3677d37aa17SJuan Castillo 
3687d37aa17SJuan Castillo 	/* Compare both signature algorithms */
3697d37aa17SJuan Castillo 	if (sig_alg1.len != sig_alg2.len) {
3707d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3717d37aa17SJuan Castillo 	}
372fabd21adSAntonio Nino Diaz 	if (0 != memcmp(sig_alg1.p, sig_alg2.p, sig_alg1.len)) {
3737d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3747d37aa17SJuan Castillo 	}
3757d37aa17SJuan Castillo 	memcpy(&sig_alg, &sig_alg1, sizeof(sig_alg));
3767d37aa17SJuan Castillo 
3777d37aa17SJuan Castillo 	/*
3787d37aa17SJuan Castillo 	 * signatureValue       BIT STRING
3797d37aa17SJuan Castillo 	 */
3807d37aa17SJuan Castillo 	signature.p = p;
381649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_BIT_STRING);
3827d37aa17SJuan Castillo 	if (ret != 0) {
3837d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3847d37aa17SJuan Castillo 	}
3857d37aa17SJuan Castillo 	signature.len = (p + len) - signature.p;
3867d37aa17SJuan Castillo 	p += len;
3877d37aa17SJuan Castillo 
3887d37aa17SJuan Castillo 	/* Check certificate length */
3897d37aa17SJuan Castillo 	if (p != end) {
3907d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3917d37aa17SJuan Castillo 	}
3927d37aa17SJuan Castillo 
3937d37aa17SJuan Castillo 	return IMG_PARSER_OK;
3947d37aa17SJuan Castillo }
3957d37aa17SJuan Castillo 
3967d37aa17SJuan Castillo 
3977d37aa17SJuan Castillo /* Exported functions */
3987d37aa17SJuan Castillo 
3997d37aa17SJuan Castillo static void init(void)
4007d37aa17SJuan Castillo {
4017d37aa17SJuan Castillo 	mbedtls_init();
4027d37aa17SJuan Castillo }
4037d37aa17SJuan Castillo 
40451c5e1a2SAntonio Nino Diaz /*
40551c5e1a2SAntonio Nino Diaz  * Wrapper for cert_parse() that clears the static variables used by it in case
40651c5e1a2SAntonio Nino Diaz  * of an error.
40751c5e1a2SAntonio Nino Diaz  */
4087d37aa17SJuan Castillo static int check_integrity(void *img, unsigned int img_len)
4097d37aa17SJuan Castillo {
41051c5e1a2SAntonio Nino Diaz 	int rc = cert_parse(img, img_len);
41151c5e1a2SAntonio Nino Diaz 
41251c5e1a2SAntonio Nino Diaz 	if (rc != IMG_PARSER_OK)
41351c5e1a2SAntonio Nino Diaz 		clear_temp_vars();
41451c5e1a2SAntonio Nino Diaz 
41551c5e1a2SAntonio Nino Diaz 	return rc;
4167d37aa17SJuan Castillo }
4177d37aa17SJuan Castillo 
4187d37aa17SJuan Castillo /*
4197d37aa17SJuan Castillo  * Extract an authentication parameter from an X509v3 certificate
42048279d52SJuan Castillo  *
42148279d52SJuan Castillo  * This function returns a pointer to the extracted data and its length.
42248279d52SJuan Castillo  * Depending on the type of parameter, a pointer to the data stored in the
42348279d52SJuan Castillo  * certificate may be returned (i.e. an octet string containing a hash). Other
42448279d52SJuan Castillo  * data may need to be copied and formatted (i.e. integers). In the later case,
42548279d52SJuan Castillo  * a buffer of the correct type needs to be statically allocated, filled and
42648279d52SJuan Castillo  * returned.
4277d37aa17SJuan Castillo  */
4287d37aa17SJuan Castillo static int get_auth_param(const auth_param_type_desc_t *type_desc,
4297d37aa17SJuan Castillo 		void *img, unsigned int img_len,
4307d37aa17SJuan Castillo 		void **param, unsigned int *param_len)
4317d37aa17SJuan Castillo {
4327d37aa17SJuan Castillo 	int rc = IMG_PARSER_OK;
4337d37aa17SJuan Castillo 
4347d37aa17SJuan Castillo 	/* We do not use img because the check_integrity function has already
4357d37aa17SJuan Castillo 	 * extracted the relevant data (v3_ext, pk, sig_alg, etc) */
4367d37aa17SJuan Castillo 
4377d37aa17SJuan Castillo 	switch (type_desc->type) {
4387d37aa17SJuan Castillo 	case AUTH_PARAM_RAW_DATA:
4397d37aa17SJuan Castillo 		/* Data to be signed */
4407d37aa17SJuan Castillo 		*param = (void *)tbs.p;
4417d37aa17SJuan Castillo 		*param_len = (unsigned int)tbs.len;
4427d37aa17SJuan Castillo 		break;
4437d37aa17SJuan Castillo 	case AUTH_PARAM_HASH:
44448279d52SJuan Castillo 	case AUTH_PARAM_NV_CTR:
4457d37aa17SJuan Castillo 		/* All these parameters are included as X509v3 extensions */
4467d37aa17SJuan Castillo 		rc = get_ext(type_desc->cookie, param, param_len);
4477d37aa17SJuan Castillo 		break;
4487d37aa17SJuan Castillo 	case AUTH_PARAM_PUB_KEY:
4497d37aa17SJuan Castillo 		if (type_desc->cookie != 0) {
4507d37aa17SJuan Castillo 			/* Get public key from extension */
4517d37aa17SJuan Castillo 			rc = get_ext(type_desc->cookie, param, param_len);
4527d37aa17SJuan Castillo 		} else {
4537d37aa17SJuan Castillo 			/* Get the subject public key */
4547d37aa17SJuan Castillo 			*param = (void *)pk.p;
4557d37aa17SJuan Castillo 			*param_len = (unsigned int)pk.len;
4567d37aa17SJuan Castillo 		}
4577d37aa17SJuan Castillo 		break;
4587d37aa17SJuan Castillo 	case AUTH_PARAM_SIG_ALG:
4597d37aa17SJuan Castillo 		/* Get the certificate signature algorithm */
4607d37aa17SJuan Castillo 		*param = (void *)sig_alg.p;
4617d37aa17SJuan Castillo 		*param_len = (unsigned int)sig_alg.len;
4627d37aa17SJuan Castillo 		break;
4637d37aa17SJuan Castillo 	case AUTH_PARAM_SIG:
4647d37aa17SJuan Castillo 		/* Get the certificate signature */
4657d37aa17SJuan Castillo 		*param = (void *)signature.p;
4667d37aa17SJuan Castillo 		*param_len = (unsigned int)signature.len;
4677d37aa17SJuan Castillo 		break;
4687d37aa17SJuan Castillo 	default:
4697d37aa17SJuan Castillo 		rc = IMG_PARSER_ERR_NOT_FOUND;
4707d37aa17SJuan Castillo 		break;
4717d37aa17SJuan Castillo 	}
4727d37aa17SJuan Castillo 
4737d37aa17SJuan Castillo 	return rc;
4747d37aa17SJuan Castillo }
4757d37aa17SJuan Castillo 
4767d37aa17SJuan Castillo REGISTER_IMG_PARSER_LIB(IMG_CERT, LIB_NAME, init, \
4777d37aa17SJuan Castillo 		       check_integrity, get_auth_param);
478