xref: /rk3399_ARM-atf/drivers/auth/mbedtls/mbedtls_x509_parser.c (revision 32f0d3c6c3fb1fb9353ec0b82ddb099281b9328c)
17d37aa17SJuan Castillo /*
251c5e1a2SAntonio Nino Diaz  * Copyright (c) 2015-2017, ARM Limited and Contributors. All rights reserved.
37d37aa17SJuan Castillo  *
47d37aa17SJuan Castillo  * Redistribution and use in source and binary forms, with or without
57d37aa17SJuan Castillo  * modification, are permitted provided that the following conditions are met:
67d37aa17SJuan Castillo  *
77d37aa17SJuan Castillo  * Redistributions of source code must retain the above copyright notice, this
87d37aa17SJuan Castillo  * list of conditions and the following disclaimer.
97d37aa17SJuan Castillo  *
107d37aa17SJuan Castillo  * Redistributions in binary form must reproduce the above copyright notice,
117d37aa17SJuan Castillo  * this list of conditions and the following disclaimer in the documentation
127d37aa17SJuan Castillo  * and/or other materials provided with the distribution.
137d37aa17SJuan Castillo  *
147d37aa17SJuan Castillo  * Neither the name of ARM nor the names of its contributors may be used
157d37aa17SJuan Castillo  * to endorse or promote products derived from this software without specific
167d37aa17SJuan Castillo  * prior written permission.
177d37aa17SJuan Castillo  *
187d37aa17SJuan Castillo  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
197d37aa17SJuan Castillo  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
207d37aa17SJuan Castillo  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
217d37aa17SJuan Castillo  * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
227d37aa17SJuan Castillo  * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
237d37aa17SJuan Castillo  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
247d37aa17SJuan Castillo  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
257d37aa17SJuan Castillo  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
267d37aa17SJuan Castillo  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
277d37aa17SJuan Castillo  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
287d37aa17SJuan Castillo  * POSSIBILITY OF SUCH DAMAGE.
297d37aa17SJuan Castillo  */
307d37aa17SJuan Castillo 
317d37aa17SJuan Castillo /*
32649dbf6fSJuan Castillo  * X509 parser based on mbed TLS
337d37aa17SJuan Castillo  *
347d37aa17SJuan Castillo  * This module implements functions to check the integrity of a X509v3
357d37aa17SJuan Castillo  * certificate ASN.1 structure and extract authentication parameters from the
367d37aa17SJuan Castillo  * extensions field, such as an image hash or a public key.
377d37aa17SJuan Castillo  */
387d37aa17SJuan Castillo 
3951c5e1a2SAntonio Nino Diaz #include <arch_helpers.h>
407d37aa17SJuan Castillo #include <assert.h>
417d37aa17SJuan Castillo #include <img_parser_mod.h>
427d37aa17SJuan Castillo #include <mbedtls_common.h>
437d37aa17SJuan Castillo #include <stddef.h>
447d37aa17SJuan Castillo #include <stdint.h>
457d37aa17SJuan Castillo #include <string.h>
46*32f0d3c6SDouglas Raillard #include <utils.h>
477d37aa17SJuan Castillo 
487d37aa17SJuan Castillo /* mbed TLS headers */
49649dbf6fSJuan Castillo #include <mbedtls/asn1.h>
50649dbf6fSJuan Castillo #include <mbedtls/oid.h>
51649dbf6fSJuan Castillo #include <mbedtls/platform.h>
527d37aa17SJuan Castillo 
537d37aa17SJuan Castillo /* Maximum OID string length ("a.b.c.d.e.f ...") */
547d37aa17SJuan Castillo #define MAX_OID_STR_LEN			64
557d37aa17SJuan Castillo 
567d37aa17SJuan Castillo #define LIB_NAME	"mbed TLS X509v3"
577d37aa17SJuan Castillo 
587d37aa17SJuan Castillo /* Temporary variables to speed up the authentication parameters search. These
597d37aa17SJuan Castillo  * variables are assigned once during the integrity check and used any time an
607d37aa17SJuan Castillo  * authentication parameter is requested, so we do not have to parse the image
617d37aa17SJuan Castillo  * again */
62649dbf6fSJuan Castillo static mbedtls_asn1_buf tbs;
63649dbf6fSJuan Castillo static mbedtls_asn1_buf v3_ext;
64649dbf6fSJuan Castillo static mbedtls_asn1_buf pk;
65649dbf6fSJuan Castillo static mbedtls_asn1_buf sig_alg;
66649dbf6fSJuan Castillo static mbedtls_asn1_buf signature;
677d37aa17SJuan Castillo 
687d37aa17SJuan Castillo /*
6951c5e1a2SAntonio Nino Diaz  * Clear all static temporary variables.
7051c5e1a2SAntonio Nino Diaz  */
7151c5e1a2SAntonio Nino Diaz static void clear_temp_vars(void)
7251c5e1a2SAntonio Nino Diaz {
7351c5e1a2SAntonio Nino Diaz #define ZERO_AND_CLEAN(x)					\
7451c5e1a2SAntonio Nino Diaz 	do {							\
75*32f0d3c6SDouglas Raillard 		zeromem(&x, sizeof(x));				\
7651c5e1a2SAntonio Nino Diaz 		clean_dcache_range((uintptr_t)&x, sizeof(x));	\
7751c5e1a2SAntonio Nino Diaz 	} while (0);
7851c5e1a2SAntonio Nino Diaz 
7951c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(tbs)
8051c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(v3_ext);
8151c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(pk);
8251c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(sig_alg);
8351c5e1a2SAntonio Nino Diaz 	ZERO_AND_CLEAN(signature);
8451c5e1a2SAntonio Nino Diaz 
8551c5e1a2SAntonio Nino Diaz #undef ZERO_AND_CLEAN
8651c5e1a2SAntonio Nino Diaz }
8751c5e1a2SAntonio Nino Diaz 
8851c5e1a2SAntonio Nino Diaz /*
897d37aa17SJuan Castillo  * Get X509v3 extension
907d37aa17SJuan Castillo  *
917d37aa17SJuan Castillo  * Global variable 'v3_ext' must point to the extensions region
927d37aa17SJuan Castillo  * in the certificate. No need to check for errors since the image has passed
937d37aa17SJuan Castillo  * the integrity check.
947d37aa17SJuan Castillo  */
957d37aa17SJuan Castillo static int get_ext(const char *oid, void **ext, unsigned int *ext_len)
967d37aa17SJuan Castillo {
977d37aa17SJuan Castillo 	int oid_len;
987d37aa17SJuan Castillo 	size_t len;
997d37aa17SJuan Castillo 	unsigned char *end_ext_data, *end_ext_octet;
1007d37aa17SJuan Castillo 	unsigned char *p;
1017d37aa17SJuan Castillo 	const unsigned char *end;
1027d37aa17SJuan Castillo 	char oid_str[MAX_OID_STR_LEN];
103649dbf6fSJuan Castillo 	mbedtls_asn1_buf extn_oid;
1047d37aa17SJuan Castillo 	int is_critical;
1057d37aa17SJuan Castillo 
1067d37aa17SJuan Castillo 	assert(oid != NULL);
1077d37aa17SJuan Castillo 
1087d37aa17SJuan Castillo 	p = v3_ext.p;
1097d37aa17SJuan Castillo 	end = v3_ext.p + v3_ext.len;
1107d37aa17SJuan Castillo 
111649dbf6fSJuan Castillo 	mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
112649dbf6fSJuan Castillo 			     MBEDTLS_ASN1_SEQUENCE);
1137d37aa17SJuan Castillo 
1147d37aa17SJuan Castillo 	while (p < end) {
115*32f0d3c6SDouglas Raillard 		zeromem(&extn_oid, sizeof(extn_oid));
1167d37aa17SJuan Castillo 		is_critical = 0; /* DEFAULT FALSE */
1177d37aa17SJuan Castillo 
118649dbf6fSJuan Castillo 		mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
119649dbf6fSJuan Castillo 				     MBEDTLS_ASN1_SEQUENCE);
1207d37aa17SJuan Castillo 		end_ext_data = p + len;
1217d37aa17SJuan Castillo 
1227d37aa17SJuan Castillo 		/* Get extension ID */
1237d37aa17SJuan Castillo 		extn_oid.tag = *p;
124649dbf6fSJuan Castillo 		mbedtls_asn1_get_tag(&p, end, &extn_oid.len, MBEDTLS_ASN1_OID);
1257d37aa17SJuan Castillo 		extn_oid.p = p;
1267d37aa17SJuan Castillo 		p += extn_oid.len;
1277d37aa17SJuan Castillo 
1287d37aa17SJuan Castillo 		/* Get optional critical */
129649dbf6fSJuan Castillo 		mbedtls_asn1_get_bool(&p, end_ext_data, &is_critical);
1307d37aa17SJuan Castillo 
1317d37aa17SJuan Castillo 		/* Extension data */
132649dbf6fSJuan Castillo 		mbedtls_asn1_get_tag(&p, end_ext_data, &len,
133649dbf6fSJuan Castillo 				     MBEDTLS_ASN1_OCTET_STRING);
1347d37aa17SJuan Castillo 		end_ext_octet = p + len;
1357d37aa17SJuan Castillo 
1367d37aa17SJuan Castillo 		/* Detect requested extension */
137649dbf6fSJuan Castillo 		oid_len = mbedtls_oid_get_numeric_string(oid_str,
138649dbf6fSJuan Castillo 							 MAX_OID_STR_LEN,
139649dbf6fSJuan Castillo 							 &extn_oid);
140649dbf6fSJuan Castillo 		if (oid_len == MBEDTLS_ERR_OID_BUF_TOO_SMALL) {
1417d37aa17SJuan Castillo 			return IMG_PARSER_ERR;
1427d37aa17SJuan Castillo 		}
1437d37aa17SJuan Castillo 		if ((oid_len == strlen(oid_str)) && !strcmp(oid, oid_str)) {
1447d37aa17SJuan Castillo 			*ext = (void *)p;
1457d37aa17SJuan Castillo 			*ext_len = (unsigned int)len;
1467d37aa17SJuan Castillo 			return IMG_PARSER_OK;
1477d37aa17SJuan Castillo 		}
1487d37aa17SJuan Castillo 
1497d37aa17SJuan Castillo 		/* Next */
1507d37aa17SJuan Castillo 		p = end_ext_octet;
1517d37aa17SJuan Castillo 	}
1527d37aa17SJuan Castillo 
1537d37aa17SJuan Castillo 	return IMG_PARSER_ERR_NOT_FOUND;
1547d37aa17SJuan Castillo }
1557d37aa17SJuan Castillo 
1567d37aa17SJuan Castillo 
1577d37aa17SJuan Castillo /*
1587d37aa17SJuan Castillo  * Check the integrity of the certificate ASN.1 structure.
15951c5e1a2SAntonio Nino Diaz  *
1607d37aa17SJuan Castillo  * Extract the relevant data that will be used later during authentication.
16151c5e1a2SAntonio Nino Diaz  *
16251c5e1a2SAntonio Nino Diaz  * This function doesn't clear the static variables located on the top of this
16351c5e1a2SAntonio Nino Diaz  * file in case of an error. It is only called from check_integrity(), which
16451c5e1a2SAntonio Nino Diaz  * performs the cleanup if necessary.
1657d37aa17SJuan Castillo  */
1667d37aa17SJuan Castillo static int cert_parse(void *img, unsigned int img_len)
1677d37aa17SJuan Castillo {
1687d37aa17SJuan Castillo 	int ret, is_critical;
1697d37aa17SJuan Castillo 	size_t len;
1707d37aa17SJuan Castillo 	unsigned char *p, *end, *crt_end;
171649dbf6fSJuan Castillo 	mbedtls_asn1_buf sig_alg1, sig_alg2;
1727d37aa17SJuan Castillo 
1737d37aa17SJuan Castillo 	p = (unsigned char *)img;
1747d37aa17SJuan Castillo 	len = img_len;
1757d37aa17SJuan Castillo 	end = p + len;
1767d37aa17SJuan Castillo 
1777d37aa17SJuan Castillo 	/*
1787d37aa17SJuan Castillo 	 * Certificate  ::=  SEQUENCE  {
1797d37aa17SJuan Castillo 	 *      tbsCertificate       TBSCertificate,
1807d37aa17SJuan Castillo 	 *      signatureAlgorithm   AlgorithmIdentifier,
1817d37aa17SJuan Castillo 	 *      signatureValue       BIT STRING  }
1827d37aa17SJuan Castillo 	 */
183649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
184649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
1857d37aa17SJuan Castillo 	if (ret != 0) {
1867d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1877d37aa17SJuan Castillo 	}
1887d37aa17SJuan Castillo 
1897d37aa17SJuan Castillo 	if (len > (size_t)(end - p)) {
1907d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
1917d37aa17SJuan Castillo 	}
1927d37aa17SJuan Castillo 	crt_end = p + len;
1937d37aa17SJuan Castillo 
1947d37aa17SJuan Castillo 	/*
1957d37aa17SJuan Castillo 	 * TBSCertificate  ::=  SEQUENCE  {
1967d37aa17SJuan Castillo 	 */
1977d37aa17SJuan Castillo 	tbs.p = p;
198649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
199649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2007d37aa17SJuan Castillo 	if (ret != 0) {
2017d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2027d37aa17SJuan Castillo 	}
2037d37aa17SJuan Castillo 	end = p + len;
2047d37aa17SJuan Castillo 	tbs.len = end - tbs.p;
2057d37aa17SJuan Castillo 
2067d37aa17SJuan Castillo 	/*
2077d37aa17SJuan Castillo 	 * Version  ::=  INTEGER  {  v1(0), v2(1), v3(2)  }
2087d37aa17SJuan Castillo 	 */
209649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
210649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
211649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 0);
2127d37aa17SJuan Castillo 	if (ret != 0) {
2137d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2147d37aa17SJuan Castillo 	}
2157d37aa17SJuan Castillo 	p += len;
2167d37aa17SJuan Castillo 
2177d37aa17SJuan Castillo 	/*
2187d37aa17SJuan Castillo 	 * CertificateSerialNumber  ::=  INTEGER
2197d37aa17SJuan Castillo 	 */
220649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_INTEGER);
2217d37aa17SJuan Castillo 	if (ret != 0) {
2227d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2237d37aa17SJuan Castillo 	}
2247d37aa17SJuan Castillo 	p += len;
2257d37aa17SJuan Castillo 
2267d37aa17SJuan Castillo 	/*
2277d37aa17SJuan Castillo 	 * signature            AlgorithmIdentifier
2287d37aa17SJuan Castillo 	 */
2297d37aa17SJuan Castillo 	sig_alg1.p = p;
230649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
231649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2327d37aa17SJuan Castillo 	if (ret != 0) {
2337d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2347d37aa17SJuan Castillo 	}
2357d37aa17SJuan Castillo 	if ((end - p) < 1) {
2367d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2377d37aa17SJuan Castillo 	}
2387d37aa17SJuan Castillo 	sig_alg1.len = (p + len) - sig_alg1.p;
2397d37aa17SJuan Castillo 	p += len;
2407d37aa17SJuan Castillo 
2417d37aa17SJuan Castillo 	/*
2427d37aa17SJuan Castillo 	 * issuer               Name
2437d37aa17SJuan Castillo 	 */
244649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
245649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2467d37aa17SJuan Castillo 	if (ret != 0) {
2477d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2487d37aa17SJuan Castillo 	}
2497d37aa17SJuan Castillo 	p += len;
2507d37aa17SJuan Castillo 
2517d37aa17SJuan Castillo 	/*
2527d37aa17SJuan Castillo 	 * Validity ::= SEQUENCE {
2537d37aa17SJuan Castillo 	 *      notBefore      Time,
2547d37aa17SJuan Castillo 	 *      notAfter       Time }
2557d37aa17SJuan Castillo 	 *
2567d37aa17SJuan Castillo 	 */
257649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
258649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2597d37aa17SJuan Castillo 	if (ret != 0) {
2607d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2617d37aa17SJuan Castillo 	}
2627d37aa17SJuan Castillo 	p += len;
2637d37aa17SJuan Castillo 
2647d37aa17SJuan Castillo 	/*
2657d37aa17SJuan Castillo 	 * subject              Name
2667d37aa17SJuan Castillo 	 */
267649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
268649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2697d37aa17SJuan Castillo 	if (ret != 0) {
2707d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2717d37aa17SJuan Castillo 	}
2727d37aa17SJuan Castillo 	p += len;
2737d37aa17SJuan Castillo 
2747d37aa17SJuan Castillo 	/*
2757d37aa17SJuan Castillo 	 * SubjectPublicKeyInfo
2767d37aa17SJuan Castillo 	 */
2777d37aa17SJuan Castillo 	pk.p = p;
278649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
279649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
2807d37aa17SJuan Castillo 	if (ret != 0) {
2817d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
2827d37aa17SJuan Castillo 	}
2837d37aa17SJuan Castillo 	pk.len = (p + len) - pk.p;
2847d37aa17SJuan Castillo 	p += len;
2857d37aa17SJuan Castillo 
2867d37aa17SJuan Castillo 	/*
2877d37aa17SJuan Castillo 	 * issuerUniqueID  [1]  IMPLICIT UniqueIdentifier OPTIONAL,
2887d37aa17SJuan Castillo 	 */
289649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
290649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
291649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 1);
2927d37aa17SJuan Castillo 	if (ret != 0) {
293649dbf6fSJuan Castillo 		if (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG) {
2947d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
2957d37aa17SJuan Castillo 		}
2967d37aa17SJuan Castillo 	} else {
2977d37aa17SJuan Castillo 		p += len;
2987d37aa17SJuan Castillo 	}
2997d37aa17SJuan Castillo 
3007d37aa17SJuan Castillo 	/*
3017d37aa17SJuan Castillo 	 * subjectUniqueID [2]  IMPLICIT UniqueIdentifier OPTIONAL,
3027d37aa17SJuan Castillo 	 */
303649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
304649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
305649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 2);
3067d37aa17SJuan Castillo 	if (ret != 0) {
307649dbf6fSJuan Castillo 		if (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG) {
3087d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3097d37aa17SJuan Castillo 		}
3107d37aa17SJuan Castillo 	} else {
3117d37aa17SJuan Castillo 		p += len;
3127d37aa17SJuan Castillo 	}
3137d37aa17SJuan Castillo 
3147d37aa17SJuan Castillo 	/*
3157d37aa17SJuan Castillo 	 * extensions      [3]  EXPLICIT Extensions OPTIONAL
3167d37aa17SJuan Castillo 	 */
317649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len,
318649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONTEXT_SPECIFIC |
319649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_CONSTRUCTED | 3);
3207d37aa17SJuan Castillo 	if (ret != 0) {
3217d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3227d37aa17SJuan Castillo 	}
3237d37aa17SJuan Castillo 
3247d37aa17SJuan Castillo 	/*
3257d37aa17SJuan Castillo 	 * Extensions  ::=  SEQUENCE SIZE (1..MAX) OF Extension
3267d37aa17SJuan Castillo 	 */
3277d37aa17SJuan Castillo 	v3_ext.p = p;
328649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
329649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
3307d37aa17SJuan Castillo 	if (ret != 0) {
3317d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3327d37aa17SJuan Castillo 	}
3337d37aa17SJuan Castillo 	v3_ext.len = (p + len) - v3_ext.p;
3347d37aa17SJuan Castillo 
3357d37aa17SJuan Castillo 	/*
3367d37aa17SJuan Castillo 	 * Check extensions integrity
3377d37aa17SJuan Castillo 	 */
3387d37aa17SJuan Castillo 	while (p < end) {
339649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_tag(&p, end, &len,
340649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_CONSTRUCTED |
341649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_SEQUENCE);
3427d37aa17SJuan Castillo 		if (ret != 0) {
3437d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3447d37aa17SJuan Castillo 		}
3457d37aa17SJuan Castillo 
3467d37aa17SJuan Castillo 		/* Get extension ID */
347649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_OID);
3487d37aa17SJuan Castillo 		if (ret != 0) {
3497d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3507d37aa17SJuan Castillo 		}
3517d37aa17SJuan Castillo 		p += len;
3527d37aa17SJuan Castillo 
3537d37aa17SJuan Castillo 		/* Get optional critical */
354649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_bool(&p, end, &is_critical);
355649dbf6fSJuan Castillo 		if ((ret != 0) && (ret != MBEDTLS_ERR_ASN1_UNEXPECTED_TAG)) {
3567d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3577d37aa17SJuan Castillo 		}
3587d37aa17SJuan Castillo 
3597d37aa17SJuan Castillo 		/* Data should be octet string type */
360649dbf6fSJuan Castillo 		ret = mbedtls_asn1_get_tag(&p, end, &len,
361649dbf6fSJuan Castillo 					   MBEDTLS_ASN1_OCTET_STRING);
3627d37aa17SJuan Castillo 		if (ret != 0) {
3637d37aa17SJuan Castillo 			return IMG_PARSER_ERR_FORMAT;
3647d37aa17SJuan Castillo 		}
3657d37aa17SJuan Castillo 		p += len;
3667d37aa17SJuan Castillo 	}
3677d37aa17SJuan Castillo 
3687d37aa17SJuan Castillo 	if (p != end) {
3697d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3707d37aa17SJuan Castillo 	}
3717d37aa17SJuan Castillo 
3727d37aa17SJuan Castillo 	end = crt_end;
3737d37aa17SJuan Castillo 
3747d37aa17SJuan Castillo 	/*
3757d37aa17SJuan Castillo 	 *  }
3767d37aa17SJuan Castillo 	 *  -- end of TBSCertificate
3777d37aa17SJuan Castillo 	 *
3787d37aa17SJuan Castillo 	 *  signatureAlgorithm   AlgorithmIdentifier
3797d37aa17SJuan Castillo 	 */
3807d37aa17SJuan Castillo 	sig_alg2.p = p;
381649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_CONSTRUCTED |
382649dbf6fSJuan Castillo 				   MBEDTLS_ASN1_SEQUENCE);
3837d37aa17SJuan Castillo 	if (ret != 0) {
3847d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3857d37aa17SJuan Castillo 	}
3867d37aa17SJuan Castillo 	if ((end - p) < 1) {
3877d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3887d37aa17SJuan Castillo 	}
3897d37aa17SJuan Castillo 	sig_alg2.len = (p + len) - sig_alg2.p;
3907d37aa17SJuan Castillo 	p += len;
3917d37aa17SJuan Castillo 
3927d37aa17SJuan Castillo 	/* Compare both signature algorithms */
3937d37aa17SJuan Castillo 	if (sig_alg1.len != sig_alg2.len) {
3947d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3957d37aa17SJuan Castillo 	}
396b621fb50SAntonio Nino Diaz 	if (0 != timingsafe_bcmp(sig_alg1.p, sig_alg2.p, sig_alg1.len)) {
3977d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
3987d37aa17SJuan Castillo 	}
3997d37aa17SJuan Castillo 	memcpy(&sig_alg, &sig_alg1, sizeof(sig_alg));
4007d37aa17SJuan Castillo 
4017d37aa17SJuan Castillo 	/*
4027d37aa17SJuan Castillo 	 * signatureValue       BIT STRING
4037d37aa17SJuan Castillo 	 */
4047d37aa17SJuan Castillo 	signature.p = p;
405649dbf6fSJuan Castillo 	ret = mbedtls_asn1_get_tag(&p, end, &len, MBEDTLS_ASN1_BIT_STRING);
4067d37aa17SJuan Castillo 	if (ret != 0) {
4077d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
4087d37aa17SJuan Castillo 	}
4097d37aa17SJuan Castillo 	signature.len = (p + len) - signature.p;
4107d37aa17SJuan Castillo 	p += len;
4117d37aa17SJuan Castillo 
4127d37aa17SJuan Castillo 	/* Check certificate length */
4137d37aa17SJuan Castillo 	if (p != end) {
4147d37aa17SJuan Castillo 		return IMG_PARSER_ERR_FORMAT;
4157d37aa17SJuan Castillo 	}
4167d37aa17SJuan Castillo 
4177d37aa17SJuan Castillo 	return IMG_PARSER_OK;
4187d37aa17SJuan Castillo }
4197d37aa17SJuan Castillo 
4207d37aa17SJuan Castillo 
4217d37aa17SJuan Castillo /* Exported functions */
4227d37aa17SJuan Castillo 
4237d37aa17SJuan Castillo static void init(void)
4247d37aa17SJuan Castillo {
4257d37aa17SJuan Castillo 	mbedtls_init();
4267d37aa17SJuan Castillo }
4277d37aa17SJuan Castillo 
42851c5e1a2SAntonio Nino Diaz /*
42951c5e1a2SAntonio Nino Diaz  * Wrapper for cert_parse() that clears the static variables used by it in case
43051c5e1a2SAntonio Nino Diaz  * of an error.
43151c5e1a2SAntonio Nino Diaz  */
4327d37aa17SJuan Castillo static int check_integrity(void *img, unsigned int img_len)
4337d37aa17SJuan Castillo {
43451c5e1a2SAntonio Nino Diaz 	int rc = cert_parse(img, img_len);
43551c5e1a2SAntonio Nino Diaz 
43651c5e1a2SAntonio Nino Diaz 	if (rc != IMG_PARSER_OK)
43751c5e1a2SAntonio Nino Diaz 		clear_temp_vars();
43851c5e1a2SAntonio Nino Diaz 
43951c5e1a2SAntonio Nino Diaz 	return rc;
4407d37aa17SJuan Castillo }
4417d37aa17SJuan Castillo 
4427d37aa17SJuan Castillo /*
4437d37aa17SJuan Castillo  * Extract an authentication parameter from an X509v3 certificate
44448279d52SJuan Castillo  *
44548279d52SJuan Castillo  * This function returns a pointer to the extracted data and its length.
44648279d52SJuan Castillo  * Depending on the type of parameter, a pointer to the data stored in the
44748279d52SJuan Castillo  * certificate may be returned (i.e. an octet string containing a hash). Other
44848279d52SJuan Castillo  * data may need to be copied and formatted (i.e. integers). In the later case,
44948279d52SJuan Castillo  * a buffer of the correct type needs to be statically allocated, filled and
45048279d52SJuan Castillo  * returned.
4517d37aa17SJuan Castillo  */
4527d37aa17SJuan Castillo static int get_auth_param(const auth_param_type_desc_t *type_desc,
4537d37aa17SJuan Castillo 		void *img, unsigned int img_len,
4547d37aa17SJuan Castillo 		void **param, unsigned int *param_len)
4557d37aa17SJuan Castillo {
4567d37aa17SJuan Castillo 	int rc = IMG_PARSER_OK;
4577d37aa17SJuan Castillo 
4587d37aa17SJuan Castillo 	/* We do not use img because the check_integrity function has already
4597d37aa17SJuan Castillo 	 * extracted the relevant data (v3_ext, pk, sig_alg, etc) */
4607d37aa17SJuan Castillo 
4617d37aa17SJuan Castillo 	switch (type_desc->type) {
4627d37aa17SJuan Castillo 	case AUTH_PARAM_RAW_DATA:
4637d37aa17SJuan Castillo 		/* Data to be signed */
4647d37aa17SJuan Castillo 		*param = (void *)tbs.p;
4657d37aa17SJuan Castillo 		*param_len = (unsigned int)tbs.len;
4667d37aa17SJuan Castillo 		break;
4677d37aa17SJuan Castillo 	case AUTH_PARAM_HASH:
46848279d52SJuan Castillo 	case AUTH_PARAM_NV_CTR:
4697d37aa17SJuan Castillo 		/* All these parameters are included as X509v3 extensions */
4707d37aa17SJuan Castillo 		rc = get_ext(type_desc->cookie, param, param_len);
4717d37aa17SJuan Castillo 		break;
4727d37aa17SJuan Castillo 	case AUTH_PARAM_PUB_KEY:
4737d37aa17SJuan Castillo 		if (type_desc->cookie != 0) {
4747d37aa17SJuan Castillo 			/* Get public key from extension */
4757d37aa17SJuan Castillo 			rc = get_ext(type_desc->cookie, param, param_len);
4767d37aa17SJuan Castillo 		} else {
4777d37aa17SJuan Castillo 			/* Get the subject public key */
4787d37aa17SJuan Castillo 			*param = (void *)pk.p;
4797d37aa17SJuan Castillo 			*param_len = (unsigned int)pk.len;
4807d37aa17SJuan Castillo 		}
4817d37aa17SJuan Castillo 		break;
4827d37aa17SJuan Castillo 	case AUTH_PARAM_SIG_ALG:
4837d37aa17SJuan Castillo 		/* Get the certificate signature algorithm */
4847d37aa17SJuan Castillo 		*param = (void *)sig_alg.p;
4857d37aa17SJuan Castillo 		*param_len = (unsigned int)sig_alg.len;
4867d37aa17SJuan Castillo 		break;
4877d37aa17SJuan Castillo 	case AUTH_PARAM_SIG:
4887d37aa17SJuan Castillo 		/* Get the certificate signature */
4897d37aa17SJuan Castillo 		*param = (void *)signature.p;
4907d37aa17SJuan Castillo 		*param_len = (unsigned int)signature.len;
4917d37aa17SJuan Castillo 		break;
4927d37aa17SJuan Castillo 	default:
4937d37aa17SJuan Castillo 		rc = IMG_PARSER_ERR_NOT_FOUND;
4947d37aa17SJuan Castillo 		break;
4957d37aa17SJuan Castillo 	}
4967d37aa17SJuan Castillo 
4977d37aa17SJuan Castillo 	return rc;
4987d37aa17SJuan Castillo }
4997d37aa17SJuan Castillo 
5007d37aa17SJuan Castillo REGISTER_IMG_PARSER_LIB(IMG_CERT, LIB_NAME, init, \
5017d37aa17SJuan Castillo 		       check_integrity, get_auth_param);
502