xref: /rk3399_ARM-atf/common/fdt_fixup.c (revision 780dd2b310facce54188b190d683f21123b5148e)
1f240728bSAndre Przywara /*
2*780dd2b3SJavier Almansa Sobrino  * Copyright (c) 2016-2020, ARM Limited and Contributors. All rights reserved.
3f240728bSAndre Przywara  *
4f240728bSAndre Przywara  * SPDX-License-Identifier: BSD-3-Clause
5f240728bSAndre Przywara  */
6f240728bSAndre Przywara 
7f240728bSAndre Przywara /*
8f240728bSAndre Przywara  * Contains generic routines to fix up the device tree blob passed on to
9f240728bSAndre Przywara  * payloads like BL32 and BL33 (and further down the boot chain).
10f240728bSAndre Przywara  * This allows to easily add PSCI nodes, when the original DT does not have
11f240728bSAndre Przywara  * it or advertises another method.
123ef45ddaSAndre Przywara  * Also it supports to add reserved memory nodes to describe memory that
133ef45ddaSAndre Przywara  * is used by the secure world, so that non-secure software avoids using
143ef45ddaSAndre Przywara  * that.
15f240728bSAndre Przywara  */
16f240728bSAndre Przywara 
17*780dd2b3SJavier Almansa Sobrino #include <errno.h>
18*780dd2b3SJavier Almansa Sobrino #include <stdio.h>
19f240728bSAndre Przywara #include <string.h>
20f240728bSAndre Przywara 
21f240728bSAndre Przywara #include <libfdt.h>
22f240728bSAndre Przywara 
23*780dd2b3SJavier Almansa Sobrino #include <arch.h>
24f240728bSAndre Przywara #include <common/debug.h>
25*780dd2b3SJavier Almansa Sobrino #include <common/fdt_fixup.h>
26*780dd2b3SJavier Almansa Sobrino #include <common/fdt_wrappers.h>
27f240728bSAndre Przywara #include <drivers/console.h>
28f240728bSAndre Przywara #include <lib/psci/psci.h>
29*780dd2b3SJavier Almansa Sobrino #include <plat/common/platform.h>
30f240728bSAndre Przywara 
31f240728bSAndre Przywara 
32f240728bSAndre Przywara static int append_psci_compatible(void *fdt, int offs, const char *str)
33f240728bSAndre Przywara {
34f240728bSAndre Przywara 	return fdt_appendprop(fdt, offs, "compatible", str, strlen(str) + 1);
35f240728bSAndre Przywara }
36f240728bSAndre Przywara 
3766799507SAndre Przywara /*
3866799507SAndre Przywara  * Those defines are for PSCI v0.1 legacy clients, which we expect to use
3966799507SAndre Przywara  * the same execution state (AArch32/AArch64) as TF-A.
4066799507SAndre Przywara  * Kernels running in AArch32 on an AArch64 TF-A should use PSCI v0.2.
4166799507SAndre Przywara  */
4266799507SAndre Przywara #ifdef __aarch64__
4366799507SAndre Przywara #define PSCI_CPU_SUSPEND_FNID	PSCI_CPU_SUSPEND_AARCH64
4466799507SAndre Przywara #define PSCI_CPU_ON_FNID	PSCI_CPU_ON_AARCH64
4566799507SAndre Przywara #else
4666799507SAndre Przywara #define PSCI_CPU_SUSPEND_FNID	PSCI_CPU_SUSPEND_AARCH32
4766799507SAndre Przywara #define PSCI_CPU_ON_FNID	PSCI_CPU_ON_AARCH32
4866799507SAndre Przywara #endif
4966799507SAndre Przywara 
506eaf928dSAndre Przywara /*******************************************************************************
516eaf928dSAndre Przywara  * dt_add_psci_node() - Add a PSCI node into an existing device tree
526eaf928dSAndre Przywara  * @fdt:	pointer to the device tree blob in memory
536eaf928dSAndre Przywara  *
546eaf928dSAndre Przywara  * Add a device tree node describing PSCI into the root level of an existing
556eaf928dSAndre Przywara  * device tree blob in memory.
566eaf928dSAndre Przywara  * This will add v0.1, v0.2 and v1.0 compatible strings and the standard
576eaf928dSAndre Przywara  * function IDs for v0.1 compatibility.
586eaf928dSAndre Przywara  * An existing PSCI node will not be touched, the function will return success
596eaf928dSAndre Przywara  * in this case. This function will not touch the /cpus enable methods, use
606eaf928dSAndre Przywara  * dt_add_psci_cpu_enable_methods() for that.
616eaf928dSAndre Przywara  *
626eaf928dSAndre Przywara  * Return: 0 on success, -1 otherwise.
636eaf928dSAndre Przywara  ******************************************************************************/
64f240728bSAndre Przywara int dt_add_psci_node(void *fdt)
65f240728bSAndre Przywara {
66f240728bSAndre Przywara 	int offs;
67f240728bSAndre Przywara 
68f240728bSAndre Przywara 	if (fdt_path_offset(fdt, "/psci") >= 0) {
69f240728bSAndre Przywara 		WARN("PSCI Device Tree node already exists!\n");
70f240728bSAndre Przywara 		return 0;
71f240728bSAndre Przywara 	}
72f240728bSAndre Przywara 
73f240728bSAndre Przywara 	offs = fdt_path_offset(fdt, "/");
74f240728bSAndre Przywara 	if (offs < 0)
75f240728bSAndre Przywara 		return -1;
76f240728bSAndre Przywara 	offs = fdt_add_subnode(fdt, offs, "psci");
77f240728bSAndre Przywara 	if (offs < 0)
78f240728bSAndre Przywara 		return -1;
79f240728bSAndre Przywara 	if (append_psci_compatible(fdt, offs, "arm,psci-1.0"))
80f240728bSAndre Przywara 		return -1;
81f240728bSAndre Przywara 	if (append_psci_compatible(fdt, offs, "arm,psci-0.2"))
82f240728bSAndre Przywara 		return -1;
83f240728bSAndre Przywara 	if (append_psci_compatible(fdt, offs, "arm,psci"))
84f240728bSAndre Przywara 		return -1;
85f240728bSAndre Przywara 	if (fdt_setprop_string(fdt, offs, "method", "smc"))
86f240728bSAndre Przywara 		return -1;
8766799507SAndre Przywara 	if (fdt_setprop_u32(fdt, offs, "cpu_suspend", PSCI_CPU_SUSPEND_FNID))
88f240728bSAndre Przywara 		return -1;
89f240728bSAndre Przywara 	if (fdt_setprop_u32(fdt, offs, "cpu_off", PSCI_CPU_OFF))
90f240728bSAndre Przywara 		return -1;
9166799507SAndre Przywara 	if (fdt_setprop_u32(fdt, offs, "cpu_on", PSCI_CPU_ON_FNID))
92f240728bSAndre Przywara 		return -1;
93f240728bSAndre Przywara 	return 0;
94f240728bSAndre Przywara }
95f240728bSAndre Przywara 
96f240728bSAndre Przywara /*
97f240728bSAndre Przywara  * Find the first subnode that has a "device_type" property with the value
98f240728bSAndre Przywara  * "cpu" and which's enable-method is not "psci" (yet).
99f240728bSAndre Przywara  * Returns 0 if no such subnode is found, so all have already been patched
100f240728bSAndre Przywara  * or none have to be patched in the first place.
101f240728bSAndre Przywara  * Returns 1 if *one* such subnode has been found and successfully changed
102f240728bSAndre Przywara  * to "psci".
103feb358b6SAndre Przywara  * Returns negative values on error.
104f240728bSAndre Przywara  *
105f240728bSAndre Przywara  * Call in a loop until it returns 0. Recalculate the node offset after
106f240728bSAndre Przywara  * it has returned 1.
107f240728bSAndre Przywara  */
108f240728bSAndre Przywara static int dt_update_one_cpu_node(void *fdt, int offset)
109f240728bSAndre Przywara {
110f240728bSAndre Przywara 	int offs;
111f240728bSAndre Przywara 
112f240728bSAndre Przywara 	/* Iterate over all subnodes to find those with device_type = "cpu". */
113f240728bSAndre Przywara 	for (offs = fdt_first_subnode(fdt, offset); offs >= 0;
114f240728bSAndre Przywara 	     offs = fdt_next_subnode(fdt, offs)) {
115f240728bSAndre Przywara 		const char *prop;
116f240728bSAndre Przywara 		int len;
117feb358b6SAndre Przywara 		int ret;
118f240728bSAndre Przywara 
119f240728bSAndre Przywara 		prop = fdt_getprop(fdt, offs, "device_type", &len);
120feb358b6SAndre Przywara 		if (prop == NULL)
121f240728bSAndre Przywara 			continue;
122feb358b6SAndre Przywara 		if ((strcmp(prop, "cpu") != 0) || (len != 4))
123f240728bSAndre Przywara 			continue;
124f240728bSAndre Przywara 
125f240728bSAndre Przywara 		/* Ignore any nodes which already use "psci". */
126f240728bSAndre Przywara 		prop = fdt_getprop(fdt, offs, "enable-method", &len);
127feb358b6SAndre Przywara 		if ((prop != NULL) &&
128feb358b6SAndre Przywara 		    (strcmp(prop, "psci") == 0) && (len == 5))
129f240728bSAndre Przywara 			continue;
130f240728bSAndre Przywara 
131feb358b6SAndre Przywara 		ret = fdt_setprop_string(fdt, offs, "enable-method", "psci");
132feb358b6SAndre Przywara 		if (ret < 0)
133feb358b6SAndre Przywara 			return ret;
134f240728bSAndre Przywara 		/*
135f240728bSAndre Przywara 		 * Subnode found and patched.
136f240728bSAndre Przywara 		 * Restart to accommodate potentially changed offsets.
137f240728bSAndre Przywara 		 */
138f240728bSAndre Przywara 		return 1;
139f240728bSAndre Przywara 	}
140f240728bSAndre Przywara 
141f240728bSAndre Przywara 	if (offs == -FDT_ERR_NOTFOUND)
142f240728bSAndre Przywara 		return 0;
143f240728bSAndre Przywara 
144f240728bSAndre Przywara 	return offs;
145f240728bSAndre Przywara }
146f240728bSAndre Przywara 
1476eaf928dSAndre Przywara /*******************************************************************************
1486eaf928dSAndre Przywara  * dt_add_psci_cpu_enable_methods() - switch CPU nodes in DT to use PSCI
1496eaf928dSAndre Przywara  * @fdt:	pointer to the device tree blob in memory
1506eaf928dSAndre Przywara  *
1516eaf928dSAndre Przywara  * Iterate over all CPU device tree nodes (/cpus/cpu@x) in memory to change
1526eaf928dSAndre Przywara  * the enable-method to PSCI. This will add the enable-method properties, if
1536eaf928dSAndre Przywara  * required, or will change existing properties to read "psci".
1546eaf928dSAndre Przywara  *
1556eaf928dSAndre Przywara  * Return: 0 on success, or a negative error value otherwise.
1566eaf928dSAndre Przywara  ******************************************************************************/
1576eaf928dSAndre Przywara 
158f240728bSAndre Przywara int dt_add_psci_cpu_enable_methods(void *fdt)
159f240728bSAndre Przywara {
160f240728bSAndre Przywara 	int offs, ret;
161f240728bSAndre Przywara 
162f240728bSAndre Przywara 	do {
163f240728bSAndre Przywara 		offs = fdt_path_offset(fdt, "/cpus");
164f240728bSAndre Przywara 		if (offs < 0)
165f240728bSAndre Przywara 			return offs;
166f240728bSAndre Przywara 
167f240728bSAndre Przywara 		ret = dt_update_one_cpu_node(fdt, offs);
168f240728bSAndre Przywara 	} while (ret > 0);
169f240728bSAndre Przywara 
170f240728bSAndre Przywara 	return ret;
171f240728bSAndre Przywara }
1723ef45ddaSAndre Przywara 
1733ef45ddaSAndre Przywara #define HIGH_BITS(x) ((sizeof(x) > 4) ? ((x) >> 32) : (typeof(x))0)
1743ef45ddaSAndre Przywara 
1756eaf928dSAndre Przywara /*******************************************************************************
1766eaf928dSAndre Przywara  * fdt_add_reserved_memory() - reserve (secure) memory regions in DT
1776eaf928dSAndre Przywara  * @dtb:	pointer to the device tree blob in memory
1786eaf928dSAndre Przywara  * @node_name:	name of the subnode to be used
1796eaf928dSAndre Przywara  * @base:	physical base address of the reserved region
1806eaf928dSAndre Przywara  * @size:	size of the reserved region
1816eaf928dSAndre Przywara  *
1826eaf928dSAndre Przywara  * Add a region of memory to the /reserved-memory node in a device tree in
1836eaf928dSAndre Przywara  * memory, creating that node if required. Each region goes into a subnode
1846eaf928dSAndre Przywara  * of that node and has a @node_name, a @base address and a @size.
1856eaf928dSAndre Przywara  * This will prevent any device tree consumer from using that memory. It
1866eaf928dSAndre Przywara  * can be used to announce secure memory regions, as it adds the "no-map"
1876eaf928dSAndre Przywara  * property to prevent mapping and speculative operations on that region.
1886eaf928dSAndre Przywara  *
1896eaf928dSAndre Przywara  * See reserved-memory/reserved-memory.txt in the (Linux kernel) DT binding
1906eaf928dSAndre Przywara  * documentation for details.
1916eaf928dSAndre Przywara  *
1926eaf928dSAndre Przywara  * Return: 0 on success, a negative error value otherwise.
1936eaf928dSAndre Przywara  ******************************************************************************/
1943ef45ddaSAndre Przywara int fdt_add_reserved_memory(void *dtb, const char *node_name,
1953ef45ddaSAndre Przywara 			    uintptr_t base, size_t size)
1963ef45ddaSAndre Przywara {
1973ef45ddaSAndre Przywara 	int offs = fdt_path_offset(dtb, "/reserved-memory");
1983ef45ddaSAndre Przywara 	uint32_t addresses[3];
1993ef45ddaSAndre Przywara 
2003ef45ddaSAndre Przywara 	if (offs < 0) {			/* create if not existing yet */
2013ef45ddaSAndre Przywara 		offs = fdt_add_subnode(dtb, 0, "reserved-memory");
2023ef45ddaSAndre Przywara 		if (offs < 0)
2033ef45ddaSAndre Przywara 			return offs;
2043ef45ddaSAndre Przywara 		fdt_setprop_u32(dtb, offs, "#address-cells", 2);
2053ef45ddaSAndre Przywara 		fdt_setprop_u32(dtb, offs, "#size-cells", 1);
2063ef45ddaSAndre Przywara 		fdt_setprop(dtb, offs, "ranges", NULL, 0);
2073ef45ddaSAndre Przywara 	}
2083ef45ddaSAndre Przywara 
2093ef45ddaSAndre Przywara 	addresses[0] = cpu_to_fdt32(HIGH_BITS(base));
2103ef45ddaSAndre Przywara 	addresses[1] = cpu_to_fdt32(base & 0xffffffff);
2113ef45ddaSAndre Przywara 	addresses[2] = cpu_to_fdt32(size & 0xffffffff);
2123ef45ddaSAndre Przywara 	offs = fdt_add_subnode(dtb, offs, node_name);
2133ef45ddaSAndre Przywara 	fdt_setprop(dtb, offs, "no-map", NULL, 0);
2143ef45ddaSAndre Przywara 	fdt_setprop(dtb, offs, "reg", addresses, 12);
2153ef45ddaSAndre Przywara 
2163ef45ddaSAndre Przywara 	return 0;
2173ef45ddaSAndre Przywara }
218*780dd2b3SJavier Almansa Sobrino 
219*780dd2b3SJavier Almansa Sobrino /*******************************************************************************
220*780dd2b3SJavier Almansa Sobrino  * fdt_add_cpu()	Add a new CPU node to the DT
221*780dd2b3SJavier Almansa Sobrino  * @dtb:		Pointer to the device tree blob in memory
222*780dd2b3SJavier Almansa Sobrino  * @parent:		Offset of the parent node
223*780dd2b3SJavier Almansa Sobrino  * @mpidr:		MPIDR for the current CPU
224*780dd2b3SJavier Almansa Sobrino  *
225*780dd2b3SJavier Almansa Sobrino  * Create and add a new cpu node to a DTB.
226*780dd2b3SJavier Almansa Sobrino  *
227*780dd2b3SJavier Almansa Sobrino  * Return the offset of the new node or a negative value in case of error
228*780dd2b3SJavier Almansa Sobrino  ******************************************************************************/
229*780dd2b3SJavier Almansa Sobrino 
230*780dd2b3SJavier Almansa Sobrino static int fdt_add_cpu(void *dtb, int parent, u_register_t mpidr)
231*780dd2b3SJavier Almansa Sobrino {
232*780dd2b3SJavier Almansa Sobrino 	int cpu_offs;
233*780dd2b3SJavier Almansa Sobrino 	int err;
234*780dd2b3SJavier Almansa Sobrino 	char snode_name[15];
235*780dd2b3SJavier Almansa Sobrino 	uint64_t reg_prop;
236*780dd2b3SJavier Almansa Sobrino 
237*780dd2b3SJavier Almansa Sobrino 	reg_prop = mpidr & MPID_MASK & ~MPIDR_MT_MASK;
238*780dd2b3SJavier Almansa Sobrino 
239*780dd2b3SJavier Almansa Sobrino 	snprintf(snode_name, sizeof(snode_name), "cpu@%x",
240*780dd2b3SJavier Almansa Sobrino 					(unsigned int)reg_prop);
241*780dd2b3SJavier Almansa Sobrino 
242*780dd2b3SJavier Almansa Sobrino 	cpu_offs = fdt_add_subnode(dtb, parent, snode_name);
243*780dd2b3SJavier Almansa Sobrino 	if (cpu_offs < 0) {
244*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: add subnode \"%s\" failed: %i\n",
245*780dd2b3SJavier Almansa Sobrino 							snode_name, cpu_offs);
246*780dd2b3SJavier Almansa Sobrino 		return cpu_offs;
247*780dd2b3SJavier Almansa Sobrino 	}
248*780dd2b3SJavier Almansa Sobrino 
249*780dd2b3SJavier Almansa Sobrino 	err = fdt_setprop_string(dtb, cpu_offs, "compatible", "arm,armv8");
250*780dd2b3SJavier Almansa Sobrino 	if (err < 0) {
251*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: write to \"%s\" property of node at offset %i failed\n",
252*780dd2b3SJavier Almansa Sobrino 			"compatible", cpu_offs);
253*780dd2b3SJavier Almansa Sobrino 		return err;
254*780dd2b3SJavier Almansa Sobrino 	}
255*780dd2b3SJavier Almansa Sobrino 
256*780dd2b3SJavier Almansa Sobrino 	err = fdt_setprop_u64(dtb, cpu_offs, "reg", reg_prop);
257*780dd2b3SJavier Almansa Sobrino 	if (err < 0) {
258*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: write to \"%s\" property of node at offset %i failed\n",
259*780dd2b3SJavier Almansa Sobrino 			"reg", cpu_offs);
260*780dd2b3SJavier Almansa Sobrino 		return err;
261*780dd2b3SJavier Almansa Sobrino 	}
262*780dd2b3SJavier Almansa Sobrino 
263*780dd2b3SJavier Almansa Sobrino 	err = fdt_setprop_string(dtb, cpu_offs, "device_type", "cpu");
264*780dd2b3SJavier Almansa Sobrino 	if (err < 0) {
265*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: write to \"%s\" property of node at offset %i failed\n",
266*780dd2b3SJavier Almansa Sobrino 			"device_type", cpu_offs);
267*780dd2b3SJavier Almansa Sobrino 		return err;
268*780dd2b3SJavier Almansa Sobrino 	}
269*780dd2b3SJavier Almansa Sobrino 
270*780dd2b3SJavier Almansa Sobrino 	err = fdt_setprop_string(dtb, cpu_offs, "enable-method", "psci");
271*780dd2b3SJavier Almansa Sobrino 	if (err < 0) {
272*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: write to \"%s\" property of node at offset %i failed\n",
273*780dd2b3SJavier Almansa Sobrino 			"enable-method", cpu_offs);
274*780dd2b3SJavier Almansa Sobrino 		return err;
275*780dd2b3SJavier Almansa Sobrino 	}
276*780dd2b3SJavier Almansa Sobrino 
277*780dd2b3SJavier Almansa Sobrino 	return cpu_offs;
278*780dd2b3SJavier Almansa Sobrino }
279*780dd2b3SJavier Almansa Sobrino 
280*780dd2b3SJavier Almansa Sobrino /******************************************************************************
281*780dd2b3SJavier Almansa Sobrino  * fdt_add_cpus_node() - Add the cpus node to the DTB
282*780dd2b3SJavier Almansa Sobrino  * @dtb:		pointer to the device tree blob in memory
283*780dd2b3SJavier Almansa Sobrino  * @afflv0:		Maximum number of threads per core (affinity level 0).
284*780dd2b3SJavier Almansa Sobrino  * @afflv1:		Maximum number of CPUs per cluster (affinity level 1).
285*780dd2b3SJavier Almansa Sobrino  * @afflv2:		Maximum number of clusters (affinity level 2).
286*780dd2b3SJavier Almansa Sobrino  *
287*780dd2b3SJavier Almansa Sobrino  * Iterate over all the possible MPIDs given the maximum affinity levels and
288*780dd2b3SJavier Almansa Sobrino  * add a cpus node to the DTB with all the valid CPUs on the system.
289*780dd2b3SJavier Almansa Sobrino  * If there is already a /cpus node, exit gracefully
290*780dd2b3SJavier Almansa Sobrino  *
291*780dd2b3SJavier Almansa Sobrino  * A system with two CPUs would generate a node equivalent or similar to:
292*780dd2b3SJavier Almansa Sobrino  *
293*780dd2b3SJavier Almansa Sobrino  *	cpus {
294*780dd2b3SJavier Almansa Sobrino  *		#address-cells = <2>;
295*780dd2b3SJavier Almansa Sobrino  *		#size-cells = <0>;
296*780dd2b3SJavier Almansa Sobrino  *
297*780dd2b3SJavier Almansa Sobrino  *		cpu0: cpu@0 {
298*780dd2b3SJavier Almansa Sobrino  *			compatible = "arm,armv8";
299*780dd2b3SJavier Almansa Sobrino  *			reg = <0x0 0x0>;
300*780dd2b3SJavier Almansa Sobrino  *			device_type = "cpu";
301*780dd2b3SJavier Almansa Sobrino  *			enable-method = "psci";
302*780dd2b3SJavier Almansa Sobrino  *		};
303*780dd2b3SJavier Almansa Sobrino  *		cpu1: cpu@10000 {
304*780dd2b3SJavier Almansa Sobrino  *			compatible = "arm,armv8";
305*780dd2b3SJavier Almansa Sobrino  *			reg = <0x0 0x100>;
306*780dd2b3SJavier Almansa Sobrino  *			device_type = "cpu";
307*780dd2b3SJavier Almansa Sobrino  *			enable-method = "psci";
308*780dd2b3SJavier Almansa Sobrino  *		};
309*780dd2b3SJavier Almansa Sobrino  *	};
310*780dd2b3SJavier Almansa Sobrino  *
311*780dd2b3SJavier Almansa Sobrino  * Full documentation about the CPU bindings can be found at:
312*780dd2b3SJavier Almansa Sobrino  * https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.txt
313*780dd2b3SJavier Almansa Sobrino  *
314*780dd2b3SJavier Almansa Sobrino  * Return the offset of the node or a negative value on error.
315*780dd2b3SJavier Almansa Sobrino  ******************************************************************************/
316*780dd2b3SJavier Almansa Sobrino 
317*780dd2b3SJavier Almansa Sobrino int fdt_add_cpus_node(void *dtb, unsigned int afflv0,
318*780dd2b3SJavier Almansa Sobrino 		      unsigned int afflv1, unsigned int afflv2)
319*780dd2b3SJavier Almansa Sobrino {
320*780dd2b3SJavier Almansa Sobrino 	int offs;
321*780dd2b3SJavier Almansa Sobrino 	int err;
322*780dd2b3SJavier Almansa Sobrino 	unsigned int i, j, k;
323*780dd2b3SJavier Almansa Sobrino 	u_register_t mpidr;
324*780dd2b3SJavier Almansa Sobrino 	int cpuid;
325*780dd2b3SJavier Almansa Sobrino 
326*780dd2b3SJavier Almansa Sobrino 	if (fdt_path_offset(dtb, "/cpus") >= 0) {
327*780dd2b3SJavier Almansa Sobrino 		return -EEXIST;
328*780dd2b3SJavier Almansa Sobrino 	}
329*780dd2b3SJavier Almansa Sobrino 
330*780dd2b3SJavier Almansa Sobrino 	offs = fdt_add_subnode(dtb, 0, "cpus");
331*780dd2b3SJavier Almansa Sobrino 	if (offs < 0) {
332*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: add subnode \"cpus\" node to parent node failed");
333*780dd2b3SJavier Almansa Sobrino 		return offs;
334*780dd2b3SJavier Almansa Sobrino 	}
335*780dd2b3SJavier Almansa Sobrino 
336*780dd2b3SJavier Almansa Sobrino 	err = fdt_setprop_u32(dtb, offs, "#address-cells", 2);
337*780dd2b3SJavier Almansa Sobrino 	if (err < 0) {
338*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: write to \"%s\" property of node at offset %i failed\n",
339*780dd2b3SJavier Almansa Sobrino 			"#address-cells", offs);
340*780dd2b3SJavier Almansa Sobrino 		return err;
341*780dd2b3SJavier Almansa Sobrino 	}
342*780dd2b3SJavier Almansa Sobrino 
343*780dd2b3SJavier Almansa Sobrino 	err = fdt_setprop_u32(dtb, offs, "#size-cells", 0);
344*780dd2b3SJavier Almansa Sobrino 	if (err < 0) {
345*780dd2b3SJavier Almansa Sobrino 		ERROR ("FDT: write to \"%s\" property of node at offset %i failed\n",
346*780dd2b3SJavier Almansa Sobrino 			"#size-cells", offs);
347*780dd2b3SJavier Almansa Sobrino 		return err;
348*780dd2b3SJavier Almansa Sobrino 	}
349*780dd2b3SJavier Almansa Sobrino 
350*780dd2b3SJavier Almansa Sobrino 	/*
351*780dd2b3SJavier Almansa Sobrino 	 * Populate the node with the CPUs.
352*780dd2b3SJavier Almansa Sobrino 	 * As libfdt prepends subnodes within a node, reverse the index count
353*780dd2b3SJavier Almansa Sobrino 	 * so the CPU nodes would be better ordered.
354*780dd2b3SJavier Almansa Sobrino 	 */
355*780dd2b3SJavier Almansa Sobrino 	for (i = afflv2; i > 0U; i--) {
356*780dd2b3SJavier Almansa Sobrino 		for (j = afflv1; j > 0U; j--) {
357*780dd2b3SJavier Almansa Sobrino 			for (k = afflv0; k > 0U; k--) {
358*780dd2b3SJavier Almansa Sobrino 				mpidr = ((i - 1) << MPIDR_AFF2_SHIFT) |
359*780dd2b3SJavier Almansa Sobrino 					((j - 1) << MPIDR_AFF1_SHIFT) |
360*780dd2b3SJavier Almansa Sobrino 					((k - 1) << MPIDR_AFF0_SHIFT) |
361*780dd2b3SJavier Almansa Sobrino 					(read_mpidr_el1() & MPIDR_MT_MASK);
362*780dd2b3SJavier Almansa Sobrino 
363*780dd2b3SJavier Almansa Sobrino 				cpuid = plat_core_pos_by_mpidr(mpidr);
364*780dd2b3SJavier Almansa Sobrino 				if (cpuid >= 0) {
365*780dd2b3SJavier Almansa Sobrino 					/* Valid MPID found */
366*780dd2b3SJavier Almansa Sobrino 					err = fdt_add_cpu(dtb, offs, mpidr);
367*780dd2b3SJavier Almansa Sobrino 					if (err < 0) {
368*780dd2b3SJavier Almansa Sobrino 						ERROR ("FDT: %s 0x%08x\n",
369*780dd2b3SJavier Almansa Sobrino 							"error adding CPU",
370*780dd2b3SJavier Almansa Sobrino 							(uint32_t)mpidr);
371*780dd2b3SJavier Almansa Sobrino 						return err;
372*780dd2b3SJavier Almansa Sobrino 					}
373*780dd2b3SJavier Almansa Sobrino 				}
374*780dd2b3SJavier Almansa Sobrino 			}
375*780dd2b3SJavier Almansa Sobrino 		}
376*780dd2b3SJavier Almansa Sobrino 	}
377*780dd2b3SJavier Almansa Sobrino 
378*780dd2b3SJavier Almansa Sobrino 	return offs;
379*780dd2b3SJavier Almansa Sobrino }
380