1*4882a593SmuzhiyunFrom 126dfefb5fddf411ad0a1316209e9c1b47abfcd2 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Khem Raj <raj.khem@gmail.com> 3*4882a593SmuzhiyunDate: Wed, 9 Feb 2022 17:30:16 -0800 4*4882a593SmuzhiyunSubject: [PATCH] man: Move local variable declaration to function scope 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunThere is a clang bug [1] unearthed here, so help clang by re-arranging 7*4882a593Smuzhiyuncode without changing the logic, until its fixed in clang 8*4882a593Smuzhiyun 9*4882a593Smuzhiyun[1] https://github.com/llvm/llvm-project/issues/53692 10*4882a593Smuzhiyun 11*4882a593SmuzhiyunUpstream-Status: Inappropriate [Inappropriate: Clang bug] 12*4882a593SmuzhiyunSigned-off-by: Khem Raj <raj.khem@gmail.com> 13*4882a593Smuzhiyun 14*4882a593Smuzhiyun--- 15*4882a593Smuzhiyun src/man.c | 4 ++-- 16*4882a593Smuzhiyun 1 file changed, 2 insertions(+), 2 deletions(-) 17*4882a593Smuzhiyun 18*4882a593Smuzhiyundiff --git a/src/man.c b/src/man.c 19*4882a593Smuzhiyunindex f16fae8..333df03 100644 20*4882a593Smuzhiyun--- a/src/man.c 21*4882a593Smuzhiyun+++ b/src/man.c 22*4882a593Smuzhiyun@@ -352,7 +352,7 @@ static void init_html_pager (void) 23*4882a593Smuzhiyun static error_t parse_opt (int key, char *arg, struct argp_state *state) 24*4882a593Smuzhiyun { 25*4882a593Smuzhiyun static bool apropos, whatis; /* retain values between calls */ 26*4882a593Smuzhiyun- 27*4882a593Smuzhiyun+ char *s; 28*4882a593Smuzhiyun /* Please keep these keys in the same order as in options above. */ 29*4882a593Smuzhiyun switch (key) { 30*4882a593Smuzhiyun case 'C': 31*4882a593Smuzhiyun@@ -384,7 +384,7 @@ static error_t parse_opt (int key, char *arg, struct argp_state *state) 32*4882a593Smuzhiyun case OPT_WARNINGS: 33*4882a593Smuzhiyun #ifdef NROFF_WARNINGS 34*4882a593Smuzhiyun { 35*4882a593Smuzhiyun- char *s = xstrdup 36*4882a593Smuzhiyun+ s = xstrdup 37*4882a593Smuzhiyun (arg ? arg : default_roff_warnings); 38*4882a593Smuzhiyun const char *warning; 39*4882a593Smuzhiyun 40