1*4882a593SmuzhiyunFrom 971b5626339ce0c4d57f9721c9a81af566c5a044 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Alex Kube <alexander.j.kube@gmail.com> 3*4882a593SmuzhiyunDate: Wed, 23 Oct 2019 21:19:26 +0430 4*4882a593SmuzhiyunSubject: [PATCH 8/9] cmd/go: Use GOBUILDMODE to set buildmode 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunUpstream-Status: Denied [upstream choose antoher solution: `17a256b 7*4882a593Smuzhiyuncmd/go: -buildmode=pie for android/arm'] 8*4882a593Smuzhiyun 9*4882a593SmuzhiyunWhile building go itself, the go build system does not support 10*4882a593Smuzhiyunto set `-buildmode=pie' from environment. 11*4882a593Smuzhiyun 12*4882a593SmuzhiyunAdd GOBUILDMODE to support it which make PIE executables the default 13*4882a593Smuzhiyunbuild mode, as PIE executables are required as of Yocto 14*4882a593Smuzhiyun 15*4882a593SmuzhiyunRefers: https://groups.google.com/forum/#!topic/golang-dev/gRCe5URKewI 16*4882a593Smuzhiyun 17*4882a593SmuzhiyunAdapted to Go 1.13 from patches originally submitted to 18*4882a593Smuzhiyunthe meta/recipes-devtools/go tree by 19*4882a593SmuzhiyunHongxu Jia <hongxu.jia@windriver.com> 20*4882a593Smuzhiyun 21*4882a593SmuzhiyunSigned-off-by: Alexander J Kube <alexander.j.kube@gmail.com> 22*4882a593Smuzhiyun--- 23*4882a593Smuzhiyun src/cmd/go/internal/work/build.go | 8 +++++++- 24*4882a593Smuzhiyun 1 file changed, 7 insertions(+), 1 deletion(-) 25*4882a593Smuzhiyun 26*4882a593Smuzhiyun--- a/src/cmd/go/internal/work/build.go 27*4882a593Smuzhiyun+++ b/src/cmd/go/internal/work/build.go 28*4882a593Smuzhiyun@@ -254,7 +254,13 @@ func AddBuildFlags(cmd *base.Command, ma 29*4882a593Smuzhiyun 30*4882a593Smuzhiyun cmd.Flag.Var(&load.BuildAsmflags, "asmflags", "") 31*4882a593Smuzhiyun cmd.Flag.Var(buildCompiler{}, "compiler", "") 32*4882a593Smuzhiyun- cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", "default", "") 33*4882a593Smuzhiyun+ 34*4882a593Smuzhiyun+ if bm := os.Getenv("GOBUILDMODE"); bm != "" { 35*4882a593Smuzhiyun+ cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", bm, "") 36*4882a593Smuzhiyun+ } else { 37*4882a593Smuzhiyun+ cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", "default", "") 38*4882a593Smuzhiyun+ } 39*4882a593Smuzhiyun+ 40*4882a593Smuzhiyun cmd.Flag.Var(&load.BuildGcflags, "gcflags", "") 41*4882a593Smuzhiyun cmd.Flag.Var(&load.BuildGccgoflags, "gccgoflags", "") 42*4882a593Smuzhiyun if mask&OmitModFlag == 0 { 43