1*4882a593SmuzhiyunFrom 931a55347a322f38eb82d5f387b2924e6c7a1746 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Gianfranco Costamagna <costamagnagianfranco@yahoo.it> 3*4882a593SmuzhiyunDate: Thu, 9 Jan 2020 10:07:20 +0100 4*4882a593SmuzhiyunSubject: [PATCH] Update SConstruct with new Python3 syntax: - new raise 5*4882a593Smuzhiyun keyword syntax - has_key deprecated method is now removed - commands 6*4882a593Smuzhiyun deprecated library is replaced by subprocess - print function fixes 7*4882a593Smuzhiyun 8*4882a593SmuzhiyunThis should fix FTBFS against new scons 3.1.2 9*4882a593Smuzhiyunhttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947584 10*4882a593Smuzhiyun--- 11*4882a593Smuzhiyun SConstruct | 45 +++++++++++++++++++++++---------------------- 12*4882a593Smuzhiyun 1 file changed, 23 insertions(+), 22 deletions(-) 13*4882a593Smuzhiyun 14*4882a593Smuzhiyundiff --git a/SConstruct b/SConstruct 15*4882a593Smuzhiyunindex ae3df10b..9d1c8914 100644 16*4882a593Smuzhiyun--- a/SConstruct 17*4882a593Smuzhiyun+++ b/SConstruct 18*4882a593Smuzhiyun@@ -1,18 +1,19 @@ 19*4882a593Smuzhiyun-import os, sys, commands 20*4882a593Smuzhiyun+import os, sys 21*4882a593Smuzhiyun+from subprocess import check_output 22*4882a593Smuzhiyun env = Environment(ENV = os.environ) 23*4882a593Smuzhiyun 24*4882a593Smuzhiyun # figure out a better way to configure this 25*4882a593Smuzhiyun-if os.environ.has_key('CXX'): 26*4882a593Smuzhiyun+if 'CXX' in os.environ: 27*4882a593Smuzhiyun env['CXX'] = os.environ['CXX'] 28*4882a593Smuzhiyun 29*4882a593Smuzhiyun-if os.environ.has_key('DEBUG'): 30*4882a593Smuzhiyun+if 'DEBUG' in os.environ: 31*4882a593Smuzhiyun env['DEBUG'] = os.environ['DEBUG'] 32*4882a593Smuzhiyun 33*4882a593Smuzhiyun-if os.environ.has_key('CXXFLAGS'): 34*4882a593Smuzhiyun+if 'CXXFLAGS' in os.environ: 35*4882a593Smuzhiyun #env['CXXFLAGS'] = os.environ['CXXFLAGS'] 36*4882a593Smuzhiyun env.Append(CXXFLAGS = os.environ['CXXFLAGS']) 37*4882a593Smuzhiyun 38*4882a593Smuzhiyun-if os.environ.has_key('LINKFLAGS'): 39*4882a593Smuzhiyun+if 'LINKFLAGS' in os.environ: 40*4882a593Smuzhiyun #env['LDFLAGS'] = os.environ['LDFLAGS'] 41*4882a593Smuzhiyun env.Append(LINKFLAGS = os.environ['LINKFLAGS']) 42*4882a593Smuzhiyun 43*4882a593Smuzhiyun@@ -22,24 +23,24 @@ if os.environ.has_key('LINKFLAGS'): 44*4882a593Smuzhiyun ## or set BOOST_INCLUDES and BOOST_LIBS if Boost comes with your OS distro e.g. and 45*4882a593Smuzhiyun ## needs BOOST_INCLUDES=/usr/include/boost and BOOST_LIBS=/usr/lib like Ubuntu. 46*4882a593Smuzhiyun ## 47*4882a593Smuzhiyun-if os.environ.has_key('BOOSTROOT'): 48*4882a593Smuzhiyun+if 'BOOSTROOT' in os.environ: 49*4882a593Smuzhiyun os.environ['BOOST_ROOT'] = os.environ['BOOSTROOT'] 50*4882a593Smuzhiyun 51*4882a593Smuzhiyun-if os.environ.has_key('BOOST_ROOT'): 52*4882a593Smuzhiyun+if 'BOOST_ROOT' in os.environ: 53*4882a593Smuzhiyun env['BOOST_INCLUDES'] = os.environ['BOOST_ROOT'] 54*4882a593Smuzhiyun env['BOOST_LIBS'] = os.path.join(os.environ['BOOST_ROOT'], 'stage', 'lib') 55*4882a593Smuzhiyun-elif os.environ.has_key('BOOST_INCLUDES') and os.environ.has_key('BOOST_LIBS'): 56*4882a593Smuzhiyun+elif 'BOOST_INCLUDES' in os.environ and 'BOOST_LIBS' in os.environ: 57*4882a593Smuzhiyun env['BOOST_INCLUDES'] = os.environ['BOOST_INCLUDES'] 58*4882a593Smuzhiyun env['BOOST_LIBS'] = os.environ['BOOST_LIBS'] 59*4882a593Smuzhiyun else: 60*4882a593Smuzhiyun- raise SCons.Errors.UserError, "Neither BOOST_ROOT, nor BOOST_INCLUDES + BOOST_LIBS was set!" 61*4882a593Smuzhiyun+ raise SCons.Errors.UserError("Neither BOOST_ROOT, nor BOOST_INCLUDES + BOOST_LIBS were set!") 62*4882a593Smuzhiyun 63*4882a593Smuzhiyun ## Custom OpenSSL 64*4882a593Smuzhiyun-if os.environ.has_key('OPENSSL_PATH'): 65*4882a593Smuzhiyun+if 'OPENSSL_PATH' in os.environ: 66*4882a593Smuzhiyun env.Append(CPPPATH = os.path.join(os.environ['OPENSSL_PATH'], 'include')) 67*4882a593Smuzhiyun env.Append(LIBPATH = os.environ['OPENSSL_PATH']) 68*4882a593Smuzhiyun 69*4882a593Smuzhiyun-if os.environ.has_key('WSPP_ENABLE_CPP11'): 70*4882a593Smuzhiyun+if 'WSPP_ENABLE_CPP11' in os.environ: 71*4882a593Smuzhiyun env['WSPP_ENABLE_CPP11'] = True 72*4882a593Smuzhiyun else: 73*4882a593Smuzhiyun env['WSPP_ENABLE_CPP11'] = False 74*4882a593Smuzhiyun@@ -76,7 +77,7 @@ if env['PLATFORM'].startswith('win'): 75*4882a593Smuzhiyun env['CCFLAGS'] = '%s /EHsc /GR /GS- /MD /nologo %s %s' % (warn_flags, arch_flags, opt_flags) 76*4882a593Smuzhiyun env['LINKFLAGS'] = '/INCREMENTAL:NO /MANIFEST /NOLOGO /OPT:REF /OPT:ICF /MACHINE:X86' 77*4882a593Smuzhiyun elif env['PLATFORM'] == 'posix': 78*4882a593Smuzhiyun- if env.has_key('DEBUG'): 79*4882a593Smuzhiyun+ if 'DEBUG' in env: 80*4882a593Smuzhiyun env.Append(CCFLAGS = ['-g', '-O0']) 81*4882a593Smuzhiyun else: 82*4882a593Smuzhiyun env.Append(CPPDEFINES = ['NDEBUG']) 83*4882a593Smuzhiyun@@ -84,9 +85,9 @@ elif env['PLATFORM'] == 'posix': 84*4882a593Smuzhiyun env.Append(CCFLAGS = ['-Wall']) 85*4882a593Smuzhiyun #env['LINKFLAGS'] = '' 86*4882a593Smuzhiyun elif env['PLATFORM'] == 'darwin': 87*4882a593Smuzhiyun- if not os.environ.has_key('CXX'): 88*4882a593Smuzhiyun+ if not 'CXX' in os.environ: 89*4882a593Smuzhiyun env['CXX'] = "clang++" 90*4882a593Smuzhiyun- if env.has_key('DEBUG'): 91*4882a593Smuzhiyun+ if 'DEBUG' in env: 92*4882a593Smuzhiyun env.Append(CCFLAGS = ['-g', '-O0']) 93*4882a593Smuzhiyun else: 94*4882a593Smuzhiyun env.Append(CPPDEFINES = ['NDEBUG']) 95*4882a593Smuzhiyun@@ -157,29 +158,29 @@ env_cpp11 = env.Clone () 96*4882a593Smuzhiyun 97*4882a593Smuzhiyun if env_cpp11['CXX'].startswith('g++'): 98*4882a593Smuzhiyun # TODO: check g++ version 99*4882a593Smuzhiyun- GCC_VERSION = commands.getoutput(env_cpp11['CXX'] + ' -dumpversion') 100*4882a593Smuzhiyun+ GCC_VERSION = check_output([env_cpp11['CXX'], '-dumpversion']) 101*4882a593Smuzhiyun 102*4882a593Smuzhiyun- if GCC_VERSION > "4.4.0": 103*4882a593Smuzhiyun- print "C++11 build environment partially enabled" 104*4882a593Smuzhiyun+ if GCC_VERSION.decode('utf-8') > "4.4.0": 105*4882a593Smuzhiyun+ print("C++11 build environment partially enabled") 106*4882a593Smuzhiyun env_cpp11.Append(WSPP_CPP11_ENABLED = "true",CXXFLAGS = ['-std=c++0x'],TOOLSET = ['g++'],CPPDEFINES = ['_WEBSOCKETPP_CPP11_STL_']) 107*4882a593Smuzhiyun else: 108*4882a593Smuzhiyun- print "C++11 build environment is not supported on this version of G++" 109*4882a593Smuzhiyun+ print("C++11 build environment is not supported on this version of G++") 110*4882a593Smuzhiyun elif env_cpp11['CXX'].startswith('clang++'): 111*4882a593Smuzhiyun- print "C++11 build environment enabled" 112*4882a593Smuzhiyun+ print("C++11 build environment enabled") 113*4882a593Smuzhiyun env.Append(CXXFLANGS = ['-stdlib=libc++'],LINKFLAGS=['-stdlib=libc++']) 114*4882a593Smuzhiyun env_cpp11.Append(WSPP_CPP11_ENABLED = "true",CXXFLAGS = ['-std=c++0x','-stdlib=libc++'],LINKFLAGS = ['-stdlib=libc++'],TOOLSET = ['clang++'],CPPDEFINES = ['_WEBSOCKETPP_CPP11_STL_']) 115*4882a593Smuzhiyun 116*4882a593Smuzhiyun # look for optional second boostroot compiled with clang's libc++ STL library 117*4882a593Smuzhiyun # this prevents warnings/errors when linking code built with two different 118*4882a593Smuzhiyun # incompatible STL libraries. 119*4882a593Smuzhiyun- if os.environ.has_key('BOOST_ROOT_CPP11'): 120*4882a593Smuzhiyun+ if 'BOOST_ROOT_CPP11' in os.environ: 121*4882a593Smuzhiyun env_cpp11['BOOST_INCLUDES'] = os.environ['BOOST_ROOT_CPP11'] 122*4882a593Smuzhiyun env_cpp11['BOOST_LIBS'] = os.path.join(os.environ['BOOST_ROOT_CPP11'], 'stage', 'lib') 123*4882a593Smuzhiyun- elif os.environ.has_key('BOOST_INCLUDES_CPP11') and os.environ.has_key('BOOST_LIBS_CPP11'): 124*4882a593Smuzhiyun+ elif 'BOOST_INCLUDES_CPP11' in os.environ and 'BOOST_LIBS_CPP11' in os.environ: 125*4882a593Smuzhiyun env_cpp11['BOOST_INCLUDES'] = os.environ['BOOST_INCLUDES_CPP11'] 126*4882a593Smuzhiyun env_cpp11['BOOST_LIBS'] = os.environ['BOOST_LIBS_CPP11'] 127*4882a593Smuzhiyun else: 128*4882a593Smuzhiyun- print "C++11 build environment disabled" 129*4882a593Smuzhiyun+ print("C++11 build environment disabled") 130*4882a593Smuzhiyun 131*4882a593Smuzhiyun # if the build system is known to allow the isystem modifier for library include 132*4882a593Smuzhiyun # values then use it for the boost libraries. Otherwise just add them to the 133