1*4882a593SmuzhiyunFrom e4582c11f76b9390a3e172dcf0741dca90a9dc8d Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Khem Raj <raj.khem@gmail.com> 3*4882a593SmuzhiyunDate: Sat, 30 Nov 2019 18:50:34 -0800 4*4882a593SmuzhiyunSubject: [PATCH] Do not use getsubopt 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunPOSIX says that behavior when subopts list is empty is undefined. 7*4882a593Smuzhiyunmusl libs will set value to NULL which leads to crash. 8*4882a593Smuzhiyun 9*4882a593SmuzhiyunSimply avoid getsubopt, since we cannot rely on it. 10*4882a593Smuzhiyun 11*4882a593SmuzhiyunImported from Alpine Linux 12*4882a593Smuzhiyun 13*4882a593SmuzhiyunUpstream-Status: Pending 14*4882a593SmuzhiyunSigned-off-by: Khem Raj <raj.khem@gmail.com> 15*4882a593Smuzhiyun 16*4882a593Smuzhiyun--- 17*4882a593Smuzhiyun utils/v4l2-ctl/v4l2-ctl-common.cpp | 18 ++++++++++-------- 18*4882a593Smuzhiyun 1 file changed, 10 insertions(+), 8 deletions(-) 19*4882a593Smuzhiyun 20*4882a593Smuzhiyundiff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp 21*4882a593Smuzhiyunindex c940171..49c0f39 100644 22*4882a593Smuzhiyun--- a/utils/v4l2-ctl/v4l2-ctl-common.cpp 23*4882a593Smuzhiyun+++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp 24*4882a593Smuzhiyun@@ -956,15 +956,17 @@ static bool parse_subset(char *optarg) 25*4882a593Smuzhiyun 26*4882a593Smuzhiyun static bool parse_next_subopt(char **subs, char **value) 27*4882a593Smuzhiyun { 28*4882a593Smuzhiyun- static char *const subopts[] = { 29*4882a593Smuzhiyun- nullptr 30*4882a593Smuzhiyun- }; 31*4882a593Smuzhiyun- int opt = getsubopt(subs, subopts, value); 32*4882a593Smuzhiyun+ char *p = *subs; 33*4882a593Smuzhiyun+ *value = *subs; 34*4882a593Smuzhiyun 35*4882a593Smuzhiyun- if (opt < 0 || *value) 36*4882a593Smuzhiyun- return false; 37*4882a593Smuzhiyun- fprintf(stderr, "Missing suboption value\n"); 38*4882a593Smuzhiyun- return true; 39*4882a593Smuzhiyun+ while (*p && *p != ',') 40*4882a593Smuzhiyun+ p++; 41*4882a593Smuzhiyun+ 42*4882a593Smuzhiyun+ if (*p) 43*4882a593Smuzhiyun+ *p++ = '\0'; 44*4882a593Smuzhiyun+ 45*4882a593Smuzhiyun+ *subs = p; 46*4882a593Smuzhiyun+ return false; 47*4882a593Smuzhiyun } 48*4882a593Smuzhiyun 49*4882a593Smuzhiyun void common_cmd(const std::string &media_bus_info, int ch, char *optarg) 50