1*4882a593SmuzhiyunFrom aa706d714294b83db696de2beca9a722a512796f Mon Sep 17 00:00:00 2001
2*4882a593SmuzhiyunFrom: Khem Raj <raj.khem@gmail.com>
3*4882a593SmuzhiyunDate: Tue, 19 Apr 2022 14:04:40 -0700
4*4882a593SmuzhiyunSubject: [PATCH] cmake: Disable nonnull-compare warning on gcc
5*4882a593Smuzhiyun
6*4882a593SmuzhiyunGCC finds a legit warning which clang does not on code like this
7*4882a593Smuzhiyun
8*4882a593Smuzhiyunclass Message;
9*4882a593Smuzhiyunvoid SendResponse(Message & aMessage)
10*4882a593Smuzhiyun{
11*4882a593Smuzhiyun    if ((&aMessage) != nullptr) { return; }
12*4882a593Smuzhiyun}
13*4882a593Smuzhiyun
14*4882a593SmuzhiyunPerhaps it should be fixed upstream but for now disable treating this
15*4882a593Smuzhiyunwarning as error when using gcc
16*4882a593Smuzhiyun
17*4882a593SmuzhiyunUpstream-Status: Pending
18*4882a593SmuzhiyunSigned-off-by: Khem Raj <raj.khem@gmail.com>
19*4882a593Smuzhiyun---
20*4882a593Smuzhiyun CMakeLists.txt | 4 ++++
21*4882a593Smuzhiyun 1 file changed, 4 insertions(+)
22*4882a593Smuzhiyun
23*4882a593Smuzhiyundiff --git a/CMakeLists.txt b/CMakeLists.txt
24*4882a593Smuzhiyunindex 59a567e729..3134740ff6 100644
25*4882a593Smuzhiyun--- a/CMakeLists.txt
26*4882a593Smuzhiyun+++ b/CMakeLists.txt
27*4882a593Smuzhiyun@@ -57,6 +57,10 @@ endif()
28*4882a593Smuzhiyun
29*4882a593Smuzhiyun set(CMAKE_CXX_EXTENSIONS OFF)
30*4882a593Smuzhiyun
31*4882a593Smuzhiyun+if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
32*4882a593Smuzhiyun+	add_compile_options(-Wno-error=nonnull-compare)
33*4882a593Smuzhiyun+endif()
34*4882a593Smuzhiyun+
35*4882a593Smuzhiyun if (OTBR_COVERAGE AND CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
36*4882a593Smuzhiyun     message(STATUS "Coverage: ON")
37*4882a593Smuzhiyun     target_compile_options(otbr-config INTERFACE -g -O0 --coverage)
38*4882a593Smuzhiyun--
39*4882a593Smuzhiyun2.36.0
40*4882a593Smuzhiyun
41