xref: /OK3568_Linux_fs/kernel/sound/firewire/dice/dice-transaction.c (revision 4882a59341e53eb6f0b4789bf948001014eff981)
1*4882a593Smuzhiyun // SPDX-License-Identifier: GPL-2.0-only
2*4882a593Smuzhiyun /*
3*4882a593Smuzhiyun  * dice_transaction.c - a part of driver for Dice based devices
4*4882a593Smuzhiyun  *
5*4882a593Smuzhiyun  * Copyright (c) Clemens Ladisch
6*4882a593Smuzhiyun  * Copyright (c) 2014 Takashi Sakamoto
7*4882a593Smuzhiyun  */
8*4882a593Smuzhiyun 
9*4882a593Smuzhiyun #include "dice.h"
10*4882a593Smuzhiyun 
get_subaddr(struct snd_dice * dice,enum snd_dice_addr_type type,u64 offset)11*4882a593Smuzhiyun static u64 get_subaddr(struct snd_dice *dice, enum snd_dice_addr_type type,
12*4882a593Smuzhiyun 		       u64 offset)
13*4882a593Smuzhiyun {
14*4882a593Smuzhiyun 	switch (type) {
15*4882a593Smuzhiyun 	case SND_DICE_ADDR_TYPE_TX:
16*4882a593Smuzhiyun 		offset += dice->tx_offset;
17*4882a593Smuzhiyun 		break;
18*4882a593Smuzhiyun 	case SND_DICE_ADDR_TYPE_RX:
19*4882a593Smuzhiyun 		offset += dice->rx_offset;
20*4882a593Smuzhiyun 		break;
21*4882a593Smuzhiyun 	case SND_DICE_ADDR_TYPE_SYNC:
22*4882a593Smuzhiyun 		offset += dice->sync_offset;
23*4882a593Smuzhiyun 		break;
24*4882a593Smuzhiyun 	case SND_DICE_ADDR_TYPE_RSRV:
25*4882a593Smuzhiyun 		offset += dice->rsrv_offset;
26*4882a593Smuzhiyun 		break;
27*4882a593Smuzhiyun 	case SND_DICE_ADDR_TYPE_GLOBAL:
28*4882a593Smuzhiyun 	default:
29*4882a593Smuzhiyun 		offset += dice->global_offset;
30*4882a593Smuzhiyun 		break;
31*4882a593Smuzhiyun 	}
32*4882a593Smuzhiyun 	offset += DICE_PRIVATE_SPACE;
33*4882a593Smuzhiyun 	return offset;
34*4882a593Smuzhiyun }
35*4882a593Smuzhiyun 
snd_dice_transaction_write(struct snd_dice * dice,enum snd_dice_addr_type type,unsigned int offset,void * buf,unsigned int len)36*4882a593Smuzhiyun int snd_dice_transaction_write(struct snd_dice *dice,
37*4882a593Smuzhiyun 			       enum snd_dice_addr_type type,
38*4882a593Smuzhiyun 			       unsigned int offset, void *buf, unsigned int len)
39*4882a593Smuzhiyun {
40*4882a593Smuzhiyun 	return snd_fw_transaction(dice->unit,
41*4882a593Smuzhiyun 				  (len == 4) ? TCODE_WRITE_QUADLET_REQUEST :
42*4882a593Smuzhiyun 					       TCODE_WRITE_BLOCK_REQUEST,
43*4882a593Smuzhiyun 				  get_subaddr(dice, type, offset), buf, len, 0);
44*4882a593Smuzhiyun }
45*4882a593Smuzhiyun 
snd_dice_transaction_read(struct snd_dice * dice,enum snd_dice_addr_type type,unsigned int offset,void * buf,unsigned int len)46*4882a593Smuzhiyun int snd_dice_transaction_read(struct snd_dice *dice,
47*4882a593Smuzhiyun 			      enum snd_dice_addr_type type, unsigned int offset,
48*4882a593Smuzhiyun 			      void *buf, unsigned int len)
49*4882a593Smuzhiyun {
50*4882a593Smuzhiyun 	return snd_fw_transaction(dice->unit,
51*4882a593Smuzhiyun 				  (len == 4) ? TCODE_READ_QUADLET_REQUEST :
52*4882a593Smuzhiyun 					       TCODE_READ_BLOCK_REQUEST,
53*4882a593Smuzhiyun 				  get_subaddr(dice, type, offset), buf, len, 0);
54*4882a593Smuzhiyun }
55*4882a593Smuzhiyun 
get_clock_info(struct snd_dice * dice,__be32 * info)56*4882a593Smuzhiyun static unsigned int get_clock_info(struct snd_dice *dice, __be32 *info)
57*4882a593Smuzhiyun {
58*4882a593Smuzhiyun 	return snd_dice_transaction_read_global(dice, GLOBAL_CLOCK_SELECT,
59*4882a593Smuzhiyun 						info, 4);
60*4882a593Smuzhiyun }
61*4882a593Smuzhiyun 
snd_dice_transaction_get_clock_source(struct snd_dice * dice,unsigned int * source)62*4882a593Smuzhiyun int snd_dice_transaction_get_clock_source(struct snd_dice *dice,
63*4882a593Smuzhiyun 					  unsigned int *source)
64*4882a593Smuzhiyun {
65*4882a593Smuzhiyun 	__be32 info;
66*4882a593Smuzhiyun 	int err;
67*4882a593Smuzhiyun 
68*4882a593Smuzhiyun 	err = get_clock_info(dice, &info);
69*4882a593Smuzhiyun 	if (err >= 0)
70*4882a593Smuzhiyun 		*source = be32_to_cpu(info) & CLOCK_SOURCE_MASK;
71*4882a593Smuzhiyun 
72*4882a593Smuzhiyun 	return err;
73*4882a593Smuzhiyun }
74*4882a593Smuzhiyun 
snd_dice_transaction_get_rate(struct snd_dice * dice,unsigned int * rate)75*4882a593Smuzhiyun int snd_dice_transaction_get_rate(struct snd_dice *dice, unsigned int *rate)
76*4882a593Smuzhiyun {
77*4882a593Smuzhiyun 	__be32 info;
78*4882a593Smuzhiyun 	unsigned int index;
79*4882a593Smuzhiyun 	int err;
80*4882a593Smuzhiyun 
81*4882a593Smuzhiyun 	err = get_clock_info(dice, &info);
82*4882a593Smuzhiyun 	if (err < 0)
83*4882a593Smuzhiyun 		goto end;
84*4882a593Smuzhiyun 
85*4882a593Smuzhiyun 	index = (be32_to_cpu(info) & CLOCK_RATE_MASK) >> CLOCK_RATE_SHIFT;
86*4882a593Smuzhiyun 	if (index >= SND_DICE_RATES_COUNT) {
87*4882a593Smuzhiyun 		err = -ENOSYS;
88*4882a593Smuzhiyun 		goto end;
89*4882a593Smuzhiyun 	}
90*4882a593Smuzhiyun 
91*4882a593Smuzhiyun 	*rate = snd_dice_rates[index];
92*4882a593Smuzhiyun end:
93*4882a593Smuzhiyun 	return err;
94*4882a593Smuzhiyun }
95*4882a593Smuzhiyun 
snd_dice_transaction_set_enable(struct snd_dice * dice)96*4882a593Smuzhiyun int snd_dice_transaction_set_enable(struct snd_dice *dice)
97*4882a593Smuzhiyun {
98*4882a593Smuzhiyun 	__be32 value;
99*4882a593Smuzhiyun 	int err = 0;
100*4882a593Smuzhiyun 
101*4882a593Smuzhiyun 	if (dice->global_enabled)
102*4882a593Smuzhiyun 		goto end;
103*4882a593Smuzhiyun 
104*4882a593Smuzhiyun 	value = cpu_to_be32(1);
105*4882a593Smuzhiyun 	err = snd_fw_transaction(dice->unit, TCODE_WRITE_QUADLET_REQUEST,
106*4882a593Smuzhiyun 				 get_subaddr(dice, SND_DICE_ADDR_TYPE_GLOBAL,
107*4882a593Smuzhiyun 					     GLOBAL_ENABLE),
108*4882a593Smuzhiyun 				 &value, 4,
109*4882a593Smuzhiyun 				 FW_FIXED_GENERATION | dice->owner_generation);
110*4882a593Smuzhiyun 	if (err < 0)
111*4882a593Smuzhiyun 		goto end;
112*4882a593Smuzhiyun 
113*4882a593Smuzhiyun 	dice->global_enabled = true;
114*4882a593Smuzhiyun end:
115*4882a593Smuzhiyun 	return err;
116*4882a593Smuzhiyun }
117*4882a593Smuzhiyun 
snd_dice_transaction_clear_enable(struct snd_dice * dice)118*4882a593Smuzhiyun void snd_dice_transaction_clear_enable(struct snd_dice *dice)
119*4882a593Smuzhiyun {
120*4882a593Smuzhiyun 	__be32 value;
121*4882a593Smuzhiyun 
122*4882a593Smuzhiyun 	value = 0;
123*4882a593Smuzhiyun 	snd_fw_transaction(dice->unit, TCODE_WRITE_QUADLET_REQUEST,
124*4882a593Smuzhiyun 			   get_subaddr(dice, SND_DICE_ADDR_TYPE_GLOBAL,
125*4882a593Smuzhiyun 				       GLOBAL_ENABLE),
126*4882a593Smuzhiyun 			   &value, 4, FW_QUIET |
127*4882a593Smuzhiyun 			   FW_FIXED_GENERATION | dice->owner_generation);
128*4882a593Smuzhiyun 
129*4882a593Smuzhiyun 	dice->global_enabled = false;
130*4882a593Smuzhiyun }
131*4882a593Smuzhiyun 
dice_notification(struct fw_card * card,struct fw_request * request,int tcode,int destination,int source,int generation,unsigned long long offset,void * data,size_t length,void * callback_data)132*4882a593Smuzhiyun static void dice_notification(struct fw_card *card, struct fw_request *request,
133*4882a593Smuzhiyun 			      int tcode, int destination, int source,
134*4882a593Smuzhiyun 			      int generation, unsigned long long offset,
135*4882a593Smuzhiyun 			      void *data, size_t length, void *callback_data)
136*4882a593Smuzhiyun {
137*4882a593Smuzhiyun 	struct snd_dice *dice = callback_data;
138*4882a593Smuzhiyun 	u32 bits;
139*4882a593Smuzhiyun 	unsigned long flags;
140*4882a593Smuzhiyun 
141*4882a593Smuzhiyun 	if (tcode != TCODE_WRITE_QUADLET_REQUEST) {
142*4882a593Smuzhiyun 		fw_send_response(card, request, RCODE_TYPE_ERROR);
143*4882a593Smuzhiyun 		return;
144*4882a593Smuzhiyun 	}
145*4882a593Smuzhiyun 	if ((offset & 3) != 0) {
146*4882a593Smuzhiyun 		fw_send_response(card, request, RCODE_ADDRESS_ERROR);
147*4882a593Smuzhiyun 		return;
148*4882a593Smuzhiyun 	}
149*4882a593Smuzhiyun 
150*4882a593Smuzhiyun 	bits = be32_to_cpup(data);
151*4882a593Smuzhiyun 
152*4882a593Smuzhiyun 	spin_lock_irqsave(&dice->lock, flags);
153*4882a593Smuzhiyun 	dice->notification_bits |= bits;
154*4882a593Smuzhiyun 	spin_unlock_irqrestore(&dice->lock, flags);
155*4882a593Smuzhiyun 
156*4882a593Smuzhiyun 	fw_send_response(card, request, RCODE_COMPLETE);
157*4882a593Smuzhiyun 
158*4882a593Smuzhiyun 	if (bits & NOTIFY_LOCK_CHG)
159*4882a593Smuzhiyun 		complete(&dice->clock_accepted);
160*4882a593Smuzhiyun 	wake_up(&dice->hwdep_wait);
161*4882a593Smuzhiyun }
162*4882a593Smuzhiyun 
register_notification_address(struct snd_dice * dice,bool retry)163*4882a593Smuzhiyun static int register_notification_address(struct snd_dice *dice, bool retry)
164*4882a593Smuzhiyun {
165*4882a593Smuzhiyun 	struct fw_device *device = fw_parent_device(dice->unit);
166*4882a593Smuzhiyun 	__be64 *buffer;
167*4882a593Smuzhiyun 	unsigned int retries;
168*4882a593Smuzhiyun 	int err;
169*4882a593Smuzhiyun 
170*4882a593Smuzhiyun 	retries = (retry) ? 3 : 0;
171*4882a593Smuzhiyun 
172*4882a593Smuzhiyun 	buffer = kmalloc(2 * 8, GFP_KERNEL);
173*4882a593Smuzhiyun 	if (!buffer)
174*4882a593Smuzhiyun 		return -ENOMEM;
175*4882a593Smuzhiyun 
176*4882a593Smuzhiyun 	for (;;) {
177*4882a593Smuzhiyun 		buffer[0] = cpu_to_be64(OWNER_NO_OWNER);
178*4882a593Smuzhiyun 		buffer[1] = cpu_to_be64(
179*4882a593Smuzhiyun 			((u64)device->card->node_id << OWNER_NODE_SHIFT) |
180*4882a593Smuzhiyun 			dice->notification_handler.offset);
181*4882a593Smuzhiyun 
182*4882a593Smuzhiyun 		dice->owner_generation = device->generation;
183*4882a593Smuzhiyun 		smp_rmb(); /* node_id vs. generation */
184*4882a593Smuzhiyun 		err = snd_fw_transaction(dice->unit, TCODE_LOCK_COMPARE_SWAP,
185*4882a593Smuzhiyun 					 get_subaddr(dice,
186*4882a593Smuzhiyun 						     SND_DICE_ADDR_TYPE_GLOBAL,
187*4882a593Smuzhiyun 						     GLOBAL_OWNER),
188*4882a593Smuzhiyun 					 buffer, 2 * 8,
189*4882a593Smuzhiyun 					 FW_FIXED_GENERATION |
190*4882a593Smuzhiyun 							dice->owner_generation);
191*4882a593Smuzhiyun 		if (err == 0) {
192*4882a593Smuzhiyun 			/* success */
193*4882a593Smuzhiyun 			if (buffer[0] == cpu_to_be64(OWNER_NO_OWNER))
194*4882a593Smuzhiyun 				break;
195*4882a593Smuzhiyun 			/* The address seems to be already registered. */
196*4882a593Smuzhiyun 			if (buffer[0] == buffer[1])
197*4882a593Smuzhiyun 				break;
198*4882a593Smuzhiyun 
199*4882a593Smuzhiyun 			dev_err(&dice->unit->device,
200*4882a593Smuzhiyun 				"device is already in use\n");
201*4882a593Smuzhiyun 			err = -EBUSY;
202*4882a593Smuzhiyun 		}
203*4882a593Smuzhiyun 		if (err != -EAGAIN || retries-- > 0)
204*4882a593Smuzhiyun 			break;
205*4882a593Smuzhiyun 
206*4882a593Smuzhiyun 		msleep(20);
207*4882a593Smuzhiyun 	}
208*4882a593Smuzhiyun 
209*4882a593Smuzhiyun 	kfree(buffer);
210*4882a593Smuzhiyun 
211*4882a593Smuzhiyun 	if (err < 0)
212*4882a593Smuzhiyun 		dice->owner_generation = -1;
213*4882a593Smuzhiyun 
214*4882a593Smuzhiyun 	return err;
215*4882a593Smuzhiyun }
216*4882a593Smuzhiyun 
unregister_notification_address(struct snd_dice * dice)217*4882a593Smuzhiyun static void unregister_notification_address(struct snd_dice *dice)
218*4882a593Smuzhiyun {
219*4882a593Smuzhiyun 	struct fw_device *device = fw_parent_device(dice->unit);
220*4882a593Smuzhiyun 	__be64 *buffer;
221*4882a593Smuzhiyun 
222*4882a593Smuzhiyun 	buffer = kmalloc(2 * 8, GFP_KERNEL);
223*4882a593Smuzhiyun 	if (buffer == NULL)
224*4882a593Smuzhiyun 		return;
225*4882a593Smuzhiyun 
226*4882a593Smuzhiyun 	buffer[0] = cpu_to_be64(
227*4882a593Smuzhiyun 		((u64)device->card->node_id << OWNER_NODE_SHIFT) |
228*4882a593Smuzhiyun 		dice->notification_handler.offset);
229*4882a593Smuzhiyun 	buffer[1] = cpu_to_be64(OWNER_NO_OWNER);
230*4882a593Smuzhiyun 	snd_fw_transaction(dice->unit, TCODE_LOCK_COMPARE_SWAP,
231*4882a593Smuzhiyun 			   get_subaddr(dice, SND_DICE_ADDR_TYPE_GLOBAL,
232*4882a593Smuzhiyun 				       GLOBAL_OWNER),
233*4882a593Smuzhiyun 			   buffer, 2 * 8, FW_QUIET |
234*4882a593Smuzhiyun 			   FW_FIXED_GENERATION | dice->owner_generation);
235*4882a593Smuzhiyun 
236*4882a593Smuzhiyun 	kfree(buffer);
237*4882a593Smuzhiyun 
238*4882a593Smuzhiyun 	dice->owner_generation = -1;
239*4882a593Smuzhiyun }
240*4882a593Smuzhiyun 
snd_dice_transaction_destroy(struct snd_dice * dice)241*4882a593Smuzhiyun void snd_dice_transaction_destroy(struct snd_dice *dice)
242*4882a593Smuzhiyun {
243*4882a593Smuzhiyun 	struct fw_address_handler *handler = &dice->notification_handler;
244*4882a593Smuzhiyun 
245*4882a593Smuzhiyun 	if (handler->callback_data == NULL)
246*4882a593Smuzhiyun 		return;
247*4882a593Smuzhiyun 
248*4882a593Smuzhiyun 	unregister_notification_address(dice);
249*4882a593Smuzhiyun 
250*4882a593Smuzhiyun 	fw_core_remove_address_handler(handler);
251*4882a593Smuzhiyun 	handler->callback_data = NULL;
252*4882a593Smuzhiyun }
253*4882a593Smuzhiyun 
snd_dice_transaction_reinit(struct snd_dice * dice)254*4882a593Smuzhiyun int snd_dice_transaction_reinit(struct snd_dice *dice)
255*4882a593Smuzhiyun {
256*4882a593Smuzhiyun 	struct fw_address_handler *handler = &dice->notification_handler;
257*4882a593Smuzhiyun 
258*4882a593Smuzhiyun 	if (handler->callback_data == NULL)
259*4882a593Smuzhiyun 		return -EINVAL;
260*4882a593Smuzhiyun 
261*4882a593Smuzhiyun 	return register_notification_address(dice, false);
262*4882a593Smuzhiyun }
263*4882a593Smuzhiyun 
get_subaddrs(struct snd_dice * dice)264*4882a593Smuzhiyun static int get_subaddrs(struct snd_dice *dice)
265*4882a593Smuzhiyun {
266*4882a593Smuzhiyun 	static const int min_values[10] = {
267*4882a593Smuzhiyun 		10, 0x60 / 4,
268*4882a593Smuzhiyun 		10, 0x18 / 4,
269*4882a593Smuzhiyun 		10, 0x18 / 4,
270*4882a593Smuzhiyun 		0, 0,
271*4882a593Smuzhiyun 		0, 0,
272*4882a593Smuzhiyun 	};
273*4882a593Smuzhiyun 	__be32 *pointers;
274*4882a593Smuzhiyun 	__be32 version;
275*4882a593Smuzhiyun 	u32 data;
276*4882a593Smuzhiyun 	unsigned int i;
277*4882a593Smuzhiyun 	int err;
278*4882a593Smuzhiyun 
279*4882a593Smuzhiyun 	pointers = kmalloc_array(ARRAY_SIZE(min_values), sizeof(__be32),
280*4882a593Smuzhiyun 				 GFP_KERNEL);
281*4882a593Smuzhiyun 	if (pointers == NULL)
282*4882a593Smuzhiyun 		return -ENOMEM;
283*4882a593Smuzhiyun 
284*4882a593Smuzhiyun 	/*
285*4882a593Smuzhiyun 	 * Check that the sub address spaces exist and are located inside the
286*4882a593Smuzhiyun 	 * private address space.  The minimum values are chosen so that all
287*4882a593Smuzhiyun 	 * minimally required registers are included.
288*4882a593Smuzhiyun 	 */
289*4882a593Smuzhiyun 	err = snd_fw_transaction(dice->unit, TCODE_READ_BLOCK_REQUEST,
290*4882a593Smuzhiyun 				 DICE_PRIVATE_SPACE, pointers,
291*4882a593Smuzhiyun 				 sizeof(__be32) * ARRAY_SIZE(min_values), 0);
292*4882a593Smuzhiyun 	if (err < 0)
293*4882a593Smuzhiyun 		goto end;
294*4882a593Smuzhiyun 
295*4882a593Smuzhiyun 	for (i = 0; i < ARRAY_SIZE(min_values); ++i) {
296*4882a593Smuzhiyun 		data = be32_to_cpu(pointers[i]);
297*4882a593Smuzhiyun 		if (data < min_values[i] || data >= 0x40000) {
298*4882a593Smuzhiyun 			err = -ENODEV;
299*4882a593Smuzhiyun 			goto end;
300*4882a593Smuzhiyun 		}
301*4882a593Smuzhiyun 	}
302*4882a593Smuzhiyun 
303*4882a593Smuzhiyun 	if (be32_to_cpu(pointers[1]) > 0x18) {
304*4882a593Smuzhiyun 		/*
305*4882a593Smuzhiyun 		 * Check that the implemented DICE driver specification major
306*4882a593Smuzhiyun 		 * version number matches.
307*4882a593Smuzhiyun 		 */
308*4882a593Smuzhiyun 		err = snd_fw_transaction(dice->unit, TCODE_READ_QUADLET_REQUEST,
309*4882a593Smuzhiyun 				DICE_PRIVATE_SPACE +
310*4882a593Smuzhiyun 				be32_to_cpu(pointers[0]) * 4 + GLOBAL_VERSION,
311*4882a593Smuzhiyun 				&version, sizeof(version), 0);
312*4882a593Smuzhiyun 		if (err < 0)
313*4882a593Smuzhiyun 			goto end;
314*4882a593Smuzhiyun 
315*4882a593Smuzhiyun 		if ((version & cpu_to_be32(0xff000000)) !=
316*4882a593Smuzhiyun 						cpu_to_be32(0x01000000)) {
317*4882a593Smuzhiyun 			dev_err(&dice->unit->device,
318*4882a593Smuzhiyun 				"unknown DICE version: 0x%08x\n",
319*4882a593Smuzhiyun 				be32_to_cpu(version));
320*4882a593Smuzhiyun 			err = -ENODEV;
321*4882a593Smuzhiyun 			goto end;
322*4882a593Smuzhiyun 		}
323*4882a593Smuzhiyun 
324*4882a593Smuzhiyun 		/* Set up later. */
325*4882a593Smuzhiyun 		dice->clock_caps = 1;
326*4882a593Smuzhiyun 	}
327*4882a593Smuzhiyun 
328*4882a593Smuzhiyun 	dice->global_offset = be32_to_cpu(pointers[0]) * 4;
329*4882a593Smuzhiyun 	dice->tx_offset = be32_to_cpu(pointers[2]) * 4;
330*4882a593Smuzhiyun 	dice->rx_offset = be32_to_cpu(pointers[4]) * 4;
331*4882a593Smuzhiyun 
332*4882a593Smuzhiyun 	/* Old firmware doesn't support these fields. */
333*4882a593Smuzhiyun 	if (pointers[7])
334*4882a593Smuzhiyun 		dice->sync_offset = be32_to_cpu(pointers[6]) * 4;
335*4882a593Smuzhiyun 	if (pointers[9])
336*4882a593Smuzhiyun 		dice->rsrv_offset = be32_to_cpu(pointers[8]) * 4;
337*4882a593Smuzhiyun end:
338*4882a593Smuzhiyun 	kfree(pointers);
339*4882a593Smuzhiyun 	return err;
340*4882a593Smuzhiyun }
341*4882a593Smuzhiyun 
snd_dice_transaction_init(struct snd_dice * dice)342*4882a593Smuzhiyun int snd_dice_transaction_init(struct snd_dice *dice)
343*4882a593Smuzhiyun {
344*4882a593Smuzhiyun 	struct fw_address_handler *handler = &dice->notification_handler;
345*4882a593Smuzhiyun 	int err;
346*4882a593Smuzhiyun 
347*4882a593Smuzhiyun 	err = get_subaddrs(dice);
348*4882a593Smuzhiyun 	if (err < 0)
349*4882a593Smuzhiyun 		return err;
350*4882a593Smuzhiyun 
351*4882a593Smuzhiyun 	/* Allocation callback in address space over host controller */
352*4882a593Smuzhiyun 	handler->length = 4;
353*4882a593Smuzhiyun 	handler->address_callback = dice_notification;
354*4882a593Smuzhiyun 	handler->callback_data = dice;
355*4882a593Smuzhiyun 	err = fw_core_add_address_handler(handler, &fw_high_memory_region);
356*4882a593Smuzhiyun 	if (err < 0) {
357*4882a593Smuzhiyun 		handler->callback_data = NULL;
358*4882a593Smuzhiyun 		return err;
359*4882a593Smuzhiyun 	}
360*4882a593Smuzhiyun 
361*4882a593Smuzhiyun 	/* Register the address space */
362*4882a593Smuzhiyun 	err = register_notification_address(dice, true);
363*4882a593Smuzhiyun 	if (err < 0) {
364*4882a593Smuzhiyun 		fw_core_remove_address_handler(handler);
365*4882a593Smuzhiyun 		handler->callback_data = NULL;
366*4882a593Smuzhiyun 	}
367*4882a593Smuzhiyun 
368*4882a593Smuzhiyun 	return err;
369*4882a593Smuzhiyun }
370