1*4882a593Smuzhiyun// SPDX-License-Identifier: GPL-2.0-only 2*4882a593Smuzhiyun/// Use WARN(1,...) rather than printk followed by WARN_ON(1) 3*4882a593Smuzhiyun/// 4*4882a593Smuzhiyun// Confidence: High 5*4882a593Smuzhiyun// Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. 6*4882a593Smuzhiyun// Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. 7*4882a593Smuzhiyun// URL: http://coccinelle.lip6.fr/ 8*4882a593Smuzhiyun// Comments: 9*4882a593Smuzhiyun// Options: --no-includes --include-headers 10*4882a593Smuzhiyun 11*4882a593Smuzhiyunvirtual patch 12*4882a593Smuzhiyunvirtual context 13*4882a593Smuzhiyunvirtual org 14*4882a593Smuzhiyunvirtual report 15*4882a593Smuzhiyun 16*4882a593Smuzhiyun@bad1@ 17*4882a593Smuzhiyunposition p; 18*4882a593Smuzhiyun@@ 19*4882a593Smuzhiyun 20*4882a593Smuzhiyunprintk(...); 21*4882a593Smuzhiyunprintk@p(...); 22*4882a593SmuzhiyunWARN_ON(1); 23*4882a593Smuzhiyun 24*4882a593Smuzhiyun@r1 depends on context || report || org@ 25*4882a593Smuzhiyunposition p != bad1.p; 26*4882a593Smuzhiyun@@ 27*4882a593Smuzhiyun 28*4882a593Smuzhiyun printk@p(...); 29*4882a593Smuzhiyun*WARN_ON(1); 30*4882a593Smuzhiyun 31*4882a593Smuzhiyun@script:python depends on org@ 32*4882a593Smuzhiyunp << r1.p; 33*4882a593Smuzhiyun@@ 34*4882a593Smuzhiyun 35*4882a593Smuzhiyuncocci.print_main("printk + WARN_ON can be just WARN",p) 36*4882a593Smuzhiyun 37*4882a593Smuzhiyun@script:python depends on report@ 38*4882a593Smuzhiyunp << r1.p; 39*4882a593Smuzhiyun@@ 40*4882a593Smuzhiyun 41*4882a593Smuzhiyunmsg = "SUGGESTION: printk + WARN_ON can be just WARN" 42*4882a593Smuzhiyuncoccilib.report.print_report(p[0],msg) 43*4882a593Smuzhiyun 44*4882a593Smuzhiyun@ok1 depends on patch@ 45*4882a593Smuzhiyunexpression list es; 46*4882a593Smuzhiyunposition p != bad1.p; 47*4882a593Smuzhiyun@@ 48*4882a593Smuzhiyun 49*4882a593Smuzhiyun-printk@p( 50*4882a593Smuzhiyun+WARN(1, 51*4882a593Smuzhiyun es); 52*4882a593Smuzhiyun-WARN_ON(1); 53*4882a593Smuzhiyun 54*4882a593Smuzhiyun@depends on patch@ 55*4882a593Smuzhiyunexpression list ok1.es; 56*4882a593Smuzhiyun@@ 57*4882a593Smuzhiyun 58*4882a593Smuzhiyunif (...) 59*4882a593Smuzhiyun- { 60*4882a593Smuzhiyun WARN(1,es); 61*4882a593Smuzhiyun- } 62*4882a593Smuzhiyun 63*4882a593Smuzhiyun// -------------------------------------------------------------------- 64*4882a593Smuzhiyun 65*4882a593Smuzhiyun@bad2@ 66*4882a593Smuzhiyunposition p; 67*4882a593Smuzhiyun@@ 68*4882a593Smuzhiyun 69*4882a593Smuzhiyunprintk(...); 70*4882a593Smuzhiyunprintk@p(...); 71*4882a593SmuzhiyunWARN_ON_ONCE(1); 72*4882a593Smuzhiyun 73*4882a593Smuzhiyun@r2 depends on context || report || org@ 74*4882a593Smuzhiyunposition p != bad1.p; 75*4882a593Smuzhiyun@@ 76*4882a593Smuzhiyun 77*4882a593Smuzhiyun printk@p(...); 78*4882a593Smuzhiyun*WARN_ON_ONCE(1); 79*4882a593Smuzhiyun 80*4882a593Smuzhiyun@script:python depends on org@ 81*4882a593Smuzhiyunp << r2.p; 82*4882a593Smuzhiyun@@ 83*4882a593Smuzhiyun 84*4882a593Smuzhiyuncocci.print_main("printk + WARN_ON_ONCE can be just WARN_ONCE",p) 85*4882a593Smuzhiyun 86*4882a593Smuzhiyun@script:python depends on report@ 87*4882a593Smuzhiyunp << r2.p; 88*4882a593Smuzhiyun@@ 89*4882a593Smuzhiyun 90*4882a593Smuzhiyunmsg = "SUGGESTION: printk + WARN_ON_ONCE can be just WARN_ONCE" 91*4882a593Smuzhiyuncoccilib.report.print_report(p[0],msg) 92*4882a593Smuzhiyun 93*4882a593Smuzhiyun@ok2 depends on patch@ 94*4882a593Smuzhiyunexpression list es; 95*4882a593Smuzhiyunposition p != bad2.p; 96*4882a593Smuzhiyun@@ 97*4882a593Smuzhiyun 98*4882a593Smuzhiyun-printk@p( 99*4882a593Smuzhiyun+WARN_ONCE(1, 100*4882a593Smuzhiyun es); 101*4882a593Smuzhiyun-WARN_ON_ONCE(1); 102*4882a593Smuzhiyun 103*4882a593Smuzhiyun@depends on patch@ 104*4882a593Smuzhiyunexpression list ok2.es; 105*4882a593Smuzhiyun@@ 106*4882a593Smuzhiyun 107*4882a593Smuzhiyunif (...) 108*4882a593Smuzhiyun- { 109*4882a593Smuzhiyun WARN_ONCE(1,es); 110*4882a593Smuzhiyun- } 111