1*4882a593Smuzhiyun// SPDX-License-Identifier: GPL-2.0 2*4882a593Smuzhiyun/// Remove an open coded simple_open() function 3*4882a593Smuzhiyun/// and replace file operations references to the function 4*4882a593Smuzhiyun/// with simple_open() instead. 5*4882a593Smuzhiyun/// 6*4882a593Smuzhiyun// Confidence: High 7*4882a593Smuzhiyun// Comments: 8*4882a593Smuzhiyun// Options: --no-includes --include-headers 9*4882a593Smuzhiyun 10*4882a593Smuzhiyunvirtual patch 11*4882a593Smuzhiyunvirtual report 12*4882a593Smuzhiyun 13*4882a593Smuzhiyun@ open depends on patch @ 14*4882a593Smuzhiyunidentifier open_f != simple_open; 15*4882a593Smuzhiyunidentifier i, f; 16*4882a593Smuzhiyun@@ 17*4882a593Smuzhiyun-int open_f(struct inode *i, struct file *f) 18*4882a593Smuzhiyun-{ 19*4882a593Smuzhiyun( 20*4882a593Smuzhiyun-if (i->i_private) 21*4882a593Smuzhiyun-f->private_data = i->i_private; 22*4882a593Smuzhiyun| 23*4882a593Smuzhiyun-f->private_data = i->i_private; 24*4882a593Smuzhiyun) 25*4882a593Smuzhiyun-return 0; 26*4882a593Smuzhiyun-} 27*4882a593Smuzhiyun 28*4882a593Smuzhiyun@ has_open depends on open @ 29*4882a593Smuzhiyunidentifier fops; 30*4882a593Smuzhiyunidentifier open.open_f; 31*4882a593Smuzhiyun@@ 32*4882a593Smuzhiyunstruct file_operations fops = { 33*4882a593Smuzhiyun..., 34*4882a593Smuzhiyun-.open = open_f, 35*4882a593Smuzhiyun+.open = simple_open, 36*4882a593Smuzhiyun... 37*4882a593Smuzhiyun}; 38*4882a593Smuzhiyun 39*4882a593Smuzhiyun@ openr depends on report @ 40*4882a593Smuzhiyunidentifier open_f != simple_open; 41*4882a593Smuzhiyunidentifier i, f; 42*4882a593Smuzhiyunposition p; 43*4882a593Smuzhiyun@@ 44*4882a593Smuzhiyunint open_f@p(struct inode *i, struct file *f) 45*4882a593Smuzhiyun{ 46*4882a593Smuzhiyun( 47*4882a593Smuzhiyunif (i->i_private) 48*4882a593Smuzhiyunf->private_data = i->i_private; 49*4882a593Smuzhiyun| 50*4882a593Smuzhiyunf->private_data = i->i_private; 51*4882a593Smuzhiyun) 52*4882a593Smuzhiyunreturn 0; 53*4882a593Smuzhiyun} 54*4882a593Smuzhiyun 55*4882a593Smuzhiyun@ has_openr depends on openr @ 56*4882a593Smuzhiyunidentifier fops; 57*4882a593Smuzhiyunidentifier openr.open_f; 58*4882a593Smuzhiyunposition p; 59*4882a593Smuzhiyun@@ 60*4882a593Smuzhiyunstruct file_operations fops = { 61*4882a593Smuzhiyun..., 62*4882a593Smuzhiyun.open = open_f@p, 63*4882a593Smuzhiyun... 64*4882a593Smuzhiyun}; 65*4882a593Smuzhiyun 66*4882a593Smuzhiyun@script:python@ 67*4882a593Smuzhiyunpf << openr.p; 68*4882a593Smuzhiyunps << has_openr.p; 69*4882a593Smuzhiyun@@ 70*4882a593Smuzhiyun 71*4882a593Smuzhiyuncoccilib.report.print_report(pf[0],"WARNING opportunity for simple_open, see also structure on line %s"%(ps[0].line)) 72