1*4882a593Smuzhiyun // SPDX-License-Identifier: GPL-2.0-or-later
2*4882a593Smuzhiyun /* Filesystem parameter parser.
3*4882a593Smuzhiyun *
4*4882a593Smuzhiyun * Copyright (C) 2018 Red Hat, Inc. All Rights Reserved.
5*4882a593Smuzhiyun * Written by David Howells (dhowells@redhat.com)
6*4882a593Smuzhiyun */
7*4882a593Smuzhiyun
8*4882a593Smuzhiyun #include <linux/export.h>
9*4882a593Smuzhiyun #include <linux/fs_context.h>
10*4882a593Smuzhiyun #include <linux/fs_parser.h>
11*4882a593Smuzhiyun #include <linux/slab.h>
12*4882a593Smuzhiyun #include <linux/security.h>
13*4882a593Smuzhiyun #include <linux/namei.h>
14*4882a593Smuzhiyun #include "internal.h"
15*4882a593Smuzhiyun
16*4882a593Smuzhiyun static const struct constant_table bool_names[] = {
17*4882a593Smuzhiyun { "0", false },
18*4882a593Smuzhiyun { "1", true },
19*4882a593Smuzhiyun { "false", false },
20*4882a593Smuzhiyun { "no", false },
21*4882a593Smuzhiyun { "true", true },
22*4882a593Smuzhiyun { "yes", true },
23*4882a593Smuzhiyun { },
24*4882a593Smuzhiyun };
25*4882a593Smuzhiyun
26*4882a593Smuzhiyun static const struct constant_table *
__lookup_constant(const struct constant_table * tbl,const char * name)27*4882a593Smuzhiyun __lookup_constant(const struct constant_table *tbl, const char *name)
28*4882a593Smuzhiyun {
29*4882a593Smuzhiyun for ( ; tbl->name; tbl++)
30*4882a593Smuzhiyun if (strcmp(name, tbl->name) == 0)
31*4882a593Smuzhiyun return tbl;
32*4882a593Smuzhiyun return NULL;
33*4882a593Smuzhiyun }
34*4882a593Smuzhiyun
35*4882a593Smuzhiyun /**
36*4882a593Smuzhiyun * lookup_constant - Look up a constant by name in an ordered table
37*4882a593Smuzhiyun * @tbl: The table of constants to search.
38*4882a593Smuzhiyun * @name: The name to look up.
39*4882a593Smuzhiyun * @not_found: The value to return if the name is not found.
40*4882a593Smuzhiyun */
lookup_constant(const struct constant_table * tbl,const char * name,int not_found)41*4882a593Smuzhiyun int lookup_constant(const struct constant_table *tbl, const char *name, int not_found)
42*4882a593Smuzhiyun {
43*4882a593Smuzhiyun const struct constant_table *p = __lookup_constant(tbl, name);
44*4882a593Smuzhiyun
45*4882a593Smuzhiyun return p ? p->value : not_found;
46*4882a593Smuzhiyun }
47*4882a593Smuzhiyun EXPORT_SYMBOL(lookup_constant);
48*4882a593Smuzhiyun
is_flag(const struct fs_parameter_spec * p)49*4882a593Smuzhiyun static inline bool is_flag(const struct fs_parameter_spec *p)
50*4882a593Smuzhiyun {
51*4882a593Smuzhiyun return p->type == NULL;
52*4882a593Smuzhiyun }
53*4882a593Smuzhiyun
fs_lookup_key(const struct fs_parameter_spec * desc,struct fs_parameter * param,bool * negated)54*4882a593Smuzhiyun static const struct fs_parameter_spec *fs_lookup_key(
55*4882a593Smuzhiyun const struct fs_parameter_spec *desc,
56*4882a593Smuzhiyun struct fs_parameter *param, bool *negated)
57*4882a593Smuzhiyun {
58*4882a593Smuzhiyun const struct fs_parameter_spec *p, *other = NULL;
59*4882a593Smuzhiyun const char *name = param->key;
60*4882a593Smuzhiyun bool want_flag = param->type == fs_value_is_flag;
61*4882a593Smuzhiyun
62*4882a593Smuzhiyun *negated = false;
63*4882a593Smuzhiyun for (p = desc; p->name; p++) {
64*4882a593Smuzhiyun if (strcmp(p->name, name) != 0)
65*4882a593Smuzhiyun continue;
66*4882a593Smuzhiyun if (likely(is_flag(p) == want_flag))
67*4882a593Smuzhiyun return p;
68*4882a593Smuzhiyun other = p;
69*4882a593Smuzhiyun }
70*4882a593Smuzhiyun if (want_flag) {
71*4882a593Smuzhiyun if (name[0] == 'n' && name[1] == 'o' && name[2]) {
72*4882a593Smuzhiyun for (p = desc; p->name; p++) {
73*4882a593Smuzhiyun if (strcmp(p->name, name + 2) != 0)
74*4882a593Smuzhiyun continue;
75*4882a593Smuzhiyun if (!(p->flags & fs_param_neg_with_no))
76*4882a593Smuzhiyun continue;
77*4882a593Smuzhiyun *negated = true;
78*4882a593Smuzhiyun return p;
79*4882a593Smuzhiyun }
80*4882a593Smuzhiyun }
81*4882a593Smuzhiyun }
82*4882a593Smuzhiyun return other;
83*4882a593Smuzhiyun }
84*4882a593Smuzhiyun
85*4882a593Smuzhiyun /*
86*4882a593Smuzhiyun * fs_parse - Parse a filesystem configuration parameter
87*4882a593Smuzhiyun * @fc: The filesystem context to log errors through.
88*4882a593Smuzhiyun * @desc: The parameter description to use.
89*4882a593Smuzhiyun * @param: The parameter.
90*4882a593Smuzhiyun * @result: Where to place the result of the parse
91*4882a593Smuzhiyun *
92*4882a593Smuzhiyun * Parse a filesystem configuration parameter and attempt a conversion for a
93*4882a593Smuzhiyun * simple parameter for which this is requested. If successful, the determined
94*4882a593Smuzhiyun * parameter ID is placed into @result->key, the desired type is indicated in
95*4882a593Smuzhiyun * @result->t and any converted value is placed into an appropriate member of
96*4882a593Smuzhiyun * the union in @result.
97*4882a593Smuzhiyun *
98*4882a593Smuzhiyun * The function returns the parameter number if the parameter was matched,
99*4882a593Smuzhiyun * -ENOPARAM if it wasn't matched and @desc->ignore_unknown indicated that
100*4882a593Smuzhiyun * unknown parameters are okay and -EINVAL if there was a conversion issue or
101*4882a593Smuzhiyun * the parameter wasn't recognised and unknowns aren't okay.
102*4882a593Smuzhiyun */
__fs_parse(struct p_log * log,const struct fs_parameter_spec * desc,struct fs_parameter * param,struct fs_parse_result * result)103*4882a593Smuzhiyun int __fs_parse(struct p_log *log,
104*4882a593Smuzhiyun const struct fs_parameter_spec *desc,
105*4882a593Smuzhiyun struct fs_parameter *param,
106*4882a593Smuzhiyun struct fs_parse_result *result)
107*4882a593Smuzhiyun {
108*4882a593Smuzhiyun const struct fs_parameter_spec *p;
109*4882a593Smuzhiyun
110*4882a593Smuzhiyun result->uint_64 = 0;
111*4882a593Smuzhiyun
112*4882a593Smuzhiyun p = fs_lookup_key(desc, param, &result->negated);
113*4882a593Smuzhiyun if (!p)
114*4882a593Smuzhiyun return -ENOPARAM;
115*4882a593Smuzhiyun
116*4882a593Smuzhiyun if (p->flags & fs_param_deprecated)
117*4882a593Smuzhiyun warn_plog(log, "Deprecated parameter '%s'", param->key);
118*4882a593Smuzhiyun
119*4882a593Smuzhiyun /* Try to turn the type we were given into the type desired by the
120*4882a593Smuzhiyun * parameter and give an error if we can't.
121*4882a593Smuzhiyun */
122*4882a593Smuzhiyun if (is_flag(p)) {
123*4882a593Smuzhiyun if (param->type != fs_value_is_flag)
124*4882a593Smuzhiyun return inval_plog(log, "Unexpected value for '%s'",
125*4882a593Smuzhiyun param->key);
126*4882a593Smuzhiyun result->boolean = !result->negated;
127*4882a593Smuzhiyun } else {
128*4882a593Smuzhiyun int ret = p->type(log, p, param, result);
129*4882a593Smuzhiyun if (ret)
130*4882a593Smuzhiyun return ret;
131*4882a593Smuzhiyun }
132*4882a593Smuzhiyun return p->opt;
133*4882a593Smuzhiyun }
134*4882a593Smuzhiyun EXPORT_SYMBOL(__fs_parse);
135*4882a593Smuzhiyun
136*4882a593Smuzhiyun /**
137*4882a593Smuzhiyun * fs_lookup_param - Look up a path referred to by a parameter
138*4882a593Smuzhiyun * @fc: The filesystem context to log errors through.
139*4882a593Smuzhiyun * @param: The parameter.
140*4882a593Smuzhiyun * @want_bdev: T if want a blockdev
141*4882a593Smuzhiyun * @_path: The result of the lookup
142*4882a593Smuzhiyun */
fs_lookup_param(struct fs_context * fc,struct fs_parameter * param,bool want_bdev,struct path * _path)143*4882a593Smuzhiyun int fs_lookup_param(struct fs_context *fc,
144*4882a593Smuzhiyun struct fs_parameter *param,
145*4882a593Smuzhiyun bool want_bdev,
146*4882a593Smuzhiyun struct path *_path)
147*4882a593Smuzhiyun {
148*4882a593Smuzhiyun struct filename *f;
149*4882a593Smuzhiyun unsigned int flags = 0;
150*4882a593Smuzhiyun bool put_f;
151*4882a593Smuzhiyun int ret;
152*4882a593Smuzhiyun
153*4882a593Smuzhiyun switch (param->type) {
154*4882a593Smuzhiyun case fs_value_is_string:
155*4882a593Smuzhiyun f = getname_kernel(param->string);
156*4882a593Smuzhiyun if (IS_ERR(f))
157*4882a593Smuzhiyun return PTR_ERR(f);
158*4882a593Smuzhiyun put_f = true;
159*4882a593Smuzhiyun break;
160*4882a593Smuzhiyun case fs_value_is_filename:
161*4882a593Smuzhiyun f = param->name;
162*4882a593Smuzhiyun put_f = false;
163*4882a593Smuzhiyun break;
164*4882a593Smuzhiyun default:
165*4882a593Smuzhiyun return invalf(fc, "%s: not usable as path", param->key);
166*4882a593Smuzhiyun }
167*4882a593Smuzhiyun
168*4882a593Smuzhiyun f->refcnt++; /* filename_lookup() drops our ref. */
169*4882a593Smuzhiyun ret = filename_lookup(param->dirfd, f, flags, _path, NULL);
170*4882a593Smuzhiyun if (ret < 0) {
171*4882a593Smuzhiyun errorf(fc, "%s: Lookup failure for '%s'", param->key, f->name);
172*4882a593Smuzhiyun goto out;
173*4882a593Smuzhiyun }
174*4882a593Smuzhiyun
175*4882a593Smuzhiyun if (want_bdev &&
176*4882a593Smuzhiyun !S_ISBLK(d_backing_inode(_path->dentry)->i_mode)) {
177*4882a593Smuzhiyun path_put(_path);
178*4882a593Smuzhiyun _path->dentry = NULL;
179*4882a593Smuzhiyun _path->mnt = NULL;
180*4882a593Smuzhiyun errorf(fc, "%s: Non-blockdev passed as '%s'",
181*4882a593Smuzhiyun param->key, f->name);
182*4882a593Smuzhiyun ret = -ENOTBLK;
183*4882a593Smuzhiyun }
184*4882a593Smuzhiyun
185*4882a593Smuzhiyun out:
186*4882a593Smuzhiyun if (put_f)
187*4882a593Smuzhiyun putname(f);
188*4882a593Smuzhiyun return ret;
189*4882a593Smuzhiyun }
190*4882a593Smuzhiyun EXPORT_SYMBOL(fs_lookup_param);
191*4882a593Smuzhiyun
fs_param_bad_value(struct p_log * log,struct fs_parameter * param)192*4882a593Smuzhiyun static int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
193*4882a593Smuzhiyun {
194*4882a593Smuzhiyun return inval_plog(log, "Bad value for '%s'", param->key);
195*4882a593Smuzhiyun }
196*4882a593Smuzhiyun
fs_param_is_bool(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)197*4882a593Smuzhiyun int fs_param_is_bool(struct p_log *log, const struct fs_parameter_spec *p,
198*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
199*4882a593Smuzhiyun {
200*4882a593Smuzhiyun int b;
201*4882a593Smuzhiyun if (param->type != fs_value_is_string)
202*4882a593Smuzhiyun return fs_param_bad_value(log, param);
203*4882a593Smuzhiyun b = lookup_constant(bool_names, param->string, -1);
204*4882a593Smuzhiyun if (b == -1)
205*4882a593Smuzhiyun return fs_param_bad_value(log, param);
206*4882a593Smuzhiyun result->boolean = b;
207*4882a593Smuzhiyun return 0;
208*4882a593Smuzhiyun }
209*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_bool);
210*4882a593Smuzhiyun
fs_param_is_u32(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)211*4882a593Smuzhiyun int fs_param_is_u32(struct p_log *log, const struct fs_parameter_spec *p,
212*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
213*4882a593Smuzhiyun {
214*4882a593Smuzhiyun int base = (unsigned long)p->data;
215*4882a593Smuzhiyun if (param->type != fs_value_is_string ||
216*4882a593Smuzhiyun kstrtouint(param->string, base, &result->uint_32) < 0)
217*4882a593Smuzhiyun return fs_param_bad_value(log, param);
218*4882a593Smuzhiyun return 0;
219*4882a593Smuzhiyun }
220*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_u32);
221*4882a593Smuzhiyun
fs_param_is_s32(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)222*4882a593Smuzhiyun int fs_param_is_s32(struct p_log *log, const struct fs_parameter_spec *p,
223*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
224*4882a593Smuzhiyun {
225*4882a593Smuzhiyun if (param->type != fs_value_is_string ||
226*4882a593Smuzhiyun kstrtoint(param->string, 0, &result->int_32) < 0)
227*4882a593Smuzhiyun return fs_param_bad_value(log, param);
228*4882a593Smuzhiyun return 0;
229*4882a593Smuzhiyun }
230*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_s32);
231*4882a593Smuzhiyun
fs_param_is_u64(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)232*4882a593Smuzhiyun int fs_param_is_u64(struct p_log *log, const struct fs_parameter_spec *p,
233*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
234*4882a593Smuzhiyun {
235*4882a593Smuzhiyun if (param->type != fs_value_is_string ||
236*4882a593Smuzhiyun kstrtoull(param->string, 0, &result->uint_64) < 0)
237*4882a593Smuzhiyun return fs_param_bad_value(log, param);
238*4882a593Smuzhiyun return 0;
239*4882a593Smuzhiyun }
240*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_u64);
241*4882a593Smuzhiyun
fs_param_is_enum(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)242*4882a593Smuzhiyun int fs_param_is_enum(struct p_log *log, const struct fs_parameter_spec *p,
243*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
244*4882a593Smuzhiyun {
245*4882a593Smuzhiyun const struct constant_table *c;
246*4882a593Smuzhiyun if (param->type != fs_value_is_string)
247*4882a593Smuzhiyun return fs_param_bad_value(log, param);
248*4882a593Smuzhiyun c = __lookup_constant(p->data, param->string);
249*4882a593Smuzhiyun if (!c)
250*4882a593Smuzhiyun return fs_param_bad_value(log, param);
251*4882a593Smuzhiyun result->uint_32 = c->value;
252*4882a593Smuzhiyun return 0;
253*4882a593Smuzhiyun }
254*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_enum);
255*4882a593Smuzhiyun
fs_param_is_string(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)256*4882a593Smuzhiyun int fs_param_is_string(struct p_log *log, const struct fs_parameter_spec *p,
257*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
258*4882a593Smuzhiyun {
259*4882a593Smuzhiyun if (param->type != fs_value_is_string || !*param->string)
260*4882a593Smuzhiyun return fs_param_bad_value(log, param);
261*4882a593Smuzhiyun return 0;
262*4882a593Smuzhiyun }
263*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_string);
264*4882a593Smuzhiyun
fs_param_is_blob(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)265*4882a593Smuzhiyun int fs_param_is_blob(struct p_log *log, const struct fs_parameter_spec *p,
266*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
267*4882a593Smuzhiyun {
268*4882a593Smuzhiyun if (param->type != fs_value_is_blob)
269*4882a593Smuzhiyun return fs_param_bad_value(log, param);
270*4882a593Smuzhiyun return 0;
271*4882a593Smuzhiyun }
272*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_blob);
273*4882a593Smuzhiyun
fs_param_is_fd(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)274*4882a593Smuzhiyun int fs_param_is_fd(struct p_log *log, const struct fs_parameter_spec *p,
275*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
276*4882a593Smuzhiyun {
277*4882a593Smuzhiyun switch (param->type) {
278*4882a593Smuzhiyun case fs_value_is_string:
279*4882a593Smuzhiyun if (kstrtouint(param->string, 0, &result->uint_32) < 0)
280*4882a593Smuzhiyun break;
281*4882a593Smuzhiyun if (result->uint_32 <= INT_MAX)
282*4882a593Smuzhiyun return 0;
283*4882a593Smuzhiyun break;
284*4882a593Smuzhiyun case fs_value_is_file:
285*4882a593Smuzhiyun result->uint_32 = param->dirfd;
286*4882a593Smuzhiyun if (result->uint_32 <= INT_MAX)
287*4882a593Smuzhiyun return 0;
288*4882a593Smuzhiyun break;
289*4882a593Smuzhiyun default:
290*4882a593Smuzhiyun break;
291*4882a593Smuzhiyun }
292*4882a593Smuzhiyun return fs_param_bad_value(log, param);
293*4882a593Smuzhiyun }
294*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_fd);
295*4882a593Smuzhiyun
fs_param_is_blockdev(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)296*4882a593Smuzhiyun int fs_param_is_blockdev(struct p_log *log, const struct fs_parameter_spec *p,
297*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
298*4882a593Smuzhiyun {
299*4882a593Smuzhiyun return 0;
300*4882a593Smuzhiyun }
301*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_blockdev);
302*4882a593Smuzhiyun
fs_param_is_path(struct p_log * log,const struct fs_parameter_spec * p,struct fs_parameter * param,struct fs_parse_result * result)303*4882a593Smuzhiyun int fs_param_is_path(struct p_log *log, const struct fs_parameter_spec *p,
304*4882a593Smuzhiyun struct fs_parameter *param, struct fs_parse_result *result)
305*4882a593Smuzhiyun {
306*4882a593Smuzhiyun return 0;
307*4882a593Smuzhiyun }
308*4882a593Smuzhiyun EXPORT_SYMBOL(fs_param_is_path);
309*4882a593Smuzhiyun
310*4882a593Smuzhiyun #ifdef CONFIG_VALIDATE_FS_PARSER
311*4882a593Smuzhiyun /**
312*4882a593Smuzhiyun * validate_constant_table - Validate a constant table
313*4882a593Smuzhiyun * @name: Name to use in reporting
314*4882a593Smuzhiyun * @tbl: The constant table to validate.
315*4882a593Smuzhiyun * @tbl_size: The size of the table.
316*4882a593Smuzhiyun * @low: The lowest permissible value.
317*4882a593Smuzhiyun * @high: The highest permissible value.
318*4882a593Smuzhiyun * @special: One special permissible value outside of the range.
319*4882a593Smuzhiyun */
validate_constant_table(const struct constant_table * tbl,size_t tbl_size,int low,int high,int special)320*4882a593Smuzhiyun bool validate_constant_table(const struct constant_table *tbl, size_t tbl_size,
321*4882a593Smuzhiyun int low, int high, int special)
322*4882a593Smuzhiyun {
323*4882a593Smuzhiyun size_t i;
324*4882a593Smuzhiyun bool good = true;
325*4882a593Smuzhiyun
326*4882a593Smuzhiyun if (tbl_size == 0) {
327*4882a593Smuzhiyun pr_warn("VALIDATE C-TBL: Empty\n");
328*4882a593Smuzhiyun return true;
329*4882a593Smuzhiyun }
330*4882a593Smuzhiyun
331*4882a593Smuzhiyun for (i = 0; i < tbl_size; i++) {
332*4882a593Smuzhiyun if (!tbl[i].name) {
333*4882a593Smuzhiyun pr_err("VALIDATE C-TBL[%zu]: Null\n", i);
334*4882a593Smuzhiyun good = false;
335*4882a593Smuzhiyun } else if (i > 0 && tbl[i - 1].name) {
336*4882a593Smuzhiyun int c = strcmp(tbl[i-1].name, tbl[i].name);
337*4882a593Smuzhiyun
338*4882a593Smuzhiyun if (c == 0) {
339*4882a593Smuzhiyun pr_err("VALIDATE C-TBL[%zu]: Duplicate %s\n",
340*4882a593Smuzhiyun i, tbl[i].name);
341*4882a593Smuzhiyun good = false;
342*4882a593Smuzhiyun }
343*4882a593Smuzhiyun if (c > 0) {
344*4882a593Smuzhiyun pr_err("VALIDATE C-TBL[%zu]: Missorted %s>=%s\n",
345*4882a593Smuzhiyun i, tbl[i-1].name, tbl[i].name);
346*4882a593Smuzhiyun good = false;
347*4882a593Smuzhiyun }
348*4882a593Smuzhiyun }
349*4882a593Smuzhiyun
350*4882a593Smuzhiyun if (tbl[i].value != special &&
351*4882a593Smuzhiyun (tbl[i].value < low || tbl[i].value > high)) {
352*4882a593Smuzhiyun pr_err("VALIDATE C-TBL[%zu]: %s->%d const out of range (%d-%d)\n",
353*4882a593Smuzhiyun i, tbl[i].name, tbl[i].value, low, high);
354*4882a593Smuzhiyun good = false;
355*4882a593Smuzhiyun }
356*4882a593Smuzhiyun }
357*4882a593Smuzhiyun
358*4882a593Smuzhiyun return good;
359*4882a593Smuzhiyun }
360*4882a593Smuzhiyun
361*4882a593Smuzhiyun /**
362*4882a593Smuzhiyun * fs_validate_description - Validate a parameter description
363*4882a593Smuzhiyun * @desc: The parameter description to validate.
364*4882a593Smuzhiyun */
fs_validate_description(const char * name,const struct fs_parameter_spec * desc)365*4882a593Smuzhiyun bool fs_validate_description(const char *name,
366*4882a593Smuzhiyun const struct fs_parameter_spec *desc)
367*4882a593Smuzhiyun {
368*4882a593Smuzhiyun const struct fs_parameter_spec *param, *p2;
369*4882a593Smuzhiyun bool good = true;
370*4882a593Smuzhiyun
371*4882a593Smuzhiyun for (param = desc; param->name; param++) {
372*4882a593Smuzhiyun /* Check for duplicate parameter names */
373*4882a593Smuzhiyun for (p2 = desc; p2 < param; p2++) {
374*4882a593Smuzhiyun if (strcmp(param->name, p2->name) == 0) {
375*4882a593Smuzhiyun if (is_flag(param) != is_flag(p2))
376*4882a593Smuzhiyun continue;
377*4882a593Smuzhiyun pr_err("VALIDATE %s: PARAM[%s]: Duplicate\n",
378*4882a593Smuzhiyun name, param->name);
379*4882a593Smuzhiyun good = false;
380*4882a593Smuzhiyun }
381*4882a593Smuzhiyun }
382*4882a593Smuzhiyun }
383*4882a593Smuzhiyun return good;
384*4882a593Smuzhiyun }
385*4882a593Smuzhiyun #endif /* CONFIG_VALIDATE_FS_PARSER */
386