xref: /OK3568_Linux_fs/kernel/drivers/power/supply/power_supply_hwmon.c (revision 4882a59341e53eb6f0b4789bf948001014eff981)
1*4882a593Smuzhiyun // SPDX-License-Identifier: GPL-2.0
2*4882a593Smuzhiyun /*
3*4882a593Smuzhiyun  *  power_supply_hwmon.c - power supply hwmon support.
4*4882a593Smuzhiyun  */
5*4882a593Smuzhiyun 
6*4882a593Smuzhiyun #include <linux/err.h>
7*4882a593Smuzhiyun #include <linux/hwmon.h>
8*4882a593Smuzhiyun #include <linux/power_supply.h>
9*4882a593Smuzhiyun #include <linux/slab.h>
10*4882a593Smuzhiyun 
11*4882a593Smuzhiyun struct power_supply_hwmon {
12*4882a593Smuzhiyun 	struct power_supply *psy;
13*4882a593Smuzhiyun 	unsigned long *props;
14*4882a593Smuzhiyun };
15*4882a593Smuzhiyun 
16*4882a593Smuzhiyun static const char *const ps_temp_label[] = {
17*4882a593Smuzhiyun 	"temp",
18*4882a593Smuzhiyun 	"ambient temp",
19*4882a593Smuzhiyun };
20*4882a593Smuzhiyun 
power_supply_hwmon_in_to_property(u32 attr)21*4882a593Smuzhiyun static int power_supply_hwmon_in_to_property(u32 attr)
22*4882a593Smuzhiyun {
23*4882a593Smuzhiyun 	switch (attr) {
24*4882a593Smuzhiyun 	case hwmon_in_average:
25*4882a593Smuzhiyun 		return POWER_SUPPLY_PROP_VOLTAGE_AVG;
26*4882a593Smuzhiyun 	case hwmon_in_min:
27*4882a593Smuzhiyun 		return POWER_SUPPLY_PROP_VOLTAGE_MIN;
28*4882a593Smuzhiyun 	case hwmon_in_max:
29*4882a593Smuzhiyun 		return POWER_SUPPLY_PROP_VOLTAGE_MAX;
30*4882a593Smuzhiyun 	case hwmon_in_input:
31*4882a593Smuzhiyun 		return POWER_SUPPLY_PROP_VOLTAGE_NOW;
32*4882a593Smuzhiyun 	default:
33*4882a593Smuzhiyun 		return -EINVAL;
34*4882a593Smuzhiyun 	}
35*4882a593Smuzhiyun }
36*4882a593Smuzhiyun 
power_supply_hwmon_curr_to_property(u32 attr)37*4882a593Smuzhiyun static int power_supply_hwmon_curr_to_property(u32 attr)
38*4882a593Smuzhiyun {
39*4882a593Smuzhiyun 	switch (attr) {
40*4882a593Smuzhiyun 	case hwmon_curr_average:
41*4882a593Smuzhiyun 		return POWER_SUPPLY_PROP_CURRENT_AVG;
42*4882a593Smuzhiyun 	case hwmon_curr_max:
43*4882a593Smuzhiyun 		return POWER_SUPPLY_PROP_CURRENT_MAX;
44*4882a593Smuzhiyun 	case hwmon_curr_input:
45*4882a593Smuzhiyun 		return POWER_SUPPLY_PROP_CURRENT_NOW;
46*4882a593Smuzhiyun 	default:
47*4882a593Smuzhiyun 		return -EINVAL;
48*4882a593Smuzhiyun 	}
49*4882a593Smuzhiyun }
50*4882a593Smuzhiyun 
power_supply_hwmon_temp_to_property(u32 attr,int channel)51*4882a593Smuzhiyun static int power_supply_hwmon_temp_to_property(u32 attr, int channel)
52*4882a593Smuzhiyun {
53*4882a593Smuzhiyun 	if (channel) {
54*4882a593Smuzhiyun 		switch (attr) {
55*4882a593Smuzhiyun 		case hwmon_temp_input:
56*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP_AMBIENT;
57*4882a593Smuzhiyun 		case hwmon_temp_min_alarm:
58*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP_AMBIENT_ALERT_MIN;
59*4882a593Smuzhiyun 		case hwmon_temp_max_alarm:
60*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP_AMBIENT_ALERT_MAX;
61*4882a593Smuzhiyun 		default:
62*4882a593Smuzhiyun 			break;
63*4882a593Smuzhiyun 		}
64*4882a593Smuzhiyun 	} else {
65*4882a593Smuzhiyun 		switch (attr) {
66*4882a593Smuzhiyun 		case hwmon_temp_input:
67*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP;
68*4882a593Smuzhiyun 		case hwmon_temp_max:
69*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP_MAX;
70*4882a593Smuzhiyun 		case hwmon_temp_min:
71*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP_MIN;
72*4882a593Smuzhiyun 		case hwmon_temp_min_alarm:
73*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP_ALERT_MIN;
74*4882a593Smuzhiyun 		case hwmon_temp_max_alarm:
75*4882a593Smuzhiyun 			return POWER_SUPPLY_PROP_TEMP_ALERT_MAX;
76*4882a593Smuzhiyun 		default:
77*4882a593Smuzhiyun 			break;
78*4882a593Smuzhiyun 		}
79*4882a593Smuzhiyun 	}
80*4882a593Smuzhiyun 
81*4882a593Smuzhiyun 	return -EINVAL;
82*4882a593Smuzhiyun }
83*4882a593Smuzhiyun 
84*4882a593Smuzhiyun static int
power_supply_hwmon_to_property(enum hwmon_sensor_types type,u32 attr,int channel)85*4882a593Smuzhiyun power_supply_hwmon_to_property(enum hwmon_sensor_types type,
86*4882a593Smuzhiyun 			       u32 attr, int channel)
87*4882a593Smuzhiyun {
88*4882a593Smuzhiyun 	switch (type) {
89*4882a593Smuzhiyun 	case hwmon_in:
90*4882a593Smuzhiyun 		return power_supply_hwmon_in_to_property(attr);
91*4882a593Smuzhiyun 	case hwmon_curr:
92*4882a593Smuzhiyun 		return power_supply_hwmon_curr_to_property(attr);
93*4882a593Smuzhiyun 	case hwmon_temp:
94*4882a593Smuzhiyun 		return power_supply_hwmon_temp_to_property(attr, channel);
95*4882a593Smuzhiyun 	default:
96*4882a593Smuzhiyun 		return -EINVAL;
97*4882a593Smuzhiyun 	}
98*4882a593Smuzhiyun }
99*4882a593Smuzhiyun 
power_supply_hwmon_is_a_label(enum hwmon_sensor_types type,u32 attr)100*4882a593Smuzhiyun static bool power_supply_hwmon_is_a_label(enum hwmon_sensor_types type,
101*4882a593Smuzhiyun 					   u32 attr)
102*4882a593Smuzhiyun {
103*4882a593Smuzhiyun 	return type == hwmon_temp && attr == hwmon_temp_label;
104*4882a593Smuzhiyun }
105*4882a593Smuzhiyun 
106*4882a593Smuzhiyun struct hwmon_type_attr_list {
107*4882a593Smuzhiyun 	const u32 *attrs;
108*4882a593Smuzhiyun 	size_t n_attrs;
109*4882a593Smuzhiyun };
110*4882a593Smuzhiyun 
111*4882a593Smuzhiyun static const u32 ps_temp_attrs[] = {
112*4882a593Smuzhiyun 	hwmon_temp_input,
113*4882a593Smuzhiyun 	hwmon_temp_min, hwmon_temp_max,
114*4882a593Smuzhiyun 	hwmon_temp_min_alarm, hwmon_temp_max_alarm,
115*4882a593Smuzhiyun };
116*4882a593Smuzhiyun 
117*4882a593Smuzhiyun static const struct hwmon_type_attr_list ps_type_attrs[hwmon_max] = {
118*4882a593Smuzhiyun 	[hwmon_temp] = { ps_temp_attrs, ARRAY_SIZE(ps_temp_attrs) },
119*4882a593Smuzhiyun };
120*4882a593Smuzhiyun 
power_supply_hwmon_has_input(const struct power_supply_hwmon * psyhw,enum hwmon_sensor_types type,int channel)121*4882a593Smuzhiyun static bool power_supply_hwmon_has_input(
122*4882a593Smuzhiyun 	const struct power_supply_hwmon *psyhw,
123*4882a593Smuzhiyun 	enum hwmon_sensor_types type, int channel)
124*4882a593Smuzhiyun {
125*4882a593Smuzhiyun 	const struct hwmon_type_attr_list *attr_list = &ps_type_attrs[type];
126*4882a593Smuzhiyun 	size_t i;
127*4882a593Smuzhiyun 
128*4882a593Smuzhiyun 	for (i = 0; i < attr_list->n_attrs; ++i) {
129*4882a593Smuzhiyun 		int prop = power_supply_hwmon_to_property(type,
130*4882a593Smuzhiyun 			attr_list->attrs[i], channel);
131*4882a593Smuzhiyun 
132*4882a593Smuzhiyun 		if (prop >= 0 && test_bit(prop, psyhw->props))
133*4882a593Smuzhiyun 			return true;
134*4882a593Smuzhiyun 	}
135*4882a593Smuzhiyun 
136*4882a593Smuzhiyun 	return false;
137*4882a593Smuzhiyun }
138*4882a593Smuzhiyun 
power_supply_hwmon_is_writable(enum hwmon_sensor_types type,u32 attr)139*4882a593Smuzhiyun static bool power_supply_hwmon_is_writable(enum hwmon_sensor_types type,
140*4882a593Smuzhiyun 					   u32 attr)
141*4882a593Smuzhiyun {
142*4882a593Smuzhiyun 	switch (type) {
143*4882a593Smuzhiyun 	case hwmon_in:
144*4882a593Smuzhiyun 		return attr == hwmon_in_min ||
145*4882a593Smuzhiyun 		       attr == hwmon_in_max;
146*4882a593Smuzhiyun 	case hwmon_curr:
147*4882a593Smuzhiyun 		return attr == hwmon_curr_max;
148*4882a593Smuzhiyun 	case hwmon_temp:
149*4882a593Smuzhiyun 		return attr == hwmon_temp_max ||
150*4882a593Smuzhiyun 		       attr == hwmon_temp_min ||
151*4882a593Smuzhiyun 		       attr == hwmon_temp_min_alarm ||
152*4882a593Smuzhiyun 		       attr == hwmon_temp_max_alarm;
153*4882a593Smuzhiyun 	default:
154*4882a593Smuzhiyun 		return false;
155*4882a593Smuzhiyun 	}
156*4882a593Smuzhiyun }
157*4882a593Smuzhiyun 
power_supply_hwmon_is_visible(const void * data,enum hwmon_sensor_types type,u32 attr,int channel)158*4882a593Smuzhiyun static umode_t power_supply_hwmon_is_visible(const void *data,
159*4882a593Smuzhiyun 					     enum hwmon_sensor_types type,
160*4882a593Smuzhiyun 					     u32 attr, int channel)
161*4882a593Smuzhiyun {
162*4882a593Smuzhiyun 	const struct power_supply_hwmon *psyhw = data;
163*4882a593Smuzhiyun 	int prop;
164*4882a593Smuzhiyun 
165*4882a593Smuzhiyun 	if (power_supply_hwmon_is_a_label(type, attr)) {
166*4882a593Smuzhiyun 		if (power_supply_hwmon_has_input(psyhw, type, channel))
167*4882a593Smuzhiyun 			return 0444;
168*4882a593Smuzhiyun 		else
169*4882a593Smuzhiyun 			return 0;
170*4882a593Smuzhiyun 	}
171*4882a593Smuzhiyun 
172*4882a593Smuzhiyun 	prop = power_supply_hwmon_to_property(type, attr, channel);
173*4882a593Smuzhiyun 	if (prop < 0 || !test_bit(prop, psyhw->props))
174*4882a593Smuzhiyun 		return 0;
175*4882a593Smuzhiyun 
176*4882a593Smuzhiyun 	if (power_supply_property_is_writeable(psyhw->psy, prop) > 0 &&
177*4882a593Smuzhiyun 	    power_supply_hwmon_is_writable(type, attr))
178*4882a593Smuzhiyun 		return 0644;
179*4882a593Smuzhiyun 
180*4882a593Smuzhiyun 	return 0444;
181*4882a593Smuzhiyun }
182*4882a593Smuzhiyun 
power_supply_hwmon_read_string(struct device * dev,enum hwmon_sensor_types type,u32 attr,int channel,const char ** str)183*4882a593Smuzhiyun static int power_supply_hwmon_read_string(struct device *dev,
184*4882a593Smuzhiyun 					  enum hwmon_sensor_types type,
185*4882a593Smuzhiyun 					  u32 attr, int channel,
186*4882a593Smuzhiyun 					  const char **str)
187*4882a593Smuzhiyun {
188*4882a593Smuzhiyun 	switch (type) {
189*4882a593Smuzhiyun 	case hwmon_temp:
190*4882a593Smuzhiyun 		*str = ps_temp_label[channel];
191*4882a593Smuzhiyun 		break;
192*4882a593Smuzhiyun 	default:
193*4882a593Smuzhiyun 		/* unreachable, but see:
194*4882a593Smuzhiyun 		 * gcc bug #51513 [1] and clang bug #978 [2]
195*4882a593Smuzhiyun 		 *
196*4882a593Smuzhiyun 		 * [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51513
197*4882a593Smuzhiyun 		 * [2] https://github.com/ClangBuiltLinux/linux/issues/978
198*4882a593Smuzhiyun 		 */
199*4882a593Smuzhiyun 		break;
200*4882a593Smuzhiyun 	}
201*4882a593Smuzhiyun 
202*4882a593Smuzhiyun 	return 0;
203*4882a593Smuzhiyun }
204*4882a593Smuzhiyun 
205*4882a593Smuzhiyun static int
power_supply_hwmon_read(struct device * dev,enum hwmon_sensor_types type,u32 attr,int channel,long * val)206*4882a593Smuzhiyun power_supply_hwmon_read(struct device *dev, enum hwmon_sensor_types type,
207*4882a593Smuzhiyun 			u32 attr, int channel, long *val)
208*4882a593Smuzhiyun {
209*4882a593Smuzhiyun 	struct power_supply_hwmon *psyhw = dev_get_drvdata(dev);
210*4882a593Smuzhiyun 	struct power_supply *psy = psyhw->psy;
211*4882a593Smuzhiyun 	union power_supply_propval pspval;
212*4882a593Smuzhiyun 	int ret, prop;
213*4882a593Smuzhiyun 
214*4882a593Smuzhiyun 	prop = power_supply_hwmon_to_property(type, attr, channel);
215*4882a593Smuzhiyun 	if (prop < 0)
216*4882a593Smuzhiyun 		return prop;
217*4882a593Smuzhiyun 
218*4882a593Smuzhiyun 	ret  = power_supply_get_property(psy, prop, &pspval);
219*4882a593Smuzhiyun 	if (ret)
220*4882a593Smuzhiyun 		return ret;
221*4882a593Smuzhiyun 
222*4882a593Smuzhiyun 	switch (type) {
223*4882a593Smuzhiyun 	/*
224*4882a593Smuzhiyun 	 * Both voltage and current is reported in units of
225*4882a593Smuzhiyun 	 * microvolts/microamps, so we need to adjust it to
226*4882a593Smuzhiyun 	 * milliamps(volts)
227*4882a593Smuzhiyun 	 */
228*4882a593Smuzhiyun 	case hwmon_curr:
229*4882a593Smuzhiyun 	case hwmon_in:
230*4882a593Smuzhiyun 		pspval.intval = DIV_ROUND_CLOSEST(pspval.intval, 1000);
231*4882a593Smuzhiyun 		break;
232*4882a593Smuzhiyun 	/*
233*4882a593Smuzhiyun 	 * Temp needs to be converted from 1/10 C to milli-C
234*4882a593Smuzhiyun 	 */
235*4882a593Smuzhiyun 	case hwmon_temp:
236*4882a593Smuzhiyun 		if (check_mul_overflow(pspval.intval, 100,
237*4882a593Smuzhiyun 				       &pspval.intval))
238*4882a593Smuzhiyun 			return -EOVERFLOW;
239*4882a593Smuzhiyun 		break;
240*4882a593Smuzhiyun 	default:
241*4882a593Smuzhiyun 		return -EINVAL;
242*4882a593Smuzhiyun 	}
243*4882a593Smuzhiyun 
244*4882a593Smuzhiyun 	*val = pspval.intval;
245*4882a593Smuzhiyun 
246*4882a593Smuzhiyun 	return 0;
247*4882a593Smuzhiyun }
248*4882a593Smuzhiyun 
249*4882a593Smuzhiyun static int
power_supply_hwmon_write(struct device * dev,enum hwmon_sensor_types type,u32 attr,int channel,long val)250*4882a593Smuzhiyun power_supply_hwmon_write(struct device *dev, enum hwmon_sensor_types type,
251*4882a593Smuzhiyun 			 u32 attr, int channel, long val)
252*4882a593Smuzhiyun {
253*4882a593Smuzhiyun 	struct power_supply_hwmon *psyhw = dev_get_drvdata(dev);
254*4882a593Smuzhiyun 	struct power_supply *psy = psyhw->psy;
255*4882a593Smuzhiyun 	union power_supply_propval pspval;
256*4882a593Smuzhiyun 	int prop;
257*4882a593Smuzhiyun 
258*4882a593Smuzhiyun 	prop = power_supply_hwmon_to_property(type, attr, channel);
259*4882a593Smuzhiyun 	if (prop < 0)
260*4882a593Smuzhiyun 		return prop;
261*4882a593Smuzhiyun 
262*4882a593Smuzhiyun 	pspval.intval = val;
263*4882a593Smuzhiyun 
264*4882a593Smuzhiyun 	switch (type) {
265*4882a593Smuzhiyun 	/*
266*4882a593Smuzhiyun 	 * Both voltage and current is reported in units of
267*4882a593Smuzhiyun 	 * microvolts/microamps, so we need to adjust it to
268*4882a593Smuzhiyun 	 * milliamps(volts)
269*4882a593Smuzhiyun 	 */
270*4882a593Smuzhiyun 	case hwmon_curr:
271*4882a593Smuzhiyun 	case hwmon_in:
272*4882a593Smuzhiyun 		if (check_mul_overflow(pspval.intval, 1000,
273*4882a593Smuzhiyun 				       &pspval.intval))
274*4882a593Smuzhiyun 			return -EOVERFLOW;
275*4882a593Smuzhiyun 		break;
276*4882a593Smuzhiyun 	/*
277*4882a593Smuzhiyun 	 * Temp needs to be converted from 1/10 C to milli-C
278*4882a593Smuzhiyun 	 */
279*4882a593Smuzhiyun 	case hwmon_temp:
280*4882a593Smuzhiyun 		pspval.intval = DIV_ROUND_CLOSEST(pspval.intval, 100);
281*4882a593Smuzhiyun 		break;
282*4882a593Smuzhiyun 	default:
283*4882a593Smuzhiyun 		return -EINVAL;
284*4882a593Smuzhiyun 	}
285*4882a593Smuzhiyun 
286*4882a593Smuzhiyun 	return power_supply_set_property(psy, prop, &pspval);
287*4882a593Smuzhiyun }
288*4882a593Smuzhiyun 
289*4882a593Smuzhiyun static const struct hwmon_ops power_supply_hwmon_ops = {
290*4882a593Smuzhiyun 	.is_visible	= power_supply_hwmon_is_visible,
291*4882a593Smuzhiyun 	.read		= power_supply_hwmon_read,
292*4882a593Smuzhiyun 	.write		= power_supply_hwmon_write,
293*4882a593Smuzhiyun 	.read_string	= power_supply_hwmon_read_string,
294*4882a593Smuzhiyun };
295*4882a593Smuzhiyun 
296*4882a593Smuzhiyun static const struct hwmon_channel_info *power_supply_hwmon_info[] = {
297*4882a593Smuzhiyun 	HWMON_CHANNEL_INFO(temp,
298*4882a593Smuzhiyun 			   HWMON_T_LABEL     |
299*4882a593Smuzhiyun 			   HWMON_T_INPUT     |
300*4882a593Smuzhiyun 			   HWMON_T_MAX       |
301*4882a593Smuzhiyun 			   HWMON_T_MIN       |
302*4882a593Smuzhiyun 			   HWMON_T_MIN_ALARM |
303*4882a593Smuzhiyun 			   HWMON_T_MIN_ALARM,
304*4882a593Smuzhiyun 
305*4882a593Smuzhiyun 			   HWMON_T_LABEL     |
306*4882a593Smuzhiyun 			   HWMON_T_INPUT     |
307*4882a593Smuzhiyun 			   HWMON_T_MIN_ALARM |
308*4882a593Smuzhiyun 			   HWMON_T_LABEL     |
309*4882a593Smuzhiyun 			   HWMON_T_MAX_ALARM),
310*4882a593Smuzhiyun 
311*4882a593Smuzhiyun 	HWMON_CHANNEL_INFO(curr,
312*4882a593Smuzhiyun 			   HWMON_C_AVERAGE |
313*4882a593Smuzhiyun 			   HWMON_C_MAX     |
314*4882a593Smuzhiyun 			   HWMON_C_INPUT),
315*4882a593Smuzhiyun 
316*4882a593Smuzhiyun 	HWMON_CHANNEL_INFO(in,
317*4882a593Smuzhiyun 			   HWMON_I_AVERAGE |
318*4882a593Smuzhiyun 			   HWMON_I_MIN     |
319*4882a593Smuzhiyun 			   HWMON_I_MAX     |
320*4882a593Smuzhiyun 			   HWMON_I_INPUT),
321*4882a593Smuzhiyun 	NULL
322*4882a593Smuzhiyun };
323*4882a593Smuzhiyun 
324*4882a593Smuzhiyun static const struct hwmon_chip_info power_supply_hwmon_chip_info = {
325*4882a593Smuzhiyun 	.ops = &power_supply_hwmon_ops,
326*4882a593Smuzhiyun 	.info = power_supply_hwmon_info,
327*4882a593Smuzhiyun };
328*4882a593Smuzhiyun 
power_supply_hwmon_bitmap_free(void * data)329*4882a593Smuzhiyun static void power_supply_hwmon_bitmap_free(void *data)
330*4882a593Smuzhiyun {
331*4882a593Smuzhiyun 	bitmap_free(data);
332*4882a593Smuzhiyun }
333*4882a593Smuzhiyun 
power_supply_add_hwmon_sysfs(struct power_supply * psy)334*4882a593Smuzhiyun int power_supply_add_hwmon_sysfs(struct power_supply *psy)
335*4882a593Smuzhiyun {
336*4882a593Smuzhiyun 	const struct power_supply_desc *desc = psy->desc;
337*4882a593Smuzhiyun 	struct power_supply_hwmon *psyhw;
338*4882a593Smuzhiyun 	struct device *dev = &psy->dev;
339*4882a593Smuzhiyun 	struct device *hwmon;
340*4882a593Smuzhiyun 	int ret, i;
341*4882a593Smuzhiyun 	const char *name;
342*4882a593Smuzhiyun 
343*4882a593Smuzhiyun 	if (!devres_open_group(dev, power_supply_add_hwmon_sysfs,
344*4882a593Smuzhiyun 			       GFP_KERNEL))
345*4882a593Smuzhiyun 		return -ENOMEM;
346*4882a593Smuzhiyun 
347*4882a593Smuzhiyun 	psyhw = devm_kzalloc(dev, sizeof(*psyhw), GFP_KERNEL);
348*4882a593Smuzhiyun 	if (!psyhw) {
349*4882a593Smuzhiyun 		ret = -ENOMEM;
350*4882a593Smuzhiyun 		goto error;
351*4882a593Smuzhiyun 	}
352*4882a593Smuzhiyun 
353*4882a593Smuzhiyun 	psyhw->psy = psy;
354*4882a593Smuzhiyun 	psyhw->props = bitmap_zalloc(POWER_SUPPLY_PROP_TIME_TO_FULL_AVG + 1,
355*4882a593Smuzhiyun 				     GFP_KERNEL);
356*4882a593Smuzhiyun 	if (!psyhw->props) {
357*4882a593Smuzhiyun 		ret = -ENOMEM;
358*4882a593Smuzhiyun 		goto error;
359*4882a593Smuzhiyun 	}
360*4882a593Smuzhiyun 
361*4882a593Smuzhiyun 	ret = devm_add_action_or_reset(dev, power_supply_hwmon_bitmap_free,
362*4882a593Smuzhiyun 			      psyhw->props);
363*4882a593Smuzhiyun 	if (ret)
364*4882a593Smuzhiyun 		goto error;
365*4882a593Smuzhiyun 
366*4882a593Smuzhiyun 	for (i = 0; i < desc->num_properties; i++) {
367*4882a593Smuzhiyun 		const enum power_supply_property prop = desc->properties[i];
368*4882a593Smuzhiyun 
369*4882a593Smuzhiyun 		switch (prop) {
370*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_CURRENT_AVG:
371*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_CURRENT_MAX:
372*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_CURRENT_NOW:
373*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP:
374*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP_MAX:
375*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP_MIN:
376*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP_ALERT_MIN:
377*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP_ALERT_MAX:
378*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP_AMBIENT:
379*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP_AMBIENT_ALERT_MIN:
380*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_TEMP_AMBIENT_ALERT_MAX:
381*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_VOLTAGE_AVG:
382*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_VOLTAGE_MIN:
383*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_VOLTAGE_MAX:
384*4882a593Smuzhiyun 		case POWER_SUPPLY_PROP_VOLTAGE_NOW:
385*4882a593Smuzhiyun 			set_bit(prop, psyhw->props);
386*4882a593Smuzhiyun 			break;
387*4882a593Smuzhiyun 		default:
388*4882a593Smuzhiyun 			break;
389*4882a593Smuzhiyun 		}
390*4882a593Smuzhiyun 	}
391*4882a593Smuzhiyun 
392*4882a593Smuzhiyun 	name = psy->desc->name;
393*4882a593Smuzhiyun 	if (strchr(name, '-')) {
394*4882a593Smuzhiyun 		char *new_name;
395*4882a593Smuzhiyun 
396*4882a593Smuzhiyun 		new_name = devm_kstrdup(dev, name, GFP_KERNEL);
397*4882a593Smuzhiyun 		if (!new_name) {
398*4882a593Smuzhiyun 			ret = -ENOMEM;
399*4882a593Smuzhiyun 			goto error;
400*4882a593Smuzhiyun 		}
401*4882a593Smuzhiyun 		strreplace(new_name, '-', '_');
402*4882a593Smuzhiyun 		name = new_name;
403*4882a593Smuzhiyun 	}
404*4882a593Smuzhiyun 	hwmon = devm_hwmon_device_register_with_info(dev, name,
405*4882a593Smuzhiyun 						psyhw,
406*4882a593Smuzhiyun 						&power_supply_hwmon_chip_info,
407*4882a593Smuzhiyun 						NULL);
408*4882a593Smuzhiyun 	ret = PTR_ERR_OR_ZERO(hwmon);
409*4882a593Smuzhiyun 	if (ret)
410*4882a593Smuzhiyun 		goto error;
411*4882a593Smuzhiyun 
412*4882a593Smuzhiyun 	devres_close_group(dev, power_supply_add_hwmon_sysfs);
413*4882a593Smuzhiyun 	return 0;
414*4882a593Smuzhiyun error:
415*4882a593Smuzhiyun 	devres_release_group(dev, NULL);
416*4882a593Smuzhiyun 	return ret;
417*4882a593Smuzhiyun }
418*4882a593Smuzhiyun 
power_supply_remove_hwmon_sysfs(struct power_supply * psy)419*4882a593Smuzhiyun void power_supply_remove_hwmon_sysfs(struct power_supply *psy)
420*4882a593Smuzhiyun {
421*4882a593Smuzhiyun 	devres_release_group(&psy->dev, power_supply_add_hwmon_sysfs);
422*4882a593Smuzhiyun }
423