xref: /OK3568_Linux_fs/kernel/drivers/platform/x86/msi-wmi.c (revision 4882a59341e53eb6f0b4789bf948001014eff981)
1*4882a593Smuzhiyun // SPDX-License-Identifier: GPL-2.0-or-later
2*4882a593Smuzhiyun /*
3*4882a593Smuzhiyun  * MSI WMI hotkeys
4*4882a593Smuzhiyun  *
5*4882a593Smuzhiyun  * Copyright (C) 2009 Novell <trenn@suse.de>
6*4882a593Smuzhiyun  *
7*4882a593Smuzhiyun  * Most stuff taken over from hp-wmi
8*4882a593Smuzhiyun  */
9*4882a593Smuzhiyun 
10*4882a593Smuzhiyun #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
11*4882a593Smuzhiyun 
12*4882a593Smuzhiyun #include <linux/kernel.h>
13*4882a593Smuzhiyun #include <linux/input.h>
14*4882a593Smuzhiyun #include <linux/input/sparse-keymap.h>
15*4882a593Smuzhiyun #include <linux/acpi.h>
16*4882a593Smuzhiyun #include <linux/backlight.h>
17*4882a593Smuzhiyun #include <linux/slab.h>
18*4882a593Smuzhiyun #include <linux/module.h>
19*4882a593Smuzhiyun #include <acpi/video.h>
20*4882a593Smuzhiyun 
21*4882a593Smuzhiyun MODULE_AUTHOR("Thomas Renninger <trenn@suse.de>");
22*4882a593Smuzhiyun MODULE_DESCRIPTION("MSI laptop WMI hotkeys driver");
23*4882a593Smuzhiyun MODULE_LICENSE("GPL");
24*4882a593Smuzhiyun 
25*4882a593Smuzhiyun #define DRV_NAME "msi-wmi"
26*4882a593Smuzhiyun 
27*4882a593Smuzhiyun #define MSIWMI_BIOS_GUID "551A1F84-FBDD-4125-91DB-3EA8F44F1D45"
28*4882a593Smuzhiyun #define MSIWMI_MSI_EVENT_GUID "B6F3EEF2-3D2F-49DC-9DE3-85BCE18C62F2"
29*4882a593Smuzhiyun #define MSIWMI_WIND_EVENT_GUID "5B3CC38A-40D9-7245-8AE6-1145B751BE3F"
30*4882a593Smuzhiyun 
31*4882a593Smuzhiyun MODULE_ALIAS("wmi:" MSIWMI_BIOS_GUID);
32*4882a593Smuzhiyun MODULE_ALIAS("wmi:" MSIWMI_MSI_EVENT_GUID);
33*4882a593Smuzhiyun MODULE_ALIAS("wmi:" MSIWMI_WIND_EVENT_GUID);
34*4882a593Smuzhiyun 
35*4882a593Smuzhiyun enum msi_scancodes {
36*4882a593Smuzhiyun 	/* Generic MSI keys (not present on MSI Wind) */
37*4882a593Smuzhiyun 	MSI_KEY_BRIGHTNESSUP	= 0xD0,
38*4882a593Smuzhiyun 	MSI_KEY_BRIGHTNESSDOWN,
39*4882a593Smuzhiyun 	MSI_KEY_VOLUMEUP,
40*4882a593Smuzhiyun 	MSI_KEY_VOLUMEDOWN,
41*4882a593Smuzhiyun 	MSI_KEY_MUTE,
42*4882a593Smuzhiyun 	/* MSI Wind keys */
43*4882a593Smuzhiyun 	WIND_KEY_TOUCHPAD	= 0x08,	/* Fn+F3 touchpad toggle */
44*4882a593Smuzhiyun 	WIND_KEY_BLUETOOTH	= 0x56,	/* Fn+F11 Bluetooth toggle */
45*4882a593Smuzhiyun 	WIND_KEY_CAMERA,		/* Fn+F6 webcam toggle */
46*4882a593Smuzhiyun 	WIND_KEY_WLAN		= 0x5f,	/* Fn+F11 Wi-Fi toggle */
47*4882a593Smuzhiyun 	WIND_KEY_TURBO,			/* Fn+F10 turbo mode toggle */
48*4882a593Smuzhiyun 	WIND_KEY_ECO		= 0x69,	/* Fn+F10 ECO mode toggle */
49*4882a593Smuzhiyun };
50*4882a593Smuzhiyun static struct key_entry msi_wmi_keymap[] = {
51*4882a593Smuzhiyun 	{ KE_KEY, MSI_KEY_BRIGHTNESSUP,		{KEY_BRIGHTNESSUP} },
52*4882a593Smuzhiyun 	{ KE_KEY, MSI_KEY_BRIGHTNESSDOWN,	{KEY_BRIGHTNESSDOWN} },
53*4882a593Smuzhiyun 	{ KE_KEY, MSI_KEY_VOLUMEUP,		{KEY_VOLUMEUP} },
54*4882a593Smuzhiyun 	{ KE_KEY, MSI_KEY_VOLUMEDOWN,		{KEY_VOLUMEDOWN} },
55*4882a593Smuzhiyun 	{ KE_KEY, MSI_KEY_MUTE,			{KEY_MUTE} },
56*4882a593Smuzhiyun 
57*4882a593Smuzhiyun 	/* These keys work without WMI. Ignore them to avoid double keycodes */
58*4882a593Smuzhiyun 	{ KE_IGNORE, WIND_KEY_TOUCHPAD,		{KEY_TOUCHPAD_TOGGLE} },
59*4882a593Smuzhiyun 	{ KE_IGNORE, WIND_KEY_BLUETOOTH,	{KEY_BLUETOOTH} },
60*4882a593Smuzhiyun 	{ KE_IGNORE, WIND_KEY_CAMERA,		{KEY_CAMERA} },
61*4882a593Smuzhiyun 	{ KE_IGNORE, WIND_KEY_WLAN,		{KEY_WLAN} },
62*4882a593Smuzhiyun 
63*4882a593Smuzhiyun 	/* These are unknown WMI events found on MSI Wind */
64*4882a593Smuzhiyun 	{ KE_IGNORE, 0x00 },
65*4882a593Smuzhiyun 	{ KE_IGNORE, 0x62 },
66*4882a593Smuzhiyun 	{ KE_IGNORE, 0x63 },
67*4882a593Smuzhiyun 
68*4882a593Smuzhiyun 	/* These are MSI Wind keys that should be handled via WMI */
69*4882a593Smuzhiyun 	{ KE_KEY, WIND_KEY_TURBO,		{KEY_PROG1} },
70*4882a593Smuzhiyun 	{ KE_KEY, WIND_KEY_ECO,			{KEY_PROG2} },
71*4882a593Smuzhiyun 
72*4882a593Smuzhiyun 	{ KE_END, 0 }
73*4882a593Smuzhiyun };
74*4882a593Smuzhiyun 
75*4882a593Smuzhiyun static ktime_t last_pressed;
76*4882a593Smuzhiyun 
77*4882a593Smuzhiyun static const struct {
78*4882a593Smuzhiyun 	const char *guid;
79*4882a593Smuzhiyun 	bool quirk_last_pressed;
80*4882a593Smuzhiyun } *event_wmi, event_wmis[] = {
81*4882a593Smuzhiyun 	{ MSIWMI_MSI_EVENT_GUID, true },
82*4882a593Smuzhiyun 	{ MSIWMI_WIND_EVENT_GUID, false },
83*4882a593Smuzhiyun };
84*4882a593Smuzhiyun 
85*4882a593Smuzhiyun static struct backlight_device *backlight;
86*4882a593Smuzhiyun 
87*4882a593Smuzhiyun static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };
88*4882a593Smuzhiyun 
89*4882a593Smuzhiyun static struct input_dev *msi_wmi_input_dev;
90*4882a593Smuzhiyun 
msi_wmi_query_block(int instance,int * ret)91*4882a593Smuzhiyun static int msi_wmi_query_block(int instance, int *ret)
92*4882a593Smuzhiyun {
93*4882a593Smuzhiyun 	acpi_status status;
94*4882a593Smuzhiyun 	union acpi_object *obj;
95*4882a593Smuzhiyun 
96*4882a593Smuzhiyun 	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
97*4882a593Smuzhiyun 
98*4882a593Smuzhiyun 	status = wmi_query_block(MSIWMI_BIOS_GUID, instance, &output);
99*4882a593Smuzhiyun 
100*4882a593Smuzhiyun 	obj = output.pointer;
101*4882a593Smuzhiyun 
102*4882a593Smuzhiyun 	if (!obj || obj->type != ACPI_TYPE_INTEGER) {
103*4882a593Smuzhiyun 		if (obj) {
104*4882a593Smuzhiyun 			pr_err("query block returned object "
105*4882a593Smuzhiyun 			       "type: %d - buffer length:%d\n", obj->type,
106*4882a593Smuzhiyun 			       obj->type == ACPI_TYPE_BUFFER ?
107*4882a593Smuzhiyun 			       obj->buffer.length : 0);
108*4882a593Smuzhiyun 		}
109*4882a593Smuzhiyun 		kfree(obj);
110*4882a593Smuzhiyun 		return -EINVAL;
111*4882a593Smuzhiyun 	}
112*4882a593Smuzhiyun 	*ret = obj->integer.value;
113*4882a593Smuzhiyun 	kfree(obj);
114*4882a593Smuzhiyun 	return 0;
115*4882a593Smuzhiyun }
116*4882a593Smuzhiyun 
msi_wmi_set_block(int instance,int value)117*4882a593Smuzhiyun static int msi_wmi_set_block(int instance, int value)
118*4882a593Smuzhiyun {
119*4882a593Smuzhiyun 	acpi_status status;
120*4882a593Smuzhiyun 
121*4882a593Smuzhiyun 	struct acpi_buffer input = { sizeof(int), &value };
122*4882a593Smuzhiyun 
123*4882a593Smuzhiyun 	pr_debug("Going to set block of instance: %d - value: %d\n",
124*4882a593Smuzhiyun 		 instance, value);
125*4882a593Smuzhiyun 
126*4882a593Smuzhiyun 	status = wmi_set_block(MSIWMI_BIOS_GUID, instance, &input);
127*4882a593Smuzhiyun 
128*4882a593Smuzhiyun 	return ACPI_SUCCESS(status) ? 0 : 1;
129*4882a593Smuzhiyun }
130*4882a593Smuzhiyun 
bl_get(struct backlight_device * bd)131*4882a593Smuzhiyun static int bl_get(struct backlight_device *bd)
132*4882a593Smuzhiyun {
133*4882a593Smuzhiyun 	int level, err, ret;
134*4882a593Smuzhiyun 
135*4882a593Smuzhiyun 	/* Instance 1 is "get backlight", cmp with DSDT */
136*4882a593Smuzhiyun 	err = msi_wmi_query_block(1, &ret);
137*4882a593Smuzhiyun 	if (err) {
138*4882a593Smuzhiyun 		pr_err("Could not query backlight: %d\n", err);
139*4882a593Smuzhiyun 		return -EINVAL;
140*4882a593Smuzhiyun 	}
141*4882a593Smuzhiyun 	pr_debug("Get: Query block returned: %d\n", ret);
142*4882a593Smuzhiyun 	for (level = 0; level < ARRAY_SIZE(backlight_map); level++) {
143*4882a593Smuzhiyun 		if (backlight_map[level] == ret) {
144*4882a593Smuzhiyun 			pr_debug("Current backlight level: 0x%X - index: %d\n",
145*4882a593Smuzhiyun 				 backlight_map[level], level);
146*4882a593Smuzhiyun 			break;
147*4882a593Smuzhiyun 		}
148*4882a593Smuzhiyun 	}
149*4882a593Smuzhiyun 	if (level == ARRAY_SIZE(backlight_map)) {
150*4882a593Smuzhiyun 		pr_err("get: Invalid brightness value: 0x%X\n", ret);
151*4882a593Smuzhiyun 		return -EINVAL;
152*4882a593Smuzhiyun 	}
153*4882a593Smuzhiyun 	return level;
154*4882a593Smuzhiyun }
155*4882a593Smuzhiyun 
bl_set_status(struct backlight_device * bd)156*4882a593Smuzhiyun static int bl_set_status(struct backlight_device *bd)
157*4882a593Smuzhiyun {
158*4882a593Smuzhiyun 	int bright = bd->props.brightness;
159*4882a593Smuzhiyun 	if (bright >= ARRAY_SIZE(backlight_map) || bright < 0)
160*4882a593Smuzhiyun 		return -EINVAL;
161*4882a593Smuzhiyun 
162*4882a593Smuzhiyun 	/* Instance 0 is "set backlight" */
163*4882a593Smuzhiyun 	return msi_wmi_set_block(0, backlight_map[bright]);
164*4882a593Smuzhiyun }
165*4882a593Smuzhiyun 
166*4882a593Smuzhiyun static const struct backlight_ops msi_backlight_ops = {
167*4882a593Smuzhiyun 	.get_brightness	= bl_get,
168*4882a593Smuzhiyun 	.update_status	= bl_set_status,
169*4882a593Smuzhiyun };
170*4882a593Smuzhiyun 
msi_wmi_notify(u32 value,void * context)171*4882a593Smuzhiyun static void msi_wmi_notify(u32 value, void *context)
172*4882a593Smuzhiyun {
173*4882a593Smuzhiyun 	struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
174*4882a593Smuzhiyun 	struct key_entry *key;
175*4882a593Smuzhiyun 	union acpi_object *obj;
176*4882a593Smuzhiyun 	acpi_status status;
177*4882a593Smuzhiyun 
178*4882a593Smuzhiyun 	status = wmi_get_event_data(value, &response);
179*4882a593Smuzhiyun 	if (status != AE_OK) {
180*4882a593Smuzhiyun 		pr_info("bad event status 0x%x\n", status);
181*4882a593Smuzhiyun 		return;
182*4882a593Smuzhiyun 	}
183*4882a593Smuzhiyun 
184*4882a593Smuzhiyun 	obj = (union acpi_object *)response.pointer;
185*4882a593Smuzhiyun 
186*4882a593Smuzhiyun 	if (obj && obj->type == ACPI_TYPE_INTEGER) {
187*4882a593Smuzhiyun 		int eventcode = obj->integer.value;
188*4882a593Smuzhiyun 		pr_debug("Eventcode: 0x%x\n", eventcode);
189*4882a593Smuzhiyun 		key = sparse_keymap_entry_from_scancode(msi_wmi_input_dev,
190*4882a593Smuzhiyun 				eventcode);
191*4882a593Smuzhiyun 		if (!key) {
192*4882a593Smuzhiyun 			pr_info("Unknown key pressed - %x\n", eventcode);
193*4882a593Smuzhiyun 			goto msi_wmi_notify_exit;
194*4882a593Smuzhiyun 		}
195*4882a593Smuzhiyun 
196*4882a593Smuzhiyun 		if (event_wmi->quirk_last_pressed) {
197*4882a593Smuzhiyun 			ktime_t cur = ktime_get_real();
198*4882a593Smuzhiyun 			ktime_t diff = ktime_sub(cur, last_pressed);
199*4882a593Smuzhiyun 			/* Ignore event if any event happened in a 50 ms
200*4882a593Smuzhiyun 			   timeframe -> Key press may result in 10-20 GPEs */
201*4882a593Smuzhiyun 			if (ktime_to_us(diff) < 1000 * 50) {
202*4882a593Smuzhiyun 				pr_debug("Suppressed key event 0x%X - "
203*4882a593Smuzhiyun 					 "Last press was %lld us ago\n",
204*4882a593Smuzhiyun 					 key->code, ktime_to_us(diff));
205*4882a593Smuzhiyun 				goto msi_wmi_notify_exit;
206*4882a593Smuzhiyun 			}
207*4882a593Smuzhiyun 			last_pressed = cur;
208*4882a593Smuzhiyun 		}
209*4882a593Smuzhiyun 
210*4882a593Smuzhiyun 		if (key->type == KE_KEY &&
211*4882a593Smuzhiyun 		/* Brightness is served via acpi video driver */
212*4882a593Smuzhiyun 		(backlight ||
213*4882a593Smuzhiyun 		(key->code != MSI_KEY_BRIGHTNESSUP &&
214*4882a593Smuzhiyun 		key->code != MSI_KEY_BRIGHTNESSDOWN))) {
215*4882a593Smuzhiyun 			pr_debug("Send key: 0x%X - Input layer keycode: %d\n",
216*4882a593Smuzhiyun 				 key->code, key->keycode);
217*4882a593Smuzhiyun 			sparse_keymap_report_entry(msi_wmi_input_dev, key, 1,
218*4882a593Smuzhiyun 						   true);
219*4882a593Smuzhiyun 		}
220*4882a593Smuzhiyun 	} else
221*4882a593Smuzhiyun 		pr_info("Unknown event received\n");
222*4882a593Smuzhiyun 
223*4882a593Smuzhiyun msi_wmi_notify_exit:
224*4882a593Smuzhiyun 	kfree(response.pointer);
225*4882a593Smuzhiyun }
226*4882a593Smuzhiyun 
msi_wmi_backlight_setup(void)227*4882a593Smuzhiyun static int __init msi_wmi_backlight_setup(void)
228*4882a593Smuzhiyun {
229*4882a593Smuzhiyun 	int err;
230*4882a593Smuzhiyun 	struct backlight_properties props;
231*4882a593Smuzhiyun 
232*4882a593Smuzhiyun 	memset(&props, 0, sizeof(struct backlight_properties));
233*4882a593Smuzhiyun 	props.type = BACKLIGHT_PLATFORM;
234*4882a593Smuzhiyun 	props.max_brightness = ARRAY_SIZE(backlight_map) - 1;
235*4882a593Smuzhiyun 	backlight = backlight_device_register(DRV_NAME, NULL, NULL,
236*4882a593Smuzhiyun 					      &msi_backlight_ops,
237*4882a593Smuzhiyun 					      &props);
238*4882a593Smuzhiyun 	if (IS_ERR(backlight))
239*4882a593Smuzhiyun 		return PTR_ERR(backlight);
240*4882a593Smuzhiyun 
241*4882a593Smuzhiyun 	err = bl_get(NULL);
242*4882a593Smuzhiyun 	if (err < 0) {
243*4882a593Smuzhiyun 		backlight_device_unregister(backlight);
244*4882a593Smuzhiyun 		return err;
245*4882a593Smuzhiyun 	}
246*4882a593Smuzhiyun 
247*4882a593Smuzhiyun 	backlight->props.brightness = err;
248*4882a593Smuzhiyun 
249*4882a593Smuzhiyun 	return 0;
250*4882a593Smuzhiyun }
251*4882a593Smuzhiyun 
msi_wmi_input_setup(void)252*4882a593Smuzhiyun static int __init msi_wmi_input_setup(void)
253*4882a593Smuzhiyun {
254*4882a593Smuzhiyun 	int err;
255*4882a593Smuzhiyun 
256*4882a593Smuzhiyun 	msi_wmi_input_dev = input_allocate_device();
257*4882a593Smuzhiyun 	if (!msi_wmi_input_dev)
258*4882a593Smuzhiyun 		return -ENOMEM;
259*4882a593Smuzhiyun 
260*4882a593Smuzhiyun 	msi_wmi_input_dev->name = "MSI WMI hotkeys";
261*4882a593Smuzhiyun 	msi_wmi_input_dev->phys = "wmi/input0";
262*4882a593Smuzhiyun 	msi_wmi_input_dev->id.bustype = BUS_HOST;
263*4882a593Smuzhiyun 
264*4882a593Smuzhiyun 	err = sparse_keymap_setup(msi_wmi_input_dev, msi_wmi_keymap, NULL);
265*4882a593Smuzhiyun 	if (err)
266*4882a593Smuzhiyun 		goto err_free_dev;
267*4882a593Smuzhiyun 
268*4882a593Smuzhiyun 	err = input_register_device(msi_wmi_input_dev);
269*4882a593Smuzhiyun 
270*4882a593Smuzhiyun 	if (err)
271*4882a593Smuzhiyun 		goto err_free_dev;
272*4882a593Smuzhiyun 
273*4882a593Smuzhiyun 	last_pressed = 0;
274*4882a593Smuzhiyun 
275*4882a593Smuzhiyun 	return 0;
276*4882a593Smuzhiyun 
277*4882a593Smuzhiyun err_free_dev:
278*4882a593Smuzhiyun 	input_free_device(msi_wmi_input_dev);
279*4882a593Smuzhiyun 	return err;
280*4882a593Smuzhiyun }
281*4882a593Smuzhiyun 
msi_wmi_init(void)282*4882a593Smuzhiyun static int __init msi_wmi_init(void)
283*4882a593Smuzhiyun {
284*4882a593Smuzhiyun 	int err;
285*4882a593Smuzhiyun 	int i;
286*4882a593Smuzhiyun 
287*4882a593Smuzhiyun 	for (i = 0; i < ARRAY_SIZE(event_wmis); i++) {
288*4882a593Smuzhiyun 		if (!wmi_has_guid(event_wmis[i].guid))
289*4882a593Smuzhiyun 			continue;
290*4882a593Smuzhiyun 
291*4882a593Smuzhiyun 		err = msi_wmi_input_setup();
292*4882a593Smuzhiyun 		if (err) {
293*4882a593Smuzhiyun 			pr_err("Unable to setup input device\n");
294*4882a593Smuzhiyun 			return err;
295*4882a593Smuzhiyun 		}
296*4882a593Smuzhiyun 
297*4882a593Smuzhiyun 		err = wmi_install_notify_handler(event_wmis[i].guid,
298*4882a593Smuzhiyun 			msi_wmi_notify, NULL);
299*4882a593Smuzhiyun 		if (ACPI_FAILURE(err)) {
300*4882a593Smuzhiyun 			pr_err("Unable to setup WMI notify handler\n");
301*4882a593Smuzhiyun 			goto err_free_input;
302*4882a593Smuzhiyun 		}
303*4882a593Smuzhiyun 
304*4882a593Smuzhiyun 		pr_debug("Event handler installed\n");
305*4882a593Smuzhiyun 		event_wmi = &event_wmis[i];
306*4882a593Smuzhiyun 		break;
307*4882a593Smuzhiyun 	}
308*4882a593Smuzhiyun 
309*4882a593Smuzhiyun 	if (wmi_has_guid(MSIWMI_BIOS_GUID) &&
310*4882a593Smuzhiyun 	    acpi_video_get_backlight_type() == acpi_backlight_vendor) {
311*4882a593Smuzhiyun 		err = msi_wmi_backlight_setup();
312*4882a593Smuzhiyun 		if (err) {
313*4882a593Smuzhiyun 			pr_err("Unable to setup backlight device\n");
314*4882a593Smuzhiyun 			goto err_uninstall_handler;
315*4882a593Smuzhiyun 		}
316*4882a593Smuzhiyun 		pr_debug("Backlight device created\n");
317*4882a593Smuzhiyun 	}
318*4882a593Smuzhiyun 
319*4882a593Smuzhiyun 	if (!event_wmi && !backlight) {
320*4882a593Smuzhiyun 		pr_err("This machine doesn't have neither MSI-hotkeys nor backlight through WMI\n");
321*4882a593Smuzhiyun 		return -ENODEV;
322*4882a593Smuzhiyun 	}
323*4882a593Smuzhiyun 
324*4882a593Smuzhiyun 	return 0;
325*4882a593Smuzhiyun 
326*4882a593Smuzhiyun err_uninstall_handler:
327*4882a593Smuzhiyun 	if (event_wmi)
328*4882a593Smuzhiyun 		wmi_remove_notify_handler(event_wmi->guid);
329*4882a593Smuzhiyun err_free_input:
330*4882a593Smuzhiyun 	if (event_wmi)
331*4882a593Smuzhiyun 		input_unregister_device(msi_wmi_input_dev);
332*4882a593Smuzhiyun 	return err;
333*4882a593Smuzhiyun }
334*4882a593Smuzhiyun 
msi_wmi_exit(void)335*4882a593Smuzhiyun static void __exit msi_wmi_exit(void)
336*4882a593Smuzhiyun {
337*4882a593Smuzhiyun 	if (event_wmi) {
338*4882a593Smuzhiyun 		wmi_remove_notify_handler(event_wmi->guid);
339*4882a593Smuzhiyun 		input_unregister_device(msi_wmi_input_dev);
340*4882a593Smuzhiyun 	}
341*4882a593Smuzhiyun 	backlight_device_unregister(backlight);
342*4882a593Smuzhiyun }
343*4882a593Smuzhiyun 
344*4882a593Smuzhiyun module_init(msi_wmi_init);
345*4882a593Smuzhiyun module_exit(msi_wmi_exit);
346