xref: /OK3568_Linux_fs/kernel/drivers/pci/controller/dwc/pcie-armada8k.c (revision 4882a59341e53eb6f0b4789bf948001014eff981)
1*4882a593Smuzhiyun // SPDX-License-Identifier: GPL-2.0
2*4882a593Smuzhiyun /*
3*4882a593Smuzhiyun  * PCIe host controller driver for Marvell Armada-8K SoCs
4*4882a593Smuzhiyun  *
5*4882a593Smuzhiyun  * Armada-8K PCIe Glue Layer Source Code
6*4882a593Smuzhiyun  *
7*4882a593Smuzhiyun  * Copyright (C) 2016 Marvell Technology Group Ltd.
8*4882a593Smuzhiyun  *
9*4882a593Smuzhiyun  * Author: Yehuda Yitshak <yehuday@marvell.com>
10*4882a593Smuzhiyun  * Author: Shadi Ammouri <shadi@marvell.com>
11*4882a593Smuzhiyun  */
12*4882a593Smuzhiyun 
13*4882a593Smuzhiyun #include <linux/clk.h>
14*4882a593Smuzhiyun #include <linux/delay.h>
15*4882a593Smuzhiyun #include <linux/interrupt.h>
16*4882a593Smuzhiyun #include <linux/kernel.h>
17*4882a593Smuzhiyun #include <linux/init.h>
18*4882a593Smuzhiyun #include <linux/of.h>
19*4882a593Smuzhiyun #include <linux/pci.h>
20*4882a593Smuzhiyun #include <linux/phy/phy.h>
21*4882a593Smuzhiyun #include <linux/platform_device.h>
22*4882a593Smuzhiyun #include <linux/resource.h>
23*4882a593Smuzhiyun #include <linux/of_pci.h>
24*4882a593Smuzhiyun #include <linux/of_irq.h>
25*4882a593Smuzhiyun 
26*4882a593Smuzhiyun #include "pcie-designware.h"
27*4882a593Smuzhiyun 
28*4882a593Smuzhiyun #define ARMADA8K_PCIE_MAX_LANES PCIE_LNK_X4
29*4882a593Smuzhiyun 
30*4882a593Smuzhiyun struct armada8k_pcie {
31*4882a593Smuzhiyun 	struct dw_pcie *pci;
32*4882a593Smuzhiyun 	struct clk *clk;
33*4882a593Smuzhiyun 	struct clk *clk_reg;
34*4882a593Smuzhiyun 	struct phy *phy[ARMADA8K_PCIE_MAX_LANES];
35*4882a593Smuzhiyun 	unsigned int phy_count;
36*4882a593Smuzhiyun };
37*4882a593Smuzhiyun 
38*4882a593Smuzhiyun #define PCIE_VENDOR_REGS_OFFSET		0x8000
39*4882a593Smuzhiyun 
40*4882a593Smuzhiyun #define PCIE_GLOBAL_CONTROL_REG		(PCIE_VENDOR_REGS_OFFSET + 0x0)
41*4882a593Smuzhiyun #define PCIE_APP_LTSSM_EN		BIT(2)
42*4882a593Smuzhiyun #define PCIE_DEVICE_TYPE_SHIFT		4
43*4882a593Smuzhiyun #define PCIE_DEVICE_TYPE_MASK		0xF
44*4882a593Smuzhiyun #define PCIE_DEVICE_TYPE_RC		0x4 /* Root complex */
45*4882a593Smuzhiyun 
46*4882a593Smuzhiyun #define PCIE_GLOBAL_STATUS_REG		(PCIE_VENDOR_REGS_OFFSET + 0x8)
47*4882a593Smuzhiyun #define PCIE_GLB_STS_RDLH_LINK_UP	BIT(1)
48*4882a593Smuzhiyun #define PCIE_GLB_STS_PHY_LINK_UP	BIT(9)
49*4882a593Smuzhiyun 
50*4882a593Smuzhiyun #define PCIE_GLOBAL_INT_CAUSE1_REG	(PCIE_VENDOR_REGS_OFFSET + 0x1C)
51*4882a593Smuzhiyun #define PCIE_GLOBAL_INT_MASK1_REG	(PCIE_VENDOR_REGS_OFFSET + 0x20)
52*4882a593Smuzhiyun #define PCIE_INT_A_ASSERT_MASK		BIT(9)
53*4882a593Smuzhiyun #define PCIE_INT_B_ASSERT_MASK		BIT(10)
54*4882a593Smuzhiyun #define PCIE_INT_C_ASSERT_MASK		BIT(11)
55*4882a593Smuzhiyun #define PCIE_INT_D_ASSERT_MASK		BIT(12)
56*4882a593Smuzhiyun 
57*4882a593Smuzhiyun #define PCIE_ARCACHE_TRC_REG		(PCIE_VENDOR_REGS_OFFSET + 0x50)
58*4882a593Smuzhiyun #define PCIE_AWCACHE_TRC_REG		(PCIE_VENDOR_REGS_OFFSET + 0x54)
59*4882a593Smuzhiyun #define PCIE_ARUSER_REG			(PCIE_VENDOR_REGS_OFFSET + 0x5C)
60*4882a593Smuzhiyun #define PCIE_AWUSER_REG			(PCIE_VENDOR_REGS_OFFSET + 0x60)
61*4882a593Smuzhiyun /*
62*4882a593Smuzhiyun  * AR/AW Cache defaults: Normal memory, Write-Back, Read / Write
63*4882a593Smuzhiyun  * allocate
64*4882a593Smuzhiyun  */
65*4882a593Smuzhiyun #define ARCACHE_DEFAULT_VALUE		0x3511
66*4882a593Smuzhiyun #define AWCACHE_DEFAULT_VALUE		0x5311
67*4882a593Smuzhiyun 
68*4882a593Smuzhiyun #define DOMAIN_OUTER_SHAREABLE		0x2
69*4882a593Smuzhiyun #define AX_USER_DOMAIN_MASK		0x3
70*4882a593Smuzhiyun #define AX_USER_DOMAIN_SHIFT		4
71*4882a593Smuzhiyun 
72*4882a593Smuzhiyun #define to_armada8k_pcie(x)	dev_get_drvdata((x)->dev)
73*4882a593Smuzhiyun 
armada8k_pcie_disable_phys(struct armada8k_pcie * pcie)74*4882a593Smuzhiyun static void armada8k_pcie_disable_phys(struct armada8k_pcie *pcie)
75*4882a593Smuzhiyun {
76*4882a593Smuzhiyun 	int i;
77*4882a593Smuzhiyun 
78*4882a593Smuzhiyun 	for (i = 0; i < ARMADA8K_PCIE_MAX_LANES; i++) {
79*4882a593Smuzhiyun 		phy_power_off(pcie->phy[i]);
80*4882a593Smuzhiyun 		phy_exit(pcie->phy[i]);
81*4882a593Smuzhiyun 	}
82*4882a593Smuzhiyun }
83*4882a593Smuzhiyun 
armada8k_pcie_enable_phys(struct armada8k_pcie * pcie)84*4882a593Smuzhiyun static int armada8k_pcie_enable_phys(struct armada8k_pcie *pcie)
85*4882a593Smuzhiyun {
86*4882a593Smuzhiyun 	int ret;
87*4882a593Smuzhiyun 	int i;
88*4882a593Smuzhiyun 
89*4882a593Smuzhiyun 	for (i = 0; i < ARMADA8K_PCIE_MAX_LANES; i++) {
90*4882a593Smuzhiyun 		ret = phy_init(pcie->phy[i]);
91*4882a593Smuzhiyun 		if (ret)
92*4882a593Smuzhiyun 			return ret;
93*4882a593Smuzhiyun 
94*4882a593Smuzhiyun 		ret = phy_set_mode_ext(pcie->phy[i], PHY_MODE_PCIE,
95*4882a593Smuzhiyun 				       pcie->phy_count);
96*4882a593Smuzhiyun 		if (ret) {
97*4882a593Smuzhiyun 			phy_exit(pcie->phy[i]);
98*4882a593Smuzhiyun 			return ret;
99*4882a593Smuzhiyun 		}
100*4882a593Smuzhiyun 
101*4882a593Smuzhiyun 		ret = phy_power_on(pcie->phy[i]);
102*4882a593Smuzhiyun 		if (ret) {
103*4882a593Smuzhiyun 			phy_exit(pcie->phy[i]);
104*4882a593Smuzhiyun 			return ret;
105*4882a593Smuzhiyun 		}
106*4882a593Smuzhiyun 	}
107*4882a593Smuzhiyun 
108*4882a593Smuzhiyun 	return 0;
109*4882a593Smuzhiyun }
110*4882a593Smuzhiyun 
armada8k_pcie_setup_phys(struct armada8k_pcie * pcie)111*4882a593Smuzhiyun static int armada8k_pcie_setup_phys(struct armada8k_pcie *pcie)
112*4882a593Smuzhiyun {
113*4882a593Smuzhiyun 	struct dw_pcie *pci = pcie->pci;
114*4882a593Smuzhiyun 	struct device *dev = pci->dev;
115*4882a593Smuzhiyun 	struct device_node *node = dev->of_node;
116*4882a593Smuzhiyun 	int ret = 0;
117*4882a593Smuzhiyun 	int i;
118*4882a593Smuzhiyun 
119*4882a593Smuzhiyun 	for (i = 0; i < ARMADA8K_PCIE_MAX_LANES; i++) {
120*4882a593Smuzhiyun 		pcie->phy[i] = devm_of_phy_get_by_index(dev, node, i);
121*4882a593Smuzhiyun 		if (IS_ERR(pcie->phy[i])) {
122*4882a593Smuzhiyun 			if (PTR_ERR(pcie->phy[i]) != -ENODEV)
123*4882a593Smuzhiyun 				return PTR_ERR(pcie->phy[i]);
124*4882a593Smuzhiyun 
125*4882a593Smuzhiyun 			pcie->phy[i] = NULL;
126*4882a593Smuzhiyun 			continue;
127*4882a593Smuzhiyun 		}
128*4882a593Smuzhiyun 
129*4882a593Smuzhiyun 		pcie->phy_count++;
130*4882a593Smuzhiyun 	}
131*4882a593Smuzhiyun 
132*4882a593Smuzhiyun 	/* Old bindings miss the PHY handle, so just warn if there is no PHY */
133*4882a593Smuzhiyun 	if (!pcie->phy_count)
134*4882a593Smuzhiyun 		dev_warn(dev, "No available PHY\n");
135*4882a593Smuzhiyun 
136*4882a593Smuzhiyun 	ret = armada8k_pcie_enable_phys(pcie);
137*4882a593Smuzhiyun 	if (ret)
138*4882a593Smuzhiyun 		dev_err(dev, "Failed to initialize PHY(s) (%d)\n", ret);
139*4882a593Smuzhiyun 
140*4882a593Smuzhiyun 	return ret;
141*4882a593Smuzhiyun }
142*4882a593Smuzhiyun 
armada8k_pcie_link_up(struct dw_pcie * pci)143*4882a593Smuzhiyun static int armada8k_pcie_link_up(struct dw_pcie *pci)
144*4882a593Smuzhiyun {
145*4882a593Smuzhiyun 	u32 reg;
146*4882a593Smuzhiyun 	u32 mask = PCIE_GLB_STS_RDLH_LINK_UP | PCIE_GLB_STS_PHY_LINK_UP;
147*4882a593Smuzhiyun 
148*4882a593Smuzhiyun 	reg = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_STATUS_REG);
149*4882a593Smuzhiyun 
150*4882a593Smuzhiyun 	if ((reg & mask) == mask)
151*4882a593Smuzhiyun 		return 1;
152*4882a593Smuzhiyun 
153*4882a593Smuzhiyun 	dev_dbg(pci->dev, "No link detected (Global-Status: 0x%08x).\n", reg);
154*4882a593Smuzhiyun 	return 0;
155*4882a593Smuzhiyun }
156*4882a593Smuzhiyun 
armada8k_pcie_establish_link(struct armada8k_pcie * pcie)157*4882a593Smuzhiyun static void armada8k_pcie_establish_link(struct armada8k_pcie *pcie)
158*4882a593Smuzhiyun {
159*4882a593Smuzhiyun 	struct dw_pcie *pci = pcie->pci;
160*4882a593Smuzhiyun 	u32 reg;
161*4882a593Smuzhiyun 
162*4882a593Smuzhiyun 	if (!dw_pcie_link_up(pci)) {
163*4882a593Smuzhiyun 		/* Disable LTSSM state machine to enable configuration */
164*4882a593Smuzhiyun 		reg = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_CONTROL_REG);
165*4882a593Smuzhiyun 		reg &= ~(PCIE_APP_LTSSM_EN);
166*4882a593Smuzhiyun 		dw_pcie_writel_dbi(pci, PCIE_GLOBAL_CONTROL_REG, reg);
167*4882a593Smuzhiyun 	}
168*4882a593Smuzhiyun 
169*4882a593Smuzhiyun 	/* Set the device to root complex mode */
170*4882a593Smuzhiyun 	reg = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_CONTROL_REG);
171*4882a593Smuzhiyun 	reg &= ~(PCIE_DEVICE_TYPE_MASK << PCIE_DEVICE_TYPE_SHIFT);
172*4882a593Smuzhiyun 	reg |= PCIE_DEVICE_TYPE_RC << PCIE_DEVICE_TYPE_SHIFT;
173*4882a593Smuzhiyun 	dw_pcie_writel_dbi(pci, PCIE_GLOBAL_CONTROL_REG, reg);
174*4882a593Smuzhiyun 
175*4882a593Smuzhiyun 	/* Set the PCIe master AxCache attributes */
176*4882a593Smuzhiyun 	dw_pcie_writel_dbi(pci, PCIE_ARCACHE_TRC_REG, ARCACHE_DEFAULT_VALUE);
177*4882a593Smuzhiyun 	dw_pcie_writel_dbi(pci, PCIE_AWCACHE_TRC_REG, AWCACHE_DEFAULT_VALUE);
178*4882a593Smuzhiyun 
179*4882a593Smuzhiyun 	/* Set the PCIe master AxDomain attributes */
180*4882a593Smuzhiyun 	reg = dw_pcie_readl_dbi(pci, PCIE_ARUSER_REG);
181*4882a593Smuzhiyun 	reg &= ~(AX_USER_DOMAIN_MASK << AX_USER_DOMAIN_SHIFT);
182*4882a593Smuzhiyun 	reg |= DOMAIN_OUTER_SHAREABLE << AX_USER_DOMAIN_SHIFT;
183*4882a593Smuzhiyun 	dw_pcie_writel_dbi(pci, PCIE_ARUSER_REG, reg);
184*4882a593Smuzhiyun 
185*4882a593Smuzhiyun 	reg = dw_pcie_readl_dbi(pci, PCIE_AWUSER_REG);
186*4882a593Smuzhiyun 	reg &= ~(AX_USER_DOMAIN_MASK << AX_USER_DOMAIN_SHIFT);
187*4882a593Smuzhiyun 	reg |= DOMAIN_OUTER_SHAREABLE << AX_USER_DOMAIN_SHIFT;
188*4882a593Smuzhiyun 	dw_pcie_writel_dbi(pci, PCIE_AWUSER_REG, reg);
189*4882a593Smuzhiyun 
190*4882a593Smuzhiyun 	/* Enable INT A-D interrupts */
191*4882a593Smuzhiyun 	reg = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_INT_MASK1_REG);
192*4882a593Smuzhiyun 	reg |= PCIE_INT_A_ASSERT_MASK | PCIE_INT_B_ASSERT_MASK |
193*4882a593Smuzhiyun 	       PCIE_INT_C_ASSERT_MASK | PCIE_INT_D_ASSERT_MASK;
194*4882a593Smuzhiyun 	dw_pcie_writel_dbi(pci, PCIE_GLOBAL_INT_MASK1_REG, reg);
195*4882a593Smuzhiyun 
196*4882a593Smuzhiyun 	if (!dw_pcie_link_up(pci)) {
197*4882a593Smuzhiyun 		/* Configuration done. Start LTSSM */
198*4882a593Smuzhiyun 		reg = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_CONTROL_REG);
199*4882a593Smuzhiyun 		reg |= PCIE_APP_LTSSM_EN;
200*4882a593Smuzhiyun 		dw_pcie_writel_dbi(pci, PCIE_GLOBAL_CONTROL_REG, reg);
201*4882a593Smuzhiyun 	}
202*4882a593Smuzhiyun 
203*4882a593Smuzhiyun 	/* Wait until the link becomes active again */
204*4882a593Smuzhiyun 	if (dw_pcie_wait_for_link(pci))
205*4882a593Smuzhiyun 		dev_err(pci->dev, "Link not up after reconfiguration\n");
206*4882a593Smuzhiyun }
207*4882a593Smuzhiyun 
armada8k_pcie_host_init(struct pcie_port * pp)208*4882a593Smuzhiyun static int armada8k_pcie_host_init(struct pcie_port *pp)
209*4882a593Smuzhiyun {
210*4882a593Smuzhiyun 	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
211*4882a593Smuzhiyun 	struct armada8k_pcie *pcie = to_armada8k_pcie(pci);
212*4882a593Smuzhiyun 
213*4882a593Smuzhiyun 	dw_pcie_setup_rc(pp);
214*4882a593Smuzhiyun 	armada8k_pcie_establish_link(pcie);
215*4882a593Smuzhiyun 
216*4882a593Smuzhiyun 	return 0;
217*4882a593Smuzhiyun }
218*4882a593Smuzhiyun 
armada8k_pcie_irq_handler(int irq,void * arg)219*4882a593Smuzhiyun static irqreturn_t armada8k_pcie_irq_handler(int irq, void *arg)
220*4882a593Smuzhiyun {
221*4882a593Smuzhiyun 	struct armada8k_pcie *pcie = arg;
222*4882a593Smuzhiyun 	struct dw_pcie *pci = pcie->pci;
223*4882a593Smuzhiyun 	u32 val;
224*4882a593Smuzhiyun 
225*4882a593Smuzhiyun 	/*
226*4882a593Smuzhiyun 	 * Interrupts are directly handled by the device driver of the
227*4882a593Smuzhiyun 	 * PCI device. However, they are also latched into the PCIe
228*4882a593Smuzhiyun 	 * controller, so we simply discard them.
229*4882a593Smuzhiyun 	 */
230*4882a593Smuzhiyun 	val = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_INT_CAUSE1_REG);
231*4882a593Smuzhiyun 	dw_pcie_writel_dbi(pci, PCIE_GLOBAL_INT_CAUSE1_REG, val);
232*4882a593Smuzhiyun 
233*4882a593Smuzhiyun 	return IRQ_HANDLED;
234*4882a593Smuzhiyun }
235*4882a593Smuzhiyun 
236*4882a593Smuzhiyun static const struct dw_pcie_host_ops armada8k_pcie_host_ops = {
237*4882a593Smuzhiyun 	.host_init = armada8k_pcie_host_init,
238*4882a593Smuzhiyun };
239*4882a593Smuzhiyun 
armada8k_add_pcie_port(struct armada8k_pcie * pcie,struct platform_device * pdev)240*4882a593Smuzhiyun static int armada8k_add_pcie_port(struct armada8k_pcie *pcie,
241*4882a593Smuzhiyun 				  struct platform_device *pdev)
242*4882a593Smuzhiyun {
243*4882a593Smuzhiyun 	struct dw_pcie *pci = pcie->pci;
244*4882a593Smuzhiyun 	struct pcie_port *pp = &pci->pp;
245*4882a593Smuzhiyun 	struct device *dev = &pdev->dev;
246*4882a593Smuzhiyun 	int ret;
247*4882a593Smuzhiyun 
248*4882a593Smuzhiyun 	pp->ops = &armada8k_pcie_host_ops;
249*4882a593Smuzhiyun 
250*4882a593Smuzhiyun 	pp->irq = platform_get_irq(pdev, 0);
251*4882a593Smuzhiyun 	if (pp->irq < 0)
252*4882a593Smuzhiyun 		return pp->irq;
253*4882a593Smuzhiyun 
254*4882a593Smuzhiyun 	ret = devm_request_irq(dev, pp->irq, armada8k_pcie_irq_handler,
255*4882a593Smuzhiyun 			       IRQF_SHARED, "armada8k-pcie", pcie);
256*4882a593Smuzhiyun 	if (ret) {
257*4882a593Smuzhiyun 		dev_err(dev, "failed to request irq %d\n", pp->irq);
258*4882a593Smuzhiyun 		return ret;
259*4882a593Smuzhiyun 	}
260*4882a593Smuzhiyun 
261*4882a593Smuzhiyun 	ret = dw_pcie_host_init(pp);
262*4882a593Smuzhiyun 	if (ret) {
263*4882a593Smuzhiyun 		dev_err(dev, "failed to initialize host: %d\n", ret);
264*4882a593Smuzhiyun 		return ret;
265*4882a593Smuzhiyun 	}
266*4882a593Smuzhiyun 
267*4882a593Smuzhiyun 	return 0;
268*4882a593Smuzhiyun }
269*4882a593Smuzhiyun 
270*4882a593Smuzhiyun static const struct dw_pcie_ops dw_pcie_ops = {
271*4882a593Smuzhiyun 	.link_up = armada8k_pcie_link_up,
272*4882a593Smuzhiyun };
273*4882a593Smuzhiyun 
armada8k_pcie_probe(struct platform_device * pdev)274*4882a593Smuzhiyun static int armada8k_pcie_probe(struct platform_device *pdev)
275*4882a593Smuzhiyun {
276*4882a593Smuzhiyun 	struct dw_pcie *pci;
277*4882a593Smuzhiyun 	struct armada8k_pcie *pcie;
278*4882a593Smuzhiyun 	struct device *dev = &pdev->dev;
279*4882a593Smuzhiyun 	struct resource *base;
280*4882a593Smuzhiyun 	int ret;
281*4882a593Smuzhiyun 
282*4882a593Smuzhiyun 	pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
283*4882a593Smuzhiyun 	if (!pcie)
284*4882a593Smuzhiyun 		return -ENOMEM;
285*4882a593Smuzhiyun 
286*4882a593Smuzhiyun 	pci = devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL);
287*4882a593Smuzhiyun 	if (!pci)
288*4882a593Smuzhiyun 		return -ENOMEM;
289*4882a593Smuzhiyun 
290*4882a593Smuzhiyun 	pci->dev = dev;
291*4882a593Smuzhiyun 	pci->ops = &dw_pcie_ops;
292*4882a593Smuzhiyun 
293*4882a593Smuzhiyun 	pcie->pci = pci;
294*4882a593Smuzhiyun 
295*4882a593Smuzhiyun 	pcie->clk = devm_clk_get(dev, NULL);
296*4882a593Smuzhiyun 	if (IS_ERR(pcie->clk))
297*4882a593Smuzhiyun 		return PTR_ERR(pcie->clk);
298*4882a593Smuzhiyun 
299*4882a593Smuzhiyun 	ret = clk_prepare_enable(pcie->clk);
300*4882a593Smuzhiyun 	if (ret)
301*4882a593Smuzhiyun 		return ret;
302*4882a593Smuzhiyun 
303*4882a593Smuzhiyun 	pcie->clk_reg = devm_clk_get(dev, "reg");
304*4882a593Smuzhiyun 	if (pcie->clk_reg == ERR_PTR(-EPROBE_DEFER)) {
305*4882a593Smuzhiyun 		ret = -EPROBE_DEFER;
306*4882a593Smuzhiyun 		goto fail;
307*4882a593Smuzhiyun 	}
308*4882a593Smuzhiyun 	if (!IS_ERR(pcie->clk_reg)) {
309*4882a593Smuzhiyun 		ret = clk_prepare_enable(pcie->clk_reg);
310*4882a593Smuzhiyun 		if (ret)
311*4882a593Smuzhiyun 			goto fail_clkreg;
312*4882a593Smuzhiyun 	}
313*4882a593Smuzhiyun 
314*4882a593Smuzhiyun 	/* Get the dw-pcie unit configuration/control registers base. */
315*4882a593Smuzhiyun 	base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");
316*4882a593Smuzhiyun 	pci->dbi_base = devm_pci_remap_cfg_resource(dev, base);
317*4882a593Smuzhiyun 	if (IS_ERR(pci->dbi_base)) {
318*4882a593Smuzhiyun 		ret = PTR_ERR(pci->dbi_base);
319*4882a593Smuzhiyun 		goto fail_clkreg;
320*4882a593Smuzhiyun 	}
321*4882a593Smuzhiyun 
322*4882a593Smuzhiyun 	ret = armada8k_pcie_setup_phys(pcie);
323*4882a593Smuzhiyun 	if (ret)
324*4882a593Smuzhiyun 		goto fail_clkreg;
325*4882a593Smuzhiyun 
326*4882a593Smuzhiyun 	platform_set_drvdata(pdev, pcie);
327*4882a593Smuzhiyun 
328*4882a593Smuzhiyun 	ret = armada8k_add_pcie_port(pcie, pdev);
329*4882a593Smuzhiyun 	if (ret)
330*4882a593Smuzhiyun 		goto disable_phy;
331*4882a593Smuzhiyun 
332*4882a593Smuzhiyun 	return 0;
333*4882a593Smuzhiyun 
334*4882a593Smuzhiyun disable_phy:
335*4882a593Smuzhiyun 	armada8k_pcie_disable_phys(pcie);
336*4882a593Smuzhiyun fail_clkreg:
337*4882a593Smuzhiyun 	clk_disable_unprepare(pcie->clk_reg);
338*4882a593Smuzhiyun fail:
339*4882a593Smuzhiyun 	clk_disable_unprepare(pcie->clk);
340*4882a593Smuzhiyun 
341*4882a593Smuzhiyun 	return ret;
342*4882a593Smuzhiyun }
343*4882a593Smuzhiyun 
344*4882a593Smuzhiyun static const struct of_device_id armada8k_pcie_of_match[] = {
345*4882a593Smuzhiyun 	{ .compatible = "marvell,armada8k-pcie", },
346*4882a593Smuzhiyun 	{},
347*4882a593Smuzhiyun };
348*4882a593Smuzhiyun 
349*4882a593Smuzhiyun static struct platform_driver armada8k_pcie_driver = {
350*4882a593Smuzhiyun 	.probe		= armada8k_pcie_probe,
351*4882a593Smuzhiyun 	.driver = {
352*4882a593Smuzhiyun 		.name	= "armada8k-pcie",
353*4882a593Smuzhiyun 		.of_match_table = of_match_ptr(armada8k_pcie_of_match),
354*4882a593Smuzhiyun 		.suppress_bind_attrs = true,
355*4882a593Smuzhiyun 	},
356*4882a593Smuzhiyun };
357*4882a593Smuzhiyun builtin_platform_driver(armada8k_pcie_driver);
358