xref: /OK3568_Linux_fs/kernel/drivers/irqchip/irq-gic-v3-mbi.c (revision 4882a59341e53eb6f0b4789bf948001014eff981)
1*4882a593Smuzhiyun // SPDX-License-Identifier: GPL-2.0
2*4882a593Smuzhiyun /*
3*4882a593Smuzhiyun  * Copyright (C) 2018 ARM Limited, All Rights Reserved.
4*4882a593Smuzhiyun  * Author: Marc Zyngier <marc.zyngier@arm.com>
5*4882a593Smuzhiyun  */
6*4882a593Smuzhiyun 
7*4882a593Smuzhiyun #define pr_fmt(fmt) "GICv3: " fmt
8*4882a593Smuzhiyun 
9*4882a593Smuzhiyun #include <linux/dma-iommu.h>
10*4882a593Smuzhiyun #include <linux/irq.h>
11*4882a593Smuzhiyun #include <linux/irqdomain.h>
12*4882a593Smuzhiyun #include <linux/kernel.h>
13*4882a593Smuzhiyun #include <linux/msi.h>
14*4882a593Smuzhiyun #include <linux/of_address.h>
15*4882a593Smuzhiyun #include <linux/of_pci.h>
16*4882a593Smuzhiyun #include <linux/slab.h>
17*4882a593Smuzhiyun #include <linux/spinlock.h>
18*4882a593Smuzhiyun 
19*4882a593Smuzhiyun #include <linux/irqchip/arm-gic-v3.h>
20*4882a593Smuzhiyun 
21*4882a593Smuzhiyun struct mbi_range {
22*4882a593Smuzhiyun 	u32			spi_start;
23*4882a593Smuzhiyun 	u32			nr_spis;
24*4882a593Smuzhiyun 	unsigned long		*bm;
25*4882a593Smuzhiyun };
26*4882a593Smuzhiyun 
27*4882a593Smuzhiyun static DEFINE_MUTEX(mbi_lock);
28*4882a593Smuzhiyun static phys_addr_t		mbi_phys_base;
29*4882a593Smuzhiyun static struct mbi_range		*mbi_ranges;
30*4882a593Smuzhiyun static unsigned int		mbi_range_nr;
31*4882a593Smuzhiyun 
32*4882a593Smuzhiyun static struct irq_chip mbi_irq_chip = {
33*4882a593Smuzhiyun 	.name			= "MBI",
34*4882a593Smuzhiyun 	.irq_mask		= irq_chip_mask_parent,
35*4882a593Smuzhiyun 	.irq_unmask		= irq_chip_unmask_parent,
36*4882a593Smuzhiyun 	.irq_eoi		= irq_chip_eoi_parent,
37*4882a593Smuzhiyun 	.irq_set_type		= irq_chip_set_type_parent,
38*4882a593Smuzhiyun 	.irq_set_affinity	= irq_chip_set_affinity_parent,
39*4882a593Smuzhiyun };
40*4882a593Smuzhiyun 
mbi_irq_gic_domain_alloc(struct irq_domain * domain,unsigned int virq,irq_hw_number_t hwirq)41*4882a593Smuzhiyun static int mbi_irq_gic_domain_alloc(struct irq_domain *domain,
42*4882a593Smuzhiyun 				       unsigned int virq,
43*4882a593Smuzhiyun 				       irq_hw_number_t hwirq)
44*4882a593Smuzhiyun {
45*4882a593Smuzhiyun 	struct irq_fwspec fwspec;
46*4882a593Smuzhiyun 	struct irq_data *d;
47*4882a593Smuzhiyun 	int err;
48*4882a593Smuzhiyun 
49*4882a593Smuzhiyun 	/*
50*4882a593Smuzhiyun 	 * Using ACPI? There is no MBI support in the spec, you
51*4882a593Smuzhiyun 	 * shouldn't even be here.
52*4882a593Smuzhiyun 	 */
53*4882a593Smuzhiyun 	if (!is_of_node(domain->parent->fwnode))
54*4882a593Smuzhiyun 		return -EINVAL;
55*4882a593Smuzhiyun 
56*4882a593Smuzhiyun 	/*
57*4882a593Smuzhiyun 	 * Let's default to edge. This is consistent with traditional
58*4882a593Smuzhiyun 	 * MSIs, and systems requiring level signaling will just
59*4882a593Smuzhiyun 	 * enforce the trigger on their own.
60*4882a593Smuzhiyun 	 */
61*4882a593Smuzhiyun 	fwspec.fwnode = domain->parent->fwnode;
62*4882a593Smuzhiyun 	fwspec.param_count = 3;
63*4882a593Smuzhiyun 	fwspec.param[0] = 0;
64*4882a593Smuzhiyun 	fwspec.param[1] = hwirq - 32;
65*4882a593Smuzhiyun 	fwspec.param[2] = IRQ_TYPE_EDGE_RISING;
66*4882a593Smuzhiyun 
67*4882a593Smuzhiyun 	err = irq_domain_alloc_irqs_parent(domain, virq, 1, &fwspec);
68*4882a593Smuzhiyun 	if (err)
69*4882a593Smuzhiyun 		return err;
70*4882a593Smuzhiyun 
71*4882a593Smuzhiyun 	d = irq_domain_get_irq_data(domain->parent, virq);
72*4882a593Smuzhiyun 	return d->chip->irq_set_type(d, IRQ_TYPE_EDGE_RISING);
73*4882a593Smuzhiyun }
74*4882a593Smuzhiyun 
mbi_free_msi(struct mbi_range * mbi,unsigned int hwirq,int nr_irqs)75*4882a593Smuzhiyun static void mbi_free_msi(struct mbi_range *mbi, unsigned int hwirq,
76*4882a593Smuzhiyun 			 int nr_irqs)
77*4882a593Smuzhiyun {
78*4882a593Smuzhiyun 	mutex_lock(&mbi_lock);
79*4882a593Smuzhiyun 	bitmap_release_region(mbi->bm, hwirq - mbi->spi_start,
80*4882a593Smuzhiyun 			      get_count_order(nr_irqs));
81*4882a593Smuzhiyun 	mutex_unlock(&mbi_lock);
82*4882a593Smuzhiyun }
83*4882a593Smuzhiyun 
mbi_irq_domain_alloc(struct irq_domain * domain,unsigned int virq,unsigned int nr_irqs,void * args)84*4882a593Smuzhiyun static int mbi_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
85*4882a593Smuzhiyun 				   unsigned int nr_irqs, void *args)
86*4882a593Smuzhiyun {
87*4882a593Smuzhiyun 	msi_alloc_info_t *info = args;
88*4882a593Smuzhiyun 	struct mbi_range *mbi = NULL;
89*4882a593Smuzhiyun 	int hwirq, offset, i, err = 0;
90*4882a593Smuzhiyun 
91*4882a593Smuzhiyun 	mutex_lock(&mbi_lock);
92*4882a593Smuzhiyun 	for (i = 0; i < mbi_range_nr; i++) {
93*4882a593Smuzhiyun 		offset = bitmap_find_free_region(mbi_ranges[i].bm,
94*4882a593Smuzhiyun 						 mbi_ranges[i].nr_spis,
95*4882a593Smuzhiyun 						 get_count_order(nr_irqs));
96*4882a593Smuzhiyun 		if (offset >= 0) {
97*4882a593Smuzhiyun 			mbi = &mbi_ranges[i];
98*4882a593Smuzhiyun 			break;
99*4882a593Smuzhiyun 		}
100*4882a593Smuzhiyun 	}
101*4882a593Smuzhiyun 	mutex_unlock(&mbi_lock);
102*4882a593Smuzhiyun 
103*4882a593Smuzhiyun 	if (!mbi)
104*4882a593Smuzhiyun 		return -ENOSPC;
105*4882a593Smuzhiyun 
106*4882a593Smuzhiyun 	hwirq = mbi->spi_start + offset;
107*4882a593Smuzhiyun 
108*4882a593Smuzhiyun 	err = iommu_dma_prepare_msi(info->desc,
109*4882a593Smuzhiyun 				    mbi_phys_base + GICD_SETSPI_NSR);
110*4882a593Smuzhiyun 	if (err)
111*4882a593Smuzhiyun 		return err;
112*4882a593Smuzhiyun 
113*4882a593Smuzhiyun 	for (i = 0; i < nr_irqs; i++) {
114*4882a593Smuzhiyun 		err = mbi_irq_gic_domain_alloc(domain, virq + i, hwirq + i);
115*4882a593Smuzhiyun 		if (err)
116*4882a593Smuzhiyun 			goto fail;
117*4882a593Smuzhiyun 
118*4882a593Smuzhiyun 		irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i,
119*4882a593Smuzhiyun 					      &mbi_irq_chip, mbi);
120*4882a593Smuzhiyun 	}
121*4882a593Smuzhiyun 
122*4882a593Smuzhiyun 	return 0;
123*4882a593Smuzhiyun 
124*4882a593Smuzhiyun fail:
125*4882a593Smuzhiyun 	irq_domain_free_irqs_parent(domain, virq, nr_irqs);
126*4882a593Smuzhiyun 	mbi_free_msi(mbi, hwirq, nr_irqs);
127*4882a593Smuzhiyun 	return err;
128*4882a593Smuzhiyun }
129*4882a593Smuzhiyun 
mbi_irq_domain_free(struct irq_domain * domain,unsigned int virq,unsigned int nr_irqs)130*4882a593Smuzhiyun static void mbi_irq_domain_free(struct irq_domain *domain,
131*4882a593Smuzhiyun 				unsigned int virq, unsigned int nr_irqs)
132*4882a593Smuzhiyun {
133*4882a593Smuzhiyun 	struct irq_data *d = irq_domain_get_irq_data(domain, virq);
134*4882a593Smuzhiyun 	struct mbi_range *mbi = irq_data_get_irq_chip_data(d);
135*4882a593Smuzhiyun 
136*4882a593Smuzhiyun 	mbi_free_msi(mbi, d->hwirq, nr_irqs);
137*4882a593Smuzhiyun 	irq_domain_free_irqs_parent(domain, virq, nr_irqs);
138*4882a593Smuzhiyun }
139*4882a593Smuzhiyun 
140*4882a593Smuzhiyun static const struct irq_domain_ops mbi_domain_ops = {
141*4882a593Smuzhiyun 	.alloc			= mbi_irq_domain_alloc,
142*4882a593Smuzhiyun 	.free			= mbi_irq_domain_free,
143*4882a593Smuzhiyun };
144*4882a593Smuzhiyun 
mbi_compose_msi_msg(struct irq_data * data,struct msi_msg * msg)145*4882a593Smuzhiyun static void mbi_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
146*4882a593Smuzhiyun {
147*4882a593Smuzhiyun 	msg[0].address_hi = upper_32_bits(mbi_phys_base + GICD_SETSPI_NSR);
148*4882a593Smuzhiyun 	msg[0].address_lo = lower_32_bits(mbi_phys_base + GICD_SETSPI_NSR);
149*4882a593Smuzhiyun 	msg[0].data = data->parent_data->hwirq;
150*4882a593Smuzhiyun 
151*4882a593Smuzhiyun 	iommu_dma_compose_msi_msg(irq_data_get_msi_desc(data), msg);
152*4882a593Smuzhiyun }
153*4882a593Smuzhiyun 
154*4882a593Smuzhiyun #ifdef CONFIG_PCI_MSI
155*4882a593Smuzhiyun /* PCI-specific irqchip */
mbi_mask_msi_irq(struct irq_data * d)156*4882a593Smuzhiyun static void mbi_mask_msi_irq(struct irq_data *d)
157*4882a593Smuzhiyun {
158*4882a593Smuzhiyun 	pci_msi_mask_irq(d);
159*4882a593Smuzhiyun 	irq_chip_mask_parent(d);
160*4882a593Smuzhiyun }
161*4882a593Smuzhiyun 
mbi_unmask_msi_irq(struct irq_data * d)162*4882a593Smuzhiyun static void mbi_unmask_msi_irq(struct irq_data *d)
163*4882a593Smuzhiyun {
164*4882a593Smuzhiyun 	pci_msi_unmask_irq(d);
165*4882a593Smuzhiyun 	irq_chip_unmask_parent(d);
166*4882a593Smuzhiyun }
167*4882a593Smuzhiyun 
168*4882a593Smuzhiyun static struct irq_chip mbi_msi_irq_chip = {
169*4882a593Smuzhiyun 	.name			= "MSI",
170*4882a593Smuzhiyun 	.irq_mask		= mbi_mask_msi_irq,
171*4882a593Smuzhiyun 	.irq_unmask		= mbi_unmask_msi_irq,
172*4882a593Smuzhiyun 	.irq_eoi		= irq_chip_eoi_parent,
173*4882a593Smuzhiyun 	.irq_compose_msi_msg	= mbi_compose_msi_msg,
174*4882a593Smuzhiyun 	.irq_write_msi_msg	= pci_msi_domain_write_msg,
175*4882a593Smuzhiyun };
176*4882a593Smuzhiyun 
177*4882a593Smuzhiyun static struct msi_domain_info mbi_msi_domain_info = {
178*4882a593Smuzhiyun 	.flags	= (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
179*4882a593Smuzhiyun 		   MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI),
180*4882a593Smuzhiyun 	.chip	= &mbi_msi_irq_chip,
181*4882a593Smuzhiyun };
182*4882a593Smuzhiyun 
mbi_allocate_pci_domain(struct irq_domain * nexus_domain,struct irq_domain ** pci_domain)183*4882a593Smuzhiyun static int mbi_allocate_pci_domain(struct irq_domain *nexus_domain,
184*4882a593Smuzhiyun 				   struct irq_domain **pci_domain)
185*4882a593Smuzhiyun {
186*4882a593Smuzhiyun 	*pci_domain = pci_msi_create_irq_domain(nexus_domain->parent->fwnode,
187*4882a593Smuzhiyun 						&mbi_msi_domain_info,
188*4882a593Smuzhiyun 						nexus_domain);
189*4882a593Smuzhiyun 	if (!*pci_domain)
190*4882a593Smuzhiyun 		return -ENOMEM;
191*4882a593Smuzhiyun 
192*4882a593Smuzhiyun 	return 0;
193*4882a593Smuzhiyun }
194*4882a593Smuzhiyun #else
mbi_allocate_pci_domain(struct irq_domain * nexus_domain,struct irq_domain ** pci_domain)195*4882a593Smuzhiyun static int mbi_allocate_pci_domain(struct irq_domain *nexus_domain,
196*4882a593Smuzhiyun 				   struct irq_domain **pci_domain)
197*4882a593Smuzhiyun {
198*4882a593Smuzhiyun 	*pci_domain = NULL;
199*4882a593Smuzhiyun 	return 0;
200*4882a593Smuzhiyun }
201*4882a593Smuzhiyun #endif
202*4882a593Smuzhiyun 
mbi_compose_mbi_msg(struct irq_data * data,struct msi_msg * msg)203*4882a593Smuzhiyun static void mbi_compose_mbi_msg(struct irq_data *data, struct msi_msg *msg)
204*4882a593Smuzhiyun {
205*4882a593Smuzhiyun 	mbi_compose_msi_msg(data, msg);
206*4882a593Smuzhiyun 
207*4882a593Smuzhiyun 	msg[1].address_hi = upper_32_bits(mbi_phys_base + GICD_CLRSPI_NSR);
208*4882a593Smuzhiyun 	msg[1].address_lo = lower_32_bits(mbi_phys_base + GICD_CLRSPI_NSR);
209*4882a593Smuzhiyun 	msg[1].data = data->parent_data->hwirq;
210*4882a593Smuzhiyun 
211*4882a593Smuzhiyun 	iommu_dma_compose_msi_msg(irq_data_get_msi_desc(data), &msg[1]);
212*4882a593Smuzhiyun }
213*4882a593Smuzhiyun 
214*4882a593Smuzhiyun /* Platform-MSI specific irqchip */
215*4882a593Smuzhiyun static struct irq_chip mbi_pmsi_irq_chip = {
216*4882a593Smuzhiyun 	.name			= "pMSI",
217*4882a593Smuzhiyun 	.irq_set_type		= irq_chip_set_type_parent,
218*4882a593Smuzhiyun 	.irq_compose_msi_msg	= mbi_compose_mbi_msg,
219*4882a593Smuzhiyun 	.flags			= IRQCHIP_SUPPORTS_LEVEL_MSI,
220*4882a593Smuzhiyun };
221*4882a593Smuzhiyun 
222*4882a593Smuzhiyun static struct msi_domain_ops mbi_pmsi_ops = {
223*4882a593Smuzhiyun };
224*4882a593Smuzhiyun 
225*4882a593Smuzhiyun static struct msi_domain_info mbi_pmsi_domain_info = {
226*4882a593Smuzhiyun 	.flags	= (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
227*4882a593Smuzhiyun 		   MSI_FLAG_LEVEL_CAPABLE),
228*4882a593Smuzhiyun 	.ops	= &mbi_pmsi_ops,
229*4882a593Smuzhiyun 	.chip	= &mbi_pmsi_irq_chip,
230*4882a593Smuzhiyun };
231*4882a593Smuzhiyun 
mbi_allocate_domains(struct irq_domain * parent)232*4882a593Smuzhiyun static int mbi_allocate_domains(struct irq_domain *parent)
233*4882a593Smuzhiyun {
234*4882a593Smuzhiyun 	struct irq_domain *nexus_domain, *pci_domain, *plat_domain;
235*4882a593Smuzhiyun 	int err;
236*4882a593Smuzhiyun 
237*4882a593Smuzhiyun 	nexus_domain = irq_domain_create_tree(parent->fwnode,
238*4882a593Smuzhiyun 					      &mbi_domain_ops, NULL);
239*4882a593Smuzhiyun 	if (!nexus_domain)
240*4882a593Smuzhiyun 		return -ENOMEM;
241*4882a593Smuzhiyun 
242*4882a593Smuzhiyun 	irq_domain_update_bus_token(nexus_domain, DOMAIN_BUS_NEXUS);
243*4882a593Smuzhiyun 	nexus_domain->parent = parent;
244*4882a593Smuzhiyun 
245*4882a593Smuzhiyun 	err = mbi_allocate_pci_domain(nexus_domain, &pci_domain);
246*4882a593Smuzhiyun 
247*4882a593Smuzhiyun 	plat_domain = platform_msi_create_irq_domain(parent->fwnode,
248*4882a593Smuzhiyun 						     &mbi_pmsi_domain_info,
249*4882a593Smuzhiyun 						     nexus_domain);
250*4882a593Smuzhiyun 
251*4882a593Smuzhiyun 	if (err || !plat_domain) {
252*4882a593Smuzhiyun 		if (plat_domain)
253*4882a593Smuzhiyun 			irq_domain_remove(plat_domain);
254*4882a593Smuzhiyun 		if (pci_domain)
255*4882a593Smuzhiyun 			irq_domain_remove(pci_domain);
256*4882a593Smuzhiyun 		irq_domain_remove(nexus_domain);
257*4882a593Smuzhiyun 		return -ENOMEM;
258*4882a593Smuzhiyun 	}
259*4882a593Smuzhiyun 
260*4882a593Smuzhiyun 	return 0;
261*4882a593Smuzhiyun }
262*4882a593Smuzhiyun 
mbi_init(struct fwnode_handle * fwnode,struct irq_domain * parent)263*4882a593Smuzhiyun int __init mbi_init(struct fwnode_handle *fwnode, struct irq_domain *parent)
264*4882a593Smuzhiyun {
265*4882a593Smuzhiyun 	struct device_node *np;
266*4882a593Smuzhiyun 	const __be32 *reg;
267*4882a593Smuzhiyun 	int ret, n;
268*4882a593Smuzhiyun 
269*4882a593Smuzhiyun 	np = to_of_node(fwnode);
270*4882a593Smuzhiyun 
271*4882a593Smuzhiyun 	if (!of_property_read_bool(np, "msi-controller"))
272*4882a593Smuzhiyun 		return 0;
273*4882a593Smuzhiyun 
274*4882a593Smuzhiyun 	n = of_property_count_elems_of_size(np, "mbi-ranges", sizeof(u32));
275*4882a593Smuzhiyun 	if (n <= 0 || n % 2)
276*4882a593Smuzhiyun 		return -EINVAL;
277*4882a593Smuzhiyun 
278*4882a593Smuzhiyun 	mbi_range_nr = n / 2;
279*4882a593Smuzhiyun 	mbi_ranges = kcalloc(mbi_range_nr, sizeof(*mbi_ranges), GFP_KERNEL);
280*4882a593Smuzhiyun 	if (!mbi_ranges)
281*4882a593Smuzhiyun 		return -ENOMEM;
282*4882a593Smuzhiyun 
283*4882a593Smuzhiyun 	for (n = 0; n < mbi_range_nr; n++) {
284*4882a593Smuzhiyun 		ret = of_property_read_u32_index(np, "mbi-ranges", n * 2,
285*4882a593Smuzhiyun 						 &mbi_ranges[n].spi_start);
286*4882a593Smuzhiyun 		if (ret)
287*4882a593Smuzhiyun 			goto err_free_mbi;
288*4882a593Smuzhiyun 		ret = of_property_read_u32_index(np, "mbi-ranges", n * 2 + 1,
289*4882a593Smuzhiyun 						 &mbi_ranges[n].nr_spis);
290*4882a593Smuzhiyun 		if (ret)
291*4882a593Smuzhiyun 			goto err_free_mbi;
292*4882a593Smuzhiyun 
293*4882a593Smuzhiyun 		mbi_ranges[n].bm = kcalloc(BITS_TO_LONGS(mbi_ranges[n].nr_spis),
294*4882a593Smuzhiyun 					   sizeof(long), GFP_KERNEL);
295*4882a593Smuzhiyun 		if (!mbi_ranges[n].bm) {
296*4882a593Smuzhiyun 			ret = -ENOMEM;
297*4882a593Smuzhiyun 			goto err_free_mbi;
298*4882a593Smuzhiyun 		}
299*4882a593Smuzhiyun 		pr_info("MBI range [%d:%d]\n", mbi_ranges[n].spi_start,
300*4882a593Smuzhiyun 			mbi_ranges[n].spi_start + mbi_ranges[n].nr_spis - 1);
301*4882a593Smuzhiyun 	}
302*4882a593Smuzhiyun 
303*4882a593Smuzhiyun 	reg = of_get_property(np, "mbi-alias", NULL);
304*4882a593Smuzhiyun 	if (reg) {
305*4882a593Smuzhiyun 		mbi_phys_base = of_translate_address(np, reg);
306*4882a593Smuzhiyun 		if (mbi_phys_base == (phys_addr_t)OF_BAD_ADDR) {
307*4882a593Smuzhiyun 			ret = -ENXIO;
308*4882a593Smuzhiyun 			goto err_free_mbi;
309*4882a593Smuzhiyun 		}
310*4882a593Smuzhiyun 	} else {
311*4882a593Smuzhiyun 		struct resource res;
312*4882a593Smuzhiyun 
313*4882a593Smuzhiyun 		if (of_address_to_resource(np, 0, &res)) {
314*4882a593Smuzhiyun 			ret = -ENXIO;
315*4882a593Smuzhiyun 			goto err_free_mbi;
316*4882a593Smuzhiyun 		}
317*4882a593Smuzhiyun 
318*4882a593Smuzhiyun 		mbi_phys_base = res.start;
319*4882a593Smuzhiyun 	}
320*4882a593Smuzhiyun 
321*4882a593Smuzhiyun 	pr_info("Using MBI frame %pa\n", &mbi_phys_base);
322*4882a593Smuzhiyun 
323*4882a593Smuzhiyun 	ret = mbi_allocate_domains(parent);
324*4882a593Smuzhiyun 	if (ret)
325*4882a593Smuzhiyun 		goto err_free_mbi;
326*4882a593Smuzhiyun 
327*4882a593Smuzhiyun 	return 0;
328*4882a593Smuzhiyun 
329*4882a593Smuzhiyun err_free_mbi:
330*4882a593Smuzhiyun 	if (mbi_ranges) {
331*4882a593Smuzhiyun 		for (n = 0; n < mbi_range_nr; n++)
332*4882a593Smuzhiyun 			kfree(mbi_ranges[n].bm);
333*4882a593Smuzhiyun 		kfree(mbi_ranges);
334*4882a593Smuzhiyun 	}
335*4882a593Smuzhiyun 
336*4882a593Smuzhiyun 	return ret;
337*4882a593Smuzhiyun }
338