xref: /OK3568_Linux_fs/kernel/drivers/gpu/drm/tilcdc/tilcdc_panel.c (revision 4882a59341e53eb6f0b4789bf948001014eff981)
1*4882a593Smuzhiyun // SPDX-License-Identifier: GPL-2.0-only
2*4882a593Smuzhiyun /*
3*4882a593Smuzhiyun  * Copyright (C) 2012 Texas Instruments
4*4882a593Smuzhiyun  * Author: Rob Clark <robdclark@gmail.com>
5*4882a593Smuzhiyun  */
6*4882a593Smuzhiyun 
7*4882a593Smuzhiyun #include <linux/gpio/consumer.h>
8*4882a593Smuzhiyun #include <linux/pinctrl/consumer.h>
9*4882a593Smuzhiyun #include <linux/platform_device.h>
10*4882a593Smuzhiyun 
11*4882a593Smuzhiyun #include <video/display_timing.h>
12*4882a593Smuzhiyun #include <video/of_display_timing.h>
13*4882a593Smuzhiyun #include <video/videomode.h>
14*4882a593Smuzhiyun 
15*4882a593Smuzhiyun #include <drm/drm_atomic_state_helper.h>
16*4882a593Smuzhiyun #include <drm/drm_connector.h>
17*4882a593Smuzhiyun #include <drm/drm_modeset_helper_vtables.h>
18*4882a593Smuzhiyun #include <drm/drm_probe_helper.h>
19*4882a593Smuzhiyun #include <drm/drm_simple_kms_helper.h>
20*4882a593Smuzhiyun 
21*4882a593Smuzhiyun #include "tilcdc_drv.h"
22*4882a593Smuzhiyun #include "tilcdc_panel.h"
23*4882a593Smuzhiyun 
24*4882a593Smuzhiyun struct panel_module {
25*4882a593Smuzhiyun 	struct tilcdc_module base;
26*4882a593Smuzhiyun 	struct tilcdc_panel_info *info;
27*4882a593Smuzhiyun 	struct display_timings *timings;
28*4882a593Smuzhiyun 	struct backlight_device *backlight;
29*4882a593Smuzhiyun 	struct gpio_desc *enable_gpio;
30*4882a593Smuzhiyun };
31*4882a593Smuzhiyun #define to_panel_module(x) container_of(x, struct panel_module, base)
32*4882a593Smuzhiyun 
33*4882a593Smuzhiyun 
34*4882a593Smuzhiyun /*
35*4882a593Smuzhiyun  * Encoder:
36*4882a593Smuzhiyun  */
37*4882a593Smuzhiyun 
38*4882a593Smuzhiyun struct panel_encoder {
39*4882a593Smuzhiyun 	struct drm_encoder base;
40*4882a593Smuzhiyun 	struct panel_module *mod;
41*4882a593Smuzhiyun };
42*4882a593Smuzhiyun #define to_panel_encoder(x) container_of(x, struct panel_encoder, base)
43*4882a593Smuzhiyun 
panel_encoder_dpms(struct drm_encoder * encoder,int mode)44*4882a593Smuzhiyun static void panel_encoder_dpms(struct drm_encoder *encoder, int mode)
45*4882a593Smuzhiyun {
46*4882a593Smuzhiyun 	struct panel_encoder *panel_encoder = to_panel_encoder(encoder);
47*4882a593Smuzhiyun 	struct backlight_device *backlight = panel_encoder->mod->backlight;
48*4882a593Smuzhiyun 	struct gpio_desc *gpio = panel_encoder->mod->enable_gpio;
49*4882a593Smuzhiyun 
50*4882a593Smuzhiyun 	if (backlight) {
51*4882a593Smuzhiyun 		backlight->props.power = mode == DRM_MODE_DPMS_ON ?
52*4882a593Smuzhiyun 					 FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN;
53*4882a593Smuzhiyun 		backlight_update_status(backlight);
54*4882a593Smuzhiyun 	}
55*4882a593Smuzhiyun 
56*4882a593Smuzhiyun 	if (gpio)
57*4882a593Smuzhiyun 		gpiod_set_value_cansleep(gpio,
58*4882a593Smuzhiyun 					 mode == DRM_MODE_DPMS_ON ? 1 : 0);
59*4882a593Smuzhiyun }
60*4882a593Smuzhiyun 
panel_encoder_prepare(struct drm_encoder * encoder)61*4882a593Smuzhiyun static void panel_encoder_prepare(struct drm_encoder *encoder)
62*4882a593Smuzhiyun {
63*4882a593Smuzhiyun 	panel_encoder_dpms(encoder, DRM_MODE_DPMS_OFF);
64*4882a593Smuzhiyun }
65*4882a593Smuzhiyun 
panel_encoder_commit(struct drm_encoder * encoder)66*4882a593Smuzhiyun static void panel_encoder_commit(struct drm_encoder *encoder)
67*4882a593Smuzhiyun {
68*4882a593Smuzhiyun 	panel_encoder_dpms(encoder, DRM_MODE_DPMS_ON);
69*4882a593Smuzhiyun }
70*4882a593Smuzhiyun 
panel_encoder_mode_set(struct drm_encoder * encoder,struct drm_display_mode * mode,struct drm_display_mode * adjusted_mode)71*4882a593Smuzhiyun static void panel_encoder_mode_set(struct drm_encoder *encoder,
72*4882a593Smuzhiyun 		struct drm_display_mode *mode,
73*4882a593Smuzhiyun 		struct drm_display_mode *adjusted_mode)
74*4882a593Smuzhiyun {
75*4882a593Smuzhiyun 	/* nothing needed */
76*4882a593Smuzhiyun }
77*4882a593Smuzhiyun 
78*4882a593Smuzhiyun static const struct drm_encoder_helper_funcs panel_encoder_helper_funcs = {
79*4882a593Smuzhiyun 		.dpms           = panel_encoder_dpms,
80*4882a593Smuzhiyun 		.prepare        = panel_encoder_prepare,
81*4882a593Smuzhiyun 		.commit         = panel_encoder_commit,
82*4882a593Smuzhiyun 		.mode_set       = panel_encoder_mode_set,
83*4882a593Smuzhiyun };
84*4882a593Smuzhiyun 
panel_encoder_create(struct drm_device * dev,struct panel_module * mod)85*4882a593Smuzhiyun static struct drm_encoder *panel_encoder_create(struct drm_device *dev,
86*4882a593Smuzhiyun 		struct panel_module *mod)
87*4882a593Smuzhiyun {
88*4882a593Smuzhiyun 	struct panel_encoder *panel_encoder;
89*4882a593Smuzhiyun 	struct drm_encoder *encoder;
90*4882a593Smuzhiyun 	int ret;
91*4882a593Smuzhiyun 
92*4882a593Smuzhiyun 	panel_encoder = devm_kzalloc(dev->dev, sizeof(*panel_encoder),
93*4882a593Smuzhiyun 				     GFP_KERNEL);
94*4882a593Smuzhiyun 	if (!panel_encoder)
95*4882a593Smuzhiyun 		return NULL;
96*4882a593Smuzhiyun 
97*4882a593Smuzhiyun 	panel_encoder->mod = mod;
98*4882a593Smuzhiyun 
99*4882a593Smuzhiyun 	encoder = &panel_encoder->base;
100*4882a593Smuzhiyun 	encoder->possible_crtcs = 1;
101*4882a593Smuzhiyun 
102*4882a593Smuzhiyun 	ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_LVDS);
103*4882a593Smuzhiyun 	if (ret < 0)
104*4882a593Smuzhiyun 		goto fail;
105*4882a593Smuzhiyun 
106*4882a593Smuzhiyun 	drm_encoder_helper_add(encoder, &panel_encoder_helper_funcs);
107*4882a593Smuzhiyun 
108*4882a593Smuzhiyun 	return encoder;
109*4882a593Smuzhiyun 
110*4882a593Smuzhiyun fail:
111*4882a593Smuzhiyun 	drm_encoder_cleanup(encoder);
112*4882a593Smuzhiyun 	return NULL;
113*4882a593Smuzhiyun }
114*4882a593Smuzhiyun 
115*4882a593Smuzhiyun /*
116*4882a593Smuzhiyun  * Connector:
117*4882a593Smuzhiyun  */
118*4882a593Smuzhiyun 
119*4882a593Smuzhiyun struct panel_connector {
120*4882a593Smuzhiyun 	struct drm_connector base;
121*4882a593Smuzhiyun 
122*4882a593Smuzhiyun 	struct drm_encoder *encoder;  /* our connected encoder */
123*4882a593Smuzhiyun 	struct panel_module *mod;
124*4882a593Smuzhiyun };
125*4882a593Smuzhiyun #define to_panel_connector(x) container_of(x, struct panel_connector, base)
126*4882a593Smuzhiyun 
127*4882a593Smuzhiyun 
panel_connector_destroy(struct drm_connector * connector)128*4882a593Smuzhiyun static void panel_connector_destroy(struct drm_connector *connector)
129*4882a593Smuzhiyun {
130*4882a593Smuzhiyun 	drm_connector_unregister(connector);
131*4882a593Smuzhiyun 	drm_connector_cleanup(connector);
132*4882a593Smuzhiyun }
133*4882a593Smuzhiyun 
panel_connector_get_modes(struct drm_connector * connector)134*4882a593Smuzhiyun static int panel_connector_get_modes(struct drm_connector *connector)
135*4882a593Smuzhiyun {
136*4882a593Smuzhiyun 	struct drm_device *dev = connector->dev;
137*4882a593Smuzhiyun 	struct panel_connector *panel_connector = to_panel_connector(connector);
138*4882a593Smuzhiyun 	struct display_timings *timings = panel_connector->mod->timings;
139*4882a593Smuzhiyun 	int i;
140*4882a593Smuzhiyun 
141*4882a593Smuzhiyun 	for (i = 0; i < timings->num_timings; i++) {
142*4882a593Smuzhiyun 		struct drm_display_mode *mode;
143*4882a593Smuzhiyun 		struct videomode vm;
144*4882a593Smuzhiyun 
145*4882a593Smuzhiyun 		if (videomode_from_timings(timings, &vm, i))
146*4882a593Smuzhiyun 			break;
147*4882a593Smuzhiyun 
148*4882a593Smuzhiyun 		mode = drm_mode_create(dev);
149*4882a593Smuzhiyun 		if (!mode)
150*4882a593Smuzhiyun 			break;
151*4882a593Smuzhiyun 
152*4882a593Smuzhiyun 		drm_display_mode_from_videomode(&vm, mode);
153*4882a593Smuzhiyun 
154*4882a593Smuzhiyun 		mode->type = DRM_MODE_TYPE_DRIVER;
155*4882a593Smuzhiyun 
156*4882a593Smuzhiyun 		if (timings->native_mode == i)
157*4882a593Smuzhiyun 			mode->type |= DRM_MODE_TYPE_PREFERRED;
158*4882a593Smuzhiyun 
159*4882a593Smuzhiyun 		drm_mode_set_name(mode);
160*4882a593Smuzhiyun 		drm_mode_probed_add(connector, mode);
161*4882a593Smuzhiyun 	}
162*4882a593Smuzhiyun 
163*4882a593Smuzhiyun 	return i;
164*4882a593Smuzhiyun }
165*4882a593Smuzhiyun 
panel_connector_best_encoder(struct drm_connector * connector)166*4882a593Smuzhiyun static struct drm_encoder *panel_connector_best_encoder(
167*4882a593Smuzhiyun 		struct drm_connector *connector)
168*4882a593Smuzhiyun {
169*4882a593Smuzhiyun 	struct panel_connector *panel_connector = to_panel_connector(connector);
170*4882a593Smuzhiyun 	return panel_connector->encoder;
171*4882a593Smuzhiyun }
172*4882a593Smuzhiyun 
173*4882a593Smuzhiyun static const struct drm_connector_funcs panel_connector_funcs = {
174*4882a593Smuzhiyun 	.destroy            = panel_connector_destroy,
175*4882a593Smuzhiyun 	.fill_modes         = drm_helper_probe_single_connector_modes,
176*4882a593Smuzhiyun 	.reset              = drm_atomic_helper_connector_reset,
177*4882a593Smuzhiyun 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
178*4882a593Smuzhiyun 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
179*4882a593Smuzhiyun };
180*4882a593Smuzhiyun 
181*4882a593Smuzhiyun static const struct drm_connector_helper_funcs panel_connector_helper_funcs = {
182*4882a593Smuzhiyun 	.get_modes          = panel_connector_get_modes,
183*4882a593Smuzhiyun 	.best_encoder       = panel_connector_best_encoder,
184*4882a593Smuzhiyun };
185*4882a593Smuzhiyun 
panel_connector_create(struct drm_device * dev,struct panel_module * mod,struct drm_encoder * encoder)186*4882a593Smuzhiyun static struct drm_connector *panel_connector_create(struct drm_device *dev,
187*4882a593Smuzhiyun 		struct panel_module *mod, struct drm_encoder *encoder)
188*4882a593Smuzhiyun {
189*4882a593Smuzhiyun 	struct panel_connector *panel_connector;
190*4882a593Smuzhiyun 	struct drm_connector *connector;
191*4882a593Smuzhiyun 	int ret;
192*4882a593Smuzhiyun 
193*4882a593Smuzhiyun 	panel_connector = devm_kzalloc(dev->dev, sizeof(*panel_connector),
194*4882a593Smuzhiyun 				       GFP_KERNEL);
195*4882a593Smuzhiyun 	if (!panel_connector)
196*4882a593Smuzhiyun 		return NULL;
197*4882a593Smuzhiyun 
198*4882a593Smuzhiyun 	panel_connector->encoder = encoder;
199*4882a593Smuzhiyun 	panel_connector->mod = mod;
200*4882a593Smuzhiyun 
201*4882a593Smuzhiyun 	connector = &panel_connector->base;
202*4882a593Smuzhiyun 
203*4882a593Smuzhiyun 	drm_connector_init(dev, connector, &panel_connector_funcs,
204*4882a593Smuzhiyun 			DRM_MODE_CONNECTOR_LVDS);
205*4882a593Smuzhiyun 	drm_connector_helper_add(connector, &panel_connector_helper_funcs);
206*4882a593Smuzhiyun 
207*4882a593Smuzhiyun 	connector->interlace_allowed = 0;
208*4882a593Smuzhiyun 	connector->doublescan_allowed = 0;
209*4882a593Smuzhiyun 
210*4882a593Smuzhiyun 	ret = drm_connector_attach_encoder(connector, encoder);
211*4882a593Smuzhiyun 	if (ret)
212*4882a593Smuzhiyun 		goto fail;
213*4882a593Smuzhiyun 
214*4882a593Smuzhiyun 	return connector;
215*4882a593Smuzhiyun 
216*4882a593Smuzhiyun fail:
217*4882a593Smuzhiyun 	panel_connector_destroy(connector);
218*4882a593Smuzhiyun 	return NULL;
219*4882a593Smuzhiyun }
220*4882a593Smuzhiyun 
221*4882a593Smuzhiyun /*
222*4882a593Smuzhiyun  * Module:
223*4882a593Smuzhiyun  */
224*4882a593Smuzhiyun 
panel_modeset_init(struct tilcdc_module * mod,struct drm_device * dev)225*4882a593Smuzhiyun static int panel_modeset_init(struct tilcdc_module *mod, struct drm_device *dev)
226*4882a593Smuzhiyun {
227*4882a593Smuzhiyun 	struct panel_module *panel_mod = to_panel_module(mod);
228*4882a593Smuzhiyun 	struct tilcdc_drm_private *priv = dev->dev_private;
229*4882a593Smuzhiyun 	struct drm_encoder *encoder;
230*4882a593Smuzhiyun 	struct drm_connector *connector;
231*4882a593Smuzhiyun 
232*4882a593Smuzhiyun 	encoder = panel_encoder_create(dev, panel_mod);
233*4882a593Smuzhiyun 	if (!encoder)
234*4882a593Smuzhiyun 		return -ENOMEM;
235*4882a593Smuzhiyun 
236*4882a593Smuzhiyun 	connector = panel_connector_create(dev, panel_mod, encoder);
237*4882a593Smuzhiyun 	if (!connector)
238*4882a593Smuzhiyun 		return -ENOMEM;
239*4882a593Smuzhiyun 
240*4882a593Smuzhiyun 	priv->encoders[priv->num_encoders++] = encoder;
241*4882a593Smuzhiyun 	priv->connectors[priv->num_connectors++] = connector;
242*4882a593Smuzhiyun 
243*4882a593Smuzhiyun 	tilcdc_crtc_set_panel_info(priv->crtc,
244*4882a593Smuzhiyun 				   to_panel_encoder(encoder)->mod->info);
245*4882a593Smuzhiyun 
246*4882a593Smuzhiyun 	return 0;
247*4882a593Smuzhiyun }
248*4882a593Smuzhiyun 
249*4882a593Smuzhiyun static const struct tilcdc_module_ops panel_module_ops = {
250*4882a593Smuzhiyun 		.modeset_init = panel_modeset_init,
251*4882a593Smuzhiyun };
252*4882a593Smuzhiyun 
253*4882a593Smuzhiyun /*
254*4882a593Smuzhiyun  * Device:
255*4882a593Smuzhiyun  */
256*4882a593Smuzhiyun 
257*4882a593Smuzhiyun /* maybe move this somewhere common if it is needed by other outputs? */
of_get_panel_info(struct device_node * np)258*4882a593Smuzhiyun static struct tilcdc_panel_info *of_get_panel_info(struct device_node *np)
259*4882a593Smuzhiyun {
260*4882a593Smuzhiyun 	struct device_node *info_np;
261*4882a593Smuzhiyun 	struct tilcdc_panel_info *info;
262*4882a593Smuzhiyun 	int ret = 0;
263*4882a593Smuzhiyun 
264*4882a593Smuzhiyun 	if (!np) {
265*4882a593Smuzhiyun 		pr_err("%s: no devicenode given\n", __func__);
266*4882a593Smuzhiyun 		return NULL;
267*4882a593Smuzhiyun 	}
268*4882a593Smuzhiyun 
269*4882a593Smuzhiyun 	info_np = of_get_child_by_name(np, "panel-info");
270*4882a593Smuzhiyun 	if (!info_np) {
271*4882a593Smuzhiyun 		pr_err("%s: could not find panel-info node\n", __func__);
272*4882a593Smuzhiyun 		return NULL;
273*4882a593Smuzhiyun 	}
274*4882a593Smuzhiyun 
275*4882a593Smuzhiyun 	info = kzalloc(sizeof(*info), GFP_KERNEL);
276*4882a593Smuzhiyun 	if (!info)
277*4882a593Smuzhiyun 		goto put_node;
278*4882a593Smuzhiyun 
279*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "ac-bias", &info->ac_bias);
280*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "ac-bias-intrpt", &info->ac_bias_intrpt);
281*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "dma-burst-sz", &info->dma_burst_sz);
282*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "bpp", &info->bpp);
283*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "fdd", &info->fdd);
284*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "sync-edge", &info->sync_edge);
285*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "sync-ctrl", &info->sync_ctrl);
286*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "raster-order", &info->raster_order);
287*4882a593Smuzhiyun 	ret |= of_property_read_u32(info_np, "fifo-th", &info->fifo_th);
288*4882a593Smuzhiyun 
289*4882a593Smuzhiyun 	/* optional: */
290*4882a593Smuzhiyun 	info->tft_alt_mode      = of_property_read_bool(info_np, "tft-alt-mode");
291*4882a593Smuzhiyun 	info->invert_pxl_clk    = of_property_read_bool(info_np, "invert-pxl-clk");
292*4882a593Smuzhiyun 
293*4882a593Smuzhiyun 	if (ret) {
294*4882a593Smuzhiyun 		pr_err("%s: error reading panel-info properties\n", __func__);
295*4882a593Smuzhiyun 		kfree(info);
296*4882a593Smuzhiyun 		info = NULL;
297*4882a593Smuzhiyun 	}
298*4882a593Smuzhiyun 
299*4882a593Smuzhiyun put_node:
300*4882a593Smuzhiyun 	of_node_put(info_np);
301*4882a593Smuzhiyun 	return info;
302*4882a593Smuzhiyun }
303*4882a593Smuzhiyun 
panel_probe(struct platform_device * pdev)304*4882a593Smuzhiyun static int panel_probe(struct platform_device *pdev)
305*4882a593Smuzhiyun {
306*4882a593Smuzhiyun 	struct device_node *node = pdev->dev.of_node;
307*4882a593Smuzhiyun 	struct backlight_device *backlight;
308*4882a593Smuzhiyun 	struct panel_module *panel_mod;
309*4882a593Smuzhiyun 	struct tilcdc_module *mod;
310*4882a593Smuzhiyun 	struct pinctrl *pinctrl;
311*4882a593Smuzhiyun 	int ret;
312*4882a593Smuzhiyun 
313*4882a593Smuzhiyun 	/* bail out early if no DT data: */
314*4882a593Smuzhiyun 	if (!node) {
315*4882a593Smuzhiyun 		dev_err(&pdev->dev, "device-tree data is missing\n");
316*4882a593Smuzhiyun 		return -ENXIO;
317*4882a593Smuzhiyun 	}
318*4882a593Smuzhiyun 
319*4882a593Smuzhiyun 	panel_mod = devm_kzalloc(&pdev->dev, sizeof(*panel_mod), GFP_KERNEL);
320*4882a593Smuzhiyun 	if (!panel_mod)
321*4882a593Smuzhiyun 		return -ENOMEM;
322*4882a593Smuzhiyun 
323*4882a593Smuzhiyun 	backlight = devm_of_find_backlight(&pdev->dev);
324*4882a593Smuzhiyun 	if (IS_ERR(backlight))
325*4882a593Smuzhiyun 		return PTR_ERR(backlight);
326*4882a593Smuzhiyun 	panel_mod->backlight = backlight;
327*4882a593Smuzhiyun 
328*4882a593Smuzhiyun 	panel_mod->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
329*4882a593Smuzhiyun 							 GPIOD_OUT_LOW);
330*4882a593Smuzhiyun 	if (IS_ERR(panel_mod->enable_gpio)) {
331*4882a593Smuzhiyun 		ret = PTR_ERR(panel_mod->enable_gpio);
332*4882a593Smuzhiyun 		dev_err(&pdev->dev, "failed to request enable GPIO\n");
333*4882a593Smuzhiyun 		goto fail_backlight;
334*4882a593Smuzhiyun 	}
335*4882a593Smuzhiyun 
336*4882a593Smuzhiyun 	if (panel_mod->enable_gpio)
337*4882a593Smuzhiyun 		dev_info(&pdev->dev, "found enable GPIO\n");
338*4882a593Smuzhiyun 
339*4882a593Smuzhiyun 	mod = &panel_mod->base;
340*4882a593Smuzhiyun 	pdev->dev.platform_data = mod;
341*4882a593Smuzhiyun 
342*4882a593Smuzhiyun 	tilcdc_module_init(mod, "panel", &panel_module_ops);
343*4882a593Smuzhiyun 
344*4882a593Smuzhiyun 	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
345*4882a593Smuzhiyun 	if (IS_ERR(pinctrl))
346*4882a593Smuzhiyun 		dev_warn(&pdev->dev, "pins are not configured\n");
347*4882a593Smuzhiyun 
348*4882a593Smuzhiyun 	panel_mod->timings = of_get_display_timings(node);
349*4882a593Smuzhiyun 	if (!panel_mod->timings) {
350*4882a593Smuzhiyun 		dev_err(&pdev->dev, "could not get panel timings\n");
351*4882a593Smuzhiyun 		ret = -EINVAL;
352*4882a593Smuzhiyun 		goto fail_free;
353*4882a593Smuzhiyun 	}
354*4882a593Smuzhiyun 
355*4882a593Smuzhiyun 	panel_mod->info = of_get_panel_info(node);
356*4882a593Smuzhiyun 	if (!panel_mod->info) {
357*4882a593Smuzhiyun 		dev_err(&pdev->dev, "could not get panel info\n");
358*4882a593Smuzhiyun 		ret = -EINVAL;
359*4882a593Smuzhiyun 		goto fail_timings;
360*4882a593Smuzhiyun 	}
361*4882a593Smuzhiyun 
362*4882a593Smuzhiyun 	return 0;
363*4882a593Smuzhiyun 
364*4882a593Smuzhiyun fail_timings:
365*4882a593Smuzhiyun 	display_timings_release(panel_mod->timings);
366*4882a593Smuzhiyun 
367*4882a593Smuzhiyun fail_free:
368*4882a593Smuzhiyun 	tilcdc_module_cleanup(mod);
369*4882a593Smuzhiyun 
370*4882a593Smuzhiyun fail_backlight:
371*4882a593Smuzhiyun 	if (panel_mod->backlight)
372*4882a593Smuzhiyun 		put_device(&panel_mod->backlight->dev);
373*4882a593Smuzhiyun 	return ret;
374*4882a593Smuzhiyun }
375*4882a593Smuzhiyun 
panel_remove(struct platform_device * pdev)376*4882a593Smuzhiyun static int panel_remove(struct platform_device *pdev)
377*4882a593Smuzhiyun {
378*4882a593Smuzhiyun 	struct tilcdc_module *mod = dev_get_platdata(&pdev->dev);
379*4882a593Smuzhiyun 	struct panel_module *panel_mod = to_panel_module(mod);
380*4882a593Smuzhiyun 	struct backlight_device *backlight = panel_mod->backlight;
381*4882a593Smuzhiyun 
382*4882a593Smuzhiyun 	if (backlight)
383*4882a593Smuzhiyun 		put_device(&backlight->dev);
384*4882a593Smuzhiyun 
385*4882a593Smuzhiyun 	display_timings_release(panel_mod->timings);
386*4882a593Smuzhiyun 
387*4882a593Smuzhiyun 	tilcdc_module_cleanup(mod);
388*4882a593Smuzhiyun 	kfree(panel_mod->info);
389*4882a593Smuzhiyun 
390*4882a593Smuzhiyun 	return 0;
391*4882a593Smuzhiyun }
392*4882a593Smuzhiyun 
393*4882a593Smuzhiyun static const struct of_device_id panel_of_match[] = {
394*4882a593Smuzhiyun 		{ .compatible = "ti,tilcdc,panel", },
395*4882a593Smuzhiyun 		{ },
396*4882a593Smuzhiyun };
397*4882a593Smuzhiyun 
398*4882a593Smuzhiyun static struct platform_driver panel_driver = {
399*4882a593Smuzhiyun 	.probe = panel_probe,
400*4882a593Smuzhiyun 	.remove = panel_remove,
401*4882a593Smuzhiyun 	.driver = {
402*4882a593Smuzhiyun 		.owner = THIS_MODULE,
403*4882a593Smuzhiyun 		.name = "tilcdc-panel",
404*4882a593Smuzhiyun 		.of_match_table = panel_of_match,
405*4882a593Smuzhiyun 	},
406*4882a593Smuzhiyun };
407*4882a593Smuzhiyun 
tilcdc_panel_init(void)408*4882a593Smuzhiyun int __init tilcdc_panel_init(void)
409*4882a593Smuzhiyun {
410*4882a593Smuzhiyun 	return platform_driver_register(&panel_driver);
411*4882a593Smuzhiyun }
412*4882a593Smuzhiyun 
tilcdc_panel_fini(void)413*4882a593Smuzhiyun void __exit tilcdc_panel_fini(void)
414*4882a593Smuzhiyun {
415*4882a593Smuzhiyun 	platform_driver_unregister(&panel_driver);
416*4882a593Smuzhiyun }
417