1*4882a593SmuzhiyunFrom 3a77dfc54271059dcac305384bf6ace34fe1f3d3 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: "Yann E. MORIN" <yann.morin.1998@free.fr> 3*4882a593SmuzhiyunDate: Sun, 18 Dec 2016 15:37:27 +0100 4*4882a593SmuzhiyunSubject: [PATCH] libxfs: do not try to run the crc32selftest 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunEven though the crc32selftest is natively compiled (because it is to be 7*4882a593Smuzhiyunexecuted), it fails in cross-compilation as the host may lack the 8*4882a593Smuzhiyunrequired headers, like uuid/uuid.h (e.g. in a minimal environment). 9*4882a593Smuzhiyun 10*4882a593SmuzhiyunMoreover, running the crc32selftest natively is completely wrong, 11*4882a593Smuzhiyunbecause it passing on the host does not mean it would still pass n the 12*4882a593Smuzhiyuntarget (because endianness or bitness or alignment differences). 13*4882a593Smuzhiyun 14*4882a593SmuzhiyunSo, just disable running the crc32selftest altogether. 15*4882a593Smuzhiyun 16*4882a593SmuzhiyunNote that there's a remaining bug-in-hiding, because the crc32 table 17*4882a593Smuzhiyungenerator is natively built, but with the target CFLAGS. 18*4882a593Smuzhiyun 19*4882a593SmuzhiyunSigned-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> 20*4882a593SmuzhiyunSigned-off-by: "Fabrice Fontaine" <fontaine.fabrice@gmail.com> 21*4882a593Smuzhiyun[Update for 4.18.0: crc32 has been moved from libxfs to libfrog] 22*4882a593Smuzhiyun--- 23*4882a593Smuzhiyun libxfs/Makefile | 4 ++-- 24*4882a593Smuzhiyun 1 file changed, 2 insertions(+), 2 deletions(-) 25*4882a593Smuzhiyun 26*4882a593Smuzhiyundiff --git a/libfrog/Makefile b/libxfs/Makefile 27*4882a593Smuzhiyunindex 62608bd..e021625 100644 28*4882a593Smuzhiyun--- a/libfrog/Makefile 29*4882a593Smuzhiyun+++ b/libfrog/Makefile 30*4882a593Smuzhiyun@@ -112,9 +112,9 @@ LTLIBS = $(LIBPTHREAD) $(LIBRT) 31*4882a593Smuzhiyun # don't try linking xfs_repair with a debug libxfs. 32*4882a593Smuzhiyun DEBUG = -DNDEBUG 33*4882a593Smuzhiyun 34*4882a593Smuzhiyun-LDIRT = gen_crc32table crc32table.h crc32selftest 35*4882a593Smuzhiyun+LDIRT = gen_crc32table crc32table.h 36*4882a593Smuzhiyun 37*4882a593Smuzhiyun-default: crc32selftest ltdepend $(LTLIBRARY) 38*4882a593Smuzhiyun+default: ltdepend $(LTLIBRARY) 39*4882a593Smuzhiyun 40*4882a593Smuzhiyun crc32table.h: gen_crc32table.c 41*4882a593Smuzhiyun @echo " [CC] gen_crc32table" 42*4882a593Smuzhiyun-- 43*4882a593Smuzhiyun2.7.4 44*4882a593Smuzhiyun 45